qcacld-3.0: Refine wma_ds_peek_rx_packet_info()

There are several issues with wma_ds_peek_rx_packet_info():
1) The bSwap parameter is unused.
2) The other parameter identifiers used in the prototype do not match
   the ones in the implementation.
3) The implementation is documented instead of the interface.

Fix these issues by removing the unused parameter, making sure the
other parameters match between the prototype and implementation, and
documenting the interface.

Change-Id: Ia9d68dbcc7093f14aec6519303c4318e950c4d2d
CRs-Fixed: 3433198

core/mac/src/pe/lim/lim_api.c

@@ -1260,7 +1260,7 @@ static QDF_STATUS pe_handle_mgmt_frame(struct wlan_objmgr_psoc *psoc,
 	}
 
 	qdf_status =
-		wma_ds_peek_rx_packet_info(pVosPkt, (void *)&pRxPacketInfo, false);
+		wma_ds_peek_rx_packet_info(pVosPkt, (void *)&pRxPacketInfo);
 
 	if (!QDF_IS_STATUS_SUCCESS(qdf_status)) {
 		cds_pkt_return_packet(pVosPkt);

core/mac/src/pe/lim/lim_process_message_queue.c

@@ -861,8 +861,7 @@ static QDF_STATUS lim_allocate_and_get_bcn(
 	if (!pkt_l)
 		return QDF_STATUS_E_FAILURE;
 
-	status = wma_ds_peek_rx_packet_info(
-		pkt_l, (void *)&rx_pkt_info_l, false);
+	status = wma_ds_peek_rx_packet_info(pkt_l, (void *)&rx_pkt_info_l);
 	if (!QDF_IS_STATUS_SUCCESS(status)) {
 		pe_err("Failed to get Rx Pkt meta");
 		goto free;
@@ -1678,8 +1677,9 @@ static void lim_process_messages(struct mac_context *mac_ctx,
 		body_ptr = (cds_pkt_t *) new_msg.bodyptr;
 		cds_pkt_get_packet_length(body_ptr, &pkt_len);
 
-		qdf_status = wma_ds_peek_rx_packet_info(body_ptr,
-			(void **) &new_msg.bodyptr, false);
+		qdf_status =
+			wma_ds_peek_rx_packet_info(body_ptr,
+						   (void **) &new_msg.bodyptr);
 
 		if (!QDF_IS_STATUS_SUCCESS(qdf_status)) {
 			lim_decrement_pending_mgmt_count(mac_ctx);

core/mac/src/pe/lim/lim_utils.c

@@ -9469,8 +9469,7 @@ QDF_STATUS lim_util_get_type_subtype(void *pkt, uint8_t *type,
 		pe_err("NULL packet received");
 		return QDF_STATUS_E_FAILURE;
 	}
-	status =
-		wma_ds_peek_rx_packet_info(cds_pkt, (void *)&rxpktinfor, false);
+	status = wma_ds_peek_rx_packet_info(cds_pkt, (void *)&rxpktinfor);
 	if (!QDF_IS_STATUS_SUCCESS(status)) {
 		pe_err("Failed extract cds packet. status %d", status);
 		return QDF_STATUS_E_FAILURE;

core/mac/src/sys/legacy/src/system/src/sys_entry_func.c

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2012-2020 The Linux Foundation. All rights reserved.
- * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -80,8 +80,7 @@ QDF_STATUS sys_bbt_process_message_core(struct mac_context *mac_ctx,
 	void *bd_ptr;
 	tMgmtFrmDropReason dropreason;
 	cds_pkt_t *vos_pkt = (cds_pkt_t *) msg->bodyptr;
-	QDF_STATUS qdf_status =
-		wma_ds_peek_rx_packet_info(vos_pkt, &bd_ptr, false);
+	QDF_STATUS qdf_status = wma_ds_peek_rx_packet_info(vos_pkt, &bd_ptr);
 
 	mac_ctx->sys.gSysBbtReceived++;
 

core/wma/inc/wma_types.h

@@ -645,9 +645,16 @@ void wma_get_rx_retry_cnt(struct mac_context *mac, uint8_t vdev_id,
 QDF_STATUS wma_set_wlm_latency_level(void *wma_ptr,
 			struct wlm_latency_level_param *latency_params);
 
-QDF_STATUS
-wma_ds_peek_rx_packet_info
-	(cds_pkt_t *vosDataBuff, void **ppRxHeader, bool bSwap);
+/**
+ * wma_ds_peek_rx_packet_info() - peek rx packet info
+ * @pkt: packet
+ * @pkt_meta: packet meta
+ *
+ * Function fills the rx packet meta info from the the cds packet
+ *
+ * Return: QDF status
+ */
+QDF_STATUS wma_ds_peek_rx_packet_info(cds_pkt_t *pkt, void **pkt_meta);
 
 /**
  * wma_tx_abort() - abort tx

core/wma/src/wma_data.c

@@ -2899,18 +2899,7 @@ error:
 	return QDF_STATUS_E_FAILURE;
 }
 
-/**
- * wma_ds_peek_rx_packet_info() - peek rx packet info
- * @pkt: packet
- * @pkt_meta: packet meta
- * @bSwap: byte swap
- *
- * Function fills the rx packet meta info from the the cds packet
- *
- * Return: QDF status
- */
-QDF_STATUS wma_ds_peek_rx_packet_info(cds_pkt_t *pkt, void **pkt_meta,
-				      bool bSwap)
+QDF_STATUS wma_ds_peek_rx_packet_info(cds_pkt_t *pkt, void **pkt_meta)
 {
 	if (!pkt) {
 		wma_err("wma:Invalid parameter sent on wma_peek_rx_pkt_info");