qcacld-3.0: Fix Common Services Documentation

The kernel-doc script identified multiple documentation issues in
components/cmn_services, so fix them.

Change-Id: Ifdc8cefcbf7b31dc3e91cc3c5dab7cccd331e473
CRs-Fixed: 3363114

components/cmn_services/interface_mgr/inc/wlan_if_mgr_roam.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2020-2021, The Linux Foundation. All rights reserved.
+ * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
@@ -55,7 +56,7 @@ struct bssid_search_arg {
 };
 
 /**
- * allow_mcc_go_diff_bi_definition - Defines the config values for allowing
+ * enum allow_mcc_go_diff_bi_definition - Defines the config values for allowing
  * different beacon intervals between P2P-G0 and STA
  * @ALLOW_MCC_GO_DIFF_BI_WFA_CERT: GO Beacon interval is not changed.
  *	MCC GO doesn't work well in optimized way. In worst scenario, it may

components/cmn_services/logging/inc/wlan_connectivity_logging.h

@@ -36,7 +36,7 @@
  * @WLAN_AUTH_REQ: Authentication request frame
  * @WLAN_AUTH_RESP: Authentication response frame
  * @WLAN_ASSOC_REQ: Association request frame
- * @WLAN_ASSOC_RESP: Association response frame
+ * @WLAN_ASSOC_RSP: Association response frame
  * @WLAN_REASSOC_REQ: Reassociation request frame
  * @WLAN_REASSOC_RSP: Reassociation response frame
  * @WLAN_DEAUTH_RX: Deauthentication frame received
@@ -46,7 +46,7 @@
  * @WLAN_DISCONN_BMISS: Disconnection due to beacon miss
  * @WLAN_ROAM_SCAN_START: ROAM scan start
  * @WLAN_ROAM_SCAN_DONE: Roam scan done
- * @WLAN_ROAM_SCR_CURR_AP: Roam score current AP
+ * @WLAN_ROAM_SCORE_CURR_AP: Roam score current AP
  * @WLAN_ROAM_SCORE_CAND_AP: Roam Score Candidate AP
  * @WLAN_ROAM_RESULT: Roam Result
  * @WLAN_ROAM_CANCEL: Roam Cancel
@@ -222,7 +222,7 @@ enum qca_conn_diag_log_event_type {
  * @vdev_id: Vdev id
  * @timestamp_us: Timestamp(time of the day) in microseconds
  * @fw_timestamp: FW timestamp in microseconds
- * @ktimes_us: Kernel Timestamp in microseconds
+ * @ktime_us: Kernel Timestamp in microseconds
  */
 struct wlan_connectivity_log_diag_cmn {
 	uint8_t bssid[6];
@@ -366,7 +366,7 @@ struct wlan_diag_roam_scan_done {
 #define DIAG_ROAM_RESULT_VERSION 1
 
 /**
- * struct wlan_diag_roam_result_info  - Roam result data
+ * struct wlan_diag_roam_result - Roam result data
  * @diag_cmn: Common diag info
  * @version: Structure Version
  * @is_roam_successful: True if roamed successfully or false if roaming failed
@@ -452,7 +452,7 @@ struct wlan_diag_btm_cand_info {
  * transaction
  * @subtype: Event Subtype
  * @validity_timer: Validity interval in TBTT
- * @disassoc_timer: Time after which the AP disassociates the STA, defined
+ * @disassoc_tim: Time after which the AP disassociates the STA, defined
  * in TBTT.
  */
 struct wlan_diag_btm_info {
@@ -541,7 +541,7 @@ struct wlan_diag_packet_info {
  * Table 12-10—Integrity and key wrap algorithms.
  * @grp_cipher: Group cipher suite value as defined in
  * Table 12-10—Integrity and key wrap algorithm in IEEE 802.11 2020.
- * grp_mgmt: Group management cipher suite as defined in
+ * @grp_mgmt: Group management cipher suite as defined in
  * Table 12-10—Integrity and key wrap algorithms in IEEE 802.11 2020.
  */
 struct wlan_diag_connect {
@@ -588,7 +588,7 @@ struct wlan_roam_candidate_info {
 /**
  * struct wlan_roam_scan_info  - Roam scan related information
  * @cand_ap_count: Roam candidate AP count
- * @num_scanned_frequencies: Number of scanned frequencies
+ * @num_scanned_freq: Number of scanned frequencies
  * @is_btcoex_active: Is bluetooth coex active
  * @scan_freq: Array of scanned frequencies value in MHz
  */
@@ -598,6 +598,7 @@ struct wlan_roam_scan_info {
 	bool is_btcoex_active;
 	qdf_freq_t scan_freq[NUM_CHANNELS];
 };
+
 /**
  * struct wlan_roam_result_info  - Roam result data
  * @roam_fail_reason: Roam failure reason code defined in enum
@@ -610,8 +611,7 @@ struct wlan_roam_result_info {
 };
 
 /**
- * struct wlan_roam_scan_trigger_info  - Structure to store roam scan trigger
- * related data.
+ * struct wlan_roam_trigger_info - Structure to store roam trigger related data.
  * @is_full_scan: True if the scan is Full scan. False if the roam scan is
  * partial channel map scan
  * @trigger_reason: Roam trigger reason defined by enum roam_trigger_reason
@@ -633,7 +633,7 @@ struct wlan_roam_trigger_info {
 
 /**
  * struct wlan_btm_cand_info  - BTM candidate information
- * @index: Candidate index
+ * @idx: Candidate index
  * @preference: Candidate preference
  * @bssid: candidate bssid
  */
@@ -930,6 +930,7 @@ void wlan_clear_sae_auth_logs_cache(struct wlan_objmgr_psoc *psoc,
  * 2 - SAE confirm frame
  * @auth_seq: Authentication frame transaction sequence number as defined in
  * IEEE 802.11 - 2020 standard section 9.4.1.2
+ * @aid: Association ID
  * @tag: Record type main tag
  *
  * Return: QDF_STATUS
@@ -953,7 +954,7 @@ static inline void wlan_connectivity_logging_stop(void)
  * logging buffer
  * @psoc: Global psoc pointer
  * @osif_cbks: OSIF callbacks
- * @osif_cbk_context: OSIF callback context argument
+ * @osif_cb_context: OSIF callback context argument
  *
  * Return: None
  */
@@ -1001,6 +1002,7 @@ QDF_STATUS wlan_connectivity_log_enqueue(struct wlan_log_record *new_record);
  * 2 - SAE confirm frame
  * @auth_seq: Authentication frame transaction sequence number as defined in
  * IEEE 802.11 - 2020 standard section 9.4.1.2
+ * @aid: Association ID
  * @tag: Record type main tag
  *
  * Return: QDF_STATUS

components/cmn_services/logging/src/wlan_connectivity_logging.c

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2021, The Linux Foundation. All rights reserved.
- * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
@@ -216,7 +216,8 @@ bool wlan_is_log_record_present_for_bssid(struct wlan_objmgr_psoc *psoc,
 /**
  * wlan_add_sae_log_record_to_available_slot() - Add a new log record into the
  * cache for the queue.
- * @mlme_priv: Mlme private object
+ * @psoc: objmgr psoc object
+ * @vdev: objmgr vdev object
  * @rec: Log record pointer
  *
  * Return: QDF_STATUS
@@ -413,7 +414,8 @@ bool wlan_is_log_record_present_for_bssid(struct wlan_objmgr_psoc *psoc,
 /**
  * wlan_add_sae_log_record_to_available_slot() - Add a new log record into the
  * cache for the queue.
- * @mlme_priv: Mlme private object
+ * @psoc: objmgr psoc object
+ * @vdev: objmgr vdev object
  * @pkt_info: Log packet record pointer
  *
  * Return: QDF_STATUS

components/cmn_services/policy_mgr/inc/cfg_policy_mgr.h

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2012-2021 The Linux Foundation. All rights reserved.
- * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -604,7 +604,7 @@ CFG_INI_UINT("g_mark_sap_indoor_as_disable", 0, 1, 0, CFG_VALUE_OR_DEFAULT, \
 CFG_INI_UINT("g_enable_go_force_scc", 0, 2, 0, CFG_VALUE_OR_DEFAULT, \
 	     "Enable/Disable P2P GO force SCC")
 
-/**
+/*
  * <ini>
  * g_pcl_band_priority - Set 5G/6G Channel order
  * Options.

components/cmn_services/policy_mgr/inc/wlan_policy_mgr_api.h

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2012-2021 The Linux Foundation. All rights reserved.
- * Copyright (c) 2021-2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2021-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -70,10 +70,10 @@ typedef const enum policy_mgr_conc_next_action
 
 /**
  * enum PM_AP_DFS_MASTER_MODE - AP dfs master mode
- * @PM_STA_SAP_ON_DFS_DEFAULT - Disallow STA+SAP SCC on DFS channel
- * @PM_STA_SAP_ON_DFS_MASTER_MODE_DISABLED - Allow STA+SAP SCC
+ * @PM_STA_SAP_ON_DFS_DEFAULT: Disallow STA+SAP SCC on DFS channel
+ * @PM_STA_SAP_ON_DFS_MASTER_MODE_DISABLED: Allow STA+SAP SCC
  *        on DFS channel with master mode disabled
- * @PM_STA_SAP_ON_DFS_MASTER_MODE_FLEX - enhance
+ * @PM_STA_SAP_ON_DFS_MASTER_MODE_FLEX: enhance
  *        "PM_STA_SAP_ON_DFS_MASTER_MODE_DISABLED" with below requirement:
  *	 a. Allow single SAP (GO) start on DFS channel.
  *	 b. Allow CAC process on DFS channel in single SAP (GO) mode
@@ -149,7 +149,7 @@ static inline const char *device_mode_to_string(uint32_t idx)
 };
 
 /**
- * trim_chan_info - trim channel info
+ * struct trim_chan_info - trim channel info
  * @band_capability: band capability
  * @sap_count: sap count
  * @trim: enum trim channel list
@@ -663,6 +663,7 @@ bool policy_mgr_check_for_session_conc(struct wlan_objmgr_psoc *psoc,
 
 /**
  * policy_mgr_handle_conc_multiport() - to handle multiport concurrency
+ * @psoc: PSOC object information
  * @session_id: Session ID
  * @ch_freq: Channel frequency
  * @reason: reason for connection update
@@ -685,8 +686,6 @@ policy_mgr_handle_conc_multiport(struct wlan_objmgr_psoc *psoc,
  * policy_mgr_check_concurrent_intf_and_restart_sap() - Check
  * concurrent change intf
  * @psoc: PSOC object information
- * @operation_channel: operation channel
- * @vdev_id: vdev id of SAP
  *
  * Checks the concurrent change interface and restarts SAP
  *
@@ -830,8 +829,8 @@ policy_mgr_is_p2p_p2p_conc_supported(struct wlan_objmgr_psoc *psoc)
  * is present and find mode, freq , vdev id and chan width
  *
  * @psoc: psoc object
- * @vdev: vdev id
- * @freq: frequency
+ * @vdev_id: vdev id
+ * @curr_go_freq: frequency
  * @mode: existing vdev mode
  * @con_freq: existing connection freq
  * @ch_width: ch_width of existing connection
@@ -853,7 +852,7 @@ policy_mgr_fetch_existing_con_info(struct wlan_objmgr_psoc *psoc,
 #define GO_FORCE_SCC_DISABLE 0
 #define GO_FORCE_SCC_STRICT 1
 #define GO_FORCE_SCC_LIBERAL 2
-/**
+/*
  * Stay in MCC for 1 second, in case of first p2p go channel
  * needs to be moved to curr go channel
  */
@@ -1047,7 +1046,7 @@ void policy_mgr_decr_session_set_pcl(struct wlan_objmgr_psoc *psoc,
 
 #ifdef WLAN_FEATURE_11BE_MLO
 /**
- * policy_mgr_is_mlo_vdev_id() - check if vdev id is part of ML
+ * policy_mgr_is_ml_vdev_id() - check if vdev id is part of ML
  * @psoc: PSOC object information
  * @vdev_id: vdev id to check
  *
@@ -1302,9 +1301,8 @@ bool policy_mgr_allow_concurrency(struct wlan_objmgr_psoc *psoc,
  * policy_mgr_check_scc_sbs_channel() - Check for allowed
  * concurrency combination
  * @psoc: PSOC object information
- * @mode: new connection mode
- * @ch_freq: channel frequency on which new connection is coming up
- * @bw: Bandwidth requested by the connection (optional)
+ * @intf_ch_freq: channel frequency on which new connection is coming up
+ * @sap_ch_freq: SoftAp channel frequency
  * @vdev_id: Vdev Id
  * @cc_mode: concurrent switch mode
  *
@@ -1506,7 +1504,7 @@ QDF_STATUS policy_mgr_decr_connection_count(struct wlan_objmgr_psoc *psoc,
 QDF_STATUS
 policy_mgr_current_connections_update(struct wlan_objmgr_psoc *psoc,
 				      uint32_t session_id, uint32_t ch_freq,
-				      enum policy_mgr_conn_update_reason,
+				      enum policy_mgr_conn_update_reason reason,
 				      uint32_t request_id);
 
 /**
@@ -1529,6 +1527,7 @@ policy_mgr_change_hw_mode_sta_connect(struct wlan_objmgr_psoc *psoc,
 /**
  * policy_mgr_is_dbs_allowed_for_concurrency() - If dbs is allowed for current
  * concurreny
+ * @psoc: PSOC object information
  * @new_conn_mode: new connection mode
  *
  * When a new connection is about to come up, check if dbs is allowed for
@@ -1580,7 +1579,7 @@ policy_mgr_get_pcl_ch_for_sap_go_with_ll_sap_present(
  * policy_mgr_get_pcl_channel_for_ll_sap_concurrency() - Get pcl channel list
  * for LL SAP concurrency
  * @psoc: PSOC object information
- * @mode: Device mode
+ * @curr_mode: Device mode
  * @vdev_id: Vdev id
  * @pcl_channels: Preferred channel freq list
  * @pcl_weight: Weights of the PCL
@@ -1759,7 +1758,7 @@ QDF_STATUS policy_mgr_pdev_set_hw_mode(struct wlan_objmgr_psoc *psoc,
 		uint32_t request_id);
 
 /**
- * policy_mgr_pdev_set_hw_mode_cback() - callback invoked by
+ * typedef policy_mgr_pdev_set_hw_mode_cback() - callback invoked by
  * other component to provide set HW mode request status
  * @status: status of the request
  * @cfgd_hw_mode_index: new HW mode index
@@ -1788,7 +1787,7 @@ typedef void (*policy_mgr_pdev_set_hw_mode_cback)(uint32_t status,
 				uint32_t request_id);
 
 /**
- * policy_mgr_nss_update_cback() - callback invoked by other
+ * typedef policy_mgr_nss_update_cback() - callback invoked by other
  * component to provide nss update request status
  * @psoc: PSOC object information
  * @tx_status: tx completion status for updated beacon with new
@@ -1854,8 +1853,9 @@ struct policy_mgr_sme_cbacks {
  * @get_mode_for_non_connected_vdev: Get the mode for a non
  *                                 connected vdev
  * @hdd_get_device_mode: Get QDF_OPMODE type for session id (vdev id)
- * @hdd_is_chan_switch_in_progress: Check if in any adater channel switch is in
+ * @hdd_is_chan_switch_in_progress: Check if in any adapter channel switch is in
  * progress
+ * @hdd_is_cac_in_progress: Check if in any adapter CAC is in progress
  * @wlan_hdd_set_sap_csa_reason: Set the sap csa reason in cases like NAN.
  * @hdd_get_ap_6ghz_capable: get ap vdev 6ghz capable info from hdd ap adapter.
  * @wlan_hdd_indicate_active_ndp_cnt: indicate active ndp cnt to hdd
@@ -1912,8 +1912,8 @@ struct policy_mgr_conc_cbacks {
 /**
  * struct policy_mgr_tdls_cbacks - TDLS Callbacks to be invoked
  * from policy manager
- * @set_tdls_ct_mode: Set the tdls connection tracker mode
- * @check_is_tdls_allowed: check if tdls allowed or not
+ * @tdls_notify_increment_session:
+ * @tdls_notify_decrement_session:
  */
 struct policy_mgr_tdls_cbacks {
 	void (*tdls_notify_increment_session)(struct wlan_objmgr_psoc *psoc);
@@ -2340,7 +2340,7 @@ bool policy_mgr_is_sap_mandatory_channel_set(struct wlan_objmgr_psoc *psoc);
 
 /**
  * policy_mgr_list_has_24GHz_channel() - Check if list contains 2.4GHz channels
- * @channel_list: Channel frequency list
+ * @ch_freq_list: Channel frequency list
  * @list_len: Length of the channel list
  *
  * Checks if the channel list contains atleast one 2.4GHz channel
@@ -2353,7 +2353,7 @@ bool policy_mgr_list_has_24GHz_channel(uint32_t *ch_freq_list,
 /**
  * policy_mgr_get_valid_chans_from_range() - get valid channel from given range
  * @psoc: PSOC object information
- * @ch_freq_list: Pointer to the channel frequency list
+ * @ch_list: Pointer to the channel frequency list
  * @ch_cnt: Pointer to the length of the channel list
  * @mode: Device mode
  *
@@ -2381,9 +2381,9 @@ QDF_STATUS policy_mgr_get_valid_chans(struct wlan_objmgr_psoc *psoc,
  * policy_mgr_get_nss_for_vdev() - Get the allowed nss value for the
  * vdev
  * @psoc: PSOC object information
- * @dev_mode: connection type.
- * @nss2g: Pointer to the 2G Nss parameter.
- * @nss5g: Pointer to the 5G Nss parameter.
+ * @mode: connection type.
+ * @nss_2g: Pointer to the 2G Nss parameter.
+ * @nss_5g: Pointer to the 5G Nss parameter.
  *
  * Fills the 2G and 5G Nss values based on connection type.
  *
@@ -2631,6 +2631,7 @@ QDF_STATUS policy_mgr_get_valid_chan_weights(struct wlan_objmgr_psoc *psoc,
 /**
  * policy_mgr_set_hw_mode_on_channel_switch() - Set hw mode
  * after channel switch
+ * @psoc: PSOC object information
  * @session_id: Session ID
  *
  * Sets hw mode after doing a channel switch
@@ -2733,9 +2734,10 @@ QDF_STATUS policy_mgr_check_conn_with_mode_and_vdev_id(
  * @new_hw_mode_index: New HW mode index
  * @num_vdev_mac_entries: Number of vdev-mac id mapping that follows
  * @vdev_mac_map: vdev-mac id map. This memory will be freed by the caller.
+ * So, make local copy if needed.
  * @num_mac_freq: Number of pdev freq mapping that follows
  * @mac_freq_range: mac_freq_range mapping
- * So, make local copy if needed.
+ * @context:
  *
  * Provides the old and new HW mode index set by the FW
  *
@@ -2833,7 +2835,7 @@ QDF_STATUS policy_mgr_register_hdd_cb(struct wlan_objmgr_psoc *psoc,
 /**
  * policy_mgr_register_conc_cb() - register Lim callbacks
  * @psoc: PSOC object information
- * @hdd_cbacks: function pointers from lim
+ * @conc_cbacks: function pointers from lim
  *
  * API, allows Lim to register callbacks to be invoked by policy
  * mgr
@@ -2885,11 +2887,11 @@ QDF_STATUS policy_mgr_register_cdp_cb(struct wlan_objmgr_psoc *psoc,
 		struct policy_mgr_cdp_cbacks *cdp_cbacks);
 
 /**
- * policy_mgr_register_dp_cb() - register CDP callbacks
+ * policy_mgr_register_dp_cb() - register DP callbacks
  * @psoc: PSOC object information
- * @cdp_cbacks: function pointers from CDP
+ * @dp_cbacks: function pointers from DP
  *
- * API, allows CDP to register callbacks to be invoked by
+ * API, allows DP to register callbacks to be invoked by
  * policy mgr
  *
  * Return: SUCCESS,
@@ -3471,7 +3473,7 @@ void policy_mgr_update_dbs_fw_config(struct wlan_objmgr_psoc *psoc);
  * request config in policy manager component
  * @psoc: PSOC object information
  * @scan_config: DBS scan config
- * @fw_config: DBS FW config
+ * @fw_mode_config: DBS FW config
  *
  * This function updates DBS request configurations required by
  * policy manager
@@ -3558,7 +3560,7 @@ void policy_mgr_update_hw_mode_index(struct wlan_objmgr_psoc *psoc,
  * policy_mgr_update_old_hw_mode_index() - Function to update
  * old HW mode in policy manager component
  * @psoc: PSOC object information
- * @new_hw_mode_index: index to old HW mode
+ * @old_hw_mode_index: index to old HW mode
  *
  * This function to update the old HW mode in policy manager
  *
@@ -3624,8 +3626,11 @@ bool policy_mgr_is_dnsc_set(struct wlan_objmgr_vdev *vdev);
  * @scan_config: DBS related scan config
  * @fw_mode_config: DBS related FW config
  * @dual_mac_disable_ini: DBS related ini config
+ * @channel_select_logic_conc:
+ *
  * This function returns the latest DBS configuration for
  * connection & scan, sent to FW
+ *
  * Return: SUCCESS or FAILURE
  */
 QDF_STATUS policy_mgr_get_updated_scan_and_fw_mode_config(
@@ -3772,7 +3777,7 @@ bool policy_mgr_disallow_mcc(struct wlan_objmgr_psoc *psoc,
  * policy_mgr_mode_specific_get_channel() - Get channel for a
  * connection type
  * @psoc: PSOC object information
- * @chan_list: Connection type
+ * @mode: Connection type
  *
  * Get channel frequency for a connection type
  *
@@ -3992,6 +3997,7 @@ bool policy_mgr_is_hwmode_set_for_given_chnl(struct wlan_objmgr_psoc *psoc,
 
 /**
  * policy_mgr_get_connection_info() - Get info of all active connections
+ * @psoc: pointer to soc
  * @info: Pointer to connection info
  *
  * Return: Connection count
@@ -4001,7 +4007,8 @@ uint32_t policy_mgr_get_connection_info(struct wlan_objmgr_psoc *psoc,
 /**
  * policy_mgr_register_mode_change_cb() - Register mode change callback with
  * policy manager
- * @callback: HDD callback to be registered
+ * @psoc: pointer to soc
+ * @mode_change_cb: HDD callback to be registered
  *
  * Return: QDF_STATUS
  */
@@ -4010,7 +4017,7 @@ QDF_STATUS policy_mgr_register_mode_change_cb(struct wlan_objmgr_psoc *psoc,
 /**
  * policy_mgr_deregister_mode_change_cb() - Deregister mode change callback with
  * policy manager
- * @callback: HDD callback to be registered
+ * @psoc: pointer to soc
  *
  * Return: QDF_STATUS
  */
@@ -4020,7 +4027,7 @@ QDF_STATUS policy_mgr_deregister_mode_change_cb(struct wlan_objmgr_psoc *psoc);
  * policy_mgr_allow_sap_go_concurrency() - check whether SAP/GO concurrency is
  * allowed.
  * @psoc: pointer to soc
- * @policy_mgr_con_mode: operating mode of interface to be checked
+ * @mode: operating mode of interface to be checked
  * @ch_freq: new operating channel of the interface to be checked
  * @vdev_id: vdev id of the connection to be checked, 0xff for new connection
  *
@@ -4080,7 +4087,7 @@ bool policy_mgr_sta_sap_scc_on_lte_coex_chan(
 	struct wlan_objmgr_psoc *psoc);
 
 /**
- * policy_mgr_valid_channel_for_channel_switch() - check for valid channel for
+ * policy_mgr_is_valid_for_channel_switch() - check for valid channel for
  * channel switch.
  * @psoc: pointer to psoc
  * @ch_freq: channel frequency to be validated.
@@ -4233,7 +4240,7 @@ void policy_mgr_set_ap_6ghz_capable(struct wlan_objmgr_psoc *psoc,
  * AP is allowed on 6G band only when all of below statements are true:
  * a. SAP config includes WPA3 security - SAE,OWE,SuiteB.
  * b. SAP is configured by ACS range which includes any 6G channel or
-      configured by 6G Fixed channel.
+ *    configured by 6G Fixed channel.
  * c. SAP has no legacy clients (client doesn't support 6G band).
  *    legacy client (non 6ghz capable): association request frame has no
  *    6G band global operating Class.
@@ -4408,9 +4415,9 @@ bool policy_mgr_is_sta_mon_concurrency(struct wlan_objmgr_psoc *psoc);
 QDF_STATUS policy_mgr_check_mon_concurrency(struct wlan_objmgr_psoc *psoc);
 
 /**
- * policy_mgr_get_hw_max_dbs_bw() - Computes DBS BW
+ * policy_mgr_get_hw_dbs_max_bw() - Computes DBS BW
  * @psoc: PSOC object information
- * @dbs_bw: BW info of both MAC0 and MAC1
+ * @bw_dbs: BW info of both MAC0 and MAC1
  * This function computes BW info of both MAC0 and MAC1
  *
  * Return: void

components/cmn_services/policy_mgr/inc/wlan_policy_mgr_public_struct.h

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2012-2021 The Linux Foundation. All rights reserved.
- * Copyright (c) 2021-2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2021-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -29,16 +29,16 @@
 /* Include files */
 #include <wmi_unified_api.h>
 
-/**
+/*
  *  Some max value greater than the max length of the channel list
  */
 #define MAX_WEIGHT_OF_PCL_CHANNELS 255
-/**
+/*
  *  Some fixed weight difference between the groups
  */
 #define PCL_GROUPS_WEIGHT_DIFFERENCE 20
 
-/**
+/*
  * Currently max, only 3 groups are possible as per 'enum policy_mgr_pcl_type'.
  * i.e., in a PCL only 3 groups of channels can be present
  * e.g., SCC channel on 2.4 Ghz, SCC channel on 5 Ghz & 5 Ghz channels.
@@ -93,7 +93,7 @@ typedef int (*send_mode_change_event_cb)(void);
  * @CSA_REASON_DCS: DCS
  * @CSA_REASON_CHAN_DISABLED: channel is disabled
  * @CSA_REASON_CHAN_PASSIVE: channel is passive
- * @CSA_REASON_GO_BSS_STARED: P2P go started
+ * @CSA_REASON_GO_BSS_STARTED: P2P go started
  * @CSA_REASON_SAP_ACS: 2.4 GHz preferred SAP ACS starting
  * @CSA_REASON_SAP_FIX_CH_CONC_WITH_GO: SAP fix channel start
  *  and move GO to other band
@@ -226,7 +226,7 @@ enum policy_mgr_pcl_group_id {
 };
 
 /**
- * policy_mgr_pcl_channel_order - Order in which the PCL is requested
+ * enum policy_mgr_pcl_channel_order - Order in which the PCL is requested
  * @POLICY_MGR_PCL_ORDER_NONE: no order
  * @POLICY_MGR_PCL_ORDER_24G_THEN_5G: 2.4 Ghz channel followed by 5 Ghz channel
  * @POLICY_MGR_PCL_ORDER_5G_THEN_2G: 5 Ghz channel followed by 2.4 Ghz channel
@@ -250,7 +250,7 @@ enum policy_mgr_pcl_channel_order {
 };
 
 /**
- * policy_mgr_pcl_band_priority - Band priority between 5G and 6G channel
+ * enum policy_mgr_pcl_band_priority - Band priority between 5G and 6G channel
  * @POLICY_MGR_PCL_BAND_5G_THEN_6G: 5 Ghz channel followed by 6 Ghz channel
  * @POLICY_MGR_PCL_BAND_6G_THEN_5G: 6 Ghz channel followed by 5 Ghz channel
  *
@@ -271,6 +271,7 @@ enum policy_mgr_pcl_band_priority {
  * @POLICY_MGR_RX_NSS_6: Receive Nss = 6
  * @POLICY_MGR_RX_NSS_7: Receive Nss = 7
  * @POLICY_MGR_RX_NSS_8: Receive Nss = 8
+ * @POLICY_MGR_RX_NSS_MAX: maximum enumeration
  *
  * Indicates the maximum number of spatial streams that the STA can receive
  */
@@ -392,6 +393,11 @@ enum policy_mgr_mac_use {
  * @PM_24G_SCC_CH_SBS_CH_5G: 2.4 Ghz channels, SCC channel,
  *      SBS channels & rest of the 5G channels
  * @PM_24G_SBS_CH_MCC_CH: 2.4 Ghz channels, SBS channels & MCC channels
+ * @PM_SBS_CH_24G_SCC_CH:
+ * @PM_SBS_CH_SCC_CH_24G:
+ * @PM_SCC_CH_SBS_CH_24G:
+ * @PM_SBS_CH_SCC_CH_5G_24G:
+ * @PM_SCC_CH_MCC_CH_SBS_CH_24G:
  * @PM_SBS_CH_2G: SBS channels & 2.4 Ghz channels
  * @PM_SCC_ON_5G_LOW_5G_LOW_PLUS_SHARED_2G: 5 GHz low SCC channel followed by
  * 5 GHz low frequencies, add 2.4 GHz if its shared with 5 GHz low
@@ -464,7 +470,7 @@ enum policy_mgr_pcl_type {
  * @PM_SAP_24_1x1: SAP connection using [email protected] Ghz
  * @PM_SAP_24_2x2: SAP connection using [email protected] Ghz
  * @PM_SAP_5_1x1: SAP connection using 1x1@5 Ghz
- * @PM_SAP_5_1x1: SAP connection using 2x2@5 Ghz
+ * @PM_SAP_5_2x2: SAP connection using 2x2@5 Ghz
  * @PM_NAN_DISC_24_1x1:  NAN Discovery using [email protected] Ghz
  * @PM_NAN_DISC_24_2x2:  NAN Discovery using [email protected] Ghz
  * @PM_NDI_24_1x1:  NAN Datapath using [email protected] Ghz
@@ -524,9 +530,12 @@ enum policy_mgr_one_connection_mode {
  *			1x1@5 Ghz
  * @PM_STA_SAP_MCC_5_2x2: STA & SAP connection on MCC using
  *			2x2@5 Ghz
+ * @PM_STA_SAP_MCC_24_5_1x1:
+ * @PM_STA_SAP_MCC_24_5_2x2:
  * @PM_STA_SAP_DBS_1x1: STA & SAP connection on DBS using 1x1
  * @PM_STA_SAP_DBS_2x2: STA & SAP connection on DBS using 2x2
  * @PM_STA_SAP_SBS_5_1x1: STA & SAP connection on 5G SBS using 1x1
+ * @PM_STA_SAP_SBS_5_2x2: STA & SAP connection on 5G SBS using 2x2
  * @PM_STA_P2P_GO_SCC_24_1x1: STA & P2P GO connection on SCC
  *			using [email protected] Ghz
  * @PM_STA_P2P_GO_SCC_24_2x2: STA & P2P GO connection on SCC
@@ -543,12 +552,16 @@ enum policy_mgr_one_connection_mode {
  *			using 1x1@5 Ghz
  * @PM_STA_P2P_GO_MCC_5_2x2: STA & P2P GO connection on MCC
  *			using 2x2@5 Ghz
+ * @PM_STA_P2P_GO_MCC_24_5_1x1:
+ * @PM_STA_P2P_GO_MCC_24_5_2x2:
  * @PM_STA_P2P_GO_DBS_1x1: STA & P2P GO connection on DBS using
  *			1x1
  * @PM_STA_P2P_GO_DBS_2x2: STA & P2P GO connection on DBS using
  *			2x2
  * @PM_STA_P2P_GO_SBS_5_1x1: STA & P2P GO connection on 5G SBS
  *			using 1x1
+ * @PM_STA_P2P_GO_SBS_5_2x2: STA & P2P GO connection on 5G SBS
+ *			using 2x2
  * @PM_STA_P2P_CLI_SCC_24_1x1: STA & P2P CLI connection on SCC
  *			using [email protected] Ghz
  * @PM_STA_P2P_CLI_SCC_24_2x2: STA & P2P CLI connection on SCC
@@ -565,12 +578,16 @@ enum policy_mgr_one_connection_mode {
  *			using 1x1@5 Ghz
  * @PM_STA_P2P_CLI_MCC_5_2x2: STA & P2P CLI connection on MCC
  *			using 2x2@5 Ghz
+ * @PM_STA_P2P_CLI_MCC_24_5_1x1:
+ * @PM_STA_P2P_CLI_MCC_24_5_2x2:
  * @PM_STA_P2P_CLI_DBS_1x1: STA & P2P CLI connection on DBS
  *			using 1x1
  * @PM_STA_P2P_CLI_DBS_2x2: STA & P2P CLI connection on DBS
  *			using 2x2
  * @PM_STA_P2P_CLI_SBS_5_1x1: STA & P2P CLI connection on 5G
  *			SBS using 1x1
+ * @PM_STA_P2P_CLI_SBS_5_2x2: STA & P2P CLI connection on 5G
+ *			SBS using 2x2
  * @PM_P2P_GO_P2P_CLI_SCC_24_1x1: P2P GO & CLI connection on
  *			SCC using [email protected] Ghz
  * @PM_P2P_GO_P2P_CLI_SCC_24_2x2: P2P GO & CLI connection on
@@ -587,12 +604,16 @@ enum policy_mgr_one_connection_mode {
  *			MCC using 1x1@5 Ghz
  * @PM_P2P_GO_P2P_CLI_MCC_5_2x2: P2P GO & CLI connection on
  *			MCC using 2x2@5 Ghz
+ * @PM_P2P_GO_P2P_CLI_MCC_24_5_1x1:
+ * @PM_P2P_GO_P2P_CLI_MCC_24_5_2x2:
  * @PM_P2P_GO_P2P_CLI_DBS_1x1: P2P GO & CLI connection on DBS
  *			using 1x1
  * @PM_P2P_GO_P2P_CLI_DBS_2x2: P2P GO & P2P CLI connection
  *			on DBS using 2x2
  * @PM_P2P_GO_P2P_CLI_SBS_5_1x1: P2P GO & P2P CLI connection
  *			on 5G SBS using 1x1
+ * @PM_P2P_GO_P2P_CLI_SBS_5_2x2: P2P GO & P2P CLI connection
+ *			on 5G SBS using 2x2
  * @PM_P2P_GO_SAP_SCC_24_1x1: P2P GO & SAP connection on
  *			SCC using [email protected] Ghz
  * @PM_P2P_GO_SAP_SCC_24_2x2: P2P GO & SAP connection on
@@ -609,12 +630,16 @@ enum policy_mgr_one_connection_mode {
  *			MCC using 1x1@5 Ghz
  * @PM_P2P_GO_SAP_MCC_5_2x2: P2P GO & SAP connection on
  *			MCC using 2x2@5 Ghz
+ * @PM_P2P_GO_SAP_MCC_24_5_1x1:
+ * @PM_P2P_GO_SAP_MCC_24_5_2x2:
  * @PM_P2P_GO_SAP_DBS_1x1: P2P GO & SAP connection on DBS using
  *			1x1
  * @PM_P2P_GO_SAP_DBS_2x2: P2P GO & SAP connection on DBS using
  *			2x2
  * @PM_P2P_GO_SAP_SBS_5_1x1: P2P GO & SAP connection on 5G SBS
  *			using 1x1
+ * @PM_P2P_GO_SAP_SBS_5_2x2: P2P GO & SAP connection on 5G SBS
+ *			using 2x2
  * @PM_P2P_GO_P2P_GO_SCC_24_1x1: P2P GO & P2P GO SCC on 2.4G using 1x1
  * @PM_P2P_GO_P2P_GO_SCC_24_2x2: P2P GO & P2P GO SCC on 2.4G using 2x2
  * @PM_P2P_GO_P2P_GO_MCC_24_1x1: P2P GO & P2P GO MCC on 2.4G using 1x1
@@ -630,6 +655,7 @@ enum policy_mgr_one_connection_mode {
  * @PM_P2P_GO_P2P_GO_DBS_1x1: P2P GO & P2P GO on DBS using 1x1
  * @PM_P2P_GO_P2P_GO_DBS_2x2: P2P GO & P2P GO on DBS using 2x2
  * @PM_P2P_GO_P2P_GO_SBS_5_1x1: P2P GO & P2P GO on SBS using 1x1
+ * @PM_P2P_GO_P2P_GO_SBS_5_2x2: P2P GO & P2P GO on SBS using 2x2
  * @PM_P2P_CLI_SAP_SCC_24_1x1: CLI & SAP connection on SCC using
  *			[email protected] Ghz
  * @PM_P2P_CLI_SAP_SCC_24_2x2: CLI & SAP connection on SCC using
@@ -646,15 +672,17 @@ enum policy_mgr_one_connection_mode {
  *			1x1@5 Ghz
  * @PM_P2P_CLI_SAP_MCC_5_2x2: CLI & SAP connection on MCC using
  *			2x2@5 Ghz
- * @POLICY_MGR_P2P_STA_SAP_MCC_24_5_1x1: CLI and SAP connecting on MCC
+ * @PM_P2P_CLI_SAP_MCC_24_5_1x1: CLI and SAP connecting on MCC
  *			in 2.4 and 5GHz 1x1
- * @POLICY_MGR_P2P_STA_SAP_MCC_24_5_2x2: CLI and SAP connecting on MCC
+ * @PM_P2P_CLI_SAP_MCC_24_5_2x2: CLI and SAP connecting on MCC
  *			in 2.4 and 5GHz 2x2
- * @PM_P2P_CLI_SAP_DBS_1x1,: CLI & SAP connection on DBS using 1x1
+ * @PM_P2P_CLI_SAP_DBS_1x1: CLI & SAP connection on DBS using 1x1
  * @PM_P2P_CLI_SAP_DBS_2x2: P2P CLI & SAP connection on DBS using
  *			2x2
  * @PM_P2P_CLI_SAP_SBS_5_1x1: P2P CLI & SAP connection on 5G SBS
  *			using 1x1
+ * @PM_P2P_CLI_SAP_SBS_5_2x2: P2P CLI & SAP connection on 5G SBS
+ *			using 2x2
  * @PM_P2P_CLI_P2P_CLI_SCC_24_1x1: P2P CLI & P2P CLI SCC on 2.4G using 1x1
  * @PM_P2P_CLI_P2P_CLI_SCC_24_2x2: P2P CLI & P2P CLI SCC on 2.4G using 2x2
  * @PM_P2P_CLI_P2P_CLI_MCC_24_1x1: P2P CLI & P2P CLI MCC on 2.4G using 1x1
@@ -670,6 +698,7 @@ enum policy_mgr_one_connection_mode {
  * @PM_P2P_CLI_P2P_CLI_DBS_1x1: P2P CLI & P2P CLI on DBS using 1x1
  * @PM_P2P_CLI_P2P_CLI_DBS_2x2: P2P CLI & P2P CLI on DBS using 2x2
  * @PM_P2P_CLI_P2P_CLI_SBS_5_1x1: P2P CLI & P2P CLI on SBS using 1x1
+ * @PM_P2P_CLI_P2P_CLI_SBS_5_2x2: P2P CLI & P2P CLI on SBS using 2x2
  * @PM_SAP_SAP_SCC_24_1x1: SAP & SAP connection on
  *			SCC using [email protected] Ghz
  * @PM_SAP_SAP_SCC_24_2x2: SAP & SAP connection on
@@ -694,6 +723,7 @@ enum policy_mgr_one_connection_mode {
  *			1x1
  * @PM_SAP_SAP_DBS_2x2: SAP & SAP connection on DBS using 2x2
  * @PM_SAP_SAP_SBS_5_1x1: SAP & SAP connection on 5G SBS using 1x1
+ * @PM_SAP_SAP_SBS_5_2x2: SAP & SAP connection on 5G SBS using 2x2
  * @PM_SAP_NAN_DISC_SCC_24_1x1: SAP & NAN connection on
  *			SCC using [email protected] Ghz
  * @PM_SAP_NAN_DISC_SCC_24_2x2: SAP & NAN connection on
@@ -728,6 +758,7 @@ enum policy_mgr_one_connection_mode {
  *			1x1
  * @PM_STA_STA_DBS_2x2: STA & STA connection on DBS using 2x2
  * @PM_STA_STA_SBS_5_1x1: STA & STA connection on 5G SBS using 1x1
+ * @PM_STA_STA_SBS_5_2x2: STA & STA connection on 5G SBS using 2x2
  * @PM_STA_NAN_DISC_SCC_24_1x1: NAN & STA connection on SCC using 1x1 on 2.4 GHz
  * @PM_STA_NAN_DISC_SCC_24_2x2: NAN & STA connection on SCC using 2x2 on 2.4 GHz
  * @PM_STA_NAN_DISC_MCC_24_1x1: NAN & STA connection on MCC using 1x1 on 2.4 GHz
@@ -740,6 +771,7 @@ enum policy_mgr_one_connection_mode {
  * @PM_NAN_DISC_NDI_MCC_24_2x2: NAN & NDI connection on MCC using 2x2 on 2.4 GHz
  * @PM_NAN_DISC_NDI_DBS_1x1: NAN & NDI connection on DBS using 1x1
  * @PM_NAN_DISC_NDI_DBS_2x2: NAN & NDI connection on DBS using 2x2
+ * @PM_MAX_TWO_CONNECTION_MODE: Max enumeration
  *
  * These are generic IDs that identify the various roles in the
  * software system
@@ -987,20 +1019,19 @@ enum policy_mgr_two_connection_mode {
  * 2.4 GHZ MCC on mac0 and second STA on high 5 GHZ on mac1 doing SBS
  * @PM_STA_STA_5_LOW_MCC_SAP_5_HIGH_SBS : First STA on high 5 GHZ & Second STA
  * on high 5 GHZ MCC on mac0 and SAP on low 5 GHZ on mac1 doing SBS
- * @PM_24_5_MCC_SCC_PLUS_5_SBS: The 2.4 GHZ vdev creating MCC/SCC with low 5 GHZ
- * or high 5 GHZ (dynamic SBS) on mac 0 and one vdev on high 5 GHZ or low 5 GHZ
- * freq respectively on mac 1 doing SBS
  * @PM_STA_24_STA_5_MCC_SAP_5_LOW_SBS: MLO STA 2+5/6 GHz, SAP on 5/6 GHz
  * low band, the current hw mode is SBS.
+ * @PM_24_5_PLUS_5_LOW_N_HIGH_SHARE_SBS:
  * @PM_SAP_24_STA_5_STA_5_LOW_N_HIGH_SHARE_SBS: The 2.4 GHZ SAP creating MCC/SCC
  * with STA of low 5 GHZ or high 5 GHZ (dynamic SBS) on mac 0 and one STA on
  * high 5 GHZ or low 5 GHZ freq respectively on mac 1 doing SBS
  * @PM_STA_24_SAP_5_STA_5_LOW_N_HIGH_SHARE_SBS: The 2.4 GHZ STA creating MCC/SCC
  * with SAP of low 5 GHZ or high 5 GHZ (dynamic SBS) on mac 0 and one STA on
  * high 5 GHZ or low 5 GHZ freq respectively on mac 1 doing SBS
- * @PM_24_5_PLUS_5_LOW_OR_HIGH_SHARE_SBS (not dynamic SBS): MLO STA 2+5/6 GHz,
+ * @PM_24_5_PLUS_5_LOW_OR_HIGH_SHARE_SBS: (not dynamic SBS) MLO STA 2+5/6 GHz,
  * SAP on 5/6 GHz, and target only support 2.4 GHz shared with 5 GHz low band
  * or 5 GHz high band but not both.
+ * @PM_MAX_THREE_CONNECTION_MODE: Maximum enumeration
  */
 enum policy_mgr_three_connection_mode {
 	PM_STA_SAP_SCC_24_SAP_5_DBS,
@@ -1091,7 +1122,7 @@ enum policy_mgr_three_connection_mode {
  * @PM_DBS2_DOWNGRADE: downgrade 5G beaconing entity to 1x1 and switch to DBS2.
  * @PM_UPGRADE_5G: upgrade 5g beaconing entity to 2x2.
  * @PM_UPGRADE_2G: upgrade 2g beaconing entity to 2x2.
- * @PM_MAX_CONC_PRIORITY_MODE: Max place holder
+ * @PM_MAX_CONC_NEXT_ACTION: Max place holder
  *
  * These are generic IDs that identify the various roles
  * in the software system
@@ -1145,12 +1176,14 @@ enum policy_mgr_band {
  * @POLICY_MGR_UPDATE_REASON_AFTER_CHANNEL_SWITCH: After Channel switch
  * @POLICY_MGR_UPDATE_REASON_CHANNEL_SWITCH_STA: Before Channel switch for STA
  * @POLICY_MGR_UPDATE_REASON_CHANNEL_SWITCH_SAP: Before Channel switch for SAP
+ * @POLICY_MGR_UPDATE_REASON_PRE_CAC: Pre-CAC
  * @POLICY_MGR_UPDATE_REASON_PRI_VDEV_CHANGE: In Dual DBS HW, if the vdev based
  *        2x2 preference enabled, the vdev down may cause prioritized active
  *        vdev change, then DBS hw mode may needs to change from one DBS mode
  *        to the other DBS mode. This reason code indicates such condition.
  * @POLICY_MGR_UPDATE_REASON_NAN_DISCOVERY: NAN Discovery related
  * @POLICY_MGR_UPDATE_REASON_NDP_UPDATE: NAN Datapath related update
+ * @POLICY_MGR_UPDATE_REASON_LFR2_ROAM: Roaming
  * @POLICY_MGR_UPDATE_REASON_STA_CONNECT: STA/CLI connection to peer
  */
 enum policy_mgr_conn_update_reason {
@@ -1172,7 +1205,7 @@ enum policy_mgr_conn_update_reason {
 
 /**
  * enum hw_mode_bandwidth - bandwidth of wifi channel.
- *
+ * @HW_MODE_BW_NONE: no bandwidth configured
  * @HW_MODE_5_MHZ: 5 Mhz bandwidth
  * @HW_MODE_10_MHZ: 10 Mhz bandwidth
  * @HW_MODE_20_MHZ: 20 Mhz bandwidth
@@ -1357,6 +1390,7 @@ struct policy_mgr_disabled_ml_link_info {
  * @mac0_band_cap: mac0 band (5g/2g) capability
  * @dbs_cap: DBS capabality
  * @agile_dfs_cap: Agile DFS capabality
+ * @sbs_cap: SBS capability
  * @emlsr_cap: eMLSR capability
  * @action_type: for dbs mode, the field indicates the "Action type" to be
  * used to switch to the mode. To help the hw mode validation.
@@ -1464,11 +1498,11 @@ struct policy_mgr_vdev_entry_info {
 };
 
 /**
- * struct policy_mgr_freq_range – hw mode freq range for the pdev
- * @low_2ghz_ freq: lower 2.4GHz channels
- * @high_2ghz_ freq: higher 2.4 GHz channels
- * @low_5ghz_ freq: lower 5 GHz channels
- * @high_5ghz_ freq: higher 5 GHz channels
+ * struct policy_mgr_freq_range - hw mode freq range for the pdev
+ * @low_2ghz_freq: lower 2.4GHz channels
+ * @high_2ghz_freq: higher 2.4 GHz channels
+ * @low_5ghz_freq: lower 5 GHz channels
+ * @high_5ghz_freq: higher 5 GHz channels
  */
 struct policy_mgr_freq_range {
 	qdf_freq_t low_2ghz_freq;
@@ -1478,13 +1512,13 @@ struct policy_mgr_freq_range {
 };
 
 /**
- * enum policy_mgr_mode – enum for host mode
+ * enum policy_mgr_mode - enum for host mode
  * @MODE_SMM:               Single mac mode
  * @MODE_DBS:               DBS mode
  * @MODE_SBS:               SBS mode with either high share or low share
  * @MODE_SBS_UPPER_SHARE:   Higher 5Ghz shared with 2.4Ghz
  * @MODE_SBS_LOWER_SHARE:   LOWER 5Ghz shared with 2.4Ghz
- * #MODE_EMLSR:             eMLSR mode
+ * @MODE_EMLSR:             eMLSR mode
  * @MODE_HW_MAX: MAX
  */
 enum policy_mgr_mode {
@@ -1583,7 +1617,7 @@ struct dbs_nss {
 	uint32_t single_mac0_band_cap;
 };
 
-/**
+/*
  * Max radio combination numbers
  */
 #define MAX_RADIO_COMBINATION 16
@@ -1660,14 +1694,14 @@ struct sta_ap_intf_check_work_ctx {
 
 /**
  * enum indoor_conc_update_type - Indoor concurrency update type
- * @CONNECT - On a new STA connection
- * @DISCONNECT_WITHOUT_CONCURRENCY - On a STA disconnection with no active
+ * @CONNECT: On a new STA connection
+ * @DISCONNECT_WITHOUT_CONCURRENCY: On a STA disconnection with no active
  * sessions on the same frequency
- * @DISCONNECT_WITH_CONCURRENCY - On a STA disconnection with an active
+ * @DISCONNECT_WITH_CONCURRENCY: On a STA disconnection with an active
  * session on the same frequency
- * @SWITCH_WITH_CONCURRENCY - On a STA roam or CSA to a different channel
+ * @SWITCH_WITH_CONCURRENCY: On a STA roam or CSA to a different channel
  * with a concurrent SAP on previous frequency
- * @SWITCH_WITHOUT_CONCURRENCY - On a STA roam or CSA to a different channel
+ * @SWITCH_WITHOUT_CONCURRENCY: On a STA roam or CSA to a different channel
  * without any concurrent SAP on previous frequency
  */
 enum indoor_conc_update_type {

components/cmn_services/policy_mgr/inc/wlan_policy_mgr_ucfg.h

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2018-2021 The Linux Foundation. All rights reserved.
- * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -25,6 +25,7 @@
 
 /**
  * ucfg_policy_mgr_psoc_open() - This API sets CFGs to policy manager context
+ * @psoc: pointer to psoc
  *
  * This API pulls policy manager's context from PSOC and initialize the CFG
  * structure of policy manager.
@@ -32,8 +33,10 @@
  * Return: QDF_STATUS_SUCCESS up on success and any other status for failure.
  */
 QDF_STATUS ucfg_policy_mgr_psoc_open(struct wlan_objmgr_psoc *psoc);
+
 /**
  * ucfg_policy_mgr_psoc_close() - This API resets CFGs for policy manager ctx
+ * @psoc: pointer to psoc
  *
  * This API pulls policy manager's context from PSOC and resets the CFG
  * structure of policy manager.
@@ -130,7 +133,7 @@ QDF_STATUS ucfg_policy_mgr_get_conc_rule2(struct wlan_objmgr_psoc *psoc,
 						uint8_t *conc_rule2);
 
 /**
- * policy_mgr_get_chnl_select_plcy() - to get channel selection policy
+ * ucfg_policy_mgr_get_chnl_select_plcy() - to get channel selection policy
  * @psoc: pointer to psoc
  * @chnl_select_plcy: value to be filled
  *
@@ -142,7 +145,7 @@ QDF_STATUS ucfg_policy_mgr_get_conc_rule2(struct wlan_objmgr_psoc *psoc,
 QDF_STATUS ucfg_policy_mgr_get_chnl_select_plcy(struct wlan_objmgr_psoc *psoc,
 						uint32_t *chnl_select_plcy);
 /**
- * policy_mgr_get_mcc_adaptive_sch() - to get mcc adaptive scheduler
+ * ucfg_policy_mgr_get_mcc_adaptive_sch() - to get mcc adaptive scheduler
  * @psoc: pointer to psoc
  * @enable_mcc_adaptive_sch: value to be filled
  *
@@ -376,7 +379,6 @@ ucfg_policy_mgr_get_indoor_chnl_marking(struct wlan_objmgr_psoc *psoc,
  * ucfg_policy_mgr_get_sta_sap_scc_on_indoor_chnl() - to get if
  * sta sap scc on indoor channel is allowed
  * @psoc: pointer to psoc
- * @sap_scc_on_indoor: value to be filled
  *
  * This API is used to get the value of  sta+sap scc on indoor channel
  *

components/cmn_services/policy_mgr/src/wlan_policy_mgr_action.c

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2012-2021 The Linux Foundation. All rights reserved.
- * Copyright (c) 2021-2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2021-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -458,16 +458,6 @@ QDF_STATUS policy_mgr_update_and_wait_for_connection_update(
 	return QDF_STATUS_SUCCESS;
 }
 
-/**
- * policy_mgr_is_dbs_allowed_for_concurrency() - If dbs is allowed for current
- * concurreny
- * @new_conn_mode: new connection mode
- *
- * When a new connection is about to come up, check if dbs is allowed for
- * STA+STA or STA+P2P
- *
- * Return: true if dbs is allowed for STA+STA or STA+P2P else false
- */
 bool policy_mgr_is_dbs_allowed_for_concurrency(
 		struct wlan_objmgr_psoc *psoc, enum QDF_OPMODE new_conn_mode)
 {
@@ -2699,17 +2689,6 @@ policy_mgr_valid_sap_conc_channel_check(struct wlan_objmgr_psoc *psoc,
 	return QDF_STATUS_SUCCESS;
 }
 
-/**
- * policy_mgr_check_concurrent_intf_and_restart_sap() - Check
- * concurrent change intf
- * @psoc: PSOC object information
- * @operation_channel: operation channel
- * @vdev_id: vdev id of SAP
- *
- * Checks the concurrent change interface and restarts SAP
- *
- * Return: None
- */
 void policy_mgr_check_concurrent_intf_and_restart_sap(
 		struct wlan_objmgr_psoc *psoc)
 {

components/cmn_services/policy_mgr/src/wlan_policy_mgr_core.c

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2012-2021 The Linux Foundation. All rights reserved.
- * Copyright (c) 2021-2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2021-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -65,21 +65,6 @@ struct policy_mgr_psoc_priv_obj *policy_mgr_get_context(
 	return pm_ctx;
 }
 
-/**
- * policy_mgr_get_updated_scan_config() - Get the updated scan configuration
- * @scan_config: Pointer containing the updated scan config
- * @dbs_scan: 0 or 1 indicating if DBS scan needs to be enabled/disabled
- * @dbs_plus_agile_scan: 0 or 1 indicating if DBS plus agile scan needs to be
- * enabled/disabled
- * @single_mac_scan_with_dfs: 0 or 1 indicating if single MAC scan with DFS
- * needs to be enabled/disabled
- *
- * Takes the current scan configuration and set the necessary scan config
- * bits to either 0/1 and provides the updated value to the caller who
- * can use this to pass it on to the FW
- *
- * Return: 0 on success
- */
 QDF_STATUS policy_mgr_get_updated_scan_config(
 		struct wlan_objmgr_psoc *psoc,
 		uint32_t *scan_config,
@@ -118,19 +103,6 @@ QDF_STATUS policy_mgr_get_updated_scan_config(
 	return QDF_STATUS_SUCCESS;
 }
 
-/**
- * policy_mgr_get_updated_fw_mode_config() - Get the updated fw
- * mode configuration
- * @fw_mode_config: Pointer containing the updated fw mode config
- * @dbs: 0 or 1 indicating if DBS needs to be enabled/disabled
- * @agile_dfs: 0 or 1 indicating if agile DFS needs to be enabled/disabled
- *
- * Takes the current fw mode configuration and set the necessary fw mode config
- * bits to either 0/1 and provides the updated value to the caller who
- * can use this to pass it on to the FW
- *
- * Return: 0 on success
- */
 QDF_STATUS policy_mgr_get_updated_fw_mode_config(
 		struct wlan_objmgr_psoc *psoc,
 		uint32_t *fw_mode_config,
@@ -153,14 +125,6 @@ QDF_STATUS policy_mgr_get_updated_fw_mode_config(
 	return QDF_STATUS_SUCCESS;
 }
 
-/**
- * policy_mgr_is_dual_mac_disabled_in_ini() - Check if dual mac
- * is disabled in INI
- *
- * Checks if the dual mac feature is disabled in INI
- *
- * Return: true if the dual mac connection is disabled from INI
- */
 bool policy_mgr_is_dual_mac_disabled_in_ini(
 		struct wlan_objmgr_psoc *psoc)
 {
@@ -217,13 +181,6 @@ bool policy_mgr_get_same_mac_conc_sr_status(struct wlan_objmgr_psoc *psoc)
 }
 #endif
 
-/**
- * policy_mgr_get_dbs_config() - Get DBS bit
- *
- * Gets the DBS bit of fw_mode_config_bits
- *
- * Return: 0 or 1 to indicate the DBS bit
- */
 bool policy_mgr_get_dbs_config(struct wlan_objmgr_psoc *psoc)
 {
 	struct policy_mgr_psoc_priv_obj *pm_ctx;
@@ -244,13 +201,6 @@ bool policy_mgr_get_dbs_config(struct wlan_objmgr_psoc *psoc)
 	return WMI_DBS_FW_MODE_CFG_DBS_GET(fw_mode_config);
 }
 
-/**
- * policy_mgr_get_agile_dfs_config() - Get Agile DFS bit
- *
- * Gets the Agile DFS bit of fw_mode_config_bits
- *
- * Return: 0 or 1 to indicate the Agile DFS bit
- */
 bool policy_mgr_get_agile_dfs_config(struct wlan_objmgr_psoc *psoc)
 {
 	struct policy_mgr_psoc_priv_obj *pm_ctx;
@@ -271,13 +221,6 @@ bool policy_mgr_get_agile_dfs_config(struct wlan_objmgr_psoc *psoc)
 	return WMI_DBS_FW_MODE_CFG_AGILE_DFS_GET(fw_mode_config);
 }
 
-/**
- * policy_mgr_get_dbs_scan_config() - Get DBS scan bit
- *
- * Gets the DBS scan bit of concurrent_scan_config_bits
- *
- * Return: 0 or 1 to indicate the DBS scan bit
- */
 bool policy_mgr_get_dbs_scan_config(struct wlan_objmgr_psoc *psoc)
 {
 	uint32_t scan_config;
@@ -298,17 +241,6 @@ bool policy_mgr_get_dbs_scan_config(struct wlan_objmgr_psoc *psoc)
 	return WMI_DBS_CONC_SCAN_CFG_DBS_SCAN_GET(scan_config);
 }
 
-/**
- * policy_mgr_get_tx_rx_ss_from_config() - Get Tx/Rx spatial
- * stream from HW mode config
- * @mac_ss: Config which indicates the HW mode as per 'hw_mode_ss_config'
- * @tx_ss: Contains the Tx spatial stream
- * @rx_ss: Contains the Rx spatial stream
- *
- * Returns the number of spatial streams of Tx and Rx
- *
- * Return: None
- */
 void policy_mgr_get_tx_rx_ss_from_config(enum hw_mode_ss_config mac_ss,
 		uint32_t *tx_ss, uint32_t *rx_ss)
 {
@@ -339,31 +271,6 @@ void policy_mgr_get_tx_rx_ss_from_config(enum hw_mode_ss_config mac_ss,
 	}
 }
 
-/**
- * policy_mgr_get_matching_hw_mode_index() - Get matching HW mode index
- * @psoc: psoc handle
- * @mac0_tx_ss: Number of tx spatial streams of MAC0
- * @mac0_rx_ss: Number of rx spatial streams of MAC0
- * @mac0_bw: Bandwidth of MAC0 of type 'hw_mode_bandwidth'
- * @mac1_tx_ss: Number of tx spatial streams of MAC1
- * @mac1_rx_ss: Number of rx spatial streams of MAC1
- * @mac1_bw: Bandwidth of MAC1 of type 'hw_mode_bandwidth'
- * @mac0_band_cap: mac0 band capability requirement
- *     (0: Don't care, 1: 2.4G, 2: 5G)
- * @dbs: DBS capability of type 'hw_mode_dbs_capab'
- * @dfs: Agile DFS capability of type 'hw_mode_agile_dfs_capab'
- * @sbs: SBS capability of type 'hw_mode_sbs_capab'
- *
- * Fetches the HW mode index corresponding to the HW mode provided.
- * In Genoa two DBS HW modes (2x2 5G + 1x1 2G, 2x2 2G + 1x1 5G),
- * the "ss" number and "bw" value are not enough to specify the expected
- * HW mode. But in both HW mode, the mac0 can support either 5G or 2G.
- * So, the Parameter "mac0_band_cap" will specify the expected band support
- * requirement on mac 0 to find the expected HW mode.
- *
- * Return: Positive hw mode index in case a match is found or a negative
- * value, otherwise
- */
 int8_t policy_mgr_get_matching_hw_mode_index(
 		struct wlan_objmgr_psoc *psoc,
 		uint32_t mac0_tx_ss, uint32_t mac0_rx_ss,
@@ -455,29 +362,6 @@ int8_t policy_mgr_get_matching_hw_mode_index(
 	return found;
 }
 
-/**
- * policy_mgr_get_hw_mode_from_dbs_hw_list() - Get hw_mode index
- * @mac0_ss: MAC0 spatial stream configuration
- * @mac0_bw: MAC0 bandwidth configuration
- * @mac1_ss: MAC1 spatial stream configuration
- * @mac1_bw: MAC1 bandwidth configuration
- * @mac0_band_cap: mac0 band capability requirement
- *     (0: Don't care, 1: 2.4G, 2: 5G)
- * @dbs: HW DBS capability
- * @dfs: HW Agile DFS capability
- * @sbs: HW SBS capability
- *
- * Get the HW mode index corresponding to the HW modes spatial stream,
- * bandwidth, DBS, Agile DFS and SBS capability
- *
- * In Genoa two DBS HW modes (2x2 5G + 1x1 2G, 2x2 2G + 1x1 5G),
- * the "ss" number and "bw" value are not enough to specify the expected
- * HW mode. But in both HW mode, the mac0 can support either 5G or 2G.
- * So, the Parameter "mac0_band_cap" will specify the expected band support
- * requirement on mac 0 to find the expected HW mode.
- *
- * Return: Index number if a match is found or -negative value if not found
- */
 int8_t policy_mgr_get_hw_mode_idx_from_dbs_hw_list(
 		struct wlan_objmgr_psoc *psoc,
 		enum hw_mode_ss_config mac0_ss,
@@ -511,16 +395,6 @@ int8_t policy_mgr_get_hw_mode_idx_from_dbs_hw_list(
 						dbs, dfs, sbs);
 }
 
-/**
- * policy_mgr_get_hw_mode_from_idx() - Get HW mode based on index
- * @psoc: psoc object
- * @idx: HW mode id
- * @hw_mode: HW mode params
- *
- * Fetches the HW mode parameters
- *
- * Return: Success if hw mode is obtained and the hw mode params
- */
 QDF_STATUS policy_mgr_get_hw_mode_from_idx(
 		struct wlan_objmgr_psoc *psoc,
 		uint32_t idx,
@@ -582,19 +456,6 @@ QDF_STATUS policy_mgr_get_hw_mode_from_idx(
 	return QDF_STATUS_SUCCESS;
 }
 
-/**
- * policy_mgr_get_old_and_new_hw_index() - Get the old and new HW index
- * @old_hw_mode_index: Value at this pointer contains the old HW mode index
- * Default value when not configured is POLICY_MGR_DEFAULT_HW_MODE_INDEX
- * @new_hw_mode_index: Value at this pointer contains the new HW mode index
- * Default value when not configured is POLICY_MGR_DEFAULT_HW_MODE_INDEX
- *
- * Get the old and new HW index configured in the driver
- *
- * Return: Failure in case the HW mode indices cannot be fetched and Success
- * otherwise. When no HW mode transition has happened the values of
- * old_hw_mode_index and new_hw_mode_index will be the same.
- */
 QDF_STATUS policy_mgr_get_old_and_new_hw_index(
 		struct wlan_objmgr_psoc *psoc,
 		uint32_t *old_hw_mode_index,
@@ -680,6 +541,7 @@ void policy_mgr_update_conc_list(struct wlan_objmgr_psoc *psoc,
 
 /**
  * policy_mgr_store_and_del_conn_info() - Store and del a connection info
+ * @psoc: psoc handle
  * @mode: Mode whose entry has to be deleted
  * @all_matching_cxn_to_del: All the specified mode entries should be deleted
  * @info: Structure array pointer where the connection info will be saved
@@ -854,6 +716,7 @@ void policy_mgr_store_and_del_conn_info_by_chan_and_mode(
 
 /**
  * policy_mgr_restore_deleted_conn_info() - Restore connection info
+ * @psoc: psoc handle
  * @info: An array saving connection info that is to be restored
  * @num_cxn_del: Number of connection temporary deleted
  *
@@ -1051,6 +914,7 @@ policy_mgr_update_curr_mac_freq(uint32_t num_mac_freq,
 /**
  * policy_mgr_update_hw_mode_conn_info() - Update connection
  * info based on HW mode
+ * @psoc: psoc handle
  * @num_vdev_mac_entries: Number of vdev-mac id entries that follow
  * @vdev_mac_map: Mapping of vdev-mac id
  * @hw_mode: HW mode
@@ -1450,7 +1314,9 @@ policy_mgr_dump_dual_mac_concurrency(struct policy_mgr_psoc_priv_obj *pm_ctx,
 /**
  * policy_mgr_dump_dbs_concurrency() - To dump the dbs concurrency
  * combination
+ * @psoc: psoc handle
  * @cc_mode: connection string
+ * @length: Maximum size of the string
  *
  * This routine is called to dump the concurrency info
  *
@@ -1474,7 +1340,9 @@ static void policy_mgr_dump_dbs_concurrency(struct wlan_objmgr_psoc *psoc,
 /**
  * policy_mgr_dump_sbs_concurrency() - To dump the sbs concurrency
  * combination
+ * @psoc: psoc handle
  * @cc_mode: connection string
+ * @length: Maximum size of the string
  *
  * This routine is called to dump the concurrency info
  *
@@ -1623,14 +1491,6 @@ policy_mgr_handle_dump_4th_connection(struct policy_mgr_psoc_priv_obj *pm_ctx,
 }
 #endif
 
-/**
- * policy_mgr_dump_current_concurrency() - To dump the current
- * concurrency combination
- *
- * This routine is called to dump the concurrency info
- *
- * Return: None
- */
 void policy_mgr_dump_current_concurrency(struct wlan_objmgr_psoc *psoc)
 {
 	uint32_t num_connections = 0;
@@ -1728,6 +1588,7 @@ void policy_mgr_dump_current_concurrency(struct wlan_objmgr_psoc *psoc)
 
 /**
  * policy_mgr_set_pcl_for_existing_combo() - Set PCL for existing connection
+ * @psoc: psoc handle
  * @mode: Connection mode of type 'policy_mgr_con_mode'
  * @vdev_id: Vdev Id
  *
@@ -3066,6 +2927,7 @@ policy_mgr_2ghz_connection_present(struct policy_mgr_psoc_priv_obj *pm_ctx)
 /**
  * policy_mgr_get_channel_list() - provides the channel list
  * suggestion for new connection
+ * @psoc: psoc handle
  * @pcl: The preferred channel list enum
  * @mode: concurrency mode for which channel list is requested
  * @pcl_channels: PCL channels
@@ -4548,7 +4410,7 @@ sbs_check:
 /**
  * policy_mgr_nss_update_cb() - callback from SME confirming nss
  * update
- * @hdd_ctx:	HDD Context
+ * @psoc: psoc handle
  * @tx_status: tx completion status for updated beacon with new
  *		nss value
  * @vdev_id: vdev id for the specific connection
@@ -4556,6 +4418,7 @@ sbs_check:
  *		beacon update
  * @reason: Reason for nss update
  * @original_vdev_id: original request hwmode change vdev id
+ * @request_id: request ID
  *
  * This function is the callback registered with SME at nss
  * update request time
@@ -4801,15 +4664,6 @@ QDF_STATUS policy_mgr_init_connection_update(
 	return QDF_STATUS_SUCCESS;
 }
 
-/**
- * policy_mgr_get_current_pref_hw_mode_dbs_2x2() - Get the
- * current preferred hw mode
- *
- * Get the preferred hw mode based on the current connection combinations
- *
- * Return: No change (PM_NOP), MCC (PM_SINGLE_MAC),
- *         DBS (PM_DBS), SBS (PM_SBS)
- */
 enum policy_mgr_conc_next_action
 		policy_mgr_get_current_pref_hw_mode_dbs_2x2(
 		struct wlan_objmgr_psoc *psoc)
@@ -4907,15 +4761,6 @@ enum policy_mgr_conc_next_action
 	}
 }
 
-/**
- * policy_mgr_get_current_pref_hw_mode_dbs_1x1() - Get the
- * current preferred hw mode
- *
- * Get the preferred hw mode based on the current connection combinations
- *
- * Return: No change (PM_NOP), MCC (PM_SINGLE_MAC_UPGRADE),
- *         DBS (PM_DBS_DOWNGRADE)
- */
 enum policy_mgr_conc_next_action
 		policy_mgr_get_current_pref_hw_mode_dbs_1x1(
 		struct wlan_objmgr_psoc *psoc)
@@ -5028,13 +4873,6 @@ policy_mgr_get_current_pref_hw_mode_dual_dbs(
 	return next_action;
 }
 
-/**
- * policy_mgr_reset_sap_mandatory_channels() - Reset the SAP mandatory channels
- *
- * Resets the SAP mandatory channel list and the length of the list
- *
- * Return: QDF_STATUS
- */
 QDF_STATUS policy_mgr_reset_sap_mandatory_channels(
 		struct policy_mgr_psoc_priv_obj *pm_ctx)
 {

components/cmn_services/policy_mgr/src/wlan_policy_mgr_get_set_utils.c

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2012-2021 The Linux Foundation. All rights reserved.
- * Copyright (c) 2021-2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2021-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -735,7 +735,7 @@ static void policy_mgr_get_hw_mode_params(
 /**
  * policy_mgr_set_hw_mode_params() - sets TX-RX stream,
  * bandwidth and DBS in hw_mode_list
- * @wma_handle: pointer to wma global structure
+ * @psoc: PSOC object information
  * @mac0_ss_bw_info: TX-RX streams, BW for MAC0
  * @mac1_ss_bw_info: TX-RX streams, BW for MAC1
  * @pos: refers to hw_mode_list array index
@@ -4877,7 +4877,7 @@ policy_mgr_validate_set_mlo_link_cb(struct wlan_objmgr_psoc *psoc,
  * @mode: Force reason
  * @num_mlo_vdev: number of mlo vdev
  * @mlo_vdev_lst: MLO STA vdev list
-
+ *
  * Interface manager Set links for MLO STA
  *
  * Return: void
@@ -6908,6 +6908,7 @@ bool policy_mgr_will_freq_lead_to_mcc(struct wlan_objmgr_psoc *psoc,
 /**
  * policy_mgr_is_two_connection_mcc() - Check if MCC scenario
  * when there are two connections
+ * @psoc: PSOC object information
  *
  * If if MCC scenario when there are two connections
  *

components/cmn_services/policy_mgr/src/wlan_policy_mgr_i.h

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2012-2021 The Linux Foundation. All rights reserved.
- * Copyright (c) 2021-2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2021-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -43,7 +43,7 @@
 #define CHANNEL_SWITCH_COMPLETE_TIMEOUT   (2000)
 #define MAX_NOA_TIME (3000)
 
-/**
+/*
  * Policy Mgr hardware mode list bit-mask definitions.
  * Bits 4:0, 31:29 are unused.
  *
@@ -315,6 +315,8 @@ struct policy_mgr_cfg {
  *                         Mode opportunistically
  * @sap_restart_chan_switch_cb: Callback for channel switch
  *                            notification for SAP
+ * @hdd_cbacks: callbacks to be registered by HDD for
+ *            interaction with Policy Manager
  * @sme_cbacks: callbacks to be registered by SME for
  *            interaction with Policy Manager
  * @wma_cbacks: callbacks to be registered by SME for
@@ -323,6 +325,8 @@ struct policy_mgr_cfg {
  * interaction with Policy Manager
  * @cdp_cbacks: callbacks to be registered by SME for
  * interaction with Policy Manager
+ * @dp_cbacks: callbacks to be registered by Datapath for
+ * interaction with Policy Manager
  * @conc_cbacks: callbacks to be registered by lim for
  * interaction with Policy Manager
  * @sap_mandatory_channels: The user preferred master list on
@@ -338,6 +342,7 @@ struct policy_mgr_cfg {
  * @no_of_open_sessions: Number of active vdevs
  * @no_of_active_sessions: Number of active connections
  * @sta_ap_intf_check_work: delayed sap restart work
+ * @nan_sap_conc_work: Info related to nan sap conc work
  * @num_dbs_hw_modes: Number of different HW modes supported
  * @hw_mode: List of HW modes supported
  * @old_hw_mode_index: Old HW mode from hw_mode table
@@ -350,19 +355,23 @@ struct policy_mgr_cfg {
  *                            change is in progress
  * @enable_mcc_adaptive_scheduler: Enable MCC adaptive scheduler
  *      value from INI
+ * @user_cfg:
  * @unsafe_channel_list: LTE coex channel freq avoidance list
  * @unsafe_channel_count: LTE coex channel avoidance list count
  * @sta_ap_intf_check_work_info: Info related to sta_ap_intf_check_work
- * @nan_sap_conc_work: Info related to nan sap conc work
+ * @cur_conc_system_pref:
  * @opportunistic_update_done_evt: qdf event to synchronize host
  *                               & FW HW mode
  * @channel_switch_complete_evt: qdf event for channel switch completion check
  * @mode_change_cb: Mode change callback
  * @cfg: Policy manager config data
+ * @valid_ch_freq_list: valid frequencies
+ * @valid_ch_freq_list_count: number of valid frequencies
  * @dynamic_mcc_adaptive_sched: disable/enable mcc adaptive scheduler feature
  * @dynamic_dfs_master_disabled: current state of dynamic dfs master
  * @set_link_in_progress: To track if set link is in progress
  * @set_link_update_done_evt: qdf event to synchronize set link
+ * @restriction_mask:
  */
 struct policy_mgr_psoc_priv_obj {
 	struct wlan_objmgr_psoc *psoc;
@@ -472,17 +481,59 @@ bool policy_mgr_get_same_mac_conc_sr_status(struct wlan_objmgr_psoc *psoc)
 
 struct policy_mgr_psoc_priv_obj *policy_mgr_get_context(
 		struct wlan_objmgr_psoc *psoc);
+
+/**
+ * policy_mgr_get_updated_scan_config() - Get the updated scan configuration
+ * @psoc: psoc handle
+ * @scan_config: Pointer containing the updated scan config
+ * @dbs_scan: 0 or 1 indicating if DBS scan needs to be enabled/disabled
+ * @dbs_plus_agile_scan: 0 or 1 indicating if DBS plus agile scan needs to be
+ * enabled/disabled
+ * @single_mac_scan_with_dfs: 0 or 1 indicating if single MAC scan with DFS
+ * needs to be enabled/disabled
+ *
+ * Takes the current scan configuration and set the necessary scan config
+ * bits to either 0/1 and provides the updated value to the caller who
+ * can use this to pass it on to the FW
+ *
+ * Return: 0 on success
+ */
 QDF_STATUS policy_mgr_get_updated_scan_config(
 		struct wlan_objmgr_psoc *psoc,
 		uint32_t *scan_config,
 		bool dbs_scan,
 		bool dbs_plus_agile_scan,
 		bool single_mac_scan_with_dfs);
+
+/**
+ * policy_mgr_get_updated_fw_mode_config() - Get the updated fw
+ * mode configuration
+ * @psoc: psoc handle
+ * @fw_mode_config: Pointer containing the updated fw mode config
+ * @dbs: 0 or 1 indicating if DBS needs to be enabled/disabled
+ * @agile_dfs: 0 or 1 indicating if agile DFS needs to be enabled/disabled
+ *
+ * Takes the current fw mode configuration and set the necessary fw mode config
+ * bits to either 0/1 and provides the updated value to the caller who
+ * can use this to pass it on to the FW
+ *
+ * Return: 0 on success
+ */
 QDF_STATUS policy_mgr_get_updated_fw_mode_config(
 		struct wlan_objmgr_psoc *psoc,
 		uint32_t *fw_mode_config,
 		bool dbs,
 		bool agile_dfs);
+
+/**
+ * policy_mgr_is_dual_mac_disabled_in_ini() - Check if dual mac
+ * is disabled in INI
+ * @psoc: psoc handle
+ *
+ * Checks if the dual mac feature is disabled in INI
+ *
+ * Return: true if the dual mac connection is disabled from INI
+ */
 bool policy_mgr_is_dual_mac_disabled_in_ini(
 		struct wlan_objmgr_psoc *psoc);
 
@@ -507,11 +558,76 @@ bool policy_mgr_find_if_hwlist_has_dbs(struct wlan_objmgr_psoc *psoc);
  */
 uint32_t policy_mgr_get_mcc_to_scc_switch_mode(
 	struct wlan_objmgr_psoc *psoc);
+
+/**
+ * policy_mgr_get_dbs_config() - Get DBS bit
+ * @psoc: psoc handle
+ *
+ * Gets the DBS bit of fw_mode_config_bits
+ *
+ * Return: 0 or 1 to indicate the DBS bit
+ */
 bool policy_mgr_get_dbs_config(struct wlan_objmgr_psoc *psoc);
+
+/**
+ * policy_mgr_get_agile_dfs_config() - Get Agile DFS bit
+ * @psoc: psoc handle
+ *
+ * Gets the Agile DFS bit of fw_mode_config_bits
+ *
+ * Return: 0 or 1 to indicate the Agile DFS bit
+ */
 bool policy_mgr_get_agile_dfs_config(struct wlan_objmgr_psoc *psoc);
+
+/**
+ * policy_mgr_get_dbs_scan_config() - Get DBS scan bit
+ * @psoc: psoc handle
+ *
+ * Gets the DBS scan bit of concurrent_scan_config_bits
+ *
+ * Return: 0 or 1 to indicate the DBS scan bit
+ */
 bool policy_mgr_get_dbs_scan_config(struct wlan_objmgr_psoc *psoc);
+
+/**
+ * policy_mgr_get_tx_rx_ss_from_config() - Get Tx/Rx spatial
+ * stream from HW mode config
+ * @mac_ss: Config which indicates the HW mode as per 'hw_mode_ss_config'
+ * @tx_ss: Contains the Tx spatial stream
+ * @rx_ss: Contains the Rx spatial stream
+ *
+ * Returns the number of spatial streams of Tx and Rx
+ *
+ * Return: None
+ */
 void policy_mgr_get_tx_rx_ss_from_config(enum hw_mode_ss_config mac_ss,
 		uint32_t *tx_ss, uint32_t *rx_ss);
+
+/**
+ * policy_mgr_get_matching_hw_mode_index() - Get matching HW mode index
+ * @psoc: psoc handle
+ * @mac0_tx_ss: Number of tx spatial streams of MAC0
+ * @mac0_rx_ss: Number of rx spatial streams of MAC0
+ * @mac0_bw: Bandwidth of MAC0 of type 'hw_mode_bandwidth'
+ * @mac1_tx_ss: Number of tx spatial streams of MAC1
+ * @mac1_rx_ss: Number of rx spatial streams of MAC1
+ * @mac1_bw: Bandwidth of MAC1 of type 'hw_mode_bandwidth'
+ * @mac0_band_cap: mac0 band capability requirement
+ *     (0: Don't care, 1: 2.4G, 2: 5G)
+ * @dbs: DBS capability of type 'hw_mode_dbs_capab'
+ * @dfs: Agile DFS capability of type 'hw_mode_agile_dfs_capab'
+ * @sbs: SBS capability of type 'hw_mode_sbs_capab'
+ *
+ * Fetches the HW mode index corresponding to the HW mode provided.
+ * In Genoa two DBS HW modes (2x2 5G + 1x1 2G, 2x2 2G + 1x1 5G),
+ * the "ss" number and "bw" value are not enough to specify the expected
+ * HW mode. But in both HW mode, the mac0 can support either 5G or 2G.
+ * So, the Parameter "mac0_band_cap" will specify the expected band support
+ * requirement on mac 0 to find the expected HW mode.
+ *
+ * Return: Positive hw mode index in case a match is found or a negative
+ * value, otherwise
+ */
 int8_t policy_mgr_get_matching_hw_mode_index(
 		struct wlan_objmgr_psoc *psoc,
 		uint32_t mac0_tx_ss, uint32_t mac0_rx_ss,
@@ -522,6 +638,31 @@ int8_t policy_mgr_get_matching_hw_mode_index(
 		enum hw_mode_dbs_capab dbs,
 		enum hw_mode_agile_dfs_capab dfs,
 		enum hw_mode_sbs_capab sbs);
+
+/**
+ * policy_mgr_get_hw_mode_idx_from_dbs_hw_list() - Get hw_mode index
+ * @psoc: psoc handle
+ * @mac0_ss: MAC0 spatial stream configuration
+ * @mac0_bw: MAC0 bandwidth configuration
+ * @mac1_ss: MAC1 spatial stream configuration
+ * @mac1_bw: MAC1 bandwidth configuration
+ * @mac0_band_cap: mac0 band capability requirement
+ *     (0: Don't care, 1: 2.4G, 2: 5G)
+ * @dbs: HW DBS capability
+ * @dfs: HW Agile DFS capability
+ * @sbs: HW SBS capability
+ *
+ * Get the HW mode index corresponding to the HW modes spatial stream,
+ * bandwidth, DBS, Agile DFS and SBS capability
+ *
+ * In Genoa two DBS HW modes (2x2 5G + 1x1 2G, 2x2 2G + 1x1 5G),
+ * the "ss" number and "bw" value are not enough to specify the expected
+ * HW mode. But in both HW mode, the mac0 can support either 5G or 2G.
+ * So, the Parameter "mac0_band_cap" will specify the expected band support
+ * requirement on mac 0 to find the expected HW mode.
+ *
+ * Return: Index number if a match is found or -negative value if not found
+ */
 int8_t policy_mgr_get_hw_mode_idx_from_dbs_hw_list(
 		struct wlan_objmgr_psoc *psoc,
 		enum hw_mode_ss_config mac0_ss,
@@ -532,6 +673,21 @@ int8_t policy_mgr_get_hw_mode_idx_from_dbs_hw_list(
 		enum hw_mode_dbs_capab dbs,
 		enum hw_mode_agile_dfs_capab dfs,
 		enum hw_mode_sbs_capab sbs);
+
+/**
+ * policy_mgr_get_old_and_new_hw_index() - Get the old and new HW index
+ * @psoc: psoc handle
+ * @old_hw_mode_index: Value at this pointer contains the old HW mode index
+ * Default value when not configured is POLICY_MGR_DEFAULT_HW_MODE_INDEX
+ * @new_hw_mode_index: Value at this pointer contains the new HW mode index
+ * Default value when not configured is POLICY_MGR_DEFAULT_HW_MODE_INDEX
+ *
+ * Get the old and new HW index configured in the driver
+ *
+ * Return: Failure in case the HW mode indices cannot be fetched and Success
+ * otherwise. When no HW mode transition has happened the values of
+ * old_hw_mode_index and new_hw_mode_index will be the same.
+ */
 QDF_STATUS policy_mgr_get_old_and_new_hw_index(
 		struct wlan_objmgr_psoc *psoc,
 		uint32_t *old_hw_mode_index,
@@ -539,12 +695,14 @@ QDF_STATUS policy_mgr_get_old_and_new_hw_index(
 
 /**
  * policy_mgr_update_conc_list() - Update the concurrent connection list
+ * @psoc: PSOC object information
  * @conn_index: Connection index
  * @mode: Mode
- * @ch_freq: channel frequency
+ * @freq: channel frequency
  * @bw: Bandwidth
  * @mac: Mac id
  * @chain_mask: Chain mask
+ * @original_nss: Original number of spatial streams
  * @vdev_id: vdev id
  * @in_use: Flag to indicate if the index is in use or not
  * @update_conn: Flag to indicate if mode change event should
@@ -641,7 +799,17 @@ static inline void
 policy_mgr_dump_disabled_ml_links(struct policy_mgr_psoc_priv_obj *pm_ctx) {}
 #endif
 
+/**
+ * policy_mgr_dump_current_concurrency() - To dump the current
+ * concurrency combination
+ * @psoc: psoc handle
+ *
+ * This routine is called to dump the concurrency info
+ *
+ * Return: None
+ */
 void policy_mgr_dump_current_concurrency(struct wlan_objmgr_psoc *psoc);
+
 void pm_dbs_opportunistic_timer_handler(void *data);
 enum policy_mgr_con_mode policy_mgr_get_mode(uint8_t type,
 		uint8_t subtype);
@@ -686,6 +854,7 @@ bool policy_mgr_allow_new_home_channel(
 
 /**
  * policy_mgr_is_5g_channel_allowed() - check if 5g channel is allowed
+ * @psoc: PSOC object information
  * @ch_freq: channel frequency which needs to be validated
  * @list: list of existing connections.
  * @mode: mode against which channel needs to be validated
@@ -706,6 +875,7 @@ bool policy_mgr_is_5g_channel_allowed(struct wlan_objmgr_psoc *psoc,
  * policy_mgr_complete_action() - initiates actions needed on
  * current connections once channel has been decided for the new
  * connection
+ * @psoc: PSOC object information
  * @new_nss: the new nss value
  * @next_action: next action to happen at policy mgr after
  *		beacon update
@@ -723,14 +893,37 @@ QDF_STATUS policy_mgr_complete_action(struct wlan_objmgr_psoc *psoc,
 				uint8_t  new_nss, uint8_t next_action,
 				enum policy_mgr_conn_update_reason reason,
 				uint32_t session_id, uint32_t request_id);
+
 enum policy_mgr_con_mode policy_mgr_get_mode_by_vdev_id(
 		struct wlan_objmgr_psoc *psoc,
 		uint8_t vdev_id);
 QDF_STATUS policy_mgr_init_connection_update(
 		struct policy_mgr_psoc_priv_obj *pm_ctx);
+
+/**
+ * policy_mgr_get_current_pref_hw_mode_dbs_2x2() - Get the
+ * current preferred hw mode
+ * @psoc: psoc handle
+ *
+ * Get the preferred hw mode based on the current connection combinations
+ *
+ * Return: No change (PM_NOP), MCC (PM_SINGLE_MAC),
+ *         DBS (PM_DBS), SBS (PM_SBS)
+ */
 enum policy_mgr_conc_next_action
 		policy_mgr_get_current_pref_hw_mode_dbs_2x2(
 		struct wlan_objmgr_psoc *psoc);
+
+/**
+ * policy_mgr_get_current_pref_hw_mode_dbs_1x1() - Get the
+ * current preferred hw mode
+ * @psoc: psoc handle
+ *
+ * Get the preferred hw mode based on the current connection combinations
+ *
+ * Return: No change (PM_NOP), MCC (PM_SINGLE_MAC_UPGRADE),
+ *         DBS (PM_DBS_DOWNGRADE)
+ */
 enum policy_mgr_conc_next_action
 		policy_mgr_get_current_pref_hw_mode_dbs_1x1(
 		struct wlan_objmgr_psoc *psoc);
@@ -738,6 +931,7 @@ enum policy_mgr_conc_next_action
 /**
  * policy_mgr_get_current_pref_hw_mode_dual_dbs() - Get the
  * current preferred hw mode
+ * @psoc: PSOC object information
  *
  * Get the preferred hw mode based on the current connection combinations
  *
@@ -748,11 +942,19 @@ enum policy_mgr_conc_next_action
 		policy_mgr_get_current_pref_hw_mode_dual_dbs(
 		struct wlan_objmgr_psoc *psoc);
 
+/**
+ * policy_mgr_reset_sap_mandatory_channels() - Reset the SAP mandatory channels
+ * @pm_ctx: policy mgr context
+ *
+ * Resets the SAP mandatory channel list and the length of the list
+ *
+ * Return: QDF_STATUS
+ */
 QDF_STATUS policy_mgr_reset_sap_mandatory_channels(
 		struct policy_mgr_psoc_priv_obj *pm_ctx);
 
 /**
- * policy_mgr_update_hw_mode_list() - Function to print frequency range
+ * policy_mgr_dump_freq_range_per_mac() - Function to print frequency range
  * for both MAC 0 and MAC1 for given Hw mode
  *
  * @freq_range: Policy Mgr context
@@ -784,7 +986,7 @@ policy_mgr_fill_curr_mac_freq_by_hwmode(struct policy_mgr_psoc_priv_obj *pm_ctx,
 					enum policy_mgr_mode mode_hw);
 
 /**
- * policy_mgr_update_hw_mode_list() - Function to print every frequency range
+ * policy_mgr_dump_freq_range() - Function to print every frequency range
  * for both MAC 0 and MAC1 for every Hw mode
  *
  * @pm_ctx: Policy Mgr context
@@ -936,6 +1138,7 @@ bool policy_mgr_2_freq_same_mac_in_sbs(struct policy_mgr_psoc_priv_obj *pm_ctx,
 /**
  * policy_mgr_get_connection_for_vdev_id() - provides the
  * particular connection with the requested vdev id
+ * @psoc: PSOC object information
  * @vdev_id: vdev id of the connection
  *
  * This function provides the specific connection with the

components/cmn_services/policy_mgr/src/wlan_policy_mgr_pcl.c

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2012-2021 The Linux Foundation. All rights reserved.
- * Copyright (c) 2021-2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2021-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -397,7 +397,7 @@ void policy_mgr_decr_session_set_pcl(struct wlan_objmgr_psoc *psoc,
 /**
  * policy_mgr_update_valid_ch_freq_list() - Update policy manager valid ch list
  * @pm_ctx: policy manager context data
- * @ch_list: Regulatory channel list
+ * @reg_ch_list: Regulatory channel list
  * @is_client: true if caller is a client, false if it is a beaconing entity
  *
  * When regulatory component channel list is updated this internal function is
@@ -2373,7 +2373,7 @@ policy_mgr_get_index_for_ml_sta_sap_dbs(
 }
 
 /**
- * policy_mgr_get_index_for_ml_sta_sap_sbs() - Find the index for next
+ * policy_mgr_get_index_for_ml_sta_sap_hwmode_sbs() - Find the index for next
  * connection for ML STA + SAP, in case current HW mode is SBS but ML STA is
  * with 2 GHz + 5/6 GHz.
  * @pm_ctx: policy manager context

components/cmn_services/policy_mgr/src/wlan_policy_mgr_tables_1x1_dbs_i.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2012-2021 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -21,7 +22,7 @@
 
 #include "wlan_policy_mgr_api.h"
 
-/**
+/*
  * second_connection_pcl_dbs_1x1_table - table which provides PCL
  * for the 2nd connection, when we have a connection already in
  * the system (with DBS supported by HW)
@@ -133,7 +134,7 @@ pm_second_connection_pcl_dbs_1x1_table = {
 	[PM_P2P_GO_MODE] = {PM_SCC_CH_24G, PM_SCC_CH_24G, PM_SCC_CH_24G} },
 };
 
-/**
+/*
  * third_connection_pcl_dbs_table - table which provides PCL for
  * the 3rd connection, when we have two connections already in
  * the system (with DBS supported by HW). For helium that is NON-DBS,
@@ -2167,7 +2168,7 @@ pm_third_connection_pcl_dbs_1x1_table = {
 	},
 };
 
-/**
+/*
  * next_action_two_connection_table - table which provides next
  * action while a new connection is coming up, with one
  * connection already in the system
@@ -2192,7 +2193,7 @@ static policy_mgr_next_action_two_connection_table_type
 	[PM_SAP_5_2x2] = {PM_DBS_DOWNGRADE,   PM_NOP},
 };
 
-/**
+/*
  * next_action_three_connection_table - table which provides next
  * action while a new connection is coming up, with two
  * connections already in the system

components/cmn_services/policy_mgr/src/wlan_policy_mgr_tables_2x2_2g_1x1_5g.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2012-2018, 2020 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -21,7 +22,7 @@
 
 #include "wlan_policy_mgr_api.h"
 
-/**
+/*
  * next_action_two_connection_table - table which provides next
  * action while a new connection is coming up, with one
  * connection already in the system
@@ -46,7 +47,7 @@ static policy_mgr_next_action_two_connection_table_type
 	[PM_SAP_5_2x2] = {PM_DBS2_DOWNGRADE, PM_NOP},
 };
 
-/**
+/*
  * next_action_three_connection_table - table which provides next
  * action while a new connection is coming up, with two
  * connections already in the system

components/cmn_services/policy_mgr/src/wlan_policy_mgr_tables_2x2_5g_1x1_2g.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2012-2018, 2020 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -21,7 +22,7 @@
 
 #include "wlan_policy_mgr_api.h"
 
-/**
+/*
  * next_action_two_connection_table - table which provides next
  * action while a new connection is coming up, with one
  * connection already in the system
@@ -46,7 +47,7 @@ static policy_mgr_next_action_two_connection_table_type
 	[PM_SAP_5_2x2] = {PM_DBS1,		PM_NOP},
 };
 
-/**
+/*
  * next_action_three_connection_table - table which provides next
  * action while a new connection is coming up, with two
  * connections already in the system

components/cmn_services/policy_mgr/src/wlan_policy_mgr_tables_2x2_dbs_i.h

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2012-2021 The Linux Foundation. All rights reserved.
- * Copyright (c) 2021-2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2021-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -22,7 +22,7 @@
 
 #include "wlan_policy_mgr_api.h"
 
-/**
+/*
  * second_connection_pcl_dbs_2x2_table - table which provides PCL
  * for the 2nd connection, when we have a connection already in
  * the system (with DBS supported by HW)
@@ -220,7 +220,7 @@ pm_second_connection_pcl_dbs_2x2_table = {
 			 PM_5G_SCC_CH } },
 };
 
-/**
+/*
  * third_connection_pcl_dbs_table - table which provides PCL for
  * the 3rd connection, when we have two connections already in
  * the system (with DBS supported by HW)
@@ -1905,7 +1905,7 @@ pm_third_connection_pcl_dbs_2x2_table = {
 };
 
 #ifdef FEATURE_FOURTH_CONNECTION
-/**
+/*
  * fourth_connection_pcl_dbs_sbs_table - table which provides PCL for
  * the 4th connection, when we have 3 connections already in
  * the system (with DBS & SBS supported by HW), this table is for auto products.
@@ -1942,7 +1942,7 @@ fourth_connection_pcl_dbs_sbs_table
 	[PM_SAP_MODE] = { PM_24G, PM_24G, PM_24G } }
 };
 #else
-/**
+/*
  * fourth_connection_pcl_dbs_sbs_table - table which provides PCL for
  * the 4th connection, when we have 3 connections already in
  * the system (with DBS & SBS supported by HW), this table is for mobile
@@ -2030,7 +2030,7 @@ fourth_connection_pcl_dbs_sbs_table
 #endif
 #endif
 
-/**
+/*
  * next_action_two_connection_table - table which provides next
  * action while a new connection is coming up, with one
  * connection already in the system
@@ -2055,7 +2055,7 @@ static policy_mgr_next_action_two_connection_table_type
 	[PM_SAP_5_2x2] = {PM_DBS,		PM_SBS_DOWNGRADE},
 };
 
-/**
+/*
  * next_action_three_connection_table - table which provides next
  * action while a new connection is coming up, with two
  * connections already in the system
@@ -2170,7 +2170,7 @@ static policy_mgr_next_action_three_connection_table_type
 	[PM_P2P_GO_SAP_SBS_5_1x1] = {PM_DBS_UPGRADE, PM_NOP},
 };
 
-/**
+/*
  * next_action_two_connection_table_v2 - table which provides next
  * action while a new connection is coming up, with one
  * connection already in the system.

components/cmn_services/policy_mgr/src/wlan_policy_mgr_tables_2x2_dbs_sbs_i.h

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2021 The Linux Foundation. All rights reserved.
- * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -22,7 +22,7 @@
 
 #include "wlan_policy_mgr_api.h"
 
-/**
+/*
  * pm_second_connection_pcl_dbs_sbs_2x2_table - table which provides PCL
  * for the 2nd connection, when we have a connection already in
  * the system (with DBS-SBS supported by HW)
@@ -222,7 +222,7 @@ pm_second_connection_pcl_dbs_sbs_2x2_table = {
 			 PM_5G_SCC_CH } },
 };
 
-/**
+/*
  * third_connection_pcl_dbs_table - table which provides PCL for
  * the 3rd connection, when we have two connections already in
  * the system (with DBS supported by HW)

components/cmn_services/policy_mgr/src/wlan_policy_mgr_tables_no_dbs_i.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2012-2017, 2019-2020 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -21,7 +22,7 @@
 
 #include "wlan_policy_mgr_api.h"
 
-/**
+/*
  * second_connection_pcl_nodbs_table - table which provides PCL
  * for the 2nd connection, when we have a connection already in
  * the system (with DBS not supported by HW)
@@ -184,7 +185,7 @@ second_connection_pcl_nodbs_table[PM_MAX_ONE_CONNECTION_MODE]
 	[PM_NDI_MODE] = {PM_NONE, PM_NONE, PM_NONE} },
 };
 
-/**
+/*
  * third_connection_pcl_nodbs_table - table which provides PCL
  * for the 3rd connection, when we have two connections already
  * in the system (with DBS not supported by HW). For helium that is NON-DBS,
@@ -1530,7 +1531,7 @@ third_connection_pcl_nodbs_table[PM_MAX_TWO_CONNECTION_MODE]
 
 #ifdef FEATURE_NO_DBS_INTRABAND_MCC_SUPPORT
 
-/**
+/*
  * second_connection_pcl_nodbs_no_interband_mcc_table - table
  * which provides PCL for the 2nd connection, when we have a
  * connection already in the system (when DBS and interband mcc
@@ -1714,7 +1715,7 @@ second_connection_pcl_nodbs_no_interband_mcc_table[PM_MAX_ONE_CONNECTION_MODE]
 	[PM_NDI_MODE] = {PM_SCC_CH_24G, PM_SCC_CH_24G, PM_SCC_CH_24G} },
 };
 
-/**
+/*
  * third_connection_pcl_nodbs_no_interband_mcc_table - table which provides
  * PCL for the 3rd connection, when we have two connections already in
  * the system (when DBS and interband mcc are not supported by HW)