samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qcacmn: Do not setup CE write index offset for FW only CE rings

Browse Source 
Currently for WCN6450, driver is updating the CE write index offset
used for CE register updates even for the CE rings that are firmware
only rings. This is resulting in a boot time WARN_ON.

Do not setup write index offset for CE rings that are used only by
the target firmware to avoid this early on boot time WARN_ON.

Change-Id: I241e11ad43f833b5cafc7cd303b935c10d9e6dd8
CRs-Fixed: 3670952
This commit is contained in:
Manikanta Pubbisetty
2023-11-23 12:21:46 +05:30
committed by Ravindra Konda
parent 2a709c7cec
commit 4015f3bf89
1 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
hif/src/ce/ce_main.c
View File

@@ -1596,7 +1596,7 @@ static void ce_update_msi_batch_intr_flags(struct CE_state *ce_state)
static inline void ce_update_wrt_idx_offset(struct hif_softc *scn,
struct CE_state *ce_state,
uint8_t ring_type)
struct CE_attr *attr)
{
}
#else
@@ -1636,12 +1636,16 @@ static void ce_update_msi_batch_intr_flags(struct CE_state *ce_state)
static inline void ce_update_wrt_idx_offset(struct hif_softc *scn,
struct CE_state *ce_state,
uint8_t ring_type)
struct CE_attr *attr)
{
if (ring_type == CE_RING_SRC)
/* Do not setup CE write index offset for FW only CE rings */
if (!attr->src_nentries && !attr->dest_nentries)
return;
if (attr->src_nentries)
ce_state->ce_wrt_idx_offset =
CE_SRC_WR_IDX_OFFSET_GET(scn, ce_state->ctrl_addr);
else if (ring_type == CE_RING_DEST)
else if (attr->dest_nentries)
ce_state->ce_wrt_idx_offset =
CE_DST_WR_IDX_OFFSET_GET(scn, ce_state->ctrl_addr);
else
@@ -2845,9 +2849,7 @@ struct CE_handle *ce_init(struct hif_softc *scn,
goto error_target_access;
ce_update_msi_batch_intr_flags(CE_state);
ce_update_wrt_idx_offset(scn, CE_state,
attr->src_nentries ?
CE_RING_SRC : CE_RING_DEST);
ce_update_wrt_idx_offset(scn, CE_state, attr);
return (struct CE_handle *)CE_state;