samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qcacld-3.0: Set is_eapol and is_dhcp to false for each skb

Browse Source 
On receiving nbuf list in hdd_rx_packet_cbk, is_eapol and
is_dhcp flags are set to false only initially. In the
loop over all skbs, if any one of these flags is set to
true, these flags are not reset for each skb leading to
incorrect stat values and possible OOB access to rx_delivered
and rx_refused array.

Fix is to set is_eapol and is_dhcp flag to false in the
beginning of the nbuf loop.

Change-Id: Iacc7620f26fb0f71dee931c78993a75232e767b0
CRs-Fixed: 2669412
This commit is contained in:
Yeshwanth Sriram Guntuka
2020-04-28 14:39:23 +05:30
committed by nshrivas
parent 453978181a
commit 3e843a398f
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
core/hdd/src/wlan_hdd_tx_rx.c
View File

@@ -2103,8 +2103,8 @@ QDF_STATUS hdd_rx_packet_cbk(void *adapter_context,
bool track_arp = false;
struct wlan_objmgr_vdev *vdev;
enum qdf_proto_subtype subtype = QDF_PROTO_INVALID;
bool is_eapol = false;
bool is_dhcp = false;
bool is_eapol;
bool is_dhcp;
/* Sanity check on inputs */
if (unlikely((!adapter_context) || (!rxBuf))) {
@@ -2136,6 +2136,8 @@ QDF_STATUS hdd_rx_packet_cbk(void *adapter_context,
skb = next;
next = skb->next;
skb->next = NULL;
is_eapol = false;
is_dhcp = false;
if (qdf_nbuf_is_ipv4_arp_pkt(skb)) {
if (qdf_nbuf_data_is_arp_rsp(skb) &&