diff --git a/components/nan/dispatcher/src/nan_ucfg_api.c b/components/nan/dispatcher/src/nan_ucfg_api.c index ced24c96fb..9bf04205ad 100644 --- a/components/nan/dispatcher/src/nan_ucfg_api.c +++ b/components/nan/dispatcher/src/nan_ucfg_api.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 2017-2018 The Linux Foundation. All rights reserved. + * Copyright (c) 2017-2019 The Linux Foundation. All rights reserved. * * Permission to use, copy, modify, and/or distribute this software for * any purpose with or without fee is hereby granted, provided that the @@ -375,11 +375,8 @@ QDF_STATUS ucfg_nan_req_processor(struct wlan_objmgr_vdev *vdev, status = scheduler_post_message(QDF_MODULE_ID_HDD, QDF_MODULE_ID_NAN, QDF_MODULE_ID_OS_IF, &msg); - if (QDF_IS_STATUS_ERROR(status)) { - nan_err("failed to post msg to NAN component, status: %d", - status); + if (QDF_IS_STATUS_ERROR(status)) qdf_mem_free(msg.bodyptr); - } return status; } diff --git a/components/ocb/core/src/wlan_ocb_main.c b/components/ocb/core/src/wlan_ocb_main.c index 928641b14f..cc1e31309a 100644 --- a/components/ocb/core/src/wlan_ocb_main.c +++ b/components/ocb/core/src/wlan_ocb_main.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018 The Linux Foundation. All rights reserved. + * Copyright (c) 2018-2019 The Linux Foundation. All rights reserved. * * Permission to use, copy, modify, and/or distribute this software for * any purpose with or without fee is hereby granted, provided that the @@ -430,8 +430,6 @@ QDF_STATUS ocb_vdev_start(struct ocb_pdev_obj *ocb_obj) status = scheduler_post_message(QDF_MODULE_ID_OCB, QDF_MODULE_ID_OCB, QDF_MODULE_ID_TARGET_IF, &msg); - if (QDF_IS_STATUS_ERROR(status)) - ocb_err("Failed to post vdev start message"); return status; } diff --git a/components/p2p/core/src/wlan_p2p_off_chan_tx.c b/components/p2p/core/src/wlan_p2p_off_chan_tx.c index 9d446f2b05..1495c31964 100644 --- a/components/p2p/core/src/wlan_p2p_off_chan_tx.c +++ b/components/p2p/core/src/wlan_p2p_off_chan_tx.c @@ -1726,7 +1726,6 @@ QDF_STATUS p2p_cleanup_tx_sync( QDF_MODULE_ID_P2P, QDF_MODULE_ID_OS_IF, &msg); if (status != QDF_STATUS_SUCCESS) { - p2p_err("failed to post message"); qdf_mem_free(param); return status; } diff --git a/components/p2p/core/src/wlan_p2p_roc.c b/components/p2p/core/src/wlan_p2p_roc.c index 10db8e74d4..03cce00382 100644 --- a/components/p2p/core/src/wlan_p2p_roc.c +++ b/components/p2p/core/src/wlan_p2p_roc.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 2017-2018 The Linux Foundation. All rights reserved. + * Copyright (c) 2017-2019 The Linux Foundation. All rights reserved. * * Permission to use, copy, modify, and/or distribute this software for * any purpose with or without fee is hereby granted, provided that the @@ -727,7 +727,6 @@ QDF_STATUS p2p_cleanup_roc_sync( QDF_MODULE_ID_P2P, QDF_MODULE_ID_OS_IF, &msg); if (status != QDF_STATUS_SUCCESS) { - p2p_err("failed to post message"); qdf_mem_free(param); return status; } diff --git a/components/target_if/nan/src/target_if_nan.c b/components/target_if/nan/src/target_if_nan.c index 5aa5b3df20..8bb2599f6c 100644 --- a/components/target_if/nan/src/target_if_nan.c +++ b/components/target_if/nan/src/target_if_nan.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 2016-2018 The Linux Foundation. All rights reserved. + * Copyright (c) 2016-2019 The Linux Foundation. All rights reserved. * * Permission to use, copy, modify, and/or distribute this software for * any purpose with or without fee is hereby granted, provided that the @@ -261,7 +261,6 @@ static int target_if_ndp_initiator_rsp_handler(ol_scn_t scn, uint8_t *data, QDF_MODULE_ID_TARGET_IF, QDF_MODULE_ID_TARGET_IF, &msg); if (QDF_IS_STATUS_ERROR(status)) { - target_if_err("failed to post msg, status: %d", status); target_if_ndp_event_flush_cb(&msg); return -EINVAL; } @@ -312,7 +311,6 @@ static int target_if_ndp_ind_handler(ol_scn_t scn, uint8_t *data, QDF_MODULE_ID_TARGET_IF, QDF_MODULE_ID_TARGET_IF, &msg); if (QDF_IS_STATUS_ERROR(status)) { - target_if_err("failed to post msg, status: %d", status); target_if_ndp_event_flush_cb(&msg); return -EINVAL; } @@ -363,7 +361,6 @@ static int target_if_ndp_confirm_handler(ol_scn_t scn, uint8_t *data, QDF_MODULE_ID_TARGET_IF, QDF_MODULE_ID_TARGET_IF, &msg); if (QDF_IS_STATUS_ERROR(status)) { - target_if_err("failed to post msg, status: %d", status); target_if_ndp_event_flush_cb(&msg); return -EINVAL; } @@ -463,7 +460,6 @@ static int target_if_ndp_responder_rsp_handler(ol_scn_t scn, uint8_t *data, QDF_MODULE_ID_TARGET_IF, QDF_MODULE_ID_TARGET_IF, &msg); if (QDF_IS_STATUS_ERROR(status)) { - target_if_err("failed to post msg, status: %d", status); target_if_ndp_event_flush_cb(&msg); return -EINVAL; } @@ -563,7 +559,6 @@ static int target_if_ndp_end_rsp_handler(ol_scn_t scn, uint8_t *data, QDF_MODULE_ID_TARGET_IF, QDF_MODULE_ID_TARGET_IF, &msg); if (QDF_IS_STATUS_ERROR(status)) { - target_if_err("failed to post msg, status: %d", status); target_if_ndp_event_flush_cb(&msg); return -EINVAL; } @@ -615,7 +610,6 @@ static int target_if_ndp_end_ind_handler(ol_scn_t scn, uint8_t *data, QDF_MODULE_ID_TARGET_IF, QDF_MODULE_ID_TARGET_IF, &msg); if (QDF_IS_STATUS_ERROR(status)) { - target_if_err("failed to post msg, status: %d", status); target_if_ndp_event_flush_cb(&msg); return -EINVAL; } @@ -666,7 +660,6 @@ static int target_if_ndp_sch_update_handler(ol_scn_t scn, uint8_t *data, QDF_MODULE_ID_TARGET_IF, QDF_MODULE_ID_TARGET_IF, &msg); if (QDF_IS_STATUS_ERROR(status)) { - target_if_err("failed to post msg, status: %d", status); target_if_ndp_event_flush_cb(&msg); return -EINVAL; } diff --git a/components/tdls/core/src/wlan_tdls_mgmt.c b/components/tdls/core/src/wlan_tdls_mgmt.c index 47b30c4f9b..70f552e504 100644 --- a/components/tdls/core/src/wlan_tdls_mgmt.c +++ b/components/tdls/core/src/wlan_tdls_mgmt.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 2017-2018 The Linux Foundation. All rights reserved. + * Copyright (c) 2017-2019 The Linux Foundation. All rights reserved. * * Permission to use, copy, modify, and/or distribute this software for * any purpose with or without fee is hereby granted, provided that the @@ -316,10 +316,8 @@ static QDF_STATUS tdls_activate_send_mgmt_request( status = scheduler_post_message(QDF_MODULE_ID_TDLS, QDF_MODULE_ID_TDLS, QDF_MODULE_ID_PE, &msg); - if (QDF_IS_STATUS_ERROR(status)) { - tdls_err("failed to post msg, status %d", status); + if (QDF_IS_STATUS_ERROR(status)) qdf_mem_free(tdls_mgmt_req); - } wlan_objmgr_peer_release_ref(peer, WLAN_TDLS_SB_ID); diff --git a/components/tdls/dispatcher/src/wlan_tdls_ucfg_api.c b/components/tdls/dispatcher/src/wlan_tdls_ucfg_api.c index c08507750e..c5a99f7506 100644 --- a/components/tdls/dispatcher/src/wlan_tdls_ucfg_api.c +++ b/components/tdls/dispatcher/src/wlan_tdls_ucfg_api.c @@ -719,10 +719,8 @@ QDF_STATUS ucfg_tdls_send_mgmt_frame( status = scheduler_post_message(QDF_MODULE_ID_HDD, QDF_MODULE_ID_TDLS, QDF_MODULE_ID_OS_IF, &msg); - if (QDF_IS_STATUS_ERROR(status)) { - tdls_err("Failed to post the mgmt tx cmd to scheduler thread"); + if (QDF_IS_STATUS_ERROR(status)) goto release_ref; - } return status; @@ -759,10 +757,8 @@ QDF_STATUS ucfg_tdls_responder(struct tdls_set_responder_req *req) status = scheduler_post_message(QDF_MODULE_ID_HDD, QDF_MODULE_ID_TDLS, QDF_MODULE_ID_OS_IF, &msg); - if (QDF_IS_STATUS_ERROR(status)) { - tdls_err("failed to post msg, status %d", status); + if (QDF_IS_STATUS_ERROR(status)) qdf_mem_free(msg_req); - } return status; } @@ -840,7 +836,6 @@ QDF_STATUS ucfg_tdls_notify_sta_connect( QDF_MODULE_ID_TDLS, QDF_MODULE_ID_TARGET_IF, &msg); if (QDF_IS_STATUS_ERROR(status)) { - tdls_err("failed to post message, status %d", status); wlan_objmgr_vdev_release_ref(notify->vdev, WLAN_TDLS_NB_ID); qdf_mem_free(notify); } @@ -877,7 +872,6 @@ QDF_STATUS ucfg_tdls_notify_sta_disconnect( QDF_MODULE_ID_TDLS, QDF_MODULE_ID_TARGET_IF, &msg); if (QDF_IS_STATUS_ERROR(status)) { - tdls_err("failed to post message, status %d", status); wlan_objmgr_vdev_release_ref(notify->vdev, WLAN_TDLS_NB_ID); qdf_mem_free(notify); } diff --git a/core/dp/txrx/ol_txrx.c b/core/dp/txrx/ol_txrx.c index f901d730e4..e14735a757 100644 --- a/core/dp/txrx/ol_txrx.c +++ b/core/dp/txrx/ol_txrx.c @@ -5118,11 +5118,8 @@ static void ol_txrx_post_data_stall_event( QDF_MODULE_ID_HDD, QDF_MODULE_ID_SYS, &msg); - if (status != QDF_STATUS_SUCCESS) { - QDF_TRACE(QDF_MODULE_ID_TXRX, QDF_TRACE_LEVEL_ERROR, - "%s: failed to post data stall msg to SYS", __func__); + if (status != QDF_STATUS_SUCCESS) qdf_mem_free(data_stall_info); - } } void diff --git a/core/mac/src/pe/lim/lim_api.c b/core/mac/src/pe/lim/lim_api.c index 462ad0ecbd..eaf9d8d037 100644 --- a/core/mac/src/pe/lim/lim_api.c +++ b/core/mac/src/pe/lim/lim_api.c @@ -1162,9 +1162,6 @@ static QDF_STATUS pe_handle_probe_req_frames(struct mac_context *mac_ctx, QDF_MODULE_ID_PE, QDF_MODULE_ID_SCAN, &msg); - if (!QDF_IS_STATUS_SUCCESS(status)) - pe_err_rl("Failed to post probe req frame to Scan Queue"); - return status; } diff --git a/core/mac/src/pe/lim/lim_process_sme_req_messages.c b/core/mac/src/pe/lim/lim_process_sme_req_messages.c index 33c8eb3638..bcb64a46ac 100644 --- a/core/mac/src/pe/lim/lim_process_sme_req_messages.c +++ b/core/mac/src/pe/lim/lim_process_sme_req_messages.c @@ -3003,11 +3003,8 @@ static void lim_delete_peers_and_send_vdev_stop(struct pe_session *session) WLAN_VDEV_SM_EV_DOWN, sizeof(*session), session); - if (QDF_IS_STATUS_ERROR(status)) { - pe_err("failed to post WLAN_VDEV_SM_EV_DOWN for vdevid %d", - session->smeSessionId); + if (QDF_IS_STATUS_ERROR(status)) lim_send_stop_bss_failure_resp(mac_ctx, session); - } } #else static void lim_delete_peers_and_send_vdev_stop(struct pe_session *session) @@ -6030,10 +6027,8 @@ static void lim_nss_update_rsp(struct mac_context *mac_ctx, msg.bodyval = 0; qdf_status = scheduler_post_message(QDF_MODULE_ID_PE, QDF_MODULE_ID_SME, QDF_MODULE_ID_SME, &msg); - if (QDF_IS_STATUS_ERROR(qdf_status)) { - pe_err("Failed to post eWNI_SME_NSS_UPDATE_RSP"); + if (QDF_IS_STATUS_ERROR(qdf_status)) qdf_mem_free(nss_rsp); - } } void lim_send_bcn_rsp(struct mac_context *mac_ctx, tpSendbeaconParams rsp) @@ -6410,7 +6405,6 @@ void lim_send_obss_color_collision_cfg(struct mac_context *mac_ctx, QDF_MODULE_ID_WMA, QDF_MODULE_ID_WMA, &msg))) { - pe_err("Failed to post WMA_OBSS_COLOR_COLLISION_REQ to WMA"); qdf_mem_free(cfg_param); } else { session->obss_color_collision_dec_evt = event_type; diff --git a/core/mac/src/pe/lim/lim_utils.c b/core/mac/src/pe/lim/lim_utils.c index 7585b3cc50..c968c40a73 100644 --- a/core/mac/src/pe/lim/lim_utils.c +++ b/core/mac/src/pe/lim/lim_utils.c @@ -2039,8 +2039,6 @@ void lim_disconnect_complete(struct pe_session *session, bool del_bss) sizeof(*session), session); if (!mac->lim.gLimIbssCoalescingHappened && QDF_IS_STATUS_ERROR(status)) { - pe_err("failed to post WLAN_VDEV_SM_EV_DISCONNECT_COMPLETE for vdevid %d", - session->smeSessionId); lim_send_stop_bss_failure_resp(mac, session); } } @@ -2065,11 +2063,8 @@ void lim_process_channel_switch_timeout(struct mac_context *mac_ctx) WLAN_VDEV_SM_EV_FW_VDEV_RESTART, sizeof(*session_entry), session_entry); - if (QDF_IS_STATUS_ERROR(status)) { - pe_err("Failed to post WLAN_VDEV_SM_EV_FW_VDEV_RESTART for vdevid %d", - session_entry->smeSessionId); + if (QDF_IS_STATUS_ERROR(status)) mlme_set_chan_switch_in_progress(session_entry->vdev, false); - } } #else void lim_disconnect_complete(struct pe_session *session, bool del_bss) @@ -2309,10 +2304,6 @@ static void lim_switch_channel_vdev_started(struct pe_session *pe_session) pe_session->vdev, WLAN_VDEV_SM_EV_START_SUCCESS, sizeof(*pe_session), pe_session); - if (QDF_IS_STATUS_ERROR(status)) { - pe_err("Failed to post WLAN_VDEV_SM_EV_START_SUCCESS for vdevid %d", - pe_session->smeSessionId); - } } #else static void lim_switch_channel_vdev_started(struct pe_session *pe_session) {} @@ -7952,10 +7943,8 @@ void lim_process_ap_ecsa_timeout(void *data) status = scheduler_post_message(QDF_MODULE_ID_PE, QDF_MODULE_ID_SME, QDF_MODULE_ID_SME, &msg); - if (QDF_IS_STATUS_ERROR(status)) { - sme_err("Failed to post eWNI_SME_DFS_CSAIE_TX_COMPLETE_IND"); + if (QDF_IS_STATUS_ERROR(status)) qdf_mem_free(chan_switch_tx_rsp); - } } } @@ -8127,8 +8116,6 @@ static inline void lim_send_csa_restart_resp(struct mac_context *mac_ctx, msg.bodyval = session->smeSessionId; status = scheduler_post_msg(QDF_MODULE_ID_SME, &msg); - if (QDF_IS_STATUS_ERROR(status)) - sme_err("Failed to post eWNI_SME_CSA_RESTART_RSP"); } QDF_STATUS lim_ap_mlme_vdev_update_beacon(struct vdev_mlme_obj *vdev_mlme, @@ -8172,8 +8159,6 @@ QDF_STATUS lim_ap_mlme_vdev_up_send(struct vdev_mlme_obj *vdev_mlme, msg.bodyval = session->smeSessionId; status = scheduler_post_msg(QDF_MODULE_ID_WMA, &msg); - if (QDF_IS_STATUS_ERROR(status)) - WMA_LOGE("Failed to post SIR_HAL_SEND_AP_VDEV_UP"); return status; } diff --git a/core/mac/src/pe/sch/sch_beacon_process.c b/core/mac/src/pe/sch/sch_beacon_process.c index 7a77f995d8..0265e6604f 100644 --- a/core/mac/src/pe/sch/sch_beacon_process.c +++ b/core/mac/src/pe/sch/sch_beacon_process.c @@ -1478,7 +1478,6 @@ QDF_STATUS lim_obss_send_detection_cfg(struct mac_context *mac_ctx, QDF_MODULE_ID_WMA, QDF_MODULE_ID_WMA, &msg); if (QDF_IS_STATUS_ERROR(status)) { - pe_err("Failed to post WMA_OBSS_DETECTION_REQ to WMA"); qdf_mem_free(req_param); return status; } diff --git a/core/sap/src/sap_fsm.c b/core/sap/src/sap_fsm.c index 6f1ffd728e..3171a581a4 100644 --- a/core/sap/src/sap_fsm.c +++ b/core/sap/src/sap_fsm.c @@ -3588,11 +3588,6 @@ static QDF_STATUS sap_move_to_cac_wait_state(struct sap_context *sap_ctx) wlan_vdev_mlme_sm_deliver_evt(sap_ctx->vdev, WLAN_VDEV_SM_EV_DFS_CAC_WAIT, 0, NULL); - if (QDF_IS_STATUS_ERROR(status)) - QDF_TRACE(QDF_MODULE_ID_SAP, QDF_TRACE_LEVEL_ERROR, - "%s: failed to post WLAN_VDEV_SM_EV_DFS_CAC_WAIT", - __func__); - return status; } #else diff --git a/core/sme/src/common/sme_api.c b/core/sme/src/common/sme_api.c index d933e2ee0a..3e3569aa22 100644 --- a/core/sme/src/common/sme_api.c +++ b/core/sme/src/common/sme_api.c @@ -360,10 +360,8 @@ static QDF_STATUS free_sme_cmd_list(struct mac_context *mac) csr_ll_close(&mac->sme.smeCmdFreeList); status = qdf_mutex_acquire(&mac->sme.lkSmeGlobalLock); - if (status != QDF_STATUS_SUCCESS) { - sme_err("Failed to acquire the lock status: %d", status); + if (status != QDF_STATUS_SUCCESS) goto done; - } free_sme_cmds(mac); @@ -852,8 +850,6 @@ void sme_update_fine_time_measurement_capab(mac_handle_t mac_handle, ROAM_SCAN_OFFLOAD_UPDATE_CFG, REASON_CONNECT_IES_CHANGED); sme_release_global_lock(&mac_ctx->sme); - } else { - sme_err("Failed to acquire SME lock"); } } @@ -1061,8 +1057,6 @@ QDF_STATUS sme_update_roam_params(mac_handle_t mac_handle, ROAM_SCAN_OFFLOAD_UPDATE_CFG, update_param); sme_release_global_lock(&mac_ctx->sme); - } else { - sme_err("Failed to acquire SME lock"); } sme_update_scan_roam_params(mac_ctx); @@ -1450,7 +1444,6 @@ QDF_STATUS sme_update_is_ese_feature_enabled(mac_handle_t mac_handle, REASON_ESE_INI_CFG_CHANGED); sme_release_global_lock(&mac->sme); } else { - sme_err("Failed to acquire SME lock"); return status; } } @@ -1740,10 +1733,9 @@ QDF_STATUS sme_set_ese_roam_scan_channel_list(mac_handle_t mac_handle, &pNeighborRoamInfo->roamChannelInfo.currentChannelListInfo; status = sme_acquire_global_lock(&mac->sme); - if (!QDF_IS_STATUS_SUCCESS(status)) { - sme_err("Failed to acquire SME lock"); + if (!QDF_IS_STATUS_SUCCESS(status)) return status; - } + if (NULL != curchnl_list_info->ChannelList) { for (i = 0; i < curchnl_list_info->numOfChannels; i++) { j += snprintf(oldChannelList + j, @@ -1939,7 +1931,6 @@ QDF_STATUS sme_process_msg(struct mac_context *mac, struct scheduler_msg *pMsg) } status = sme_acquire_global_lock(&mac->sme); if (!QDF_IS_STATUS_SUCCESS(status)) { - sme_warn("Locking failed, bailing out"); if (pMsg->bodyptr) qdf_mem_free(pMsg->bodyptr); return status; @@ -2643,8 +2634,6 @@ QDF_STATUS sme_get_ap_channel_from_scan_cache( csr_free_scan_filter(mac_ctx, scan_filter); sme_release_global_lock(&mac_ctx->sme); } else { - QDF_TRACE(QDF_MODULE_ID_SME, QDF_TRACE_LEVEL_ERROR, - FL("Aquiring lock failed")); csr_free_scan_filter(mac_ctx, scan_filter); status = QDF_STATUS_E_FAILURE; } @@ -2799,8 +2788,6 @@ QDF_STATUS sme_roam_connect(mac_handle_t mac_handle, uint8_t sessionId, status = QDF_STATUS_E_INVAL; } sme_release_global_lock(&mac->sme); - } else { - sme_err("sme_acquire_global_lock failed"); } return status; @@ -3569,7 +3556,6 @@ QDF_STATUS sme_roam_set_default_key_index(mac_handle_t mac_handle, scheduler_post_message(QDF_MODULE_ID_SME, QDF_MODULE_ID_WMA, QDF_MODULE_ID_WMA, &msg)) { - sme_err("Failed to post WMA_UPDATE_WEP_DEFAULT_KEY to WMA"); qdf_mem_free(update_key); return QDF_STATUS_E_FAILURE; } @@ -3797,7 +3783,6 @@ QDF_STATUS sme_generic_change_country_code(mac_handle_t mac_handle, scheduler_post_message(QDF_MODULE_ID_SME, QDF_MODULE_ID_SME, QDF_MODULE_ID_SME, &msg)) { - sme_err("sme_generic_change_country_code failed to post msg to self"); qdf_mem_free(pMsg); status = QDF_STATUS_E_FAILURE; } @@ -5646,9 +5631,6 @@ QDF_STATUS sme_set_tx_power(mac_handle_t mac_handle, uint8_t sessionId, QDF_MODULE_ID_WMA, QDF_MODULE_ID_WMA, &msg)) { - QDF_TRACE(QDF_MODULE_ID_SME, QDF_TRACE_LEVEL_ERROR, - "%s: failed to post WMA_SET_TX_POWER_REQ to WMA", - __func__); qdf_mem_free(pTxParams); return QDF_STATUS_E_FAILURE; } @@ -7676,12 +7658,9 @@ QDF_STATUS sme_enable_rmc(mac_handle_t mac_handle, uint32_t sessionId) QDF_MODULE_ID_WMA, QDF_MODULE_ID_WMA, &message); - if (!QDF_IS_STATUS_SUCCESS(qdf_status)) { - QDF_TRACE(QDF_MODULE_ID_SME, QDF_TRACE_LEVEL_ERROR, - "%s: failed to post message to WMA", - __func__); + if (!QDF_IS_STATUS_SUCCESS(qdf_status)) status = QDF_STATUS_E_FAILURE; - } + sme_release_global_lock(&mac->sme); } return status; @@ -7711,12 +7690,9 @@ QDF_STATUS sme_disable_rmc(mac_handle_t mac_handle, uint32_t sessionId) QDF_MODULE_ID_WMA, QDF_MODULE_ID_WMA, &message); - if (!QDF_IS_STATUS_SUCCESS(qdf_status)) { - QDF_TRACE(QDF_MODULE_ID_SME, QDF_TRACE_LEVEL_ERROR, - "%s: failed to post message to WMA", - __func__); + if (!QDF_IS_STATUS_SUCCESS(qdf_status)) status = QDF_STATUS_E_FAILURE; - } + sme_release_global_lock(&mac->sme); } return status; @@ -7745,12 +7721,9 @@ QDF_STATUS sme_send_rmc_action_period(mac_handle_t mac_handle, QDF_MODULE_ID_WMA, QDF_MODULE_ID_WMA, &message); - if (!QDF_IS_STATUS_SUCCESS(qdf_status)) { - QDF_TRACE(QDF_MODULE_ID_SME, QDF_TRACE_LEVEL_ERROR, - "%s: failed to post message to WMA", - __func__); + if (!QDF_IS_STATUS_SUCCESS(qdf_status)) status = QDF_STATUS_E_FAILURE; - } + sme_release_global_lock(&mac->sme); } @@ -7825,7 +7798,6 @@ QDF_STATUS sme_send_cesium_enable_ind(mac_handle_t mac_handle, uint32_t sessionId) { QDF_STATUS status = QDF_STATUS_SUCCESS; - QDF_STATUS qdf_status = QDF_STATUS_SUCCESS; struct mac_context *mac = MAC_CONTEXT(mac_handle); struct scheduler_msg message = {0}; @@ -7833,16 +7805,10 @@ QDF_STATUS sme_send_cesium_enable_ind(mac_handle_t mac_handle, if (QDF_STATUS_SUCCESS == status) { message.bodyptr = NULL; message.type = WMA_IBSS_CESIUM_ENABLE_IND; - qdf_status = scheduler_post_message(QDF_MODULE_ID_SME, - QDF_MODULE_ID_WMA, - QDF_MODULE_ID_WMA, - &message); - if (!QDF_IS_STATUS_SUCCESS(qdf_status)) { - QDF_TRACE(QDF_MODULE_ID_SME, QDF_TRACE_LEVEL_ERROR, - "%s: failed to post message to WMA", - __func__); - status = QDF_STATUS_E_FAILURE; - } + status = scheduler_post_message(QDF_MODULE_ID_SME, + QDF_MODULE_ID_WMA, + QDF_MODULE_ID_WMA, + &message); sme_release_global_lock(&mac->sme); } @@ -7878,10 +7844,6 @@ QDF_STATUS sme_set_wlm_latency_level(mac_handle_t mac_handle, params.vdev_id = session_id; status = wma_set_wlm_latency_level(wma, ¶ms); - if (!QDF_IS_STATUS_SUCCESS(status)) - QDF_TRACE(QDF_MODULE_ID_SME, QDF_TRACE_LEVEL_ERROR, - "%s: failed to set latency level", - __func__); return status; } @@ -7892,19 +7854,17 @@ void sme_get_command_q_status(mac_handle_t mac_handle) tListElem *pEntry; struct mac_context *mac; - if (NULL != mac_handle) { - mac = MAC_CONTEXT(mac_handle); - } else { - QDF_TRACE(QDF_MODULE_ID_SME, QDF_TRACE_LEVEL_ERROR, - "%s: Invalid mac_handle pointer", __func__); + if (!mac_handle) return; - } + + mac = MAC_CONTEXT(mac_handle); + pEntry = csr_nonscan_active_ll_peek_head(mac, LL_ACCESS_LOCK); if (pEntry) pTempCmd = GET_BASE_ADDR(pEntry, tSmeCmd, Link); sme_err("WLAN_BUG_RCA: Currently smeCmdActiveList has command (0x%X)", - (pTempCmd) ? pTempCmd->command : eSmeNoCommand); + (pTempCmd) ? pTempCmd->command : eSmeNoCommand); if (pTempCmd) { if (eSmeCsrCommandMask & pTempCmd->command) /* CSR command is stuck. See what the reason code is @@ -7914,7 +7874,7 @@ void sme_get_command_q_status(mac_handle_t mac_handle) } /* if(pTempCmd) */ sme_err("Currently smeCmdPendingList has %d commands", - csr_nonscan_pending_ll_count(mac)); + csr_nonscan_pending_ll_count(mac)); } @@ -8295,7 +8255,6 @@ int sme_send_addba_req(mac_handle_t mac_handle, uint8_t session_id, uint8_t tid, QDF_MODULE_ID_WMA, QDF_MODULE_ID_WMA, &msg); if (QDF_STATUS_SUCCESS != status) { - sme_err("Failed to post WMA_SEND_ADDBA_REQ"); qdf_mem_free(send_ba_req); return -EIO; } @@ -12624,10 +12583,8 @@ QDF_STATUS sme_get_apf_capabilities(mac_handle_t mac_handle, status = QDF_STATUS_E_FAILURE; } sme_release_global_lock(&mac_ctx->sme); - } else { - QDF_TRACE(QDF_MODULE_ID_SME, QDF_TRACE_LEVEL_ERROR, - FL("sme_acquire_global_lock error")); } + SME_EXIT(); return status; } @@ -13106,8 +13063,6 @@ QDF_STATUS sme_update_sta_roam_policy(mac_handle_t mac_handle, ROAM_SCAN_OFFLOAD_UPDATE_CFG, REASON_ROAM_SCAN_STA_ROAM_POLICY_CHANGED); sme_release_global_lock(&mac_ctx->sme); - } else { - sme_err("Failed to acquire SME lock"); } } qdf_mem_free(sme_config); @@ -13320,8 +13275,6 @@ QDF_STATUS sme_set_lost_link_info_cb(mac_handle_t mac_handle, if (QDF_IS_STATUS_SUCCESS(status)) { mac->sme.lost_link_info_cb = cb; sme_release_global_lock(&mac->sme); - } else { - sme_err("sme_acquire_global_lock error status: %d", status); } return status; @@ -13931,8 +13884,6 @@ QDF_STATUS sme_get_rcpi(mac_handle_t mac_handle, struct sme_rcpi_req *rcpi) qdf_mem_free(rcpi_req); } } else { - QDF_TRACE(QDF_MODULE_ID_SME, QDF_TRACE_LEVEL_ERROR, - FL("sme_acquire_global_lock failed")); qdf_mem_free(rcpi_req); } @@ -13972,8 +13923,6 @@ QDF_STATUS sme_congestion_register_callback(mac_handle_t mac_handle, mac->sme.congestion_cb = congestion_cb; sme_release_global_lock(&mac->sme); sme_debug("congestion callback set"); - } else { - sme_err("Aquiring lock failed %d", status); } return status; @@ -13990,8 +13939,6 @@ QDF_STATUS sme_register_tx_queue_cb(mac_handle_t mac_handle, mac->sme.tx_queue_cb = tx_queue_cb; sme_release_global_lock(&mac->sme); sme_debug("Tx queue callback set"); - } else { - sme_err("Aquiring lock failed %d", status); } return status; @@ -14014,8 +13961,6 @@ QDF_STATUS sme_register_twt_enable_complete_cb(mac_handle_t mac_handle, mac->sme.twt_enable_cb = twt_enable_cb; sme_release_global_lock(&mac->sme); sme_debug("TWT: enable callback set"); - } else { - sme_err("Aquiring lock failed %d", status); } return status; @@ -14032,8 +13977,6 @@ QDF_STATUS sme_register_twt_disable_complete_cb(mac_handle_t mac_handle, mac->sme.twt_disable_cb = twt_disable_cb; sme_release_global_lock(&mac->sme); sme_debug("TWT: disable callback set"); - } else { - sme_err("Aquiring lock failed %d", status); } return status; @@ -14115,8 +14058,6 @@ QDF_STATUS sme_set_bt_activity_info_cb(mac_handle_t mac_handle, mac->sme.bt_activity_info_cb = cb; sme_release_global_lock(&mac->sme); sme_debug("bt activity info callback set"); - } else { - sme_debug("sme_acquire_global_lock failed %d", status); } return status; @@ -14742,7 +14683,6 @@ sme_get_roam_scan_stats(mac_handle_t mac_handle, qdf_mem_free(req); } } else { - sme_err("sme_acquire_global_lock failed"); qdf_mem_free(req); } diff --git a/core/sme/src/csr/csr_api_roam.c b/core/sme/src/csr/csr_api_roam.c index 8179db4566..f5df77eab9 100644 --- a/core/sme/src/csr/csr_api_roam.c +++ b/core/sme/src/csr/csr_api_roam.c @@ -1202,8 +1202,6 @@ QDF_STATUS csr_update_channel_list(struct mac_context *mac) QDF_MODULE_ID_WMA, QDF_MODULE_ID_WMA, &msg)) { - QDF_TRACE(QDF_MODULE_ID_SME, QDF_TRACE_LEVEL_FATAL, - "%s: Failed to post msg to WMA", __func__); qdf_mem_free(pChanList); return QDF_STATUS_E_FAILURE; } @@ -16319,10 +16317,8 @@ QDF_STATUS csr_process_del_sta_session_rsp(struct mac_context *mac_ctx, else { rsp->sme_callback(rsp->session_id); status = sme_acquire_global_lock(&mac_ctx->sme); - if (!QDF_IS_STATUS_SUCCESS(status)) { - sme_debug("Failed to get Lock"); + if (!QDF_IS_STATUS_SUCCESS(status)) return status; - } } } @@ -16902,7 +16898,6 @@ QDF_STATUS csr_get_rssi(struct mac_context *mac, QDF_MODULE_ID_SME, QDF_MODULE_ID_SME, &msg)) { - sme_err("scheduler_post_msg failed to post msg to self"); qdf_mem_free((void *)pMsg); status = QDF_STATUS_E_FAILURE; } @@ -16943,7 +16938,6 @@ QDF_STATUS csr_get_snr(struct mac_context *mac, QDF_MODULE_ID_SME, QDF_MODULE_ID_SME, &msg)) { - sme_err("failed to post msg to self"); qdf_mem_free((void *)pMsg); status = QDF_STATUS_E_FAILURE; } @@ -19614,7 +19608,6 @@ QDF_STATUS csr_handoff_request(struct mac_context *mac, QDF_MODULE_ID_SME, QDF_MODULE_ID_SME, &msg)) { - sme_err("scheduler_post_msg failed to post msg to self"); qdf_mem_free((void *)pMsg); status = QDF_STATUS_E_FAILURE; } @@ -21025,10 +21018,8 @@ QDF_STATUS csr_roam_synch_callback(struct mac_context *mac_ctx, QDF_STATUS status; status = sme_acquire_global_lock(&mac_ctx->sme); - if (!QDF_IS_STATUS_SUCCESS(status)) { - sme_err("LFR3: Locking failed, bailing out"); + if (!QDF_IS_STATUS_SUCCESS(status)) return status; - } status = csr_process_roam_sync_callback(mac_ctx, roam_synch_data, bss_desc, reason); diff --git a/core/sme/src/csr/csr_neighbor_roam.c b/core/sme/src/csr/csr_neighbor_roam.c index 8918a2a1be..d96fb949e7 100644 --- a/core/sme/src/csr/csr_neighbor_roam.c +++ b/core/sme/src/csr/csr_neighbor_roam.c @@ -145,8 +145,6 @@ QDF_STATUS csr_neighbor_roam_update_fast_roaming_enabled(struct mac_context *mac REASON_DISCONNECTED); } sme_release_global_lock(&mac_ctx->sme); - } else { - sme_err("Failed to acquire SME lock"); } break; case eCSR_NEIGHBOR_ROAM_STATE_INIT: diff --git a/core/sme/src/csr/csr_util.c b/core/sme/src/csr/csr_util.c index adba537f5a..ca00af3bf9 100644 --- a/core/sme/src/csr/csr_util.c +++ b/core/sme/src/csr/csr_util.c @@ -6144,10 +6144,8 @@ bool csr_wait_for_connection_update(struct mac_context *mac, if (do_release_reacquire_lock == true) { ret = sme_acquire_global_lock(&mac->sme); - if (!QDF_IS_STATUS_SUCCESS(ret)) { - cds_err("lock acquire fail %d", ret); + if (!QDF_IS_STATUS_SUCCESS(ret)) return false; - } } if (!QDF_IS_STATUS_SUCCESS(status)) { diff --git a/core/sme/src/qos/sme_qos.c b/core/sme/src/qos/sme_qos.c index 053ee53bc4..946fb4495e 100644 --- a/core/sme/src/qos/sme_qos.c +++ b/core/sme/src/qos/sme_qos.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 2012-2018 The Linux Foundation. All rights reserved. + * Copyright (c) 2012-2019 The Linux Foundation. All rights reserved. * * Permission to use, copy, modify, and/or distribute this software for * any purpose with or without fee is hereby granted, provided that the @@ -675,11 +675,8 @@ enum sme_qos_statustype sme_qos_setup_req(mac_handle_t mac_handle, "%s: %d: QoS Setup requested by client on session %d", __func__, __LINE__, sessionId); lock_status = sme_acquire_global_lock(&mac->sme); - if (!QDF_IS_STATUS_SUCCESS(lock_status)) { - QDF_TRACE(QDF_MODULE_ID_SME, QDF_TRACE_LEVEL_ERROR, - "%s: %d: Unable to obtain lock", __func__, __LINE__); + if (!QDF_IS_STATUS_SUCCESS(lock_status)) return SME_QOS_STATUS_SETUP_FAILURE_RSP; - } /* Make sure the session is valid */ if (!CSR_IS_SESSION_VALID(mac, sessionId)) { QDF_TRACE(QDF_MODULE_ID_SME, QDF_TRACE_LEVEL_ERROR, diff --git a/core/wma/src/wma_data.c b/core/wma/src/wma_data.c index f46406dda8..dc55defc09 100644 --- a/core/wma/src/wma_data.c +++ b/core/wma/src/wma_data.c @@ -3007,7 +3007,6 @@ void ol_rx_aggregation_hole(uint32_t hole_info) status = cds_mq_post_message(CDS_MQ_ID_SME, &cds_msg); if (status != QDF_STATUS_SUCCESS) { - WMA_LOGE("%s: Failed to post aggr event to SME", __func__); qdf_mem_free(rx_aggr_hole_event); return; } diff --git a/core/wma/src/wma_dev_if.c b/core/wma/src/wma_dev_if.c index 214b1bb789..10b9654e63 100644 --- a/core/wma/src/wma_dev_if.c +++ b/core/wma/src/wma_dev_if.c @@ -548,10 +548,8 @@ static inline void wma_send_del_sta_self_resp(struct del_sta_self_params *param) status = scheduler_post_message(QDF_MODULE_ID_WMA, QDF_MODULE_ID_SME, QDF_MODULE_ID_SME, &sme_msg); - if (!QDF_IS_STATUS_SUCCESS(status)) { - WMA_LOGE("Failed to post eWNI_SME_DEL_STA_SELF_RSP"); + if (!QDF_IS_STATUS_SUCCESS(status)) qdf_mem_free(param); - } } /** diff --git a/core/wma/src/wma_features.c b/core/wma/src/wma_features.c index ad8dd59ed4..28b59af53a 100644 --- a/core/wma/src/wma_features.c +++ b/core/wma/src/wma_features.c @@ -425,8 +425,6 @@ int wma_vdev_tsf_handler(void *handle, uint8_t *data, uint32_t data_len) scheduler_post_message(QDF_MODULE_ID_WMA, QDF_MODULE_ID_SME, QDF_MODULE_ID_SME, &tsf_msg)) { - - WMA_LOGP("%s: Failed to post eWNI_SME_TSF_EVENT", __func__); qdf_mem_free(ptsf); return -EINVAL; } @@ -3691,10 +3689,8 @@ static void wma_send_status_of_ext_wow(tp_wma_handle wma, bool status) vstatus = scheduler_post_message(QDF_MODULE_ID_WMA, QDF_MODULE_ID_SME, QDF_MODULE_ID_SME, &message); - if (vstatus != QDF_STATUS_SUCCESS) { - WMA_LOGE("Failed to post ready to suspend"); + if (vstatus != QDF_STATUS_SUCCESS) qdf_mem_free(ready_to_extwow); - } } /** @@ -5541,10 +5537,8 @@ int wma_wlan_bt_activity_evt_handler(void *handle, uint8_t *event, uint32_t len) qdf_status = scheduler_post_message(QDF_MODULE_ID_WMA, QDF_MODULE_ID_SME, QDF_MODULE_ID_SME, &sme_msg); - if (QDF_IS_STATUS_ERROR(qdf_status)) { - WMA_LOGE(FL("Failed to post msg to SME")); + if (QDF_IS_STATUS_ERROR(qdf_status)) return -EINVAL; - } return 0; } diff --git a/core/wma/src/wma_main.c b/core/wma/src/wma_main.c index 368bed33bb..ea33f5b84a 100644 --- a/core/wma/src/wma_main.c +++ b/core/wma/src/wma_main.c @@ -563,8 +563,6 @@ int wma_cli_set2_command(int vdev_id, int param_id, int sval1, scheduler_post_message(QDF_MODULE_ID_WMA, QDF_MODULE_ID_WMA, QDF_MODULE_ID_WMA, &msg)) { - WMA_LOGE("%s: Failed to post WMA_CLI_SET_CMD msg", - __func__); qdf_mem_free(iwcmd); return -EIO; } @@ -1762,8 +1760,6 @@ static int wma_process_fw_event_mc_thread_ctx(void *ctx, void *ev) scheduler_post_message(QDF_MODULE_ID_WMA, QDF_MODULE_ID_WMA, QDF_MODULE_ID_WMA, &cds_msg)) { - WMA_LOGE("%s: Failed to post WMA_PROCESS_FW_EVENT msg", - __func__); qdf_nbuf_free(ev); qdf_mem_free(params_buf); return -EFAULT; @@ -1957,8 +1953,6 @@ static void wma_shutdown_notifier_cb(void *priv) status = scheduler_post_message(QDF_MODULE_ID_WMA, QDF_MODULE_ID_WMA, QDF_MODULE_ID_TARGET_IF, &msg); - if (QDF_IS_STATUS_ERROR(status)) - WMA_LOGE(FL("Failed to post SYS_MSG_ID_CLEAN_VDEV_RSP_QUEUE")); } struct wma_version_info g_wmi_version_info; @@ -3800,7 +3794,6 @@ QDF_STATUS wma_pre_start(void) QDF_MODULE_ID_WMA, QDF_MODULE_ID_WMA, &wma_msg); if (QDF_STATUS_SUCCESS != qdf_status) { - WMA_LOGE("%s: Failed to post WNI_CFG_DNLD_REQ msg", __func__); QDF_ASSERT(0); qdf_status = QDF_STATUS_E_FAILURE; } @@ -3823,7 +3816,6 @@ void wma_send_msg_by_priority(tp_wma_handle wma_handle, uint16_t msg_type, status = scheduler_post_msg_by_priority(QDF_MODULE_ID_PE, &msg, is_high_priority); if (!QDF_IS_STATUS_SUCCESS(status)) { - WMA_LOGE("Failed to post msg %d to PE", msg_type); if (body_ptr) qdf_mem_free(body_ptr); } @@ -9412,7 +9404,6 @@ int wma_lro_init(struct cdp_lro_hash_config *lro_config) scheduler_post_message(QDF_MODULE_ID_WMA, QDF_MODULE_ID_WMA, QDF_MODULE_ID_WMA, &msg)) { - WMA_LOGE("Failed to post WMA_LRO_CONFIG_CMD msg!"); qdf_mem_free(iwcmd); return -EAGAIN; } diff --git a/core/wma/src/wma_scan_roam.c b/core/wma/src/wma_scan_roam.c index 63da280ddd..7401030e2a 100644 --- a/core/wma/src/wma_scan_roam.c +++ b/core/wma/src/wma_scan_roam.c @@ -1808,10 +1808,6 @@ QDF_STATUS wma_process_roaming_config(tp_wma_handle wma_handle, QDF_MODULE_ID_SME, &cds_msg)) { qdf_mem_free(scan_offload_rsp); - QDF_TRACE(QDF_MODULE_ID_WMA, - QDF_TRACE_LEVEL_INFO, - "%s: Failed to post Scan Offload Rsp to UMAC", - __func__); } } break; @@ -4878,8 +4874,6 @@ void wma_roam_better_ap_handler(tp_wma_handle wma, uint32_t vdev_id) QDF_MODULE_ID_SCAN, &cds_msg)) { qdf_mem_free(candidate_ind); - QDF_TRACE(QDF_MODULE_ID_WMA, QDF_TRACE_LEVEL_ERROR, - FL("Failed to post candidate ind to SME")); } } diff --git a/core/wma/src/wma_utils.c b/core/wma/src/wma_utils.c index 8c1ac280fc..a161d403c4 100644 --- a/core/wma/src/wma_utils.c +++ b/core/wma/src/wma_utils.c @@ -484,7 +484,6 @@ int wma_stats_ext_event_handler(void *handle, uint8_t *event_buf, QDF_MODULE_ID_SME, QDF_MODULE_ID_SME, &cds_msg); if (status != QDF_STATUS_SUCCESS) { - WMA_LOGE("%s: Failed to post stats ext event to SME", __func__); qdf_mem_free(stats_ext_event); return -EFAULT; } @@ -1244,7 +1243,6 @@ static int wma_ll_stats_evt_handler(void *handle, u_int8_t *event, QDF_MODULE_ID_SME, QDF_MODULE_ID_SME, &sme_msg); if (!QDF_IS_STATUS_SUCCESS(qdf_status)) { - WMA_LOGP(FL("Failed to post peer stat change msg!")); qdf_mem_free(link_stats_results); return -EINVAL; }