浏览代码

msm: camera: isp: Fix null pointer issue

Null pointer might be used uninitialized in case param input is null,
now we will return with -EINVAL directly to avoid passing null pointer
to other function.

CRs-Fixed: 3250360
Change-Id: I19bd6f83d2f6315f55f05559b6984e721ca3d143
Signed-off-by: Stark Lin <[email protected]>
Signed-off-by: Depeng Shao <[email protected]>
Stark Lin 2 年之前
父节点
当前提交
3dd3448144
共有 1 个文件被更改,包括 3 次插入6 次删除
  1. 3 6
      drivers/cam_isp/isp_hw_mgr/isp_hw/ife_csid_hw/cam_ife_csid_hw_ver2.c

+ 3 - 6
drivers/cam_isp/isp_hw_mgr/isp_hw/ife_csid_hw/cam_ife_csid_hw_ver2.c

@@ -1747,8 +1747,7 @@ static int cam_ife_csid_ver2_ipp_bottom_half(
 		CAM_ERR(CAM_ISP, "Invalid params. evt_payload_priv: %s, handler_priv: %s",
 			CAM_IS_NULL_TO_STR(evt_payload_priv),
 			CAM_IS_NULL_TO_STR(handler_priv));
-		rc = -EINVAL;
-		goto end;
+		return -EINVAL;
 	}
 
 	payload = evt_payload_priv;
@@ -1853,8 +1852,7 @@ static int cam_ife_csid_ver2_ppp_bottom_half(
 		CAM_ERR(CAM_ISP, "Invalid params. evt_payload_priv: %s, handler_priv: %s",
 			CAM_IS_NULL_TO_STR(evt_payload_priv),
 			CAM_IS_NULL_TO_STR(handler_priv));
-		rc = -EINVAL;
-		goto end;
+		return -EINVAL;
 	}
 
 	payload = evt_payload_priv;
@@ -1938,8 +1936,7 @@ static int cam_ife_csid_ver2_rdi_bottom_half(
 		CAM_ERR(CAM_ISP, "Invalid params. evt_payload_priv: %s, handler_priv: %s",
 			CAM_IS_NULL_TO_STR(evt_payload_priv),
 			CAM_IS_NULL_TO_STR(handler_priv));
-		rc = -EINVAL;
-		goto end;
+		return -EINVAL;
 	}
 
 	payload = evt_payload_priv;