Browse Source

qcacld-3.0: Refactor SCAN_ENABLE configuration

One of the HDD functions with the highest cyclomatic complexity is
__wlan_hdd_cfg80211_wifi_configuration_set(). In order to reduce the
complexity there is a plan to replace the inline attribute handling
with a vtable-based approach.

As part of that goal refactor the following independent attribute
handling into a separate function and add that function to the vtable:
- QCA_WLAN_VENDOR_ATTR_CONFIG_SCAN_ENABLE

Change-Id: Ia9e97c19c26d7fbdaed0ddaec2def1bdc78ae34c
CRs-Fixed: 2371564
Jeff Johnson 6 years ago
parent
commit
3d4f64cc60
1 changed files with 20 additions and 14 deletions
  1. 20 14
      core/hdd/src/wlan_hdd_cfg80211.c

+ 20 - 14
core/hdd/src/wlan_hdd_cfg80211.c

@@ -5659,6 +5659,23 @@ static int hdd_config_lro(struct hdd_adapter *adapter,
 	return hdd_lro_set_reset(hdd_ctx, adapter, enable_flag);
 }
 
+static int hdd_config_scan_enable(struct hdd_adapter *adapter,
+				  const struct nlattr *attr)
+{
+	struct hdd_context *hdd_ctx = WLAN_HDD_GET_CTX(adapter);
+	uint8_t enable_flag;
+
+	enable_flag = nla_get_u8(attr);
+	if (enable_flag)
+		ucfg_scan_psoc_set_enable(hdd_ctx->psoc,
+					  REASON_USER_SPACE);
+	else
+		ucfg_scan_psoc_set_disable(hdd_ctx->psoc,
+					   REASON_USER_SPACE);
+
+	return 0;
+}
+
 static int hdd_config_scan_default_ies(struct hdd_adapter *adapter,
 				       const struct nlattr *attr)
 {
@@ -5742,6 +5759,8 @@ static const struct independent_setters independent_setters[] = {
 	 hdd_config_listen_interval},
 	{QCA_WLAN_VENDOR_ATTR_CONFIG_LRO,
 	 hdd_config_lro},
+	{QCA_WLAN_VENDOR_ATTR_CONFIG_SCAN_ENABLE,
+	 hdd_config_scan_enable},
 };
 
 /**
@@ -5866,7 +5885,7 @@ __wlan_hdd_cfg80211_wifi_configuration_set(struct wiphy *wiphy,
 	bool vendor_ie_present = false, access_policy_present = false;
 	struct sir_set_tx_rx_aggregation_size request;
 	QDF_STATUS qdf_status;
-	uint8_t retry, delay, enable_flag;
+	uint8_t retry, delay;
 	uint32_t abs_delay;
 	int param_id;
 	uint32_t tx_fail_count;
@@ -5910,19 +5929,6 @@ __wlan_hdd_cfg80211_wifi_configuration_set(struct wiphy *wiphy,
 
 	mac_handle = hdd_ctx->mac_handle;
 
-	if (tb[QCA_WLAN_VENDOR_ATTR_CONFIG_SCAN_ENABLE]) {
-		enable_flag =
-			nla_get_u8(tb[QCA_WLAN_VENDOR_ATTR_CONFIG_SCAN_ENABLE]);
-
-		hdd_debug("scan enable %d", enable_flag);
-		if (enable_flag)
-			ucfg_scan_psoc_set_enable(hdd_ctx->psoc,
-						  REASON_USER_SPACE);
-		else
-			ucfg_scan_psoc_set_disable(hdd_ctx->psoc,
-						   REASON_USER_SPACE);
-	}
-
 	if (tb[QCA_WLAN_VENDOR_ATTR_CONFIG_QPOWER]) {
 		qpower = nla_get_u8(
 			tb[QCA_WLAN_VENDOR_ATTR_CONFIG_QPOWER]);