From 3caf63aa26025efd69d4608063f337f0e5fd89d6 Mon Sep 17 00:00:00 2001 From: jitiphil Date: Wed, 21 Mar 2018 21:02:01 +0530 Subject: [PATCH] qcacmn: Add NULL check for 'pl_dev' Currently 'pl_dev' is dereferenced without check for NULL in get_pktlog_handle function in pktlog_internal.c To address this issue add NULL check before dereferencing Change-Id: Ic258db7bf1b404ff4f2d6c18abe775335074268b CRs-Fixed: 2196058 --- utils/pktlog/pktlog_internal.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/utils/pktlog/pktlog_internal.c b/utils/pktlog/pktlog_internal.c index d4cf098587..98d37033c3 100644 --- a/utils/pktlog/pktlog_internal.c +++ b/utils/pktlog/pktlog_internal.c @@ -370,7 +370,12 @@ A_STATUS process_tx_info(struct cdp_pdev *txrx_pdev, void *data) return A_ERROR; } - qdf_assert(pl_dev); + if (!pl_dev) { + pr_err("Invalid pktlog handle in %s\n", __func__); + qdf_assert(pl_dev); + return A_ERROR; + } + qdf_assert(data); fw_data = (struct ol_fw_data *)data;