Просмотр исходного кода

qcacld-3.0: Replace typedef tSirMacPowerCapInfo

The Linux Coding Style enumerates a few special cases where typedefs
are useful, but stresses "NEVER EVER use a typedef unless you can
clearly match one of those rules." The tSirMacPowerCapInfo typedef
does not meet any of those criteria, so replace it (and the "tp"
variant) with a reference to the underlying struct.

Further note the Linux Coding Style frowns upon mixed-case names
and so-called Hungarian notation, so in conjunction rename the
underlying struct to be in compliance.

Change-Id: I51fcb7d5d37d86b3ee9b5b104d48b0ad5354018b
CRs-Fixed: 2392403
Jeff Johnson 6 лет назад
Родитель
Сommit
39f02ae5af
2 измененных файлов с 5 добавлено и 5 удалено
  1. 4 4
      core/mac/inc/sir_api.h
  2. 1 1
      core/mac/src/pe/lim/lim_types.h

+ 4 - 4
core/mac/inc/sir_api.h

@@ -448,10 +448,10 @@ typedef enum eSirBssType {
 } tSirBssType;
 
 /* / Power Capability info used in 11H */
-typedef struct sSirMacPowerCapInfo {
+struct power_cap_info {
 	uint8_t minTxPower;
 	uint8_t maxTxPower;
-} tSirMacPowerCapInfo, *tpSirMacPowerCapInfo;
+};
 
 /* / Supported Channel info used in 11H */
 typedef struct sSirSupChnl {
@@ -978,7 +978,7 @@ typedef struct sSirSmeJoinReq {
 	bool isOSENConnection;
 	struct rrm_config_param rrm_config;
 	bool spectrumMgtIndicator;
-	tSirMacPowerCapInfo powerCap;
+	struct power_cap_info powerCap;
 	tSirSupChnl supportedChannels;
 	bool enable_bcast_probe_rsp;
 #ifdef WLAN_FEATURE_FILS_SK
@@ -1098,7 +1098,7 @@ typedef struct sSirSmeAssocInd {
 	/* powerCap & supportedChannels are present only when */
 	/* spectrumMgtIndicator flag is set */
 	bool spectrumMgtIndicator;
-	tSirMacPowerCapInfo powerCap;
+	struct power_cap_info powerCap;
 	tSirSupChnl supportedChannels;
 	bool wmmEnabledSta; /* if present - STA is WMM enabled */
 	bool reassocReq;

+ 1 - 1
core/mac/src/pe/lim/lim_types.h

@@ -216,7 +216,7 @@ typedef struct sLimMlmAssocInd {
 	tSirAddie addIE;        /* additional IE received from the peer, which possibly includes WSC IE and/or P2P IE. */
 	tSirMacCapabilityInfo capabilityInfo;
 	bool spectrumMgtIndicator;
-	tSirMacPowerCapInfo powerCap;
+	struct power_cap_info powerCap;
 	tSirSupChnl supportedChannels;
 	uint8_t sessionId;