Browse Source

qcacmn: Interpret delayed work interval as milliseconds

The QDF delayed work APIs currently expect delay intervals in terms of
jiffies. Since QDF is OS agnostic, and jiffies are Linux specific,
interpret delay intervals in terms of milliseconds instead. This aligns
the delayed work APIs with the general timer APIs as well.

Change-Id: I9b9300425baa0857c35f63823de2037a954eed1f
CRs-Fixed: 2111987
Dustin Brown 7 years ago
parent
commit
37dd1494e6
2 changed files with 6 additions and 6 deletions
  1. 2 2
      qdf/inc/qdf_defer.h
  2. 4 4
      qdf/linux/src/i_qdf_defer.h

+ 2 - 2
qdf/inc/qdf_defer.h

@@ -173,7 +173,7 @@ qdf_queue_work(qdf_handle_t hdl, qdf_workqueue_t *wqueue, qdf_work_t *work)
  * @hdl: OS handle
  * @wqueue: pointer to workqueue
  * @work: pointer to work
- * @delay: delay interval
+ * @delay: delay interval in milliseconds
  * Return: none
  */
 static inline void qdf_queue_delayed_work(qdf_handle_t hdl,
@@ -223,7 +223,7 @@ static inline void qdf_sched_work(qdf_handle_t hdl, qdf_work_t *work)
  * qdf_sched_delayed_work() - Schedule a delayed task
  * @hdl: OS handle
  * @work: pointer to delayed work
- * @delay: delay interval
+ * @delay: delay interval in milliseconds
  * Return: none
  */
 static inline void qdf_sched_delayed_work(qdf_handle_t hdl,

+ 4 - 4
qdf/linux/src/i_qdf_defer.h

@@ -141,7 +141,7 @@ static inline void __qdf_queue_delayed_work(qdf_handle_t hdl,
 					    __qdf_delayed_work_t *work,
 					    uint32_t delay)
 {
-	queue_delayed_work(wqueue, work, delay);
+	queue_delayed_work(wqueue, work, msecs_to_jiffies(delay));
 }
 
 /**
@@ -167,7 +167,7 @@ static inline QDF_STATUS __qdf_sched_delayed_work(qdf_handle_t hdl,
 						  __qdf_delayed_work_t *work,
 						  uint32_t delay)
 {
-	schedule_delayed_work(work, delay);
+	schedule_delayed_work(work, msecs_to_jiffies(delay));
 	return QDF_STATUS_SUCCESS;
 }
 
@@ -254,7 +254,7 @@ static inline void __qdf_queue_delayed_work(qdf_handle_t hdl,
 					    __qdf_delayed_work_t *work,
 					    uint32_t delay)
 {
-	queue_delayed_work(wqueue, &work->dwork, delay);
+	queue_delayed_work(wqueue, &work->dwork, msecs_to_jiffies(delay));
 }
 
 static inline QDF_STATUS __qdf_sched_work(qdf_handle_t hdl, __qdf_work_t *work)
@@ -267,7 +267,7 @@ static inline QDF_STATUS __qdf_sched_delayed_work(qdf_handle_t hdl,
 						  __qdf_delayed_work_t *work,
 						  uint32_t delay)
 {
-	schedule_delayed_work(&work->dwork, delay);
+	schedule_delayed_work(&work->dwork, msecs_to_jiffies(delay));
 	return QDF_STATUS_SUCCESS;
 }