Просмотр исходного кода

qcacmn: Resolve difference in pointer signedness

The control buffer element of socket buffer structure (sk_buff)
is of the data type char and the virtual address element of network
buffer control block structure is of the type unsigned char. The
current prototypes cause this pointer assignment with different
signedness.
Fix this by using appropriate type in the API definition.

Change-Id: Ic20ca29ce5d26a134ef295663632a5b7fd420954
CRs-Fixed: 3269690
Sreeramya Soratkal 2 лет назад
Родитель
Сommit
351edebeae
2 измененных файлов с 3 добавлено и 3 удалено
  1. 2 2
      qdf/inc/qdf_nbuf.h
  2. 1 1
      qdf/linux/src/i_qdf_nbuf.h

+ 2 - 2
qdf/inc/qdf_nbuf.h

@@ -1584,7 +1584,7 @@ qdf_nbuf_mapped_paddr_set(qdf_nbuf_t buf, qdf_dma_addr_t paddr)
 
 static inline void
 qdf_nbuf_frag_push_head(qdf_nbuf_t buf,
-			int frag_len, char *frag_vaddr,
+			int frag_len, unsigned char *frag_vaddr,
 			qdf_dma_addr_t frag_paddr)
 {
 	__qdf_nbuf_frag_push_head(buf, frag_len, frag_vaddr, frag_paddr);
@@ -4379,7 +4379,7 @@ qdf_nbuf_set_queue_mapping(qdf_nbuf_t buf, uint16_t val)
 	__qdf_nbuf_set_queue_mapping(buf, val);
 }
 
-static inline uint8_t *
+static inline char *
 qdf_nbuf_get_priv_ptr(qdf_nbuf_t buf)
 {
 	return __qdf_nbuf_get_priv_ptr(buf);

+ 1 - 1
qdf/linux/src/i_qdf_nbuf.h

@@ -2236,7 +2236,7 @@ static inline uint32_t __qdf_nbuf_tcp_seq(struct sk_buff *skb)
  *
  * Return: data pointer to typecast into your priv structure
  */
-static inline uint8_t *
+static inline char *
 __qdf_nbuf_get_priv_ptr(struct sk_buff *skb)
 {
 	return &skb->cb[8];