From c90f535a2425942832eb8d95252c08d27b63b893 Mon Sep 17 00:00:00 2001 From: Tatenda Chipeperekwa Date: Mon, 23 Nov 2020 15:48:50 -0800 Subject: [PATCH] disp: msm: dp: remove debug log output in isr Remove all debug logs and replace them with event logs in the isr path. This change will reduce the likelihood of an interrupt storm causing a watchdog bark if display threads are being prevented from completing execution due to debug logs holding the console lock. CRs-Fixed: 2810115 Change-Id: I906f19fb73a7501114fd0a62e9ae66c83dde4d5d Signed-off-by: Tatenda Chipeperekwa --- msm/dp/dp_ctrl.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/msm/dp/dp_ctrl.c b/msm/dp/dp_ctrl.c index 955c5e987f..ad08e90197 100644 --- a/msm/dp/dp_ctrl.c +++ b/msm/dp/dp_ctrl.c @@ -10,6 +10,7 @@ #include "dp_ctrl.h" #include "dp_debug.h" +#include "sde_dbg.h" #define DP_MST_DEBUG(fmt, ...) DP_DEBUG(fmt, ##__VA_ARGS__) @@ -93,13 +94,11 @@ enum notification_status { static void dp_ctrl_idle_patterns_sent(struct dp_ctrl_private *ctrl) { - DP_DEBUG("idle_patterns_sent\n"); complete(&ctrl->idle_comp); } static void dp_ctrl_video_ready(struct dp_ctrl_private *ctrl) { - DP_DEBUG("dp_video_ready\n"); complete(&ctrl->video_comp); } @@ -185,6 +184,8 @@ static void dp_ctrl_wait4video_ready(struct dp_ctrl_private *ctrl) { if (!wait_for_completion_timeout(&ctrl->video_comp, HZ / 2)) DP_WARN("SEND_VIDEO time out\n"); + else + DP_DEBUG("SEND_VIDEO triggered\n"); } static int dp_ctrl_update_sink_vx_px(struct dp_ctrl_private *ctrl) @@ -1410,12 +1411,14 @@ static void dp_ctrl_isr(struct dp_ctrl *dp_ctrl) { struct dp_ctrl_private *ctrl; + SDE_EVT32_EXTERNAL(SDE_EVTLOG_FUNC_ENTRY); if (!dp_ctrl) return; ctrl = container_of(dp_ctrl, struct dp_ctrl_private, dp_ctrl); ctrl->catalog->get_interrupt(ctrl->catalog); + SDE_EVT32_EXTERNAL(ctrl->catalog->isr); if (ctrl->catalog->isr & DP_CTRL_INTR_READY_FOR_VIDEO) dp_ctrl_video_ready(ctrl); @@ -1428,6 +1431,7 @@ static void dp_ctrl_isr(struct dp_ctrl *dp_ctrl) if (ctrl->catalog->isr5 & DP_CTRL_INTR_MST_DP1_VCPF_SENT) dp_ctrl_idle_patterns_sent(ctrl); + SDE_EVT32_EXTERNAL(SDE_EVTLOG_FUNC_EXIT); } void dp_ctrl_set_sim_mode(struct dp_ctrl *dp_ctrl, bool en)