samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qcacmn: Add support for rate limiting QDF trace prints

Browse Source 
The existing QDF implementation does the following
1. The QDF trace either prints to the console
2. The QDF trace message  is directed to the utils,
   which based on log level
	a. redirects to a user space daemon or
	b. redirects to console

There is excessive logging detection in the utils code
before redirecting the prints to  the console.
If the number of prints to console is more than
the configured threshold, we assert in development builds.

Moving the API for excessive logging detection from utils to
QDF trace.

The configuration for detection of excessive logging currently
is only for the number of prints per second.
Adding time configuration also to detection of excess logging
to the console.

CRs-Fixed: 2809752
Change-Id: Iecc408fc9b576fa900a6d7ee793639f1dde3110d
This commit is contained in:
Vivek
2020-11-29 15:21:30 +05:30
committed by snandini
parent e04aeaeed8
commit 3327a6a92b
3 changed files with 121 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
utils/logging/src/wlan_logging_sock_svc.c
View File

@@ -308,41 +308,14 @@ static int wlan_add_user_log_time_stamp(char *tbuf, size_t tbuf_sz, uint64_t ts)
}
#ifdef WLAN_MAX_LOGS_PER_SEC
static qdf_time_t __log_window_end_ticks;
static qdf_atomic_t __log_window_count;
/**
* assert_on_excessive_logging() - Check for and panic on excessive logging
*
* Track logging count using a quasi-tumbling window, 1 second long. If the max
* logging count for a given window is exceeded, panic.
*
* Return: None
*/
static void assert_on_excessive_logging(void)
static inline void wlan_panic_on_excessive_logging(void)
{
qdf_time_t now = qdf_system_ticks();
/*
* If 'now' is more recent than the end of the window, reset.
*
* Note: This is not thread safe, and can result in more than one reset.
* For our purposes, this is fine.
*/
if (!qdf_atomic_read(&__log_window_count)) {
__log_window_end_ticks = now + qdf_system_ticks_per_sec;
} else if (qdf_system_time_after(now, __log_window_end_ticks)) {
__log_window_end_ticks = now + qdf_system_ticks_per_sec;
qdf_atomic_set(&__log_window_count, 0);
}
/* this _is_ thread safe, and results in at most one panic */
if (qdf_atomic_inc_return(&__log_window_count) == WLAN_MAX_LOGS_PER_SEC)
if (qdf_detected_excessive_logging())
QDF_DEBUG_PANIC("Exceeded %d logs per second",
WLAN_MAX_LOGS_PER_SEC);
}
#else
static inline void assert_on_excessive_logging(void) { }
static inline void wlan_panic_on_excessive_logging(void) {}
#endif /* WLAN_MAX_LOGS_PER_SEC */
static inline void
@@ -351,19 +324,19 @@ log_to_console(QDF_TRACE_LEVEL level, const char *timestamp, const char *msg)
switch (level) {
case QDF_TRACE_LEVEL_FATAL:
pr_alert("%s %s\n", timestamp, msg);
assert_on_excessive_logging();
wlan_panic_on_excessive_logging();
break;
case QDF_TRACE_LEVEL_ERROR:
pr_err("%s %s\n", timestamp, msg);
assert_on_excessive_logging();
wlan_panic_on_excessive_logging();
break;
case QDF_TRACE_LEVEL_WARN:
pr_warn("%s %s\n", timestamp, msg);
assert_on_excessive_logging();
wlan_panic_on_excessive_logging();
break;
case QDF_TRACE_LEVEL_INFO:
pr_info("%s %s\n", timestamp, msg);
assert_on_excessive_logging();
wlan_panic_on_excessive_logging();
break;
case QDF_TRACE_LEVEL_INFO_HIGH:
case QDF_TRACE_LEVEL_INFO_MED: