disp: msm: sde: avoid caching color processing properties in validate

Recent investigation shows that color processing properties are
incorrectly being cached in validate. This can result in unwanted
color processing properties being applied if a previous commit
failed or was validate only.

Add color processing properties to sde crtc state instead of marking
them dirty in color processing driver. When atomic commit is called
properties from state will be marked as dirty and applied.

Change-Id: If231a1f028e4cbd0b50eb0a947f4d58f94390a0c
Signed-off-by: Gopikrishnaiah Anandan <agopik@codeaurora.org>
Signed-off-by: Christopher Braga <cbraga@codeaurora.org>

msm/msm_prop.c

@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0-only
 /*
- * Copyright (c) 2016-2020, The Linux Foundation. All rights reserved.
+ * Copyright (c) 2016-2021, The Linux Foundation. All rights reserved.
  */
 
 #include "msm_prop.h"
@@ -453,7 +453,7 @@ void *msm_property_alloc_state(struct msm_property_info *info)
 	mutex_unlock(&info->property_lock);
 
 	if (!state && info->state_size)
-		state = kmalloc(info->state_size, GFP_KERNEL);
+		state = kzalloc(info->state_size, GFP_KERNEL);
 
 	if (!state)
 		DRM_ERROR("failed to allocate state\n");