qcacmn: Introduce new versions of TDLS peer callbacks

The parameters to function typedef tdls_register_tl_peer_callback()
currently includes ucastsig.  This "unicast signature" parameter dates
back to a previous version of the driver that used signatures to
synchronize the data plane with the control plane. However the current
version of the driver does not use this mechanism, so there is a
desire to remove this parameter from the callback.

In addition both typedef tdls_register_tl_peer_callback() and typedef
tdls_deregister_tl_peer_callback() suffer from poor naming since the
"_tl_" in the names refers to a datapath component that was present in
an older version of the driver but which is no longer present.

Therefore introduce a new version of these typedefs with better naming
and which removes the ucastsig parameter.

Use temporary conditional compilation to allow support for both the
old and new interfaces until such time as all registrants have
converted to the new interfaces. This is part of the plan to
completely remove the obsolete unicast and broadcast signatures from
throughout the driver.

Change-Id: Id4ea23266b0f3e1480b645c5afce6c17585ccb46
CRs-Fixed: 2200931
This commit is contained in:
Jeff Johnson
2018-03-01 15:31:35 -08:00
committed by nshrivas
parent 97e0192b65
commit 31dade3142
5 changed files with 84 additions and 8 deletions

View File

@@ -1,5 +1,5 @@
/*
* Copyright (c) 2017 The Linux Foundation. All rights reserved.
* Copyright (c) 2017-2018 The Linux Foundation. All rights reserved.
*
* Permission to use, copy, modify, and/or distribute this software for
* any purpose with or without fee is hereby granted, provided that the
@@ -547,6 +547,22 @@ typedef void (*tdls_evt_callback) (void *data,
typedef int (*tdls_tx_ack_cnf_callback)(void *user_data,
struct tdls_tx_cnf *tx_ack_cnf_cb_data);
#ifdef USE_NEW_TDLS_PEER_CALLBACKS
/* This callback is used to register TDLS peer with the datapath */
typedef QDF_STATUS (*tdls_register_peer_callback)(void *userdata,
uint32_t vdev_id,
const uint8_t *mac,
uint16_t stat_id,
uint8_t qos);
/* This callback is used to deregister TDLS peer from the datapath */
typedef QDF_STATUS (*tdls_deregister_peer_callback)(void *userdata,
uint32_t vdev_id,
uint8_t sta_id);
#else
/* This callback is used to register TDLS peer with TL */
typedef QDF_STATUS (*tdls_register_tl_peer_callback)(void *userdata,
uint32_t vdev_id,
@@ -560,6 +576,8 @@ typedef QDF_STATUS (*tdls_deregister_tl_peer_callback)(void *userdata,
uint32_t vdev_id,
uint8_t sta_id);
#endif
/* This callback is used to update datapath vdev flags */
typedef QDF_STATUS
(*tdls_dp_vdev_update_flags_callback)(void *cbk_data,
@@ -580,10 +598,16 @@ typedef QDF_STATUS
* @tdls_evt_cb_data: tdls event data
* @ack_cnf_cb: tdls tx ack callback to indicate the tx status
* @tx_ack_cnf_cb_data: tdls tx ack user data
#ifdef USE_NEW_TDLS_PEER_CALLBACKS
* @tdls_peer_context: userdata for register/deregister TDLS peer
* @tdls_reg_peer: register tdls peer with datapath
* @tdls_dereg_peer: deregister tdls peer from datapath
#else
* @tdls_tl_peer_data: userdata for register/deregister TDLS peer
* @tdls_reg_tl_peer: tdls register tdls peer
* @tdls_dereg_tl_peer: tdls deregister tdls peer
#endif
* @tdls_dp_vdev_update: update vdev flags in datapath
* @tdls_tl_peer_data: userdata for register/deregister TDLS peer
*/
struct tdls_start_params {
struct tdls_user_config config;
@@ -601,10 +625,16 @@ struct tdls_start_params {
void *tdls_evt_cb_data;
tdls_tx_ack_cnf_callback ack_cnf_cb;
void *tx_ack_cnf_cb_data;
#ifdef USE_NEW_TDLS_PEER_CALLBACKS
void *tdls_peer_context;
tdls_register_peer_callback tdls_reg_peer;
tdls_deregister_peer_callback tdls_dereg_peer;
#else
void *tdls_tl_peer_data;
tdls_register_tl_peer_callback tdls_reg_tl_peer;
tdls_deregister_tl_peer_callback tdls_dereg_tl_peer;
#endif
tdls_dp_vdev_update_flags_callback tdls_dp_vdev_update;
void *tdls_tl_peer_data;
};
/**