Browse Source

qcacld-3.0: Invalid checks for operating channel validation

Inside hdd_ndi_create_req_handler(), we need to check if
the operating channel is valid. The current checks do
not ensure the operating channel is checked against all
valid values.

Correct the check condition to validate the operating
channel against all valid values.

Change-Id: I01c035b996ab26779ee005bef437393875fdd95a
CRs-Fixed: 2233118
jitiphil 7 years ago
parent
commit
31cf1ba577
1 changed files with 3 additions and 3 deletions
  1. 3 3
      core/hdd/src/wlan_hdd_nan_datapath.c

+ 3 - 3
core/hdd/src/wlan_hdd_nan_datapath.c

@@ -533,9 +533,9 @@ int hdd_ndi_start(uint8_t vdev_id)
 	 * interface does not have any such formal requests. The NDI
 	 * create request is responsible for starting the BSS as well.
 	 */
-	if (op_channel != NAN_SOCIAL_CHANNEL_2_4GHZ ||
-		op_channel != NAN_SOCIAL_CHANNEL_5GHZ_LOWER_BAND ||
-		op_channel != NAN_SOCIAL_CHANNEL_5GHZ_UPPER_BAND) {
+	if (op_channel != NAN_SOCIAL_CHANNEL_2_4GHZ &&
+	    op_channel != NAN_SOCIAL_CHANNEL_5GHZ_LOWER_BAND &&
+	    op_channel != NAN_SOCIAL_CHANNEL_5GHZ_UPPER_BAND) {
 		/* start NDI on the default 2.4 GHz social channel */
 		op_channel = NAN_SOCIAL_CHANNEL_2_4GHZ;
 	}