From 30d3a5d018fdd7ad79d71e2ba0f4f65a9b23bddf Mon Sep 17 00:00:00 2001 From: Jeff Johnson Date: Sat, 2 Feb 2019 21:08:43 -0800 Subject: [PATCH] qcacld-3.0: Replace typedef tSirEseBcnReportBssInfo The Linux Coding Style enumerates a few special cases where typedefs are useful, but stresses "NEVER EVER use a typedef unless you can clearly match one of those rules." The tSirEseBcnReportBssInfo typedef does not meet any of those criteria, so replace it (and the "tp" variant) with a reference to the underlying struct. Further note the Linux Coding Style frowns upon mixed-case names and so-called Hungarian notation, so in conjunction rename the underlying struct to be in compliance. Change-Id: I241243a7e3313870cf08731775eb5bbf21f2cc62 CRs-Fixed: 2394251 --- core/mac/inc/sir_api.h | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/core/mac/inc/sir_api.h b/core/mac/inc/sir_api.h index 9869e5490f..d5419fa59d 100644 --- a/core/mac/inc/sir_api.h +++ b/core/mac/inc/sir_api.h @@ -831,17 +831,18 @@ typedef struct sAniGetTsmStatsRsp { void *tsmStatsReq; /* tsm stats request backup */ } tAniGetTsmStatsRsp, *tpAniGetTsmStatsRsp; -typedef struct sSirEseBcnReportBssInfo { +struct ese_bcn_report_bss_info { tBcnReportFields bcnReportFields; uint8_t ieLen; uint8_t *pBuf; -} tSirEseBcnReportBssInfo, *tpSirEseBcnReportBssInfo; +}; typedef struct sSirEseBcnReportRsp { uint16_t measurementToken; uint8_t flag; /* Flag to report measurement done and more data */ uint8_t numBss; - tSirEseBcnReportBssInfo bcnRepBssInfo[SIR_BCN_REPORT_MAX_BSS_DESC]; + struct ese_bcn_report_bss_info + bcnRepBssInfo[SIR_BCN_REPORT_MAX_BSS_DESC]; } tSirEseBcnReportRsp, *tpSirEseBcnReportRsp; #define TSRS_11AG_RATE_6MBPS 0xC