qcacld-3.0: Optimization of logs

optimize logs in one line for func sch_qos_update_broadcast and
wma_process_update_edca_param_req/wma_update_edca_params_for_ac,
to avoid printing in loop

Change-Id: I0feaa9822406a2610959bb8edbb1ce40b3a9cae8
CRs-Fixed: 3128531

core/mac/src/pe/sch/sch_message.c

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2012-2021 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -38,6 +39,9 @@
 /* / convert the CW values into a uint16_t */
 #define GET_CW(pCw) ((uint16_t) ((*(pCw) << 8) + *((pCw) + 1)))
 
+/* Max debug string size for WMM in bytes  */
+#define SCH_WMM_DEBUG_STRING_SIZE    512
+
 /* local functions */
 static QDF_STATUS
 get_wmm_local_params(struct mac_context *mac,
@@ -264,6 +268,8 @@ void sch_qos_update_broadcast(struct mac_context *mac, struct pe_session *pe_ses
 	uint8_t i;
 	bool updated = false;
 	QDF_STATUS status;
+	uint8_t *debug_str;
+	uint32_t len = 0;
 
 	if (sch_get_params(mac, params, false) != QDF_STATUS_SUCCESS) {
 		pe_debug("QosUpdateBroadcast: failed");
@@ -271,8 +277,6 @@ void sch_qos_update_broadcast(struct mac_context *mac, struct pe_session *pe_ses
 	}
 	lim_get_phy_mode(mac, &phyMode, pe_session);
 
-	pe_debug("QosUpdBcast: mode %d", phyMode);
-
 	if (phyMode == WNI_CFG_PHY_MODE_11G) {
 		cwminidx = CFG_EDCA_PROFILE_CWMING_IDX;
 		cwmaxidx = CFG_EDCA_PROFILE_CWMAXG_IDX;
@@ -288,6 +292,10 @@ void sch_qos_update_broadcast(struct mac_context *mac, struct pe_session *pe_ses
 		txopidx = CFG_EDCA_PROFILE_TXOPA_IDX;
 	}
 
+	debug_str = qdf_mem_malloc(SCH_WMM_DEBUG_STRING_SIZE);
+	if (!debug_str)
+		return;
+
 	for (i = 0; i < QCA_WLAN_AC_ALL; i++) {
 		if (pe_session->gLimEdcaParamsBC[i].aci.acm !=
 			(uint8_t)params[i][CFG_EDCA_PROFILE_ACM_IDX]) {
@@ -320,15 +328,20 @@ void sch_qos_update_broadcast(struct mac_context *mac, struct pe_session *pe_ses
 			updated = true;
 		}
 
-		pe_debug("QoSUpdateBCast: AC :%d: AIFSN: %d, ACM %d, CWmin %d, CWmax %d, TxOp %d",
-			       i, pe_session->gLimEdcaParamsBC[i].aci.aifsn,
-			       pe_session->gLimEdcaParamsBC[i].aci.acm,
-			       pe_session->gLimEdcaParamsBC[i].cw.min,
-			       pe_session->gLimEdcaParamsBC[i].cw.max,
-			       pe_session->gLimEdcaParamsBC[i].txoplimit);
+		len += qdf_scnprintf(debug_str + len,
+				     SCH_WMM_DEBUG_STRING_SIZE - len,
+				     "AC[%d]: AIFSN %d ACM %d CWmin %d CWmax %d TxOp %d, ",
+				     i, pe_session->gLimEdcaParamsBC[i].aci.aifsn,
+				     pe_session->gLimEdcaParamsBC[i].aci.acm,
+				     pe_session->gLimEdcaParamsBC[i].cw.min,
+				     pe_session->gLimEdcaParamsBC[i].cw.max,
+				     pe_session->gLimEdcaParamsBC[i].txoplimit);
 
 	}
 
+	pe_nofl_debug("QosUpdBcast: mode %d, %s", phyMode, debug_str);
+	qdf_mem_free(debug_str);
+
 	/*
 	 * If there exists a concurrent STA-AP session, use its WMM
 	 * params to broadcast in beacons. WFA Wifi Direct test plan

core/wma/inc/wma_internal.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2013-2021 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -837,7 +838,9 @@ QDF_STATUS wma_set_ap_peer_uapsd(tp_wma_handle wma, uint32_t vdev_id,
 
 void wma_update_edca_params_for_ac(tSirMacEdcaParamRecord *edca_param,
 				   struct wmi_host_wme_vparams *wmm_param,
-				   int ac, bool mu_edca_param);
+				   int ac, bool mu_edca_param,
+				   uint8_t *debug_str,
+				   uint32_t debug_str_size, uint32_t *len);
 
 void wma_set_tx_power(WMA_HANDLE handle,
 			     tMaxTxPowerParams *tx_pwr_params);

core/wma/src/wma_mgmt.c

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2013-2021 The Linux Foundation. All rights reserved.
- * Copyright (c) 2021 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2021-2022 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -89,6 +89,9 @@
 #include "wlan_cm_roam_api.h"
 #include "wlan_cm_api.h"
 
+/* Max debug string size for WMM in bytes */
+#define WMA_WMM_DEBUG_STRING_SIZE    512
+
 /**
  * wma_send_bcn_buf_ll() - prepare and send beacon buffer to fw for LL
  * @wma: wma handle
@@ -1990,6 +1993,8 @@ QDF_STATUS wma_process_update_edca_param_req(WMA_HANDLE handle,
 	uint8_t vdev_id;
 	QDF_STATUS status;
 	void *soc = cds_get_context(QDF_MODULE_ID_SOC);
+	uint8_t *debug_str;
+	uint32_t len = 0;
 
 	vdev_id = edca_params->vdev_id;
 	if (!wma_is_vdev_valid(vdev_id)) {
@@ -1997,6 +2002,10 @@ QDF_STATUS wma_process_update_edca_param_req(WMA_HANDLE handle,
 		goto fail;
 	}
 
+	debug_str = qdf_mem_malloc(WMA_WMM_DEBUG_STRING_SIZE);
+	if (!debug_str)
+		goto fail;
+
 	for (ac = 0; ac < QCA_WLAN_AC_ALL; ac++) {
 		switch (ac) {
 		case QCA_WLAN_AC_BE:
@@ -2012,17 +2021,23 @@ QDF_STATUS wma_process_update_edca_param_req(WMA_HANDLE handle,
 			edca_record = &edca_params->acvo;
 			break;
 		default:
+			qdf_mem_free(debug_str);
 			goto fail;
 		}
 
 		wma_update_edca_params_for_ac(edca_record, &wmm_param[ac], ac,
-				edca_params->mu_edca_params);
+					      edca_params->mu_edca_params,
+					      debug_str,
+					      WMA_WMM_DEBUG_STRING_SIZE, &len);
 
 		ol_tx_wmm_param.ac[ac].aifs = wmm_param[ac].aifs;
 		ol_tx_wmm_param.ac[ac].cwmin = wmm_param[ac].cwmin;
 		ol_tx_wmm_param.ac[ac].cwmax = wmm_param[ac].cwmax;
 	}
 
+	wma_nofl_debug("WMM params: %s", debug_str);
+	qdf_mem_free(debug_str);
+
 	status = wmi_unified_process_update_edca_param(wma_handle->wmi_handle,
 						vdev_id,
 						edca_params->mu_edca_params,

core/wma/src/wma_power.c

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2013-2021 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -217,7 +218,9 @@ QDF_STATUS wma_set_ap_peer_uapsd(tp_wma_handle wma, uint32_t vdev_id,
  */
 void wma_update_edca_params_for_ac(tSirMacEdcaParamRecord *edca_param,
 				   struct wmi_host_wme_vparams *wmm_param,
-				   int ac, bool mu_edca_param)
+				   int ac, bool mu_edca_param,
+				   uint8_t *debug_str,
+				   uint32_t debug_str_size, uint32_t *len)
 {
 	wmm_param->cwmin = WMA_WMM_EXPO_TO_VAL(edca_param->cw.min);
 	wmm_param->cwmax = WMA_WMM_EXPO_TO_VAL(edca_param->cw.max);
@@ -230,13 +233,13 @@ void wma_update_edca_params_for_ac(tSirMacEdcaParamRecord *edca_param,
 
 	wmm_param->noackpolicy = edca_param->no_ack;
 
-	wma_debug("WMM PARAMS AC[%d]: AIFS %d Min %d Max %d %s %d ACM %d NOACK %d",
-			ac, wmm_param->aifs, wmm_param->cwmin,
-			wmm_param->cwmax,
-			mu_edca_param ? "MU_EDCA TIMER" : "TXOP",
-			mu_edca_param ? wmm_param->mu_edca_timer :
-				wmm_param->txoplimit,
-			wmm_param->acm, wmm_param->noackpolicy);
+	*len += qdf_scnprintf(debug_str + *len, debug_str_size - *len,
+			      "AC[%d]: AIFS %d Min %d Max %d %s %d ACM %d NOACK %d, ",
+			      ac, wmm_param->aifs, wmm_param->cwmin,
+			      wmm_param->cwmax,
+			      mu_edca_param ? "MU_EDCA TIMER" : "TXOP",
+			      mu_edca_param ? wmm_param->mu_edca_timer : wmm_param->txoplimit,
+			      wmm_param->acm, wmm_param->noackpolicy);
 }
 
 /**