Эх сурвалжийг харах

qcacld-3.0: Avoid calling skb_put twice

The change in commit If578d66eada17784eef7daafa7351df95fc74f5a
is removing skb_put from switch case which missed during
propagation. Currently in function “wlan_hdd_send_svc_nlink_msg”
skb_put is calling twice in single code flow is leading to skb_tail
overflow crash.

Fix is to remove skb_put in switch case.

Change-Id: Icea19d92b5f7625d6a39f734bbb2fa01fa1ce2cf
CRs-Fixed: 1112350
Nishank Aggarwal 8 жил өмнө
parent
commit
2f55b3747b

+ 0 - 2
core/hdd/src/wlan_hdd_main.c

@@ -8746,7 +8746,6 @@ void wlan_hdd_send_svc_nlink_msg(int radio, int type, void *data, int len)
 	case WLAN_SVC_WLAN_AUTO_SHUTDOWN_CANCEL_IND:
 		ani_hdr->length = 0;
 		nlh->nlmsg_len = NLMSG_LENGTH((sizeof(tAniMsgHdr)));
-		skb_put(skb, NLMSG_SPACE(sizeof(tAniMsgHdr)));
 		break;
 	case WLAN_SVC_WLAN_STATUS_IND:
 	case WLAN_SVC_WLAN_VERSION_IND:
@@ -8761,7 +8760,6 @@ void wlan_hdd_send_svc_nlink_msg(int radio, int type, void *data, int len)
 		nlh->nlmsg_len = NLMSG_LENGTH((sizeof(tAniMsgHdr) + len));
 		nl_data = (char *)ani_hdr + sizeof(tAniMsgHdr);
 		memcpy(nl_data, data, len);
-		skb_put(skb, NLMSG_SPACE(sizeof(tAniMsgHdr) + len));
 		break;
 
 	default: