Преглед изворни кода

qcacld-3.0: Converge on struct tdls_del_all_tdls_peers

During TDLS componentization the legacy struct sir_del_all_tdls_peers
was replicated, creating struct tdls_del_all_tdls_peers. Unfortunately
this left the driver with two different data structures which serve
the same purpose. Not only is this pointless, but due to the way in
which these structures are used there is an implicit requirement that
they be exactly identical. This approach is very fragile. To align
with the converged software architecture and to improve code
maintainability exclusively use the TDLS component public struct.

Change-Id: Id2140e5143167e90d869de6d65ee75273830b5b0
CRs-Fixed: 2404151
Jeff Johnson пре 6 година
родитељ
комит
2b2a5509ec
2 измењених фајлова са 2 додато и 14 уклоњено
  1. 0 12
      core/mac/inc/sir_api.h
  2. 2 2
      core/mac/src/pe/lim/lim_process_tdls.c

+ 0 - 12
core/mac/inc/sir_api.h

@@ -5736,18 +5736,6 @@ struct he_capability {
 			(nss)++;                                     \
 	} while (0)
 
-/**
- * struct sir_del_all_tdls_peers - delete all tdls peers
- * @msg_type: type of message
- * @msg_len: length of message
- * @bssid: bssid of peer device
- */
-struct sir_del_all_tdls_peers {
-	uint16_t msg_type;
-	uint16_t msg_len;
-	struct qdf_mac_addr bssid;
-};
-
 /**
  * struct rsp_stats - arp packet stats
  * @arp_req_enqueue: fw tx count

+ 2 - 2
core/mac/src/pe/lim/lim_process_tdls.c

@@ -3208,11 +3208,11 @@ QDF_STATUS lim_delete_tdls_peers(struct mac_context *mac_ctx,
 QDF_STATUS lim_process_sme_del_all_tdls_peers(struct mac_context *p_mac,
 						 uint32_t *msg_buf)
 {
-	struct sir_del_all_tdls_peers *msg;
+	struct tdls_del_all_tdls_peers *msg;
 	struct pe_session *session_entry;
 	uint8_t session_id;
 
-	msg = (struct sir_del_all_tdls_peers *)msg_buf;
+	msg = (struct tdls_del_all_tdls_peers *)msg_buf;
 	if (msg == NULL) {
 		pe_err("NULL msg");
 		return QDF_STATUS_E_FAILURE;