浏览代码

qcacld-3.0: Fix incorrect condition in sap_add_mac_to_acl function

Currently sap_add_mac_to_acl() function has incorrect validation check,
size of MacList will be always zero if no elements added to the list.

Validating size always be greater than zero will prevent adding first
element itself. There by breaking whole ACL functionality.

To fix this, remove ‘*size == 0’ condition in validation code.

Change-Id: Ic3e51db798a996870ef65cda0eddfd1ec738d290
CRs-Fixed: 1104152
Arif Hussain 8 年之前
父节点
当前提交
2988e45d5c
共有 1 个文件被更改,包括 2 次插入2 次删除
  1. 2 2
      core/sap/src/sap_fsm.c

+ 2 - 2
core/sap/src/sap_fsm.c

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2012-2016 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2012-2017 The Linux Foundation. All rights reserved.
  *
  * Previously licensed under the ISC license by Qualcomm Atheros, Inc.
  *
@@ -4480,7 +4480,7 @@ void sap_add_mac_to_acl(struct qdf_mac_addr *macList,
 	QDF_TRACE(QDF_MODULE_ID_SAP, QDF_TRACE_LEVEL_INFO_HIGH,
 		  "add acl entered");
 
-	if (NULL == macList || *size == 0 || *size > MAX_ACL_MAC_ADDRESS) {
+	if (NULL == macList || *size > MAX_ACL_MAC_ADDRESS) {
 		QDF_TRACE(QDF_MODULE_ID_SAP, QDF_TRACE_LEVEL_INFO_HIGH,
 			FL("either buffer is NULL or size = %d is incorrect."),
 			*size);