samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Video: Driver: fix crash issue when dumping packet

Browse Source 
Using session id instead of session debug string when
dumping packet for a given session, in case of the
instance objest released in the other thread.

Change-Id: I1b91c051d510b8beea9d37de87f63f346efda050
Signed-off-by: Zhongbo Shi <quic_zhongbos@quicinc.com>
This commit is contained in:
Zhongbo Shi
2021-11-26 10:17:04 +08:00
committed by Govindaraj Rajagopal
parent a646e75752
commit 25c72537e8
1 changed files with 2 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
driver/vidc/src/venus_hfi.c
View File

@@ -139,36 +139,21 @@ static void __dump_packet(u8 *packet, const char *function, void *qinfo)
{ {
u32 c = 0, session_id, packet_size = *(u32 *)packet; u32 c = 0, session_id, packet_size = *(u32 *)packet;
const int row_size = 32; const int row_size = 32;
struct msm_vidc_inst *inst = NULL;
bool matches = false;
/* /*
* row must contain enough for 0xdeadbaad * 8 to be converted into * row must contain enough for 0xdeadbaad * 8 to be converted into
* "de ad ba ab " * 8 + '\0' * "de ad ba ab " * 8 + '\0'
*/ */
char row[3 * 32]; char row[3 * 32];
session_id = *((u32 *)packet + 1); session_id = *((u32 *)packet + 1);
list_for_each_entry(inst, &g_core->instances, list) {
if (inst->session_id == session_id) {
matches = true;
break;
}
}
if (matches) d_vpr_t("%08x: %s: %pK\n", session_id, function, qinfo);
i_vpr_t(inst, "%s: %pK\n", function, qinfo);
else
d_vpr_t("%s: %pK\n", function, qinfo);
for (c = 0; c * row_size < packet_size; ++c) { for (c = 0; c * row_size < packet_size; ++c) {
int bytes_to_read = ((c + 1) * row_size > packet_size) ? int bytes_to_read = ((c + 1) * row_size > packet_size) ?
packet_size % row_size : row_size; packet_size % row_size : row_size;
hex_dump_to_buffer(packet + c * row_size, bytes_to_read, hex_dump_to_buffer(packet + c * row_size, bytes_to_read,
row_size, 4, row, sizeof(row), false); row_size, 4, row, sizeof(row), false);
if (matches) d_vpr_t("%08x: %s\n", session_id, row);
i_vpr_t(inst, "%s\n", row);
else
d_vpr_t("%s\n", row);
} }
} }