qcacmn: remove the assert for DP peer state

Remove the ASSERTs added for DP peer state tranistion

Change-Id: I3fdf355fc6a79642b5527a35015f96d04e4272c0
This commit is contained in:
Chaithanya Garrepalli
2020-08-29 18:18:22 +05:30
committed by snandini
parent 4d5fb39e3e
commit 21787e51de

View File

@@ -410,6 +410,30 @@ dp_soc_iterate_peer_lock_safe(struct dp_soc *soc,
} }
} }
#ifdef DP_PEER_STATE_DEBUG
#define DP_PEER_STATE_ASSERT(_peer, _new_state, _condition) \
do { \
if (!(_condition)) { \
dp_alert("Invalid state shift from %u to %u peer " \
QDF_MAC_ADDR_FMT, \
(_peer)->peer_state, (_new_state), \
QDF_MAC_ADDR_REF((_peer)->mac_addr.raw)); \
QDF_ASSERT(0); \
} \
} while (0)
#else
#define DP_PEER_STATE_ASSERT(_peer, _new_state, _condition) \
do { \
if (!(_condition)) { \
dp_alert("Invalid state shift from %u to %u peer ", \
QDF_MAC_ADDR_FMT, \
(_peer)->peer_state, (_new_state), \
QDF_MAC_ADDR_REF((_peer)->mac_addr.raw)); \
} \
} while (0)
#endif
/** /**
* dp_peer_update_state() - update dp peer state * dp_peer_update_state() - update dp peer state
* *
@@ -428,42 +452,47 @@ dp_peer_update_state(struct dp_soc *soc,
switch (state) { switch (state) {
case DP_PEER_STATE_INIT: case DP_PEER_STATE_INIT:
QDF_ASSERT DP_PEER_STATE_ASSERT
((peer_state != DP_PEER_STATE_ACTIVE) || (peer, state, (peer_state != DP_PEER_STATE_ACTIVE) ||
(peer_state != DP_PEER_STATE_LOGICAL_DELETE)); (peer_state != DP_PEER_STATE_LOGICAL_DELETE));
break; break;
case DP_PEER_STATE_ACTIVE: case DP_PEER_STATE_ACTIVE:
QDF_ASSERT(peer_state == DP_PEER_STATE_INIT); DP_PEER_STATE_ASSERT(peer, state,
(peer_state == DP_PEER_STATE_INIT));
break; break;
case DP_PEER_STATE_LOGICAL_DELETE: case DP_PEER_STATE_LOGICAL_DELETE:
QDF_ASSERT((peer_state == DP_PEER_STATE_ACTIVE) || DP_PEER_STATE_ASSERT(peer, state,
(peer_state == DP_PEER_STATE_INIT)); (peer_state == DP_PEER_STATE_ACTIVE) ||
(peer_state == DP_PEER_STATE_INIT));
break; break;
case DP_PEER_STATE_INACTIVE: case DP_PEER_STATE_INACTIVE:
QDF_ASSERT(peer_state == DP_PEER_STATE_LOGICAL_DELETE); DP_PEER_STATE_ASSERT
(peer, state,
(peer_state == DP_PEER_STATE_LOGICAL_DELETE));
break; break;
case DP_PEER_STATE_FREED: case DP_PEER_STATE_FREED:
if (peer->sta_self_peer) if (peer->sta_self_peer)
QDF_ASSERT(peer_state == DP_PEER_STATE_ASSERT
DP_PEER_STATE_INIT); (peer, state, (peer_state == DP_PEER_STATE_INIT));
else else
QDF_ASSERT((peer_state == DP_PEER_STATE_ASSERT
DP_PEER_STATE_INACTIVE) || (peer, state,
(peer_state == (peer_state == DP_PEER_STATE_INACTIVE) ||
DP_PEER_STATE_LOGICAL_DELETE)); (peer_state == DP_PEER_STATE_LOGICAL_DELETE));
break; break;
default: default:
QDF_ASSERT(0); dp_alert("Invalid peer state %u for peer "QDF_MAC_ADDR_FMT,
break; state, QDF_MAC_ADDR_REF(peer->mac_addr.raw));
return;
} }
qdf_info("Updating peer state from %u to %u mac "QDF_MAC_ADDR_FMT"\n", dp_info("Updating peer state from %u to %u mac "QDF_MAC_ADDR_FMT"\n",
peer_state, state, peer_state, state,
QDF_MAC_ADDR_REF(peer->mac_addr.raw)); QDF_MAC_ADDR_REF(peer->mac_addr.raw));
peer->peer_state = state; peer->peer_state = state;
} }