qcacmn: Fix WMI documentation

The kernel-doc script identified many documentation issues in
the wmi folder, so fix them.

Note that in quite a few cases there is duplicate documentation in .h
and .c files, and in those cases remove the documentation from the .c
files since the interface should be documented, not the
implementation.

Change-Id: I097d5b8e8f0ba09046b7b8abe338d05a00f8cc7e
CRs-Fixed: 3372831

wmi/inc/wmi_filtered_logging.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2015-2020 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -115,7 +116,7 @@ int debug_wmi_filtered_command_log_show(qdf_debugfs_file_t m, void *v);
 int debug_wmi_filtered_event_log_show(qdf_debugfs_file_t m, void *v);
 
 /**
- * debug_wmi_filtered_wmi_cmds_write() - debugfs write for filtered_wmi_cmds
+ * debug_filtered_wmi_cmds_write() - debugfs write for filtered_wmi_cmds
  *
  * @file: file handler to access wmi_handle
  * @buf: received data buffer
@@ -129,7 +130,7 @@ ssize_t debug_filtered_wmi_cmds_write(struct file *file,
 				      size_t count, loff_t *ppos);
 
 /**
- * debug_wmi_filtered_wmi_evts_write() - debugfs write for filtered_wmi_evts
+ * debug_filtered_wmi_evts_write() - debugfs write for filtered_wmi_evts
  *
  * @file: file handler to access wmi_handle
  * @buf: received data buffer

wmi/inc/wmi_hang_event.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2020, The Linux Foundation. All rights reserved.
+ * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
@@ -31,7 +32,6 @@ QDF_STATUS wmi_hang_event_notifier_register(struct wmi_unified *wmi_hdl);
 
 /**
  * wmi_hang_event_notifier_unregister() - wmi hang event notifier unregister
- * @wmi_hdl: WMI Handle
  *
  * This function unregisters wmi layer notifier for the hang event notifier
  * chain.

wmi/inc/wmi_unified_11be_setup_api.h

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2021, The Linux Foundation. All rights reserved.
- * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
@@ -68,7 +68,7 @@ wmi_extract_mlo_setup_cmpl_event(wmi_unified_t wmi_handle,
  *  wmi_extract_mlo_teardown_cmpl_event() - Extract MLO teardown completion
  *  @wmi_handle: WMI handle for this pdev
  *  @buf: Event buffer
- *  @params: MLO teardown event params
+ *  @param: MLO teardown event params
  *
  *  Return: QDF_STATUS code
  */

wmi/inc/wmi_unified_crypto_api.h

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2019, 2021 The Linux Foundation. All rights reserved.
- * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -41,7 +41,7 @@ typedef enum {
  * @wmi_handle: wmi handle
  * @evt_buf: pointer to event buffer
  * @len: length of the event buffer
- * @params: Pointer to hold params of install key complete
+ * @param: Pointer to hold params of install key complete
  *
  * Return: QDF_STATUS_SUCCESS on success and QDF_STATUS_E_FAILURE for failure
  */

wmi/inc/wmi_unified_dbr_param.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2016-2018, 2020 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -76,8 +77,9 @@
  * struct direct_buf_rx_rsp: direct buffer rx response structure
  *
  * @pdev_id: Index of the pdev for which response is received
- * @mod_mod: Index of the module for which respone is received
+ * @mod_id: Index of the module for which respone is received
  * @num_buf_release_entry: Number of buffers released through event
+ * @num_meta_data_entry:
  * @dbr_entries: Pointer to direct buffer rx entry struct
  */
 struct direct_buf_rx_rsp {
@@ -101,6 +103,8 @@ struct direct_buf_rx_rsp {
  * @tail_idx_paddr_hi: Higher 32bits of tail idx register address
  * @buf_size: Size of the buffer for each pointer in the ring
  * @num_elems: Number of pointers allocated and part of the source ring
+ * @event_timeout_ms:
+ * @num_resp_per_event:
  */
 struct direct_buf_rx_cfg_req {
 	uint32_t pdev_id;
@@ -137,8 +141,8 @@ struct direct_buf_rx_metadata {
 /**
  * struct direct_buf_rx_entry: direct buffer rx release entry structure
  *
- * @addr_lo: LSB 32-bits of the buffer
- * @addr_hi: MSB 32-bits of the buffer
+ * @paddr_lo: LSB 32-bits of the buffer
+ * @paddr_hi: MSB 32-bits of the buffer
  * @len: Length of the buffer
  */
 struct direct_buf_rx_entry {

wmi/inc/wmi_unified_dcs_api.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2020-2021, The Linux Foundation. All rights reserved.
+ * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
@@ -29,7 +30,7 @@
 
 /**
  * wmi_extract_dcs_interference_type() - extract dcs interference type
- * @wmi_handle: wmi handle
+ * @wmi_hdl: wmi handle
  * @evt_buf: pointer to event buffer
  * @param: Pointer to hold dcs interference param
  *
@@ -44,7 +45,7 @@ QDF_STATUS wmi_extract_dcs_interference_type(
 
 /**
  * wmi_extract_dcs_im_tgt_stats() - extract dcs im target stats
- * @wmi_handle: wmi handle
+ * @wmi_hdl: wmi handle
  * @evt_buf: pointer to event buffer
  * @wlan_stat: Pointer to hold wlan stats
  *
@@ -57,9 +58,9 @@ QDF_STATUS wmi_extract_dcs_im_tgt_stats(
 	void *evt_buf,
 	struct wlan_host_dcs_im_tgt_stats *wlan_stat);
 
-/*
+/**
  * wmi_extract_dcs_awgn_info() - extract DCS AWGN interference info from event
- * @wmi_handle: WMI handle
+ * @wmi_hdl: WMI handle
  * @evt_buf: Pointer to event buffer
  * @awgn_info: Pointer to hold AWGN interference info
  *

wmi/inc/wmi_unified_dfs_api.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2017-2019, 2021 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -29,7 +30,7 @@
 /**
  * wmi_extract_dfs_cac_complete_event() - function to handle cac complete event
  * @wmi_handle: wmi handle
- * @event_buf: event buffer
+ * @evt_buf: event buffer
  * @vdev_id: vdev id
  * @len: length of buffer
  *
@@ -45,7 +46,7 @@ QDF_STATUS wmi_extract_dfs_cac_complete_event(
  * wmi_extract_dfs_ocac_complete_event() - function to handle off channel
  *						CAC complete event
  * @wmi_handle: wmi handle
- * @event_buf: event buffer
+ * @evt_buf: event buffer
  * @param: off channel cac  complete params
  *
  * Return: 0 for success or error code
@@ -57,7 +58,7 @@ wmi_extract_dfs_ocac_complete_event(wmi_unified_t wmi_handle, uint8_t *evt_buf,
 /**
  * wmi_extract_dfs_radar_detection_event() - function to handle radar event
  * @wmi_handle: wmi handle
- * @event_buf: event buffer
+ * @evt_buf: event buffer
  * @radar_found: radar found event info
  * @len: length of buffer
  *

wmi/inc/wmi_unified_fwol_api.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2019-2021 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -107,7 +108,7 @@ wmi_unified_send_set_mdns_config_cmd(struct wmi_unified *wmi_handle,
  * @wmi_handle: wmi handle
  * @req_type: Request type
  * @temp_offset: temperature offset for setting the range for thermal stats
-
+ *
  * Send WMI get thermal stats req command to firmware.
  *
  * Return: QDF_STATUS

wmi/inc/wmi_unified_nan_api.h

@@ -1,6 +1,6 @@
-
 /*
  * Copyright (c) 2013-2020 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -90,7 +90,7 @@ QDF_STATUS wmi_unified_terminate_all_ndps_req_cmd(wmi_unified_t wmi_handle,
 
 /**
  * wmi_extract_ndp_initiator_rsp - api to extract initiator rsp from even buffer
- * @wmi_hdl: wmi handle
+ * @wmi_handle: wmi handle
  * @data: event buffer
  * @rsp: buffer to populate
  *
@@ -102,7 +102,7 @@ wmi_extract_ndp_initiator_rsp(wmi_unified_t wmi_handle, uint8_t *data,
 
 /**
  * wmi_extract_ndp_ind - api to extract ndp indication struct from even buffer
- * @wmi_hdl: wmi handle
+ * @wmi_handle: wmi handle
  * @data: event buffer
  * @ind: buffer to populate
  *
@@ -113,6 +113,7 @@ QDF_STATUS wmi_extract_ndp_ind(wmi_unified_t wmi_handle, uint8_t *data,
 
 /**
  * wmi_extract_nan_msg - api to extract ndp dmesg buffer to print logs
+ * @wmi_handle: wmi handle
  * @data: event buffer
  * @msg: buffer to populate
  *
@@ -123,7 +124,7 @@ QDF_STATUS wmi_extract_nan_msg(wmi_unified_t wmi_handle, uint8_t *data,
 
 /**
  * wmi_extract_ndp_confirm - api to extract ndp confim struct from even buffer
- * @wmi_hdl: wmi handle
+ * @wmi_handle: wmi handle
  * @data: event buffer
  * @ev: buffer to populate
  *
@@ -134,7 +135,7 @@ QDF_STATUS wmi_extract_ndp_confirm(wmi_unified_t wmi_handle, uint8_t *data,
 
 /**
  * wmi_extract_ndp_responder_rsp - api to extract responder rsp from even buffer
- * @wmi_hdl: wmi handle
+ * @wmi_handle: wmi handle
  * @data: event buffer
  * @rsp: buffer to populate
  *
@@ -146,7 +147,7 @@ wmi_extract_ndp_responder_rsp(wmi_unified_t wmi_handle, uint8_t *data,
 
 /**
  * wmi_extract_ndp_end_rsp - api to extract ndp end rsp from even buffer
- * @wmi_hdl: wmi handle
+ * @wmi_handle: wmi handle
  * @data: event buffer
  * @rsp: buffer to populate
  *
@@ -157,7 +158,7 @@ QDF_STATUS wmi_extract_ndp_end_rsp(wmi_unified_t wmi_handle, uint8_t *data,
 
 /**
  * wmi_extract_ndp_end_ind - api to extract ndp end indication from even buffer
- * @wmi_hdl: wmi handle
+ * @wmi_handle: wmi handle
  * @data: event buffer
  * @ind: buffer to populate
  *
@@ -169,7 +170,7 @@ wmi_extract_ndp_end_ind(wmi_unified_t wmi_handle, uint8_t *data,
 
 /**
  * wmi_extract_ndp_sch_update - api to extract ndp sch update from event buffer
- * @wmi_hdl: wmi handle
+ * @wmi_handle: wmi handle
  * @data: event buffer
  * @ind: buffer to populate
  *
@@ -181,8 +182,8 @@ wmi_extract_ndp_sch_update(wmi_unified_t wmi_handle, uint8_t *data,
 
 /**
  * wmi_extract_nan_event_rsp - api to extract nan event into event parameters
- * @wmi_hdl: wmi handle
- * @wvt_buf: pointer to the event buffer
+ * @wmi_handle: wmi handle
+ * @evt_buf: pointer to the event buffer
  * @temp_evt_params: Pointer to a temporary parameters structure to populate
  * @nan_msg_buf: Pointer to the NAN Message buffer encapsulated in the event
  *
@@ -194,7 +195,7 @@ QDF_STATUS wmi_extract_nan_event_rsp(wmi_unified_t wmi_handle, void *evt_buf,
 
 /**
  * wmi_extract_ndp_host_event - api to extract ndp event from event buffer
- * @wmi_hdl: wmi handle
+ * @wmi_handle: wmi handle
  * @data: event buffer
  * @evt: event buffer to populate
  *

wmi/inc/wmi_unified_ocb_api.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2013-2018 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -66,9 +67,9 @@ QDF_STATUS wmi_unified_ocb_get_tsf_timer(struct wmi_unified *wmi_handle,
 					 struct ocb_get_tsf_timer_param *req);
 
 /**
- * wmi_unified_ocb_set_utc_time_cmd() - get ocb tsf timer val
+ * wmi_unified_ocb_set_utc_time_cmd() - set OCB UTC time
  * @wmi_handle: pointer to the wmi handle
- * @vdev_id: vdev id
+ * @utc: UTC time
  *
  * Return: QDF_STATUS_SUCCESS on success and QDF_STATUS_E_FAILURE for failure
  */
@@ -145,7 +146,7 @@ QDF_STATUS wmi_extract_dcc_update_ndl_resp(struct wmi_unified *wmi_handle,
  * wmi_extract_dcc_stats() - extract DCC stats from wmi event
  * @wmi_handle: wmi handle
  * @evt_buf: pointer to event buffer
- * @resp: DCC stats
+ * @response: DCC stats
  *
  * Since length of the response is variable, response buffer will be allocated.
  * The caller must free the response buffer.

wmi/inc/wmi_unified_pmo_api.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2017-2019, 2021 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -93,7 +94,7 @@ QDF_STATUS wmi_unified_wow_patterns_to_fw_cmd(
  * wmi_unified_add_clear_mcbc_filter_cmd() - set mcast filter command to fw
  * @wmi_handle: wmi handle
  * @vdev_id: vdev id
- * @multicastAddr: mcast address
+ * @multicast_addr: mcast address
  * @clear_list: clear list flag
  *
  * Return: QDF_STATUS_SUCCESS on success and QDF_STATUS_E_FAILURE for failure
@@ -109,7 +110,7 @@ QDF_STATUS wmi_unified_add_clear_mcbc_filter_cmd(
  *						      filter command to fw
  * @wmi_handle: wmi handle
  * @vdev_id: vdev id
- * @filter_params: mcast filter params
+ * @filter_param: mcast filter params
  *
  * Return: QDF_STATUS_SUCCESS on success and QDF_STATUS_E_FAILURE for failure
  */
@@ -135,7 +136,8 @@ QDF_STATUS wmi_unified_wow_sta_ra_filter_cmd(wmi_unified_t wmi_handle,
 #endif
 
 /**
- * wmi_unified_enable_enhance_multicast_offload() - enhance multicast offload
+ * wmi_unified_enable_enhance_multicast_offload_cmd() - enhance multicast
+ *                                                      offload
  * @wmi_handle: wmi handle
  * @vdev_id: vdev id
  * @action: true for enable else false
@@ -152,12 +154,12 @@ QDF_STATUS wmi_unified_enable_enhance_multicast_offload_cmd(
  * @wmi_handle: wmi handle
  * @evt_buf: pointer to event buffer
  * @gtk_rsp_param: Pointer to gtk rsp parameters
- * @ len: len of gtk rsp event
+ * @len: len of gtk rsp event
  *
  * Return: QDF_STATUS_SUCCESS on success and QDF_STATUS_E_FAILURE for failure
  */
 QDF_STATUS wmi_extract_gtk_rsp_event(
-	wmi_unified_t wmi_hdl, void *evt_buf,
+	wmi_unified_t wmi_handle, void *evt_buf,
 	struct pmo_gtk_rsp_params *gtk_rsp_param, uint32_t len);
 
 /**
@@ -202,7 +204,7 @@ QDF_STATUS wmi_unified_send_gtk_offload_cmd(wmi_unified_t wmi_handle,
 
 /**
  * wmi_unified_enable_arp_ns_offload_cmd() - enable ARP NS offload
- * @wmi_hdl: wmi handle
+ * @wmi_handle: wmi handle
  * @arp_offload_req: arp offload request
  * @ns_offload_req: ns offload request
  * @vdev_id: vdev id
@@ -379,7 +381,7 @@ QDF_STATUS wmi_unified_set_app_type2_params_in_fw_cmd(
 
 /**
  * wmi_unified_app_type1_params_in_fw_cmd() - set app type1 params in fw
- * @wmi_hdl: wmi handle
+ * @wmi_handle: wmi handle
  * @app_type1_params: app type1 params
  *
  * Return: QDF_STATUS_SUCCESS on success and QDF_STATUS_E_FAILURE for failure
@@ -392,7 +394,7 @@ QDF_STATUS wmi_unified_app_type1_params_in_fw_cmd(
 #ifdef WLAN_FEATURE_IGMP_OFFLOAD
 /**
  * wmi_unified_send_igmp_offload_cmd() - send igmp offload cmd to fw
- * @wmi_hdl: wmi handle
+ * @wmi_handle: wmi handle
  * @pmo_igmp_req: igmp params
  *
  * Return: Success or failure
@@ -405,7 +407,7 @@ wmi_unified_send_igmp_offload_cmd(wmi_unified_t wmi_handle,
 #ifdef WLAN_FEATURE_ICMP_OFFLOAD
 /**
  * wmi_unified_config_icmp_offload_cmd() - enable ICMP offload
- * @wmi_hdl: wmi handle
+ * @wmi_handle: wmi handle
  * @pmo_icmp_req: icmp offload request
  *
  * To configure ICMP offload data to firmware

wmi/inc/wmi_unified_priv.h

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2013-2021 The Linux Foundation. All rights reserved.
- * Copyright (c) 2021-2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2021-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -127,8 +127,8 @@
 
 /**
  * enum WMI_MSG_TYPE - WMI message types
- * @ WMI_MSG_TYPE_CMD - Message is of type WMI command
- * @ WMI_MSG_TYPE_EVENT - Message is of type WMI event
+ * @WMI_MSG_TYPE_CMD: Message is of type WMI command
+ * @WMI_MSG_TYPE_EVENT: Message is of type WMI event
  */
 enum WMI_MSG_TYPE {
 	WMI_MSG_TYPE_CMD = 0,
@@ -137,11 +137,11 @@ enum WMI_MSG_TYPE {
 
 /**
  * struct wmi_ext_dbg_msg - WMI command/event msg details
- * @ node - qdf list node of wmi messages
- * @ len - command/event message length
- * @ ts - Time of WMI command/event handling
- * @ WMI_MSG_TYPE - message type
- * @ bug - command/event buffer
+ * @node: qdf list node of wmi messages
+ * @len: command/event message length
+ * @ts: Time of WMI command/event handling
+ * @type: message type
+ * @buf: command/event buffer
  */
 struct wmi_ext_dbg_msg {
 	qdf_list_node_t node;
@@ -225,9 +225,9 @@ struct wmi_ext_dbg_msg {
 
 /**
  * struct wmi_command_debug - WMI command log buffer data type
- * @ command - Store WMI Command id
- * @ data - Stores WMI command data
- * @ time - Time of WMI command handling
+ * @command: Store WMI Command id
+ * @data: Stores WMI command data
+ * @time: Time of WMI command handling
  */
 struct wmi_command_debug {
 	uint32_t command;
@@ -238,11 +238,11 @@ struct wmi_command_debug {
 
 /**
  * struct wmi_command_cmp_debug - WMI command completion log buffer data type
- * @ command - Store WMI Command id
- * @ data - Stores WMI command data
- * @ time - Time of WMI command handling
- * @ dma_addr - dma address of the WMI buffer
- * @ phy_addr - physical address of the WMI buffer
+ * @command: Store WMI Command id
+ * @data: Stores WMI command data
+ * @time: Time of WMI command handling
+ * @dma_addr: dma address of the WMI buffer
+ * @phy_addr: physical address of the WMI buffer
  */
 struct wmi_command_cmp_debug {
 	uint32_t command;
@@ -255,9 +255,9 @@ struct wmi_command_cmp_debug {
 
 /**
  * struct wmi_event_debug - WMI event log buffer data type
- * @ command - Store WMI Event id
- * @ data - Stores WMI Event data
- * @ time - Time of WMI Event handling
+ * @event: Store WMI Event id
+ * @data: Stores WMI Event data
+ * @time: Time of WMI Event handling
  */
 struct wmi_event_debug {
 	uint32_t event;
@@ -268,9 +268,9 @@ struct wmi_event_debug {
 
 /**
  * struct wmi_command_header - Type for accessing frame data
- * @ type - 802.11 Frame type
- * @ subType - 802.11 Frame subtype
- * @ protVer - 802.11 Version
+ * @type: 802.11 Frame type
+ * @sub_type: 802.11 Frame subtype
+ * @prot_ver: 802.11 Version
  */
 struct wmi_command_header {
 #ifndef ANI_LITTLE_BIT_ENDIAN
@@ -291,12 +291,12 @@ struct wmi_command_header {
 
 /**
  * struct wmi_log_buf_t - WMI log buffer information type
- * @buf - Reference to WMI log buffer
- * @ length - length of buffer
- * @ buf_tail_idx - Tail index of buffer
- * @ p_buf_tail_idx - reference to buffer tail index. It is added to accommodate
+ * @buf: Reference to WMI log buffer
+ * @length: length of buffer
+ * @buf_tail_idx: Tail index of buffer
+ * @p_buf_tail_idx: reference to buffer tail index. It is added to accommodate
  * unified design since MCL uses global variable for buffer tail index
- * @ size - the size of the buffer in number of entries
+ * @size: the size of the buffer in number of entries
  */
 struct wmi_log_buf_t {
 	void *buf;
@@ -309,29 +309,29 @@ struct wmi_log_buf_t {
 /**
  * struct wmi_debug_log_info - Meta data to hold information of all buffers
  * used for WMI logging
- * @wmi_command_log_buf_info - Buffer info for WMI Command log
- * @wmi_command_tx_cmp_log_buf_info - Buffer info for WMI Command Tx completion
+ * @wmi_command_log_buf_info: Buffer info for WMI Command log
+ * @wmi_command_tx_cmp_log_buf_info: Buffer info for WMI Command Tx completion
  * log
- * @wmi_event_log_buf_info - Buffer info for WMI Event log
- * @wmi_rx_event_log_buf_info - Buffer info for WMI event received log
- * @wmi_mgmt_command_log_buf_info - Buffer info for WMI Management Command log
- * @wmi_mgmt_command_tx_cmp_log_buf_info - Buffer info for WMI Management
+ * @wmi_event_log_buf_info: Buffer info for WMI Event log
+ * @wmi_rx_event_log_buf_info: Buffer info for WMI event received log
+ * @wmi_mgmt_command_log_buf_info: Buffer info for WMI Management Command log
+ * @wmi_mgmt_command_tx_cmp_log_buf_info: Buffer info for WMI Management
  * Command Tx completion log
- * @wmi_mgmt_event_log_buf_info - Buffer info for WMI Management event log
- * @wmi_diag_event_log_buf_info - Buffer info for WMI diag event log
- * @wmi_record_lock - Lock WMI recording
- * @wmi_logging_enable - Enable/Disable state for WMI logging
- * @wmi_id_to_name - Function reference to API to convert Command id to
+ * @wmi_mgmt_event_log_buf_info: Buffer info for WMI Management event log
+ * @wmi_diag_event_log_buf_info: Buffer info for WMI diag event log
+ * @wmi_record_lock: Lock WMI recording
+ * @wmi_logging_enable: Enable/Disable state for WMI logging
+ * @wmi_id_to_name: Function reference to API to convert Command id to
  * string name
- * @wmi_log_debugfs_dir - reference to debugfs directory
- * @filtered_wmi_cmds - Buffer to save inputs from user on
+ * @wmi_log_debugfs_dir: reference to debugfs directory
+ * @filtered_wmi_cmds: Buffer to save inputs from user on
  * which WMI commands to record
- * @filtered_wmi_cmds_idx - target cmd index
- * @filtered_wmi_evts - Buffer to save inputs from user on
+ * @filtered_wmi_cmds_idx: target cmd index
+ * @filtered_wmi_evts: Buffer to save inputs from user on
  * which WMI event to record
- * @filtered_wmi_evts_idx - target evt index
- * @wmi_filtered_command_log - buffer to record user specified WMI commands
- * @wmi_filtered_event_log - buffer to record user specified WMI events
+ * @filtered_wmi_evts_idx: target evt index
+ * @wmi_filtered_command_log: buffer to record user specified WMI commands
+ * @wmi_filtered_event_log: buffer to record user specified WMI events
  */
 struct wmi_debug_log_info {
 	struct wmi_log_buf_t wmi_command_log_buf_info;
@@ -361,8 +361,8 @@ struct wmi_debug_log_info {
 
 /**
  * enum WMI_RECORD_TYPE - User specified WMI logging types
- * @ WMI_CMD - wmi command id
- * @ WMI_EVT - wmi event id
+ * @WMI_CMD: wmi command id
+ * @WMI_EVT: wmi event id
  */
 enum WMI_RECORD_TYPE {
 	WMI_CMD = 1,
@@ -381,9 +381,9 @@ struct fwdebug {
 
 /**
  * struct wmi_wq_dbg_info - WMI WQ debug info
- * @ wd_msg_type_id - wmi event id
- * @ wmi_wq - WMI workqueue struct
- * @ task - WMI workqueue task struct
+ * @wd_msg_type_id: wmi event id
+ * @wmi_wq: WMI workqueue struct
+ * @task: WMI workqueue task struct
  */
 struct wmi_wq_dbg_info {
 	uint32_t wd_msg_type_id;
@@ -422,7 +422,7 @@ QDF_STATUS
  * @wmi_handle: WMI handle
  * @evt_buf: Event buffer
  * @len: evt buffer data len
- * @synd_ind: roam sync ptr
+ * @sync_ind: roam sync ptr
  *
  * This api will allocate memory for roam sync info, extract
  * the information sent by FW and pass to CM.The memory will be
@@ -3207,7 +3207,7 @@ QDF_STATUS (*send_update_edca_pifs_param_cmd)(
 struct wlan_objmgr_psoc;
 
 /**
- * struct wmi_init_cmd - Saved wmi INIT command
+ * struct wmi_cmd_init - Saved wmi INIT command
  * @buf: Buffer containing the wmi INIT command
  * @buf_len: Length of the buffer
  */
@@ -3217,6 +3217,7 @@ struct wmi_cmd_init {
 };
 
 /**
+ * struct wmi_host_abi_version - HOST WMI ABI version
  * @abi_version_0: WMI Major and Minor versions
  * @abi_version_1: WMI change revision
  * @abi_version_ns_0: ABI version namespace first four dwords

wmi/inc/wmi_unified_reg_api.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2017-2021 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -27,7 +28,7 @@
 /**
  * wmi_extract_reg_chan_list_update_event() - function to update channel list
  * @wmi_handle: wmi handle
- * @event_buf: event buffer
+ * @evt_buf: event buffer
  * @reg_info: regulatory info
  * @len: length of buffer
  *

wmi/inc/wmi_unified_sta_api.h

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2013-2020 The Linux Foundation. All rights reserved.
- * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -145,8 +145,8 @@ wmi_unified_wlm_latency_level_cmd(wmi_unified_t wmi_handle,
 
 /**
  * wmi_unified_process_set_ie_info_cmd() - Function to send IE info to firmware
- * @wmi_handle:    Pointer to WMi handle
- * @ie_data:       Pointer for ie data
+ * @wmi_handle:    Pointer to WMI handle
+ * @ie_info:       Pointer for IE information
  *
  * This function sends IE information to firmware
  *
@@ -197,6 +197,7 @@ QDF_STATUS wmi_unified_update_fw_tdls_state_cmd(wmi_unified_t wmi_handle,
  * wmi_unified_update_tdls_peer_state_cmd() - update TDLS peer state
  * @wmi_handle: wmi handle
  * @peer_state: TDLS peer state params
+ * @ch_mhz: peer channel list
  *
  * Return: QDF_STATUS_SUCCESS on success and QDF_STATUS_E_FAILURE for failure
  */
@@ -259,9 +260,9 @@ QDF_STATUS wmi_unified_extract_sar_limit_event(wmi_unified_t wmi_handle,
 QDF_STATUS wmi_unified_extract_sar2_result_event(void *handle,
 						 uint8_t *event, uint32_t len);
 
-/*
+/**
  * wmi_unified_set_del_pmkid_cache() - set delete PMKID
- * @wmi_handle: wma handle
+ * @wmi_handle: wmi handle
  * @pmksa: pointer to pmk cache entry
  *
  * Return: QDF_STATUS_SUCCESS on success and QDF_STATUS_E_FAILURE for failure
@@ -398,7 +399,7 @@ QDF_STATUS wmi_unified_pdev_set_dual_mac_config_cmd(
 /**
  * wmi_unified_send_adapt_dwelltime_params_cmd() - send wmi cmd of
  * adaptive dwelltime configuration params
- * @wma_handle:  wma handler
+ * @wmi_handle:  wmi handler
  * @wmi_param: pointer to dwelltime_params
  *
  * Return: QDF_STATUS_SUCCESS on success and QDF failure reason code for failure
@@ -410,7 +411,7 @@ QDF_STATUS wmi_unified_send_adapt_dwelltime_params_cmd(
 /**
  * wmi_unified_send_dbs_scan_sel_params_cmd() - send wmi cmd of
  * DBS scan selection configuration params
- * @wma_handle:  wma handler
+ * @wmi_handle:  wmi handler
  * @wmi_param: pointer to wmi_dbs_scan_sel_params
  *
  * Return: QDF_STATUS_SUCCESS on success and QDF failure reason code for failure

wmi/inc/wmi_unified_sta_param.h

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2013-2020 The Linux Foundation. All rights reserved.
- * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -43,13 +43,13 @@ struct sta_keep_alive_params {
 };
 
 /**
- * struct gtx_config_t - GTX config
+ * struct wmi_gtx_config - GTX config
  * @gtx_rt_mask: for HT and VHT rate masks
  * @gtx_usrcfg: host request for GTX mask
  * @gtx_threshold: PER Threshold (default: 10%)
  * @gtx_margin: PER margin (default: 2%)
- * @gtx_tcpstep: TCP step (default: 1)
- * @gtx_tpcMin: TCP min (default: 5)
+ * @gtx_tpcstep: TPC step (default: 1)
+ * @gtx_tpcmin: TPC min (default: 5)
  * @gtx_bwmask: BW mask (20/40/80/160 Mhz)
  */
 struct wmi_gtx_config {
@@ -111,10 +111,12 @@ struct wlm_latency_level_param {
 
 /**
  * struct vdev_ie_info_param - IE info
- * @vdev_id - vdev for which the IE is being sent
- * @ie_id - ID of the IE
- * @length - length of the IE data
- * @data - IE data
+ * @vdev_id: vdev for which the IE is being sent
+ * @ie_id: ID of the IE
+ * @length: length of the IE data
+ * @ie_source:
+ * @band:
+ * @data: IE data
  *
  * This structure is used to store the IE information.
  */
@@ -235,7 +237,7 @@ struct wmi_unified_pmk_cache {
  * struct aggr_add_ts_param - ADDTS parameters
  * @tspecIdx: TSPEC handler uniquely identifying a TSPEC for a STA in a BSS
  * @tspec: tspec value
- * @status: CDF status
+ * @status: QDF status
  * @sessionId: session id
  * @vdev_id: vdev id
  */
@@ -266,7 +268,7 @@ struct periodic_tx_pattern {
 
 /**
  * struct flashing_req_params - led flashing parameter
- * @reqId: request id
+ * @req_id: request id
  * @pattern_id: pattern identifier. 0: disconnected 1: connected
  * @led_x0: led flashing parameter0
  * @led_x1: led flashing parameter1

wmi/inc/wmi_unified_twt_api.h

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2018-2021 The Linux Foundation. All rights reserved.
- * Copyright (c) 2021-2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2021-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -159,7 +159,7 @@ QDF_STATUS wmi_extract_twt_disable_comp_event(
 /**
  * wmi_extract_twt_add_dialog_comp_event() - Extract WMI event params for TWT
  *                               add dialog completion event
- * @wmi_hdl: wmi handle
+ * @wmi_handle: wmi handle
  * @evt_buf: Pointer event buffer
  * @params: Parameters to extract
  *
@@ -173,7 +173,7 @@ QDF_STATUS wmi_extract_twt_add_dialog_comp_event(
 /**
  * wmi_extract_twt_add_dialog_comp_additional_params() - Extracts additional
  * twt parameters, as part of add dialog completion event
- * @wmi_hdl: wmi handle
+ * @wmi_handle: wmi handle
  * @evt_buf: Pointer event buffer
  * @evt_buf_len: length of the add dialog event buffer
  * @idx: index of num_twt_params to extract
@@ -189,7 +189,7 @@ QDF_STATUS wmi_extract_twt_add_dialog_comp_additional_params(
 /**
  * wmi_extract_twt_del_dialog_comp_event() - Extract WMI event params for TWT
  *                               delete dialog completion event
- * @wmi_hdl: wmi handle
+ * @wmi_handle: wmi handle
  * @evt_buf: Pointer event buffer
  * @params: Parameters to extract
  *
@@ -326,7 +326,7 @@ void wmi_twt_attach_tlv(struct wmi_unified *wmi_handle);
  *                                         service ready2 event
  * @wmi_handle: WMI handle
  * @evt_buf: Event buffer
- * @param: Pointer to TWT bitmap param
+ * @params: Pointer to TWT bitmap param
  *
  * Return: QDF_STATUS_SUCCESS for success or error code
  */
@@ -340,7 +340,7 @@ QDF_STATUS wmi_extract_twt_cap_service_ready_ext2(
  *
  * @wmi_handle: wmi handle
  * @evt_buf: Pointer event buffer
- * @params: Parameters to extract
+ * @param: Parameters to extract
  *
  * Return: QDF_STATUS_SUCCESS on success and QDF_STATUS_E_FAILURE for failure
  */
@@ -482,7 +482,7 @@ QDF_STATUS wmi_extract_twt_disable_comp_event(
 /**
  * wmi_extract_twt_add_dialog_comp_event() - Extract WMI event params for TWT
  *                               add dialog completion event
- * @wmi_hdl: wmi handle
+ * @wmi_handle: wmi handle
  * @evt_buf: Pointer event buffer
  * @params: Parameters to extract
  *
@@ -496,7 +496,7 @@ QDF_STATUS wmi_extract_twt_add_dialog_comp_event(
 /**
  * wmi_extract_twt_add_dialog_comp_additional_params() - Extracts additional
  * twt parameters, as part of add dialog completion event
- * @wmi_hdl: wmi handle
+ * @wmi_handle: wmi handle
  * @evt_buf: Pointer event buffer
  * @evt_buf_len: length of the add dialog event buffer
  * @idx: index of num_twt_params to extract
@@ -512,7 +512,7 @@ QDF_STATUS wmi_extract_twt_add_dialog_comp_additional_params(
 /**
  * wmi_extract_twt_del_dialog_comp_event() - Extract WMI event params for TWT
  *                               delete dialog completion event
- * @wmi_hdl: wmi handle
+ * @wmi_handle: wmi handle
  * @evt_buf: Pointer event buffer
  * @params: Parameters to extract
  *
@@ -649,7 +649,7 @@ void wmi_twt_attach_tlv(struct wmi_unified *wmi_handle);
  *                                         service ready2 event
  * @wmi_handle: WMI handle
  * @evt_buf: Event buffer
- * @param: Pointer to TWT bitmap param
+ * @params: Pointer to TWT bitmap param
  *
  * Return: QDF_STATUS_SUCCESS for success or error code
  */
@@ -663,7 +663,7 @@ QDF_STATUS wmi_extract_twt_cap_service_ready_ext2(
  *
  * @wmi_handle: wmi handle
  * @evt_buf: Pointer event buffer
- * @params: Parameters to extract
+ * @param: Parameters to extract
  *
  * Return: QDF_STATUS_SUCCESS on success and QDF_STATUS_E_FAILURE for failure
  */

wmi/inc/wmi_unified_twt_param.h

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2018-2021 The Linux Foundation. All rights reserved.
- * Copyright (c) 2021-2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2021-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -24,18 +24,20 @@
 #ifndef _WMI_UNIFIED_TWT_PARAM_H_
 #define _WMI_UNIFIED_TWT_PARAM_H_
 
-/* enum WMI_TWT_ROLE - role specified in ext conf in wmi_twt_enable/disable_cmd
- * WMI_TWT_ROLE_REQUESTOR: TWT role is requestor
- * WMI_TWT_ROLE_RESPONDER: TWT role is responder
+/**
+ * enum WMI_TWT_ROLE - role specified in ext conf in wmi_twt_enable/disable_cmd
+ * @WMI_TWT_ROLE_REQUESTOR: TWT role is requestor
+ * @WMI_TWT_ROLE_RESPONDER: TWT role is responder
  */
 enum WMI_TWT_ROLE {
 	WMI_TWT_ROLE_REQUESTOR,
 	WMI_TWT_ROLE_RESPONDER,
 };
 
-/* enum WMI_TWT_OPERATION - specified in ext conf in wmi_twt_enable/disable_cmd
- * WMI_TWT_OPERATION_INDIVIDUAL: Individual TWT operation
- * WMI_TWT_OPERATION_BROADCAST: Broadcast TWT operation
+/**
+ * enum WMI_TWT_OPERATION - specified in ext conf in wmi_twt_enable/disable_cmd
+ * @WMI_TWT_OPERATION_INDIVIDUAL: Individual TWT operation
+ * @WMI_TWT_OPERATION_BROADCAST: Broadcast TWT operation
  */
 enum WMI_TWT_OPERATION {
 	WMI_TWT_OPERATION_INDIVIDUAL,
@@ -43,6 +45,7 @@ enum WMI_TWT_OPERATION {
 };
 
 /**
+ * struct wmi_twt_enable_param - TWT Enable parameters
  * @pdev_id: pdev_id for identifying the MAC.
  * @sta_cong_timer_ms: STA TWT congestion timer TO value in terms of ms
  * @mbss_support: Flag indicating if AP TWT feature supported in
@@ -132,7 +135,7 @@ enum WMI_HOST_ENABLE_TWT_STATUS {
 
 /**
  * struct wmi_twt_enable_complete_event_param:
- * @pdev_is: pdev_id for identifying the MAC.
+ * @pdev_id: pdev_id for identifying the MAC.
  * @status: From enum WMI_HOST_ENABLE_TWT_STATUS
  */
 struct wmi_twt_enable_complete_event_param {
@@ -163,7 +166,7 @@ struct wmi_twt_disable_complete_event {
 };
 
 /**
- * wmi_twt_ack_complete_event_param:
+ * struct wmi_twt_ack_complete_event_param -
  * @vdev_id: vdev id
  * @peer_macaddr: peer mac address
  * @dialog_id: dialog id
@@ -228,7 +231,7 @@ struct wmi_host_twt_session_stats_info {
 };
 
 /**
- * struct wmi_twt_session_stats_event:
+ * struct wmi_twt_session_stats_event_param -
  * @pdev_id: pdev_id for identifying the MAC.
  * @num_sessions: number of TWT sessions
  * @twt_sessions: received TWT sessions
@@ -287,7 +290,7 @@ enum WMI_HOST_TWT_COMMAND {
  * @b_twt_recommendation: defines types of frames tx during bTWT SP
  * @b_twt_persistence: Countdown VAL frames to param update/teardown
  * @wake_time_tsf: Absolute TSF value to start first TWT service period
- * @annouce_timeout_us: Timeout value before sending QoS NULL frame.
+ * @announce_timeout_us: Timeout value before sending QoS NULL frame.
  */
 struct wmi_twt_add_dialog_param {
 	uint32_t vdev_id;
@@ -386,7 +389,7 @@ enum WMI_HOST_ADD_TWT_STATUS {
  *                          0 means responder pm mode field is not valid
  * @pm_responder_bit: 1 means that responder set responder pm mode to 1
  *                    0 means that responder set responder pm mode to 0
- * @wake_dura_us: wake duration in us
+ * @wake_dur_us: wake duration in us
  * @wake_intvl_us: wake time interval in us
  * @sp_offset_us: Time until initial TWT SP occurs
  * @sp_tsf_us_lo: TWT service period tsf in usecs lower bits - 31:0
@@ -410,7 +413,8 @@ struct wmi_twt_add_dialog_additional_params {
 };
 
 /**
- * struct wmi_twt_add_dialog_complete_param -
+ * struct wmi_twt_add_dialog_complete_event_param - parameters from TWT
+ *	Add Dialog Complete event
  * @vdev_id: VDEV identifier
  * @peer_macaddr: Peer mac address
  * @dialog_id: TWT dialog ID
@@ -426,8 +430,8 @@ struct wmi_twt_add_dialog_complete_event_param {
 };
 
 /**
- * struct wmi_twt_cap_bitmap_params -
- * twt_cap_bitmap: TWT capability bitmap
+ * struct wmi_twt_cap_bitmap_params - TWT capabilities bitmap
+ * @twt_ack_support_cap: TWT ACK supported
  *
  */
 struct wmi_twt_cap_bitmap_params {
@@ -799,12 +803,12 @@ struct wmi_twt_btwt_remove_sta_complete_event_param {
 
 /**
  * enum WMI_HOST_TWT_CMD_FOR_ACK_EVENT - Ack event for different TWT command
- * WMI_HOST_TWT_ADD_DIALOG_CMDID: Ack event for add dialog command
- * WMI_HOST_TWT_DEL_DIALOG_CMDID: Ack event for delete dialog command
- * WMI_HOST_TWT_PAUSE_DIALOG_CMDID: Ack event for pause command
- * WMI_HOST_TWT_RESUME_DIALOG_CMDID: Ack event for resume command
- * WMI_HOST_TWT_NUDGE_DIALOG_CMDID: Ack event for nudge command
- * WMI_HOST_TWT_UNKNOWN_CMDID: Ack event for unknown TWT command
+ * @WMI_HOST_TWT_ADD_DIALOG_CMDID: Ack event for add dialog command
+ * @WMI_HOST_TWT_DEL_DIALOG_CMDID: Ack event for delete dialog command
+ * @WMI_HOST_TWT_PAUSE_DIALOG_CMDID: Ack event for pause command
+ * @WMI_HOST_TWT_RESUME_DIALOG_CMDID: Ack event for resume command
+ * @WMI_HOST_TWT_NUDGE_DIALOG_CMDID: Ack event for nudge command
+ * @WMI_HOST_TWT_UNKNOWN_CMDID: Ack event for unknown TWT command
  */
 enum WMI_HOST_TWT_CMD_FOR_ACK_EVENT {
 	WMI_HOST_TWT_ADD_DIALOG_CMDID = 0,

wmi/inc/wmi_unified_vdev_api.h

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2016-2021 The Linux Foundation. All rights reserved.
- * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -29,11 +29,11 @@
 
 /**
  *  wmi_unified_peer_filter_set_tx_cmd_send() - WMI set tx peer filter function
- *  @param wmi_handle: handle to WMI.
- *  @param macaddr: MAC address
- *  @param param: pointer to hold peer filter parameter
+ *  @wmi_handle: handle to WMI.
+ *  @macaddr: MAC address
+ *  @param: pointer to hold peer filter parameter
  *
- *  @return QDF_STATUS_SUCCESS on success and QDF_STATUS_E_FAILURE for failure
+ *  Return: QDF_STATUS_SUCCESS on success and QDF_STATUS_E_FAILURE for failure
  */
 QDF_STATUS
 wmi_unified_peer_filter_set_tx_cmd_send(struct wmi_unified *wmi_handle,
@@ -42,11 +42,11 @@ wmi_unified_peer_filter_set_tx_cmd_send(struct wmi_unified *wmi_handle,
 
 /**
  *  wmi_unified_vdev_set_neighbour_rx_cmd_send() - WMI set neighbour rx function
- *  @param wmi_handle: handle to WMI.
- *  @param macaddr: MAC address
- *  @param param: pointer to hold neighbour rx parameter
+ *  @wmi_handle: handle to WMI.
+ *  @macaddr: MAC address
+ *  @param: pointer to hold neighbour rx parameter
  *
- *  @return QDF_STATUS_SUCCESS on success and QDF_STATUS_E_FAILURE for failure
+ *  Return: QDF_STATUS_SUCCESS on success and QDF_STATUS_E_FAILURE for failure
  */
 QDF_STATUS wmi_unified_vdev_set_neighbour_rx_cmd_send(
 				struct wmi_unified *wmi_handle,
@@ -55,10 +55,10 @@ QDF_STATUS wmi_unified_vdev_set_neighbour_rx_cmd_send(
 
 /**
  *  wmi_unified_vdev_config_ratemask_cmd_send() - WMI config ratemask function
- *  @param wmi_handle: handle to WMI.
- *  @param param: pointer to hold config ratemask param
+ *  @wmi_handle: handle to WMI.
+ *  @param: pointer to hold config ratemask param
  *
- *  @return QDF_STATUS_SUCCESS on success and QDF_STATUS_E_FAILURE for failure
+ *  Return: QDF_STATUS_SUCCESS on success and QDF_STATUS_E_FAILURE for failure
  */
 QDF_STATUS
 wmi_unified_vdev_config_ratemask_cmd_send(struct wmi_unified *wmi_handle,
@@ -93,9 +93,8 @@ QDF_STATUS wmi_unified_send_multiple_vdev_set_param_cmd(
 
 /**
  *  wmi_unified_beacon_send_cmd() - WMI beacon send function
- *  @param wmi_handle: handle to WMI.
- *  @param macaddr: MAC address
- *  @param param: pointer to hold beacon send cmd parameter
+ *  @wmi_handle: handle to WMI.
+ *  @param: pointer to hold beacon send cmd parameter
  *
  *  Return: QDF_STATUS_SUCCESS on success and QDF_STATUS_E_FAILURE for failure
  */
@@ -105,8 +104,8 @@ QDF_STATUS wmi_unified_beacon_send_cmd(struct wmi_unified *wmi_handle,
 /**
  * wmi_extract_vdev_start_resp() - extract vdev start response
  * @wmi_handle: wmi handle
- * @param evt_buf: pointer to event buffer
- * @param vdev_rsp: Pointer to hold vdev response
+ * @evt_buf: pointer to event buffer
+ * @vdev_rsp: Pointer to hold vdev response
  *
  * Return: QDF_STATUS_SUCCESS on success and QDF_STATUS_E_FAILURE for failure
  */
@@ -117,8 +116,8 @@ wmi_extract_vdev_start_resp(struct wmi_unified *wmi_handle, void *evt_buf,
 /**
  * wmi_extract_vdev_stopped_param() - extract vdev stop param from event
  * @wmi_handle: wmi handle
- * @param evt_buf: pointer to event buffer
- * @param vdev_id: Pointer to hold vdev identifier
+ * @evt_buf: pointer to event buffer
+ * @vdev_id: Pointer to hold vdev identifier
  *
  * Return: QDF_STATUS_SUCCESS on success and QDF_STATUS_E_FAILURE for failure
  */
@@ -129,8 +128,8 @@ wmi_extract_vdev_stopped_param(struct wmi_unified *wmi_handle, void *evt_buf,
 /**
  * wmi_extract_vdev_delete_resp() - extract vdev delete response
  * @wmi_handle: wmi handle
- * @param evt_buf: pointer to event buffer
- * @param delete_rsp: Pointer to hold vdev delete response
+ * @evt_buf: pointer to event buffer
+ * @vdev_del_resp: Pointer to hold vdev delete response
  *
  * Return: QDF_STATUS_SUCCESS on success and QDF_STATUS_E_FAILURE for failure
  */
@@ -142,8 +141,8 @@ wmi_extract_vdev_delete_resp(struct wmi_unified *wmi_handle, void *evt_buf,
  * wmi_extract_vdev_peer_delete_all_response_event() - extract peer delete all
  * response
  * @wmi_handle: wmi handle
- * @param evt_buf: pointer to event buffer
- * @param delete_rsp: Pointer to hold peer delete all response
+ * @evt_buf: pointer to event buffer
+ * @delete_rsp: Pointer to hold peer delete all response
  *
  * Return: QDF_STATUS_SUCCESS on success and QDF_STATUS_E_FAILURE for failure
  */
@@ -155,8 +154,8 @@ QDF_STATUS wmi_extract_vdev_peer_delete_all_response_event(
 /**
  * wmi_extract_ext_tbttoffset_num_vdevs() - extract ext tbtt offset num vdev
  * @wmi_handle: wmi handle
- * @param evt_buf: pointer to event buffer
- * @param vdev_map: Pointer to hold num vdev
+ * @evt_buf: pointer to event buffer
+ * @num_vdevs: Pointer to hold num vdev
  *
  * Return: QDF_STATUS_SUCCESS on success and QDF_STATUS_E_FAILURE for failure
  */
@@ -167,8 +166,8 @@ wmi_extract_ext_tbttoffset_num_vdevs(struct wmi_unified *wmi_handle,
 /**
  * wmi_extract_tbttoffset_num_vdevs() - extract tbtt offset num vdev
  * @wmi_handle: wmi handle
- * @param evt_buf: pointer to event buffer
- * @param vdev_map: Pointer to hold num vdev
+ * @evt_buf: pointer to event buffer
+ * @num_vdevs: Pointer to hold num vdev
  *
  * Return: QDF_STATUS_SUCCESS on success and QDF_STATUS_E_FAILURE for failure
  */
@@ -204,7 +203,7 @@ wmi_unified_multisoc_tbtt_sync_cmd(wmi_unified_t wmi_handle,
 #ifdef WLAN_FEATURE_SR
 /**
  * wmi_unified_vdev_param_sr_prohibit_send() - send vdev SR prohibit command
- * @wmi: wmi handle
+ * @wmi_hdl: wmi handle
  * @srp_param: SR Prohibit parameters
  *
  * Return: QDF_STATUS_SUCCESS for success or error code

wmi/inc/wmi_unified_wds_api.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2021 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -29,7 +30,7 @@
 
 /**
  *  wmi_unified_peer_add_wds_entry_cmd() - WMI add wds entry cmd function
- *  @wmi_hdl: handle to WMI
+ *  @wmi_handle: handle to WMI
  *  @param: pointer to hold wds entry param
  *
  *  Return: QDF_STATUS_SUCCESS on success and QDF_STATUS_E_FAILURE for failure
@@ -40,7 +41,7 @@ wmi_unified_peer_add_wds_entry_cmd(wmi_unified_t wmi_handle,
 
 /**
  *  wmi_unified_peer_del_wds_entry_cmd() - WMI del wds entry cmd function
- *  @wmi_hdl: handle to WMI
+ *  @wmi_handle: handle to WMI
  *  @param: pointer to hold wds entry param
  *
  *  Return: QDF_STATUS_SUCCESS on success and QDF_STATUS_E_FAILURE for failure
@@ -52,7 +53,7 @@ wmi_unified_peer_del_wds_entry_cmd(wmi_unified_t wmi_handle,
 /**
  *  wmi_unified_update_wds_entry_cmd() - WMI update wds entry
  *  cmd function
- *  @wmi_hdl: handle to WMI
+ *  @wmi_handle: handle to WMI
  *  @param: pointer to hold wds entry param
  *
  *  Return: QDF_STATUS_SUCCESS on success and QDF_STATUS_E_FAILURE for failure

wmi/src/wmi_tlv_helper.c

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2013-2019 The Linux Foundation. All rights reserved.
- * Copyright (c) 2021-2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2021-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -179,6 +179,7 @@ uint32_t wmitlv_get_attributes(uint32_t is_cmd_id, uint32_t cmd_event_id,
  * wmitlv_check_tlv_params() - tlv helper function
  * @os_handle: os context handle
  * @param_struc_ptr: pointer to tlv structure
+ * @param_buf_len: length of input buffer
  * @is_cmd_id: boolean for command attribute
  * @wmi_cmd_event_id: command event id
  *
@@ -424,7 +425,7 @@ Error_wmitlv_check_tlv_params:
  * wmitlv_check_event_tlv_params() - tlv helper function
  * @os_handle: os context handle
  * @param_struc_ptr: pointer to tlv structure
- * @is_cmd_id: boolean for command attribute
+ * @param_buf_len: length of input buffer
  * @wmi_cmd_event_id: command event id
  *
  *
@@ -448,7 +449,7 @@ wmitlv_check_event_tlv_params(void *os_handle, void *param_struc_ptr,
  * wmitlv_check_command_tlv_params() - tlv helper function
  * @os_handle: os context handle
  * @param_struc_ptr: pointer to tlv structure
- * @is_cmd_id: boolean for command attribute
+ * @param_buf_len: length of input buffer
  * @wmi_cmd_event_id: command event id
  *
  *
@@ -1159,6 +1160,7 @@ wmi_versions_are_compatible(wmi_abi_version *vers1, wmi_abi_version *vers2)
 
 /**
  * wmi_versions_can_downgrade() - tlv helper function
+ * @num_allowlist: number of entries in @version_whitelist_table
  * @version_whitelist_table: version table
  * @my_vers: host version
  * @opp_vers: target version
@@ -1274,6 +1276,7 @@ wmi_versions_can_downgrade(int num_allowlist,
 
 /**
  * wmi_cmp_and_set_abi_version() - tlv helper function
+ * @num_allowlist: number of entries in @version_whitelist_table
  * @version_whitelist_table: version table
  * @my_vers: host version
  * @opp_vers: target version

wmi/src/wmi_unified.c

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2015-2021 The Linux Foundation. All rights reserved.
- * Copyright (c) 2021-2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2021-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -876,7 +876,7 @@ wmi_print_mgmt_event_log(wmi_unified_t wmi, uint32_t count,
 
 /* debugfs routines*/
 
-/**
+/*
  * debug_wmi_##func_base##_show() - debugfs functions to display content of
  * command and event buffers. Macro uses max buffer length to display
  * buffer when it is wraparound.
@@ -1058,7 +1058,7 @@ static int debug_wmi_log_size_show(struct seq_file *m, void *v)
 				 wmi_diag_log_max_entry);
 }
 
-/**
+/*
  * debug_wmi_##func_base##_write() - debugfs functions to clear
  * wmi logging command/event buffer and management command/event buffer.
  *
@@ -1176,7 +1176,7 @@ struct wmi_debugfs_info {
 #define DEBUG_FOO(func_base) { .name = #func_base,			\
 	.ops = &debug_##func_base##_ops }
 
-/**
+/*
  * debug_##func_base##_open() - Open debugfs entry for respective command
  * and event buffer.
  *
@@ -1241,7 +1241,6 @@ struct wmi_debugfs_info wmi_debugfs_infos[NUM_DEBUG_INFOS] = {
  *
  * @wmi_handle: wmi handle
  * @par_entry: debug directory entry
- * @id: Index to debug info data array
  *
  * Return: none
  */
@@ -1278,8 +1277,6 @@ out:
 /**
  * wmi_debugfs_remove() - Remove debugfs entry for wmi logging.
  * @wmi_handle: wmi handle
- * @dentry: debugfs directory entry
- * @id: Index to debug info data array
  *
  * Return: none
  */
@@ -1301,9 +1298,9 @@ static void wmi_debugfs_remove(wmi_unified_t wmi_handle)
 
 /**
  * wmi_debugfs_init() - debugfs functions to create debugfs directory and to
- * create debugfs enteries.
- *
- * @h: wmi handler
+ *                      create debugfs entries.
+ * @wmi_handle: wmi handler
+ * @pdev_idx: pdev id
  *
  * Return: init status
  */
@@ -1327,17 +1324,6 @@ static QDF_STATUS wmi_debugfs_init(wmi_unified_t wmi_handle, uint32_t pdev_idx)
 	return QDF_STATUS_SUCCESS;
 }
 
-/**
- * wmi_mgmt_cmd_record() - Wrapper function for mgmt command logging macro
- *
- * @wmi_handle: wmi handle
- * @cmd: mgmt command
- * @header: pointer to 802.11 header
- * @vdev_id: vdev id
- * @chanfreq: channel frequency
- *
- * Return: none
- */
 void wmi_mgmt_cmd_record(wmi_unified_t wmi_handle, uint32_t cmd,
 			void *header, uint32_t vdev_id, uint32_t chanfreq)
 {
@@ -1356,14 +1342,6 @@ void wmi_mgmt_cmd_record(wmi_unified_t wmi_handle, uint32_t cmd,
 	qdf_spin_unlock_bh(&wmi_handle->log_info.wmi_record_lock);
 }
 #else
-/**
- * wmi_debugfs_remove() - Remove debugfs entry for wmi logging.
- * @wmi_handle: wmi handle
- * @dentry: debugfs directory entry
- * @id: Index to debug info data array
- *
- * Return: none
- */
 static void wmi_debugfs_remove(wmi_unified_t wmi_handle) { }
 void wmi_mgmt_cmd_record(wmi_unified_t wmi_handle, uint32_t cmd,
 			void *header, uint32_t vdev_id, uint32_t chanfreq) { }
@@ -1378,6 +1356,7 @@ qdf_export_symbol(wmi_mgmt_cmd_record);
 /**
  * wmi_ext_dbg_msg_enqueue() - enqueue wmi message
  * @wmi_handle: wmi handler
+ * @msg: WMI message
  *
  * Return: size of wmi message queue after enqueue
  */
@@ -1571,7 +1550,7 @@ static QDF_STATUS wmi_ext_dbg_msg_write(void *priv, const char *buf,
 static struct qdf_debugfs_fops wmi_ext_dbgfs_ops[WMI_MAX_RADIOS];
 
 /**
- * wmi_ext_debugfs_init() - init debugfs items for extended wmi dump.
+ * wmi_ext_dbgfs_init() - init debugfs items for extended wmi dump.
  * @wmi_handle: wmi handler
  * @pdev_idx: pdev index
  *
@@ -1619,7 +1598,7 @@ static QDF_STATUS wmi_ext_dbgfs_init(struct wmi_unified *wmi_handle,
 }
 
 /**
- * wmi_ext_debugfs_deinit() - cleanup/deinit debugfs items of extended wmi dump.
+ * wmi_ext_dbgfs_deinit() - cleanup/deinit debugfs items of extended wmi dump.
  * @wmi_handle: wmi handler
  *
  * Return: QDF_STATUS_SUCCESS if cleanup is successful
@@ -1760,14 +1739,6 @@ void wmi_buf_free(wmi_buf_t net_buf)
 qdf_export_symbol(wmi_buf_free);
 #endif
 
-/**
- * wmi_get_max_msg_len() - get maximum WMI message length
- * @wmi_handle: WMI handle.
- *
- * This function returns the maximum WMI message length
- *
- * Return: maximum WMI message length
- */
 uint16_t wmi_get_max_msg_len(wmi_unified_t wmi_handle)
 {
 	return wmi_handle->max_msg_len - WMI_MIN_HEAD_ROOM;
@@ -2440,9 +2411,8 @@ static QDF_STATUS wmi_process_fw_event_handler(struct scheduler_msg *msg)
 /**
  * wmi_process_fw_event_sched_thread_ctx() - common event handler to serialize
  *                                  event processing through scheduler thread
- * @ctx: wmi context
+ * @wmi: wmi context
  * @ev: event buffer
- * @rx_ctx: rx execution context
  *
  * Return: 0 on success, errno on failure
  */
@@ -2754,27 +2724,11 @@ int wmi_process_qmi_fw_event(void *wmi_cb_ctx, void *buf, int len)
 }
 #endif
 
-/**
- * wmi_process_fw_event() - process any fw event
- * @wmi_handle: wmi handle
- * @evt_buf: fw event buffer
- *
- * This function process fw event in caller context
- *
- * Return: none
- */
 void wmi_process_fw_event(struct wmi_unified *wmi_handle, wmi_buf_t evt_buf)
 {
 	__wmi_control_rx(wmi_handle, evt_buf);
 }
 
-/**
- * __wmi_control_rx() - process serialize wmi event callback
- * @wmi_handle: wmi handle
- * @evt_buf: fw event buffer
- *
- * Return: none
- */
 void __wmi_control_rx(struct wmi_unified *wmi_handle, wmi_buf_t evt_buf)
 {
 	uint32_t id;
@@ -3002,21 +2956,12 @@ static void wmi_runtime_pm_init(struct wmi_unified *wmi_handle)
 	qdf_atomic_init(&wmi_handle->runtime_pm_inprogress);
 }
 
-/**
- * wmi_set_runtime_pm_inprogress() - set runtime pm progress flag
- * @wmi_handle: wmi context
- * @val: runtime pm progress flag
- */
 void wmi_set_runtime_pm_inprogress(wmi_unified_t wmi_handle, A_BOOL val)
 {
 	qdf_atomic_set(&wmi_handle->runtime_pm_inprogress, val);
 }
 
-/**
- * wmi_get_runtime_pm_inprogress() - get runtime pm progress flag
- * @wmi_handle: wmi context
- */
-inline bool wmi_get_runtime_pm_inprogress(wmi_unified_t wmi_handle)
+bool wmi_get_runtime_pm_inprogress(wmi_unified_t wmi_handle)
 {
 	return qdf_atomic_read(&wmi_handle->runtime_pm_inprogress);
 }
@@ -3026,12 +2971,6 @@ static void wmi_runtime_pm_init(struct wmi_unified *wmi_handle)
 }
 #endif
 
-/**
- * wmi_unified_get_soc_handle: Get WMI SoC handle
- * @param wmi_handle: WMI context got from wmi_attach
- *
- * return: Pointer to Soc handle
- */
 void *wmi_unified_get_soc_handle(struct wmi_unified *wmi_handle)
 {
 	return wmi_handle->soc;
@@ -3039,9 +2978,10 @@ void *wmi_unified_get_soc_handle(struct wmi_unified *wmi_handle)
 
 /**
  * wmi_interface_logging_init: Interface looging init
- * @param wmi_handle: Pointer to wmi handle object
+ * @wmi_handle: Pointer to wmi handle object
+ * @pdev_idx: pdev index
  *
- * return: None
+ * Return: None
  */
 #ifdef WMI_INTERFACE_EVENT_LOGGING
 static inline void wmi_interface_logging_init(struct wmi_unified *wmi_handle,
@@ -3088,13 +3028,6 @@ static QDF_STATUS wmi_initialize_worker_context(struct wmi_unified *wmi_handle)
 	return QDF_STATUS_SUCCESS;
 }
 
-/**
- * wmi_unified_get_pdev_handle: Get WMI SoC handle
- * @param wmi_soc: Pointer to wmi soc object
- * @param pdev_idx: pdev index
- *
- * return: Pointer to wmi handle or NULL on failure
- */
 void *wmi_unified_get_pdev_handle(struct wmi_soc *soc, uint32_t pdev_idx)
 {
 	struct wmi_unified *wmi_handle;
@@ -3173,7 +3106,7 @@ qdf_export_symbol(wmi_unified_register_module);
  * wmi_wbuff_register() - register wmi with wbuff
  * @wmi_handle: handle to wmi
  *
- * @Return: void
+ * Return: void
  */
 static void wmi_wbuff_register(struct wmi_unified *wmi_handle)
 {
@@ -3196,7 +3129,7 @@ static void wmi_wbuff_register(struct wmi_unified *wmi_handle)
  * wmi_wbuff_deregister() - deregister wmi with wbuff
  * @wmi_handle: handle to wmi
  *
- * @Return: void
+ * Return: void
  */
 static inline void wmi_wbuff_deregister(struct wmi_unified *wmi_handle)
 {
@@ -3204,17 +3137,6 @@ static inline void wmi_wbuff_deregister(struct wmi_unified *wmi_handle)
 	wmi_handle->wbuff_handle = NULL;
 }
 
-/**
- * wmi_unified_attach() -  attach for unified WMI
- * @scn_handle: handle to SCN
- * @osdev: OS device context
- * @target_type: TLV or not-TLV based target
- * @use_cookie: cookie based allocation enabled/disabled
- * @ops: umac rx callbacks
- * @psoc: objmgr psoc
- *
- * @Return: wmi handle.
- */
 void *wmi_unified_attach(void *scn_handle,
 			 struct wmi_unified_attach_params *param)
 {
@@ -3302,13 +3224,6 @@ error:
 	return NULL;
 }
 
-/**
- * wmi_unified_detach() -  detach for unified WMI
- *
- * @wmi_handle  : handle to wmi.
- *
- * @Return: none.
- */
 void wmi_unified_detach(struct wmi_unified *wmi_handle)
 {
 	wmi_buf_t buf;
@@ -3385,17 +3300,6 @@ void wmi_unified_detach(struct wmi_unified *wmi_handle)
 	qdf_mem_free(soc);
 }
 
-/**
- * wmi_unified_remove_work() - detach for WMI work
- * @wmi_handle: handle to WMI
- *
- * A function that does not fully detach WMI, but just remove work
- * queue items associated with it. This is used to make sure that
- * before any other processing code that may destroy related contexts
- * (HTC, etc), work queue processing on WMI has already been stopped.
- *
- * Return: None
- */
 void
 wmi_unified_remove_work(struct wmi_unified *wmi_handle)
 {
@@ -3425,9 +3329,9 @@ wmi_unified_remove_work(struct wmi_unified *wmi_handle)
  * wmi_htc_tx_complete() - Process htc tx completion
  *
  * @ctx: handle to wmi
- * @htc_packet: pointer to htc packet
+ * @htc_pkt: pointer to htc packet
  *
- * @Return: none.
+ * Return: none.
  */
 static void wmi_htc_tx_complete(void *ctx, HTC_PACKET *htc_pkt)
 {
@@ -3496,7 +3400,7 @@ static void wmi_htc_tx_complete(void *ctx, HTC_PACKET *htc_pkt)
  * @ctx: handle of WMI context
  * @htc_pkt: handle of HTC packet
  *
- * @Return: none
+ * Return: none
  */
 static void wmi_htc_log_pkt(void *ctx, HTC_PACKET *htc_pkt)
 {
@@ -3518,11 +3422,10 @@ static void wmi_htc_log_pkt(void *ctx, HTC_PACKET *htc_pkt)
 
 /**
  * wmi_connect_pdev_htc_service() -  WMI API to get connect to HTC service
- *
- * @wmi_handle: handle to WMI.
+ * @soc: handle to WMI SoC
  * @pdev_idx: Pdev index
  *
- * @Return: QDF_STATUS
+ * Return: QDF_STATUS
  */
 static QDF_STATUS wmi_connect_pdev_htc_service(struct wmi_soc *soc,
 					       uint32_t pdev_idx)
@@ -3667,13 +3570,6 @@ QDF_STATUS wmi_dbr_connect_pdev_htc_service(struct wmi_unified *wmi_handle,
 }
 #endif
 
-/**
- * wmi_get_host_credits() -  WMI API to get updated host_credits
- *
- * @wmi_handle: handle to WMI.
- *
- * @Return: updated host_credits.
- */
 int wmi_get_host_credits(wmi_unified_t wmi_handle)
 {
 	int host_credits = 0;
@@ -3683,69 +3579,28 @@ int wmi_get_host_credits(wmi_unified_t wmi_handle)
 	return host_credits;
 }
 
-/**
- * wmi_get_pending_cmds() - WMI API to get WMI Pending Commands in the HTC
- *                          queue
- *
- * @wmi_handle: handle to WMI.
- *
- * @Return: Pending Commands in the HTC queue.
- */
 int wmi_get_pending_cmds(wmi_unified_t wmi_handle)
 {
 	return qdf_atomic_read(&wmi_handle->pending_cmds);
 }
 
-/**
- * wmi_set_target_suspend() -  WMI API to set target suspend state
- *
- * @wmi_handle: handle to WMI.
- * @val: suspend state boolean.
- *
- * @Return: none.
- */
 void wmi_set_target_suspend(wmi_unified_t wmi_handle, A_BOOL val)
 {
 	qdf_atomic_set(&wmi_handle->is_target_suspended, val);
 }
 
-/**
- * wmi_set_target_suspend_acked() -  WMI API to set target suspend acked flag
- *
- * @wmi_handle: handle to WMI.
- * @val: target suspend command acked flag.
- *
- * @Return: none.
- */
 void wmi_set_target_suspend_acked(wmi_unified_t wmi_handle, A_BOOL val)
 {
 	qdf_atomic_set(&wmi_handle->is_target_suspend_acked, val);
 	qdf_atomic_set(&wmi_handle->num_stats_over_qmi, 0);
 }
 
-/**
- * wmi_is_target_suspended() - WMI API to check target suspend state
- * @wmi_handle: handle to WMI.
- *
- * WMI API to check target suspend state
- *
- * Return: true if target is suspended, else false.
- */
 bool wmi_is_target_suspended(struct wmi_unified *wmi_handle)
 {
 	return qdf_atomic_read(&wmi_handle->is_target_suspended);
 }
 qdf_export_symbol(wmi_is_target_suspended);
 
-/**
- * wmi_is_target_suspend_acked() - WMI API to check target suspend command is
- *                                 acked or not
- * @wmi_handle: handle to WMI.
- *
- * WMI API to check whether the target suspend command is acked or not
- *
- * Return: true if target suspend command is acked, else false.
- */
 bool wmi_is_target_suspend_acked(struct wmi_unified *wmi_handle)
 {
 	return qdf_atomic_read(&wmi_handle->is_target_suspend_acked);
@@ -3764,21 +3619,11 @@ bool wmi_is_qmi_stats_enabled(struct wmi_unified *wmi_handle)
 }
 #endif
 
-/**
- * WMI API to set crash injection state
- * @param wmi_handle:	handle to WMI.
- * @param val:		crash injection state boolean.
- */
 void wmi_tag_crash_inject(wmi_unified_t wmi_handle, A_BOOL flag)
 {
 	wmi_handle->tag_crash_inject = flag;
 }
 
-/**
- * WMI API to set bus suspend state
- * @param wmi_handle:	handle to WMI.
- * @param val:		suspend state boolean.
- */
 void wmi_set_is_wow_bus_suspended(wmi_unified_t wmi_handle, A_BOOL val)
 {
 	qdf_atomic_set(&wmi_handle->is_wow_bus_suspended, val);
@@ -3789,12 +3634,6 @@ void wmi_set_tgt_assert(wmi_unified_t wmi_handle, bool val)
 	wmi_handle->tgt_force_assert_enable = val;
 }
 
-/**
- * wmi_stop() - generic function to block unified WMI command
- * @wmi_handle: handle to WMI.
- *
- * @Return: success always.
- */
 int
 wmi_stop(wmi_unified_t wmi_handle)
 {
@@ -3804,12 +3643,6 @@ wmi_stop(wmi_unified_t wmi_handle)
 	return 0;
 }
 
-/**
- * wmi_start() - generic function to allow unified WMI command
- * @wmi_handle: handle to WMI.
- *
- * @Return: success always.
- */
 int
 wmi_start(wmi_unified_t wmi_handle)
 {
@@ -3819,23 +3652,12 @@ wmi_start(wmi_unified_t wmi_handle)
 	return 0;
 }
 
-/**
- * wmi_is_blocked() - generic function to check if WMI is blocked
- * @wmi_handle: handle to WMI.
- *
- * @Return: true, if blocked, false if not blocked
- */
 bool
 wmi_is_blocked(wmi_unified_t wmi_handle)
 {
 	return (!(!wmi_handle->wmi_stopinprogress));
 }
 
-/**
- * API to flush all the previous packets  associated with the wmi endpoint
- *
- * @param wmi_handle      : handle to WMI.
- */
 void
 wmi_flush_endpoint(wmi_unified_t wmi_handle)
 {
@@ -3844,15 +3666,6 @@ wmi_flush_endpoint(wmi_unified_t wmi_handle)
 }
 qdf_export_symbol(wmi_flush_endpoint);
 
-/**
- * wmi_pdev_id_conversion_enable() - API to enable pdev_id/phy_id conversion
- *                     in WMI. By default pdev_id conversion is not done in WMI.
- *                     This API can be used enable conversion in WMI.
- * @param wmi_handle   : handle to WMI
- * @param pdev_map     : pointer to pdev_map
- * @size               : size of pdev_id_map
- * Return none
- */
 void wmi_pdev_id_conversion_enable(wmi_unified_t wmi_handle,
 				   uint32_t *pdev_id_map,
 				   uint8_t size)

wmi/src/wmi_unified_api.c

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2016-2021 The Linux Foundation. All rights reserved.
- * Copyright (c) 2021-2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2021-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -927,13 +927,6 @@ QDF_STATUS wmi_unified_snr_cmd(wmi_unified_t wmi_handle, uint8_t vdev_id)
 	return QDF_STATUS_E_FAILURE;
 }
 
-/**
- * wmi_unified_link_status_req_cmd() - process link status request from UMAC
- * @wmi_handle: wmi handle
- * @params: get link status params
- *
- * Return: QDF_STATUS_SUCCESS on success and QDF_STATUS_E_FAILURE for failure
- */
 QDF_STATUS wmi_unified_link_status_req_cmd(wmi_unified_t wmi_handle,
 					   struct link_status_params *params)
 {
@@ -1583,13 +1576,6 @@ QDF_STATUS wmi_unified_remove_beacon_filter_cmd_send(
 	return QDF_STATUS_E_FAILURE;
 }
 
-/**
- * wmi_unified_get_pn_send_cmd() - send command to get PN for peer
- * @wmi_hdl: wmi handle
- * @wmi_peer_tx_pn_request_cmd_fixed_param: pn request params
- *
- * Return: QDF_STATUS_SUCCESS on success and QDF_STATUS_E_FAILURE for failure
- */
 QDF_STATUS wmi_unified_get_pn_send_cmd(wmi_unified_t wmi_hdl,
 				       struct peer_request_pn_param *pn_params)
 {
@@ -1612,29 +1598,6 @@ QDF_STATUS wmi_unified_get_rxpn_send_cmd(
 }
 qdf_export_symbol(wmi_unified_get_rxpn_send_cmd);
 
-/**
- *  wmi_unified_mgmt_cmd_send() - WMI mgmt cmd function
- *  @param wmi_handle      : handle to WMI.
- *  @param macaddr        : MAC address
- *  @param param    : pointer to hold mgmt parameter
- *
- *  @return QDF_STATUS_SUCCESS on success and QDF_STATUS_E_FAILURE for failure
- */
-#if 0
-QDF_STATUS wmi_unified_mgmt_cmd_send(void *wmi_hdl,
-				uint8_t macaddr[QDF_MAC_ADDR_SIZE],
-				struct mgmt_params *param)
-{
-	wmi_unified_t wmi_handle = (wmi_unified_t) wmi_hdl;
-
-	if (wmi_handle->ops->send_mgmt_cmd)
-		return wmi_handle->ops->send_mgmt_cmd(wmi_handle,
-				  macaddr, param);
-
-	return QDF_STATUS_E_FAILURE;
-}
-#endif
-
 QDF_STATUS wmi_unified_addba_clearresponse_cmd_send(
 			wmi_unified_t wmi_handle,
 			uint8_t macaddr[QDF_MAC_ADDR_SIZE],
@@ -2074,14 +2037,6 @@ wmi_extract_fips_extend_event_data(wmi_unified_t wmi_handle, void *evt_buf,
 }
 #endif
 
-/**
- * wmi_unified_extract_pn() - extract pn event data
- * @wmi_handle: wmi handle
- * @param evt_buf: pointer to event buffer
- * @param param: pointer to get pn event param
- *
- * Return: QDF_STATUS_SUCCESS on success and QDF_STATUS_E_FAILURE for failure
- */
 QDF_STATUS wmi_unified_extract_pn(wmi_unified_t wmi_hdl, void *evt_buf,
 				  struct wmi_host_get_pn_event *param)
 {
@@ -3823,14 +3778,6 @@ wmi_unified_extract_halphy_stats_event_count(wmi_unified_t wmi_handle,
 	return QDF_STATUS_E_FAILURE;
 }
 
-/**
- * wmi_unified_send_vdev_tsf_tstamp_action_cmd() - send vdev tsf action command
- * @wmi: wmi handle
- * @vdev_id: vdev id
- *
- * TSF_TSTAMP_READ_VALUE is the only operation supported
- * Return: QDF_STATUS_SUCCESS for success or error code
- */
 QDF_STATUS wmi_unified_send_vdev_tsf_tstamp_action_cmd(wmi_unified_t wmi_hdl,
 						       uint8_t vdev_id)
 {
@@ -3843,14 +3790,6 @@ QDF_STATUS wmi_unified_send_vdev_tsf_tstamp_action_cmd(wmi_unified_t wmi_hdl,
 	return QDF_STATUS_E_FAILURE;
 }
 
-/**
- * wmi_extract_vdev_tsf_report_event() - extract vdev tsf report from event
- * @wmi_handle: wmi handle
- * @param evt_buf: pointer to event buffer
- * @wmi_host_tsf_event param: Pointer to hold event info
- *
- * Return: QDF_STATUS_SUCCESS on success and QDF_STATUS_E_FAILURE for failure
- */
 QDF_STATUS wmi_extract_vdev_tsf_report_event(wmi_unified_t wmi_hdl,
 					     uint8_t *evt_buf,
 					     struct wmi_host_tsf_event *param)
@@ -4011,13 +3950,6 @@ wmi_unified_peer_ppe_ds_param_send(wmi_unified_t wmi_handle,
 }
 #endif /* WLAN_SUPPORT_PPEDS */
 
-/**
- * wmi_unified_pn_mgmt_rxfilter_send_cmd() - Send PN mgmt RxFilter command to FW
- * @wmi_handle: WMI handle
- * @params: RxFilter params
- *
- * Return: QDF_STATUS_SUCCESS for success or error code
- */
 QDF_STATUS wmi_unified_pn_mgmt_rxfilter_send_cmd(
 		struct wmi_unified *wmi_handle,
 		struct vdev_pn_mgmt_rxfilter_params *params)
@@ -4043,14 +3975,6 @@ wmi_extract_pktlog_decode_info_event(wmi_unified_t wmi_handle,
 	return QDF_STATUS_E_FAILURE;
 }
 
-/**
- * wmi_extract_pdev_telemetry_stats_tlv - extract pdev telemetry stats
- * @wmi_handle: wmi handle
- * @evt_buf: pointer to event buffer
- * @pdev stats: Pointer to hold pdev telemetry stats
- *
- * Return: QDF_STATUS_SUCCESS for success or error code
- */
 QDF_STATUS wmi_extract_pdev_telemetry_stats(
 		wmi_unified_t wmi_handle, void *evt_buf,
 		struct wmi_host_pdev_telemetry_stats *pdev_stats)

wmi/src/wmi_unified_cfr_api.c

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2019-2021, The Linux Foundation. All rights reserved.
+ * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
@@ -29,9 +30,6 @@ QDF_STATUS wmi_unified_send_peer_cfr_capture_cmd(wmi_unified_t wmi_handle,
 	return QDF_STATUS_E_FAILURE;
 }
 
-/**
- * wmi_extract_cfr_peer_tx_event_param() - extract tx event params from event
- */
 QDF_STATUS
 wmi_extract_cfr_peer_tx_event_param(wmi_unified_t wmi_handle, void *evt_buf,
 				    wmi_cfr_peer_tx_event_param *peer_tx_event)

wmi/src/wmi_unified_concurrency_tlv.c

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2013-2020 The Linux Foundation. All rights reserved.
- * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -30,6 +30,7 @@
  *							     mcc scheduler
  * @wmi_handle: wmi handle
  * @mcc_adaptive_scheduler: enable/disable
+ * @pdev_id: pdev identifier
  *
  * This function enable/disable mcc adaptive scheduler in fw.
  *
@@ -75,15 +76,15 @@ static QDF_STATUS send_set_enable_disable_mcc_adaptive_scheduler_cmd_tlv(
 
 /**
  * send_set_mcc_channel_time_latency_cmd_tlv() -set MCC channel time latency
- * @wmi: wmi handle
- * @mcc_channel: mcc channel
+ * @wmi_handle: wmi handle
+ * @mcc_channel_freq: mcc channel frequency in MHz
  * @mcc_channel_time_latency: MCC channel time latency.
  *
  * Currently used to set time latency for an MCC vdev/adapter using operating
  * channel of it and channel number. The info is provided run time using
  * iwpriv command: iwpriv <wlan0 | p2p0> setMccLatency <latency in ms>.
  *
- * Return: CDF status
+ * Return: QDF status
  */
 static QDF_STATUS send_set_mcc_channel_time_latency_cmd_tlv(
 					wmi_unified_t wmi_handle,
@@ -150,12 +151,12 @@ static QDF_STATUS send_set_mcc_channel_time_latency_cmd_tlv(
 
 /**
  * send_set_mcc_channel_time_quota_cmd_tlv() -set MCC channel time quota
- * @wmi: wmi handle
- * @adapter_1_chan_number: adapter 1 channel number
+ * @wmi_handle: wmi handle
+ * @adapter_1_chan_freq: adapter 1 channel frequency in MHz
  * @adapter_1_quota: adapter 1 quota
- * @adapter_2_chan_number: adapter 2 channel number
+ * @adapter_2_chan_freq: adapter 2 channel frequency in MHz
  *
- * Return: CDF status
+ * Return: QDF status
  */
 static QDF_STATUS send_set_mcc_channel_time_quota_cmd_tlv(
 					wmi_unified_t wmi_handle,
@@ -259,8 +260,8 @@ static enum mcc_quota_type convert_to_host_quota_type(uint32_t quota_type)
  * extract_mcc_quota_ev_param_tlv() - extract mcc quota information from wmi
  *    event
  * @wmi_handle: wmi handle
- * @param evt_buf: pointer to event buffer
- * @param param: Pointer to hold mcc quota info
+ * @evt_buf: pointer to event buffer
+ * @param: Pointer to hold mcc quota info
  *
  * Return: QDF_STATUS_SUCCESS for success or error code
  */

wmi/src/wmi_unified_cp_stats_tlv.c

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2016-2021, The Linux Foundation. All rights reserved.
- * Copyright (c) 2021-2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2021-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
@@ -176,7 +176,7 @@ void wmi_bmiss_extract_stats_struct(void *tag_buf,
 
 #endif/* CONFIG_WLAN_BMISS */
 
-/*
+/**
  * wmi_stats_extract_tag_struct: function to extract tag structs
  * @tag_type: tag type that is to be printed
  * @tag_buf: pointer to the tag structure
@@ -463,9 +463,9 @@ send_stats_request_cmd_tlv(wmi_unified_t wmi_handle,
 #else
 /**
  * send_stats_request_cmd_tlv() - WMI request stats function
- * @param wmi_handle: handle to WMI.
- * @param macaddr: MAC address
- * @param param: pointer to hold stats request parameter
+ * @wmi_handle: handle to WMI.
+ * @macaddr: MAC address
+ * @param: pointer to hold stats request parameter
  *
  * Return: 0  on success and -ve on failure.
  */
@@ -520,7 +520,7 @@ send_stats_request_cmd_tlv(wmi_unified_t wmi_handle,
 /**
  * send_big_data_stats_request_cmd_tlv () - send big data stats cmd
  * @wmi_handle: wmi handle
- * @param : pointer to command request param
+ * @param: pointer to command request param
  *
  * Return: QDF_STATUS_SUCCESS for success or error code
  */
@@ -563,9 +563,9 @@ send_big_data_stats_request_cmd_tlv(wmi_unified_t wmi_handle,
 
 /**
  * extract_all_stats_counts_tlv() - extract all stats count from event
- * @param wmi_handle: wmi handle
- * @param evt_buf: pointer to event buffer
- * @param stats_param: Pointer to hold stats count
+ * @wmi_handle: wmi handle
+ * @evt_buf: pointer to event buffer
+ * @stats_param: Pointer to hold stats count
  *
  * Return: QDF_STATUS_SUCCESS for success or error code
  */
@@ -725,6 +725,8 @@ extract_all_stats_counts_tlv(wmi_unified_t wmi_handle, void *evt_buf,
 
 /**
  * extract_pdev_tx_stats() - extract pdev tx stats from event
+ * @tx: destination
+ * @tx_stats: source event data
  */
 static void extract_pdev_tx_stats(wmi_host_dbg_tx_stats *tx,
 				  struct wlan_dbg_tx_stats *tx_stats)
@@ -759,6 +761,8 @@ static void extract_pdev_tx_stats(wmi_host_dbg_tx_stats *tx,
 
 /**
  * extract_pdev_rx_stats() - extract pdev rx stats from event
+ * @rx: destination
+ * @rx_stats: source event data
  */
 static void extract_pdev_rx_stats(wmi_host_dbg_rx_stats *rx,
 				  struct wlan_dbg_rx_stats *rx_stats)
@@ -785,10 +789,10 @@ static void extract_pdev_rx_stats(wmi_host_dbg_rx_stats *rx,
 
 /**
  * extract_pdev_stats_tlv() - extract pdev stats from event
- * @param wmi_handle: wmi handle
- * @param evt_buf: pointer to event buffer
- * @param index: Index into pdev stats
- * @param pdev_stats: Pointer to hold pdev stats
+ * @wmi_handle: wmi handle
+ * @evt_buf: pointer to event buffer
+ * @index: Index into pdev stats
+ * @pdev_stats: Pointer to hold pdev stats
  *
  * Return: QDF_STATUS_SUCCESS for success or error code
  */
@@ -831,10 +835,10 @@ extract_pdev_stats_tlv(wmi_unified_t wmi_handle, void *evt_buf, uint32_t index,
 
 /**
  * extract_vdev_stats_tlv() - extract vdev stats from event
- * @param wmi_handle: wmi handle
- * @param evt_buf: pointer to event buffer
- * @param index: Index into vdev stats
- * @param vdev_stats: Pointer to hold vdev stats
+ * @wmi_handle: wmi handle
+ * @evt_buf: pointer to event buffer
+ * @index: Index into vdev stats
+ * @vdev_stats: Pointer to hold vdev stats
  *
  * Return: QDF_STATUS_SUCCESS for success or error code
  */
@@ -884,10 +888,10 @@ static QDF_STATUS extract_vdev_stats_tlv(wmi_unified_t wmi_handle,
 
 /**
  * extract_peer_stats_tlv() - extract peer stats from event
- * @param wmi_handle: wmi handle
- * @param evt_buf: pointer to event buffer
- * @param index: Index into peer stats
- * @param peer_stats: Pointer to hold peer stats
+ * @wmi_handle: wmi handle
+ * @evt_buf: pointer to event buffer
+ * @index: Index into peer stats
+ * @peer_stats: Pointer to hold peer stats
  *
  * Return: QDF_STATUS_SUCCESS for success or error code
  */
@@ -924,10 +928,10 @@ extract_peer_stats_tlv(wmi_unified_t wmi_handle, void *evt_buf, uint32_t index,
 
 /**
  * extract_peer_extd_stats_tlv() - extract extended peer stats from event
- * @param wmi_handle: wmi handle
- * @param evt_buf: pointer to event buffer
- * @param index: Index into extended peer stats
- * @param peer_extd_stats: Pointer to hold extended peer stats
+ * @wmi_handle: wmi handle
+ * @evt_buf: pointer to event buffer
+ * @index: Index into extended peer stats
+ * @peer_extd_stats: Pointer to hold extended peer stats
  *
  * Return: QDF_STATUS_SUCCESS for success or error code
  */
@@ -1025,7 +1029,7 @@ static void wmi_infra_cp_stats_ops_attach_tlv(struct wmi_ops *ops)
  * @evt_buf: pointer to event buffer
  * @inst_rssi_resp: Pointer to hold inst rssi response
  *
- * @Return: QDF_STATUS_SUCCESS for success or error code
+ * Return: QDF_STATUS_SUCCESS for success or error code
  */
 static QDF_STATUS
 extract_inst_rssi_stats_resp_tlv(wmi_unified_t wmi_handle, void *evt_buf,

wmi/src/wmi_unified_dbr_tlv.c

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2016-2021 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -25,8 +26,7 @@
 /**
  * send_dbr_cfg_cmd_tlv() - configure DMA rings for Direct Buf RX
  * @wmi_handle: wmi handle
- * @data_len: len of dma cfg req
- * @data: dma cfg req
+ * @cfg: dma cfg req
  *
  * Return: QDF_STATUS_SUCCESS on success and QDF_STATUS_E_FAILURE for failure
  */

wmi/src/wmi_unified_dcs_tlv.c

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2020-2021, The Linux Foundation. All rights reserved.
+ * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for any
  * purpose with or without fee is hereby granted, provided that the above
@@ -22,8 +23,8 @@
  * extract_dcs_interference_type_tlv() - extract dcs interference type
  * from event
  * @wmi_handle: wmi handle
- * @param evt_buf: pointer to event buffer
- * @param param: Pointer to hold dcs interference param
+ * @evt_buf: pointer to event buffer
+ * @param: Pointer to hold dcs interference param
  *
  * Return: 0 for success or error code
  */
@@ -56,8 +57,8 @@ static QDF_STATUS extract_dcs_interference_type_tlv(
 /**
  * extract_dcs_im_tgt_stats_tlv() - extract dcs im target stats from event
  * @wmi_handle: wmi handle
- * @param evt_buf: pointer to event buffer
- * @param wlan_stat: Pointer to hold wlan stats
+ * @evt_buf: pointer to event buffer
+ * @wlan_stat: Pointer to hold wlan stats
  *
  * Return: 0 for success or error code
  */

wmi/src/wmi_unified_extscan_tlv.c

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2016-2018, 2020, The Linux Foundation. All rights reserved.
- * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -287,7 +287,7 @@ static QDF_STATUS send_set_epno_network_list_cmd_tlv(wmi_unified_t wmi_handle,
  *
  * This function send request to fw to get extscan capabilities.
  *
- * Return: CDF status
+ * Return: QDF status
  */
 static QDF_STATUS send_extscan_get_capabilities_cmd_tlv(wmi_unified_t wmi_handle,
 		    struct extscan_capabilities_params *pgetcapab)
@@ -329,7 +329,7 @@ static QDF_STATUS send_extscan_get_capabilities_cmd_tlv(wmi_unified_t wmi_handle
  *
  * This function send request to fw to get cached results.
  *
- * Return: CDF status
+ * Return: QDF status
  */
 static QDF_STATUS send_extscan_get_cached_results_cmd_tlv(wmi_unified_t wmi_handle,
 		  struct extscan_cached_result_params *pcached_results)
@@ -373,7 +373,7 @@ static QDF_STATUS send_extscan_get_cached_results_cmd_tlv(wmi_unified_t wmi_hand
  *
  * This function sends stop change monitor request to fw.
  *
- * Return: CDF status
+ * Return: QDF status
  */
 static QDF_STATUS send_extscan_stop_change_monitor_cmd_tlv
 			(wmi_unified_t wmi_handle,
@@ -516,7 +516,7 @@ static QDF_STATUS wmi_get_buf_extscan_change_monitor_cmd
  *
  * This function sends start change monitor request to fw.
  *
- * Return: CDF status
+ * Return: QDF status
  */
 static QDF_STATUS send_extscan_start_change_monitor_cmd_tlv
 			(wmi_unified_t wmi_handle,
@@ -555,7 +555,7 @@ static QDF_STATUS send_extscan_start_change_monitor_cmd_tlv
  *
  * This function configures hotlist monitor to stop in fw.
  *
- * Return: CDF status
+ * Return: QDF status
  */
 static QDF_STATUS send_extscan_stop_hotlist_monitor_cmd_tlv
 		(wmi_unified_t wmi_handle,

wmi/src/wmi_unified_interop_issues_ap_tlv.c

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2019-2020 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -24,8 +25,8 @@
 /**
  * extract_interop_issues_ap_ev_param_tlv() - extract info from event
  * @wmi_handle: wmi handle
- * @param evt_buf: pointer to event buffer
- * @param param: Pointer to hold interop issues ap info
+ * @evt_buf: pointer to event buffer
+ * @data: Pointer to hold interop issues ap info
  *
  * Return: QDF_STATUS_SUCCESS for success or error code
  */

wmi/src/wmi_unified_nan_tlv.c

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2013-2021 The Linux Foundation. All rights reserved.
- * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -115,7 +115,7 @@ extract_nan_event_rsp_tlv(wmi_unified_t wmi_handle, void *evt_buf,
  * @wmi_handle: wmi handle
  * @nan_msg: request data which will be non-null
  *
- * Return: CDF status
+ * Return: QDF status
  */
 static QDF_STATUS send_nan_disable_req_cmd_tlv(wmi_unified_t wmi_handle,
 					       struct nan_disable_req *nan_msg)
@@ -228,7 +228,7 @@ static QDF_STATUS send_nan_disable_req_cmd_tlv(wmi_unified_t wmi_handle,
  * @wmi_handle: wmi handle
  * @nan_msg: request data which will be non-null
  *
- * Return: CDF status
+ * Return: QDF status
  */
 static QDF_STATUS send_nan_req_cmd_tlv(wmi_unified_t wmi_handle,
 				       struct nan_msg_params *nan_msg)

wmi/src/wmi_unified_ocb_tlv.c

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2013-2020 The Linux Foundation. All rights reserved.
- * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -24,7 +24,7 @@
 #include <wmi_unified_ocb_api.h>
 
 /**
- * send_ocb_set_utc_time_cmd() - send the UTC time to the firmware
+ * send_ocb_set_utc_time_cmd_tlv() - send the UTC time to the firmware
  * @wmi_handle: pointer to the wmi handle
  * @utc: pointer to the UTC time struct
  *
@@ -178,7 +178,7 @@ static QDF_STATUS send_ocb_stop_timing_advert_cmd_tlv(wmi_unified_t wmi_handle,
 /**
  * send_ocb_get_tsf_timer_cmd_tlv() - get ocb tsf timer val
  * @wmi_handle: pointer to the wmi handle
- * @request: pointer to the request
+ * @vdev_id: vdev identifier
  *
  * Return: 0 on success
  */

wmi/src/wmi_unified_ocb_ut.c

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2018-2020 The Linux Foundation. All rights reserved.
- * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -90,7 +90,7 @@ static QDF_STATUS fake_ocb_set_utc_time_cmd_tlv(wmi_unified_t wmi_handle,
 /**
  * fake_ocb_get_tsf_timer_cmd_tlv() - get ocb tsf timer val
  * @wmi_handle: pointer to the wmi handle
- * @request: pointer to the request
+ * @vdev_id: vdev of interest
  *
  * Return: 0 on success
  */
@@ -357,9 +357,7 @@ fake_ocb_start_timing_advert_cmd_tlv(wmi_unified_t wmi_handle,
 /**
  * fake_peer_create_cmd_tlv() - send peer create command to fw
  * @wmi: wmi handle
- * @peer_addr: peer mac address
- * @peer_type: peer type
- * @vdev_id: vdev id
+ * @param: peer create parameters
  *
  * Return: QDF_STATUS_SUCCESS for success or error code
  */
@@ -374,7 +372,7 @@ static QDF_STATUS fake_peer_create_cmd_tlv(wmi_unified_t wmi,
  * fake_peer_delete_cmd_tlv() - send PEER delete command to fw
  * @wmi: wmi handle
  * @peer_addr: peer mac addr
- * @vdev_id: vdev id
+ * @param: peer delete parameters
  *
  * Return: QDF_STATUS_SUCCESS for success or error code
  */
@@ -429,9 +427,8 @@ static QDF_STATUS fake_vdev_down_cmd_tlv(wmi_unified_t wmi, uint8_t vdev_id)
 
 /**
  *  fake_vdev_set_param_cmd_tlv() - WMI vdev set parameter function
- *  @param wmi_handle      : handle to WMI.
- *  @param macaddr        : MAC address
- *  @param param    : pointer to hold vdev set parameter
+ *  @wmi_handle: handle to WMI.
+ *  @param: pointer to hold vdev set parameter
  *
  *  Return: 0  on success and -ve on failure.
  */
@@ -447,6 +444,7 @@ static QDF_STATUS fake_vdev_set_param_cmd_tlv(wmi_unified_t wmi_handle,
  *  faked API to enable/disable mcc scheduler
  * @wmi_handle: wmi handle
  * @mcc_adaptive_scheduler: enable/disable
+ * @pdev_id: pdev ID
  *
  * This function enable/disable mcc adaptive scheduler in fw.
  *
@@ -460,10 +458,10 @@ static QDF_STATUS fake_set_enable_disable_mcc_adaptive_scheduler_cmd_tlv(
 	return QDF_STATUS_SUCCESS;
 }
 
-/*
+/**
  * fake_process_set_ie_info_cmd_tlv() - Function to send IE info to firmware
  * @wmi_handle:    Pointer to WMi handle
- * @ie_data:       Pointer for ie data
+ * @ie_info:       Pointer for ie info
  *
  * This function sends IE information to firmware
  *

wmi/src/wmi_unified_p2p_tlv.c

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2013-2018, 2020 The Linux Foundation. All rights reserved.
- * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -27,7 +27,7 @@
  * @wmi_handle: wmi handle
  * @noa: p2p power save parameters
  *
- * Return: CDF status
+ * Return: QDF status
  */
 static QDF_STATUS send_set_p2pgo_noa_req_cmd_tlv(wmi_unified_t wmi_handle,
 						 struct p2p_ps_params *noa)
@@ -90,9 +90,9 @@ end:
 /**
  * send_set_p2pgo_oppps_req_cmd_tlv() - send p2p go opp power save request to fw
  * @wmi_handle: wmi handle
- * @noa: p2p opp power save parameters
+ * @oppps: p2p opp power save parameters
  *
- * Return: CDF status
+ * Return: QDF status
  */
 static QDF_STATUS send_set_p2pgo_oppps_req_cmd_tlv(wmi_unified_t wmi_handle,
 						   struct p2p_ps_params *oppps)
@@ -134,8 +134,8 @@ end:
 /**
  * extract_p2p_noa_ev_param_tlv() - extract p2p noa information from event
  * @wmi_handle: wmi handle
- * @param evt_buf: pointer to event buffer
- * @param param: Pointer to hold p2p noa info
+ * @evt_buf: pointer to event buffer
+ * @param: Pointer to hold p2p noa info
  *
  * Return: QDF_STATUS_SUCCESS for success or error code
  */
@@ -325,7 +325,7 @@ static QDF_STATUS send_p2p_lo_start_cmd_tlv(wmi_unified_t wmi_handle,
 /**
  * send_p2p_lo_stop_cmd_tlv() - send p2p lo stop request to fw
  * @wmi_handle: wmi handle
- * @param: p2p listen offload stop parameters
+ * @vdev_id: vdev identifier
  *
  * Return: QDF status
  */
@@ -373,8 +373,8 @@ static QDF_STATUS send_p2p_lo_stop_cmd_tlv(wmi_unified_t wmi_handle,
  * extract_p2p_lo_stop_ev_param_tlv() - extract p2p lo stop
  * information from event
  * @wmi_handle: wmi handle
- * @param evt_buf: pointer to event buffer
- * @param param: Pointer to hold p2p lo stop event information
+ * @evt_buf: pointer to event buffer
+ * @param: Pointer to hold p2p lo stop event information
  *
  * Return: QDF_STATUS_SUCCESS for success or error code
  */

wmi/src/wmi_unified_pmo_tlv.c

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2018-2021 The Linux Foundation. All rights reserved.
- * Copyright (c) 2021-2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2021-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -25,7 +25,7 @@
 #ifdef FEATURE_WLAN_D0WOW
 /**
  *  send_d0wow_enable_cmd_tlv() - WMI d0 wow enable function
- *  @param wmi_handle: handle to WMI.
+ *  @wmi_handle: handle to WMI.
  *  @mac_id: radio context
  *
  *  Return: 0  on success  and  error code on failure.
@@ -63,7 +63,7 @@ static QDF_STATUS send_d0wow_enable_cmd_tlv(wmi_unified_t wmi_handle,
 
 /**
  *  send_d0wow_disable_cmd_tlv() - WMI d0 wow disable function
- *  @param wmi_handle: handle to WMI.
+ *  @wmi_handle: handle to WMI.
  *  @mac_id: radio context
  *
  *  Return: 0  on success  and  error code on failure.
@@ -115,7 +115,7 @@ void wmi_d0wow_attach_tlv(struct wmi_unified *wmi_handle)
  * @bitmap: Event bitmap
  * @enable: enable/disable
  *
- * Return: CDF status
+ * Return: QDF status
  */
 static QDF_STATUS send_add_wow_wakeup_event_cmd_tlv(wmi_unified_t wmi_handle,
 						    uint32_t vdev_id,
@@ -171,7 +171,7 @@ static QDF_STATUS send_add_wow_wakeup_event_cmd_tlv(wmi_unified_t wmi_handle,
  * @user: true for user configured pattern and false for default pattern
  * @default_patterns: default patterns
  *
- * Return: CDF status
+ * Return: QDF status
  */
 static QDF_STATUS send_wow_patterns_to_fw_cmd_tlv(wmi_unified_t wmi_handle,
 				uint8_t vdev_id, uint8_t ptrn_id,
@@ -334,8 +334,8 @@ static void fill_arp_offload_params_tlv(wmi_unified_t wmi_handle,
 #ifdef WLAN_NS_OFFLOAD
 /**
  * fill_ns_offload_params_tlv() - Fill NS offload data
- * @wmi|_handle: wmi handle
- * @offload_req: offload request
+ * @wmi_handle: wmi handle
+ * @ns_req: offload request
  * @buf_ptr: buffer pointer
  *
  * To fill NS offload data to firmware
@@ -398,8 +398,8 @@ static void fill_ns_offload_params_tlv(wmi_unified_t wmi_handle,
 
 /**
  * fill_nsoffload_ext_tlv() - Fill NS offload ext data
- * @wmi: wmi handle
- * @offload_req: offload request
+ * @wmi_handle: wmi handle
+ * @ns_req: offload request
  * @buf_ptr: buffer pointer
  *
  * To fill extended NS offload extended data to firmware
@@ -478,10 +478,10 @@ static void fill_nsoffload_ext_tlv(wmi_unified_t wmi_handle,
 
 /**
  * send_enable_arp_ns_offload_cmd_tlv() - enable ARP NS offload
- * @wma: wmi handle
+ * @wmi_handle: wmi handle
  * @arp_offload_req: arp offload request
  * @ns_offload_req: ns offload request
- * @arp_only: flag
+ * @vdev_id: vdev ID
  *
  * To configure ARP NS off load data to firmware
  * when target goes to wow mode.
@@ -566,7 +566,7 @@ static QDF_STATUS send_enable_arp_ns_offload_cmd_tlv(wmi_unified_t wmi_handle,
  * send_add_clear_mcbc_filter_cmd_tlv() - set mcast filter command to fw
  * @wmi_handle: wmi handle
  * @vdev_id: vdev id
- * @multicastAddr: mcast address
+ * @multicast_addr: mcast address
  * @clearList: clear list flag
  *
  * Return: QDF_STATUS_SUCCESS for success or error code
@@ -619,7 +619,7 @@ static QDF_STATUS send_add_clear_mcbc_filter_cmd_tlv(wmi_unified_t wmi_handle,
  *						   command to fw
  * @wmi_handle: wmi handle
  * @vdev_id: vdev id
- * @mcast_filter_params: mcast filter params
+ * @filter_param: mcast filter params
  *
  * Return: QDF_STATUS_SUCCESS for success or error code
  */
@@ -767,7 +767,7 @@ fill_fils_tlv_params(WMI_GTK_OFFLOAD_CMD_fixed_param *cmd,
 /**
  * send_igmp_offload_cmd_tlv() - send IGMP offload command to fw
  * @wmi_handle: wmi handle
- * @params: IGMP offload parameters
+ * @pmo_igmp_req: IGMP offload parameters
  *
  * Return: QDF status
  */
@@ -840,8 +840,10 @@ out:
  * @wmi_handle: wmi handle
  * @vdev_id: vdev id
  * @params: GTK offload parameters
+ * @enable_offload: true to enable the offload
+ * @gtk_offload_opcode: GTK offload opcode
  *
- * Return: CDF status
+ * Return: QDF status
  */
 static
 QDF_STATUS send_gtk_offload_cmd_tlv(wmi_unified_t wmi_handle, uint8_t vdev_id,
@@ -940,9 +942,10 @@ out:
 /**
  * send_process_gtk_offload_getinfo_cmd_tlv() - send GTK offload cmd to fw
  * @wmi_handle: wmi handle
- * @params: GTK offload params
+ * @vdev_id: vdev id
+ * @offload_req_opcode: GTK offload request opcode
  *
- * Return: CDF status
+ * Return: QDF status
  */
 static QDF_STATUS send_process_gtk_offload_getinfo_cmd_tlv(
 			wmi_unified_t wmi_handle,
@@ -1039,9 +1042,9 @@ QDF_STATUS send_enable_enhance_multicast_offload_tlv(
 /**
  * extract_gtk_rsp_event_tlv() - extract gtk rsp params from event
  * @wmi_handle: wmi handle
- * @param evt_buf: pointer to event buffer
- * @param hdr: Pointer to hold header
- * @param bufp: Pointer to hold pointer to rx param buffer
+ * @evt_buf: pointer to event buffer
+ * @gtk_rsp_param: Pointer to extraction buffer
+ * @len: length of the @evt_buf event buffer
  *
  * Return: QDF_STATUS_SUCCESS for success or error code
  */
@@ -1086,8 +1089,10 @@ static QDF_STATUS extract_gtk_rsp_event_tlv(wmi_unified_t wmi_handle,
  * send_wow_sta_ra_filter_cmd_tlv() - set RA filter pattern in fw
  * @wmi_handle: wmi handle
  * @vdev_id: vdev id
+ * @default_pattern: default pattern
+ * @rate_limit_interval: ra packets interval
  *
- * Return: CDF status
+ * Return: QDF status
  */
 static QDF_STATUS send_wow_sta_ra_filter_cmd_tlv(wmi_unified_t wmi_handle,
 						 uint8_t vdev_id,
@@ -1240,9 +1245,9 @@ static QDF_STATUS send_action_frame_patterns_cmd_tlv(wmi_unified_t wmi_handle,
 /**
  * send_lphb_config_hbenable_cmd_tlv() - enable command of LPHB configuration
  * @wmi_handle: wmi handle
- * @lphb_conf_req: configuration info
+ * @params: LPHB configuration info
  *
- * Return: CDF status
+ * Return: QDF status
  */
 static QDF_STATUS send_lphb_config_hbenable_cmd_tlv(wmi_unified_t wmi_handle,
 				wmi_hb_set_enable_cmd_fixed_param *params)
@@ -1288,7 +1293,7 @@ static QDF_STATUS send_lphb_config_hbenable_cmd_tlv(wmi_unified_t wmi_handle,
  * @wmi_handle: wmi handle
  * @lphb_conf_req: lphb config request
  *
- * Return: CDF status
+ * Return: QDF status
  */
 static QDF_STATUS send_lphb_config_tcp_params_cmd_tlv(wmi_unified_t wmi_handle,
 	    wmi_hb_set_tcp_params_cmd_fixed_param *lphb_conf_req)
@@ -1340,9 +1345,9 @@ static QDF_STATUS send_lphb_config_tcp_params_cmd_tlv(wmi_unified_t wmi_handle,
 /**
  * send_lphb_config_tcp_pkt_filter_cmd_tlv() - configure tcp packet filter cmd
  * @wmi_handle: wmi handle
- * @lphb_conf_req: lphb config request
+ * @g_hb_tcp_filter_fp: tcp packet filter params
  *
- * Return: CDF status
+ * Return: QDF status
  */
 static
 QDF_STATUS send_lphb_config_tcp_pkt_filter_cmd_tlv(wmi_unified_t wmi_handle,
@@ -1393,7 +1398,7 @@ QDF_STATUS send_lphb_config_tcp_pkt_filter_cmd_tlv(wmi_unified_t wmi_handle,
  * @wmi_handle: wmi handle
  * @lphb_conf_req: lphb config request
  *
- * Return: CDF status
+ * Return: QDF status
  */
 static QDF_STATUS send_lphb_config_udp_params_cmd_tlv(wmi_unified_t wmi_handle,
 		   wmi_hb_set_udp_params_cmd_fixed_param *lphb_conf_req)
@@ -1446,7 +1451,7 @@ static QDF_STATUS send_lphb_config_udp_params_cmd_tlv(wmi_unified_t wmi_handle,
  * @wmi_handle: wmi handle
  * @lphb_conf_req: lphb config request
  *
- * Return: CDF status
+ * Return: QDF status
  */
 static
 QDF_STATUS send_lphb_config_udp_pkt_filter_cmd_tlv(wmi_unified_t wmi_handle,
@@ -1654,7 +1659,7 @@ void wmi_packet_filtering_attach_tlv(struct wmi_unified *wmi_handle)
  * @ptrn_id: pattern id
  * @vdev_id: vdev id
  *
- * Return: CDF status
+ * Return: QDF status
  */
 static QDF_STATUS send_wow_delete_pattern_cmd_tlv(wmi_unified_t wmi_handle,
 						  uint8_t ptrn_id,
@@ -1723,7 +1728,7 @@ QDF_STATUS wmi_unified_cmd_send_chk(struct wmi_unified *wmi_handle,
  * Sends host wakeup indication to FW. On receiving this indication,
  * FW will come out of WOW.
  *
- * Return: CDF status
+ * Return: QDF status
  */
 static QDF_STATUS send_host_wakeup_ind_to_fw_cmd_tlv(wmi_unified_t wmi_handle,
 						     bool tx_pending_ind)
@@ -1906,7 +1911,7 @@ static QDF_STATUS send_enable_ext_wow_cmd_tlv(wmi_unified_t wmi_handle,
  * @wmi_handle: wmi handle
  * @appType2Params: app type2 params
  *
- * Return: CDF status
+ * Return: QDF status
  */
 static QDF_STATUS send_set_app_type2_params_in_fw_cmd_tlv(wmi_unified_t wmi_handle,
 			  struct app_type2_params *appType2Params)
@@ -1988,7 +1993,7 @@ static QDF_STATUS send_set_app_type2_params_in_fw_cmd_tlv(wmi_unified_t wmi_hand
  * @wmi_handle: wmi handle
  * @app_type1_params: app type1 params
  *
- * Return: CDF status
+ * Return: QDF status
  */
 static QDF_STATUS send_app_type1_params_in_fw_cmd_tlv(wmi_unified_t wmi_handle,
 				   struct app_type1_params *app_type1_params)

wmi/src/wmi_unified_sta_tlv.c

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2013-2020 The Linux Foundation. All rights reserved.
- * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -84,7 +84,7 @@ static QDF_STATUS send_set_sta_sa_query_param_cmd_tlv(wmi_unified_t wmi_handle,
  *
  * This function sets keep alive related parameters in fw.
  *
- * Return: CDF status
+ * Return: QDF status
  */
 static QDF_STATUS
 send_set_sta_keep_alive_cmd_tlv(wmi_unified_t wmi_handle,
@@ -254,9 +254,9 @@ static QDF_STATUS send_process_dhcp_ind_cmd_tlv(wmi_unified_t wmi_handle,
 /**
  * send_get_link_speed_cmd_tlv() -send command to get linkspeed
  * @wmi_handle: wmi handle
- * @pLinkSpeed: link speed info
+ * @peer_macaddr: peer address
  *
- * Return: CDF status
+ * Return: QDF status
  */
 static QDF_STATUS send_get_link_speed_cmd_tlv(wmi_unified_t wmi_handle,
 					      wmi_mac_addr peer_macaddr)
@@ -296,7 +296,7 @@ static QDF_STATUS send_get_link_speed_cmd_tlv(wmi_unified_t wmi_handle,
 
 /**
  * send_fw_profiling_cmd_tlv() - send FW profiling cmd to WLAN FW
- * @wmi_handl: wmi handle
+ * @wmi_handle: wmi handle
  * @cmd: Profiling command index
  * @value1: parameter1 value
  * @value2: parameter2 value
@@ -554,7 +554,7 @@ static uint8_t tdls_get_wmi_offchannel_mode(uint8_t tdls_sw_mode)
 
 /**
  * tdls_get_wmi_offchannel_bw - Get WMI tdls off channel Bandwidth
- * @tdls_sw_mode: tdls_sw_mode
+ * @tdls_off_ch_bw_offset: bandwidth offset
  *
  * This function returns wmi tdls offchannel bandwidth
  *
@@ -655,7 +655,8 @@ static QDF_STATUS send_set_tdls_offchan_mode_cmd_tlv(wmi_unified_t wmi_handle,
 /**
  * send_update_fw_tdls_state_cmd_tlv() - send enable/disable tdls for a vdev
  * @wmi_handle: wmi handle
- * @pwmaTdlsparams: TDLS params
+ * @tdls_param: TDLS params
+ * @tdls_state: TDLS state
  *
  * Return: 0 for success or error code
  */
@@ -747,6 +748,7 @@ send_update_fw_tdls_state_cmd_tlv(wmi_unified_t wmi_handle,
  * send_update_tdls_peer_state_cmd_tlv() - update TDLS peer state
  * @wmi_handle: wmi handle
  * @peer_state: TDLS peer state params
+ * @ch_mhz: peer channels
  *
  * Return: QDF_STATUS_SUCCESS for success or error code
  */
@@ -905,8 +907,8 @@ send_update_tdls_peer_state_cmd_tlv(wmi_unified_t wmi_handle,
 /**
  * extract_vdev_tdls_ev_param_tlv() - extract vdev tdls param from event
  * @wmi_handle: wmi handle
- * @param evt_buf: pointer to event buffer
- * @param param: Pointer to hold vdev tdls param
+ * @evt_buf: pointer to event buffer
+ * @param: Pointer to hold vdev tdls param
  *
  * Return: QDF_STATUS_SUCCESS for success or error code
  */
@@ -1259,7 +1261,7 @@ void wmi_denylist_mgr_attach_tlv(struct wmi_unified *wmi_handle)
 /**
  * send_sar_limit_cmd_tlv() - send sar limit cmd to fw
  * @wmi_handle: wmi handle
- * @params: sar limit params
+ * @sar_limit_params: sar limit params
  *
  * Return: QDF_STATUS_SUCCESS for success or error code
  */
@@ -1497,7 +1499,6 @@ static QDF_STATUS extract_sar_limit_event_tlv(wmi_unified_t wmi_handle,
  * send_set_del_pmkid_cache_cmd_tlv() - send wmi cmd of set del pmkid
  * @wmi_handle: wmi handler
  * @pmk_info: pointer to PMK cache entry
- * @vdev_id: vdev id
  *
  * Return: 0 for success and non zero for failure
  */
@@ -1578,9 +1579,10 @@ send_cmd:
 /**
  * send_del_ts_cmd_tlv() - send DELTS request to fw
  * @wmi_handle: wmi handle
- * @msg: delts params
+ * @vdev_id: vdev identifier
+ * @ac: access category
  *
- * Return: CDF status
+ * Return: QDF status
  */
 static QDF_STATUS send_del_ts_cmd_tlv(wmi_unified_t wmi_handle, uint8_t vdev_id,
 				uint8_t ac)
@@ -1616,13 +1618,13 @@ static QDF_STATUS send_del_ts_cmd_tlv(wmi_unified_t wmi_handle, uint8_t vdev_id,
 /**
  * send_aggr_qos_cmd_tlv() - send aggr qos request to fw
  * @wmi_handle: handle to wmi
- * @aggr_qos_rsp_msg - combined struct for all ADD_TS requests.
+ * @aggr_qos_rsp_msg: combined struct for all ADD_TS requests.
  *
  * A function to handle WMI_AGGR_QOS_REQ. This will send out
  * ADD_TS requests to firmware in loop for all the ACs with
  * active flow.
  *
- * Return: CDF status
+ * Return: QDF status
  */
 static QDF_STATUS send_aggr_qos_cmd_tlv(wmi_unified_t wmi_handle,
 		      struct aggr_add_ts_param *aggr_qos_rsp_msg)
@@ -1683,7 +1685,7 @@ static QDF_STATUS send_aggr_qos_cmd_tlv(wmi_unified_t wmi_handle,
  * @wmi_handle: wmi handle
  * @msg: ADDTS params
  *
- * Return: CDF status
+ * Return: QDF status
  */
 static QDF_STATUS send_add_ts_cmd_tlv(wmi_unified_t wmi_handle,
 		 struct add_ts_param *msg)
@@ -1838,7 +1840,7 @@ static QDF_STATUS send_process_del_periodic_tx_ptrn_cmd_tlv(
  * @wmi_handle: wmi handle
  * @timer_val: auto shutdown timer value
  *
- * Return: CDF status
+ * Return: QDF status
  */
 static QDF_STATUS send_set_auto_shutdown_timer_cmd_tlv(wmi_unified_t wmi_handle,
 						  uint32_t timer_val)
@@ -1883,7 +1885,7 @@ static QDF_STATUS send_set_auto_shutdown_timer_cmd_tlv(wmi_unified_t wmi_handle,
  * @wmi_handle: wmi handle
  * @flashing: flashing request
  *
- * Return: CDF status
+ * Return: QDF status
  */
 static QDF_STATUS send_set_led_flashing_cmd_tlv(wmi_unified_t wmi_handle,
 				struct flashing_req_params *flashing)
@@ -1923,9 +1925,8 @@ static QDF_STATUS send_set_led_flashing_cmd_tlv(wmi_unified_t wmi_handle,
 /**
  * send_process_ch_avoid_update_cmd_tlv() - handles channel avoid update request
  * @wmi_handle: wmi handle
- * @ch_avoid_update_req: channel avoid update params
  *
- * Return: CDF status
+ * Return: QDF status
  */
 static QDF_STATUS send_process_ch_avoid_update_cmd_tlv(wmi_unified_t wmi_handle)
 {
@@ -2085,7 +2086,7 @@ void wmi_policy_mgr_attach_tlv(struct wmi_unified *wmi_handle)
 /**
  * send_adapt_dwelltime_params_cmd_tlv() - send wmi cmd of adaptive dwelltime
  * configuration params
- * @wma_handle:  wma handler
+ * @wmi_handle:  wmi handler
  * @dwelltime_params: pointer to dwelltime_params
  *
  * Return: QDF_STATUS_SUCCESS on success and QDF failure reason code for failure

wmi/src/wmi_unified_tlv.c

@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2016-2021 The Linux Foundation. All rights reserved.
- * Copyright (c) 2021-2022 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2021-2023 Qualcomm Innovation Center, Inc. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -5748,7 +5748,7 @@ static QDF_STATUS send_p2p_go_set_beacon_ie_cmd_tlv(wmi_unified_t wmi_handle,
  *
  * set scan probe OUI parameters in firmware
  *
- * Return: CDF status
+ * Return: QDF status
  */
 static QDF_STATUS send_scan_probe_setoui_cmd_tlv(wmi_unified_t wmi_handle,
 			  struct scan_mac_oui *psetoui)
@@ -5868,7 +5868,7 @@ static QDF_STATUS send_ipa_offload_control_cmd_tlv(wmi_unified_t wmi_handle,
  *
  * This function request FW to stop ongoing PNO operation.
  *
- * Return: CDF status
+ * Return: QDF status
  */
 static QDF_STATUS send_pno_stop_cmd_tlv(wmi_unified_t wmi_handle, uint8_t vdev_id)
 {
@@ -6247,7 +6247,7 @@ static void wmi_dump_pno_scan_freq_list(struct chan_list *scan_freq_list)
  * @pno: PNO request
  *
  * This function request FW to start PNO request.
- * Request: CDF status
+ * Request: QDF status
  */
 static QDF_STATUS send_pno_start_cmd_tlv(wmi_unified_t wmi_handle,
 		   struct pno_scan_req_params *pno)
@@ -6849,7 +6849,7 @@ static QDF_STATUS send_unified_ll_stats_get_sta_cmd_tlv(
  * @wmi_handle: wmi handle
  * @vdev_id: vdev id
  *
- * Return: CDF status
+ * Return: QDF status
  */
 static QDF_STATUS send_congestion_cmd_tlv(wmi_unified_t wmi_handle,
 			uint8_t vdev_id)
@@ -6925,7 +6925,7 @@ static QDF_STATUS send_snr_request_cmd_tlv(wmi_unified_t wmi_handle)
  * @wmi_handle: wmi handle
  * @vdev_id: vdev id
  *
- * Return: CDF status
+ * Return: QDF status
  */
 static QDF_STATUS send_snr_cmd_tlv(wmi_unified_t wmi_handle, uint8_t vdev_id)
 {
@@ -6961,7 +6961,7 @@ static QDF_STATUS send_snr_cmd_tlv(wmi_unified_t wmi_handle, uint8_t vdev_id)
  * @wmi_handle: wmi handle
  * @link_status: get link params
  *
- * Return: CDF status
+ * Return: QDF status
  */
 static QDF_STATUS send_link_status_req_cmd_tlv(wmi_unified_t wmi_handle,
 				 struct link_status_params *link_status)
@@ -7208,7 +7208,7 @@ static QDF_STATUS send_stop_11d_scan_cmd_tlv(wmi_unified_t wmi_handle,
  * @data_len: the length of @data
  * @data: the pointer to data buf
  *
- * Return: CDF status
+ * Return: QDF status
  */
 static QDF_STATUS send_start_oem_data_cmd_tlv(wmi_unified_t wmi_handle,
 					      uint32_t data_len,
@@ -7425,7 +7425,7 @@ send_dfs_phyerr_filter_offload_en_cmd_tlv(wmi_unified_t wmi_handle,
  * @cmd_id: pktlog cmd id
  * @user_triggered: user triggered input for PKTLOG enable mode
  *
- * Return: CDF status
+ * Return: QDF status
  */
 static QDF_STATUS send_pktlog_wmi_send_cmd_tlv(wmi_unified_t wmi_handle,
 				   WMI_PKTLOG_EVENT pktlog_event,
@@ -7514,7 +7514,7 @@ wmi_send_failed:
  * @wmi_handle: wmi handle
  * @preq: stats ext params
  *
- * Return: CDF status
+ * Return: QDF status
  */
 static QDF_STATUS send_stats_ext_req_cmd_tlv(wmi_unified_t wmi_handle,
 			struct stats_ext_params *preq)