samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qcacld-3.0: Provide reason to QDF_DEBUG_PANIC()

Browse Source 
A common pattern in WLAN to panic the driver is to log the reason and
then unconditionally panic. QDF_DEBUG_PANIC() takes a reason string to
help make the reason for the panic more obvious, but it is not always
used. Ensure all callers of QDF_DEBUG_PANIC() provide a reason string.

Change-Id: I3d23a8980adaeaa1a9798a4a6b0fba1f36eb52ad
CRs-Fixed: 2403829
This commit is contained in:
Dustin Brown
2019-02-22 10:52:33 -08:00
committed by nshrivas
parent b3c9d4c9be
commit 207286b118
2 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
components/dsc/test/wlan_dsc_test.c
View File

@@ -51,7 +51,7 @@ static struct dsc_psoc *nth_psoc(struct dsc_driver *driver, int n)
return psoc;
}
QDF_DEBUG_PANIC();
QDF_DEBUG_PANIC("Failed to find nth psoc: %d", n);
return NULL;
}
@@ -72,7 +72,7 @@ static struct dsc_vdev *nth_vdev(struct dsc_psoc *psoc, int n)
return vdev;
}
QDF_DEBUG_PANIC();
QDF_DEBUG_PANIC("Failed to find nth vdev: %d", n);
return NULL;
}

7
core/dp/txrx3.0/dp_rx_thread.c
View File

@@ -402,8 +402,7 @@ static int dp_rx_thread_loop(void *arg)
dp_debug("woken up");
if (status == -ERESTARTSYS) {
dp_err("wait_event_interruptible returned -ERESTARTSYS");
QDF_DEBUG_PANIC();
QDF_DEBUG_PANIC("wait_event_interruptible returned -ERESTARTSYS");
break;
}
qdf_atomic_clear_bit(RX_POST_EVENT, &rx_thread->event_flag);
@@ -428,8 +427,8 @@ static int dp_rx_thread_loop(void *arg)
*/
static int dp_rx_tm_thread_napi_poll(struct napi_struct *napi, int budget)
{
dp_err("this napi_poll should not be polled as we don't schedule it");
QDF_BUG(0);
QDF_DEBUG_PANIC("this napi_poll should not be polled as we don't schedule it");
return 0;
}