Browse Source

qcacmn: preventing potential Side effect of ++ operation

preventing potential Side effect of ++ operation in assertion

Change-Id: Ibdad7e856143fbcde45d4c8db637b608ef3983cd
CRs-Fixed: 3617044
aloksing 1 year ago
parent
commit
1f0e7d3b82
1 changed files with 12 additions and 6 deletions
  1. 12 6
      dp/wifi3.0/dp_htt.c

+ 12 - 6
dp/wifi3.0/dp_htt.c

@@ -2881,8 +2881,10 @@ dp_queue_mon_ring_stats(struct dp_pdev *pdev,
 			 RXDMA_MONITOR_BUF,
 			 &soc_srngs_state->ring_state[*num_srng]);
 
-		if (status == QDF_STATUS_SUCCESS)
-			qdf_assert_always(++(*num_srng) < DP_MAX_SRNGS);
+		if (status == QDF_STATUS_SUCCESS) {
+			++(*num_srng);
+			qdf_assert_always(*num_srng < DP_MAX_SRNGS);
+		}
 
 		status = dp_get_srng_ring_state_from_hal
 			(pdev->soc, pdev,
@@ -2890,8 +2892,10 @@ dp_queue_mon_ring_stats(struct dp_pdev *pdev,
 			 RXDMA_MONITOR_DST,
 			 &soc_srngs_state->ring_state[*num_srng]);
 
-		if (status == QDF_STATUS_SUCCESS)
-			qdf_assert_always(++(*num_srng) < DP_MAX_SRNGS);
+		if (status == QDF_STATUS_SUCCESS) {
+			++(*num_srng);
+			qdf_assert_always(*num_srng < DP_MAX_SRNGS);
+		}
 
 		status = dp_get_srng_ring_state_from_hal
 			(pdev->soc, pdev,
@@ -2899,8 +2903,10 @@ dp_queue_mon_ring_stats(struct dp_pdev *pdev,
 			 RXDMA_MONITOR_DESC,
 			 &soc_srngs_state->ring_state[*num_srng]);
 
-		if (status == QDF_STATUS_SUCCESS)
-			qdf_assert_always(++(*num_srng) < DP_MAX_SRNGS);
+		if (status == QDF_STATUS_SUCCESS) {
+			++(*num_srng);
+			qdf_assert_always(*num_srng < DP_MAX_SRNGS);
+		}
 	}
 }
 #else