samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
複製 0
程式碼 問題管理 合併請求 Actions Packages Projects 版本發佈 Wiki Activity

qcacmn: Address minor HTC review comments

瀏覽代碼 
Address minor review comments raised against previous change
Ic417f6b008fdc769227c7a23bc8e01a2064ce928. Specifically, remove function
recv_packet_completion() and member EpRecvPktMultiple from struct
htc_ep_callbacks.

Change-Id: I431579356664ad6a6274f58352adf8ce273e084f
CRs-Fixed: 2168647
This commit is contained in:
Dustin Brown
2018-01-08 12:30:30 -08:00
committed by snandini
父節點 5428570e41
當前提交 1e61fbc2a0
共有 2 個文件被更改，包括 8 次插入 和 17 次删除
Download Patch File Download Diff File Expand all files Collapse all files

8
htc/htc_api.h
查看文件

@@ -1,5 +1,5 @@
/* /*
* Copyright (c) 2013-2014, 2016-2017 The Linux Foundation. All rights reserved. * Copyright (c) 2013-2014, 2016-2018 The Linux Foundation. All rights reserved.
* *
* Previously licensed under the ISC license by Qualcomm Atheros, Inc. * Previously licensed under the ISC license by Qualcomm Atheros, Inc.
* *
@@ -171,10 +171,7 @@ struct htc_ep_callbacks {
* indications (EpTxComplete must be NULL) * indications (EpTxComplete must be NULL)
*/ */
HTC_EP_SEND_PKT_COMP_MULTIPLE EpTxCompleteMultiple; HTC_EP_SEND_PKT_COMP_MULTIPLE EpTxCompleteMultiple;
/* OPTIONAL completion handler for multiple
* recv packet indications (EpRecv must be NULL)
*/
HTC_EP_RECV_PKT_MULTIPLE EpRecvPktMultiple;
HTC_EP_RESUME_TX_QUEUE ep_resume_tx_queue; HTC_EP_RESUME_TX_QUEUE ep_resume_tx_queue;
/* if EpRecvAllocThresh is non-NULL, HTC will compare the /* if EpRecvAllocThresh is non-NULL, HTC will compare the
* threshold value to the current recv packet length and invoke * threshold value to the current recv packet length and invoke
@@ -188,7 +185,6 @@ struct htc_ep_callbacks {
* are empty * are empty
*/ */
int RecvRefillWaterMark; int RecvRefillWaterMark;
}; };
/* service connection information */ /* service connection information */

17
htc/htc_recv.c
查看文件

@@ -1,5 +1,5 @@
/* /*
* Copyright (c) 2013-2017 The Linux Foundation. All rights reserved. * Copyright (c) 2013-2018 The Linux Foundation. All rights reserved.
* *
* Previously licensed under the ISC license by Qualcomm Atheros, Inc. * Previously licensed under the ISC license by Qualcomm Atheros, Inc.
* *
@@ -116,15 +116,6 @@ static void do_recv_completion(HTC_ENDPOINT *pEndpoint,
} }
} }
static void recv_packet_completion(HTC_TARGET *target, HTC_ENDPOINT *pEndpoint,
HTC_PACKET *pPacket)
{
do_recv_completion_pkt(pEndpoint, pPacket);
/* recover the packet container */
free_htc_packet_container(target, pPacket);
}
void htc_control_rx_complete(void *Context, HTC_PACKET *pPacket) void htc_control_rx_complete(void *Context, HTC_PACKET *pPacket)
{ {
/* TODO, can't really receive HTC control messages yet.... */ /* TODO, can't really receive HTC control messages yet.... */
@@ -504,7 +495,11 @@ QDF_STATUS htc_rx_completion_handler(void *Context, qdf_nbuf_t netbuf,
qdf_nbuf_pull_head(netbuf, HTC_HEADER_LEN); qdf_nbuf_pull_head(netbuf, HTC_HEADER_LEN);
qdf_nbuf_set_pktlen(netbuf, pPacket->ActualLength); qdf_nbuf_set_pktlen(netbuf, pPacket->ActualLength);
recv_packet_completion(target, pEndpoint, pPacket); do_recv_completion_pkt(pEndpoint, pPacket);
/* recover the packet container */
free_htc_packet_container(target, pPacket);
netbuf = NULL; netbuf = NULL;
} while (false); } while (false);