qcacld-3.0: Handle power save mode ind while roaming

Host receives set cfg80211 power management config
(enable/disable power save mode) indication in any
driver state (connected / disconnected / roaming state).

In connected state, Host directly sends power save
enable/disable power save mode indication to FW.

In non-associated state driver does below steps:
1. As kernel expects return status success if host is in
the disconnected state for request then host first cache
power save mode per VDEV and return success to kernel
from sme_ps_enable_disable().
2. In next connection, Host checks cache power save mode
cached at step 1, while processing changes in IPv6/IPv4
state for the interface and sends "power save enable/disable
power save mode indication to FW accordingly.

Currently in roaming state, if host receives enable/disable
power save mode command from user space, Host sends failure
to kernel with error message "not in connected state", which
is not correct. As by this time VDEV is active and FW also
ready to honor power save enable/disable power save mode
indication, host should send indication to FW.

To fix this issue send power save enable/disable power save
mode indication to FW if host receives "set cfg80211 power
management config" in roaming state.

Change-Id: I0fea2275123840e936ddd6c0326f5e9b866de52a
CRs-Fixed: 3665639

core/sme/src/common/sme_power_save.c

@@ -313,27 +313,6 @@ QDF_STATUS sme_ps_process_command(struct mac_context *mac_ctx, uint32_t session_
 	return status;
 }
 
-#ifdef QCA_WIFI_EMULATION
-static QDF_STATUS sme_ps_enable_user_check(bool usr_cfg_ps_enable,
-					   enum sme_ps_cmd command,
-					   uint32_t session_id)
-{
-	return QDF_STATUS_SUCCESS;
-}
-#else
-static QDF_STATUS sme_ps_enable_user_check(bool usr_cfg_ps_enable,
-					   enum sme_ps_cmd command,
-					   uint32_t session_id)
-{
-	if (command == SME_PS_ENABLE && !usr_cfg_ps_enable) {
-		sme_debug("vdev:%d Cannot initiate PS. PS is disabled by usr(ioctl)",
-			  session_id);
-		return QDF_STATUS_E_FAILURE;
-	}
-	return QDF_STATUS_SUCCESS;
-}
-#endif
-
 /**
  * sme_enable_sta_ps_check(): Checks if it is ok to enable power save or not.
  * @mac_ctx: global mac context
@@ -346,33 +325,37 @@ static QDF_STATUS sme_ps_enable_user_check(bool usr_cfg_ps_enable,
  * Return: QDF_STATUS
  */
 QDF_STATUS sme_enable_sta_ps_check(struct mac_context *mac_ctx,
-				   uint32_t session_id, enum sme_ps_cmd command)
+				   uint32_t vdev_id, enum sme_ps_cmd command)
 {
-	struct wlan_mlme_powersave *powersave_params;
 	bool usr_cfg_ps_enable;
 
-	QDF_BUG(session_id < WLAN_MAX_VDEVS);
-	if (session_id >= WLAN_MAX_VDEVS)
+	QDF_BUG(vdev_id < WLAN_MAX_VDEVS);
+	if (vdev_id >= WLAN_MAX_VDEVS)
 		return QDF_STATUS_E_INVAL;
 
-	/* Check if Sta Ps is enabled. */
-	powersave_params = &mac_ctx->mlme_cfg->ps_params;
-	if (!powersave_params->is_bmps_enabled) {
-		sme_debug("Cannot initiate PS. PS is disabled in ini");
+	if (!mac_ctx->mlme_cfg->ps_params.is_bmps_enabled) {
+		sme_debug("vdev:%d power save mode is disabled via ini", vdev_id);
 		return QDF_STATUS_E_FAILURE;
 	}
 
-	usr_cfg_ps_enable = mlme_get_user_ps(mac_ctx->psoc, session_id);
-
-	if (sme_ps_enable_user_check(usr_cfg_ps_enable, command, session_id)
-	    != QDF_STATUS_SUCCESS)
+	usr_cfg_ps_enable = mlme_get_user_ps(mac_ctx->psoc, vdev_id);
+	if (command == SME_PS_ENABLE && !usr_cfg_ps_enable) {
+		sme_debug("vdev:%d power save mode is disabled by usr(ioctl)",
+			  vdev_id);
 		return QDF_STATUS_E_FAILURE;
+	}
+
+	/*
+	 * If command is power save disable there is not need to check for
+	 * connected or roaming state as firmware can handle this
+	 */
+	if (command == SME_PS_DISABLE)
+		return QDF_STATUS_SUCCESS;
 
-	/* Check whether the given session is Infra and in Connected State
-	 * also if command is power save disable  there is not need to check
-	 * for connected state as firmware can handle this
+	/* If command is power save enable, check whether the given session is
+	 * in connected or roaming state or not
 	 */
-	if (!cm_is_vdevid_connected(mac_ctx->pdev, session_id))
+	if (!cm_is_vdevid_active(mac_ctx->pdev, vdev_id))
 		return QDF_STATUS_E_FAILURE;
 
 	return QDF_STATUS_SUCCESS;
@@ -381,12 +364,12 @@ QDF_STATUS sme_enable_sta_ps_check(struct mac_context *mac_ctx,
 /**
  * sme_ps_enable_disable(): function to enable/disable PS.
  * @mac_handle: Opaque handle to the global MAC context
- * @session_id: session id
+ * @vdev_id: session id
  * sme_ps_cmd: power save message
  *
  * Return: QDF_STATUS
  */
-QDF_STATUS sme_ps_enable_disable(mac_handle_t mac_handle, uint32_t session_id,
+QDF_STATUS sme_ps_enable_disable(mac_handle_t mac_handle, uint32_t vdev_id,
 				 enum sme_ps_cmd command)
 {
 	QDF_STATUS status;
@@ -398,19 +381,19 @@ QDF_STATUS sme_ps_enable_disable(mac_handle_t mac_handle, uint32_t session_id,
 		return status;
 	}
 
-	status =  sme_enable_sta_ps_check(mac_ctx, session_id, command);
-	if (status != QDF_STATUS_SUCCESS) {
+	status =  sme_enable_sta_ps_check(mac_ctx, vdev_id, command);
+	if (QDF_IS_STATUS_ERROR(status)) {
 		/*
 		 * In non associated state driver won't handle the power save
-		 * But kernel expects return status success even
-		 * in the disconnected state.
+		 * But kernel expects return status success even in the
+		 * disconnected state.
 		 */
-		if (!cm_is_vdevid_connected(mac_ctx->pdev, session_id))
+		if (!cm_is_vdevid_active(mac_ctx->pdev, vdev_id))
 			status = QDF_STATUS_SUCCESS;
 		sme_release_global_lock(&mac_ctx->sme);
 		return status;
 	}
-	status = sme_ps_process_command(mac_ctx, session_id, command);
+	status = sme_ps_process_command(mac_ctx, vdev_id, command);
 	sme_release_global_lock(&mac_ctx->sme);
 
 	return status;