samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qcacmn: Converge on struct tdls_peer_update_state

Browse Source 
As part of the original TDLS componentization the legacy typedef
tTdlsPeerStateParams was replicated as qca-wifi-host-cmn struct
tdls_peer_state_params. Subsequently when the TDLS component was
relocated back to qcacld-3.0 this struct was replicated again as
struct tdls_peer_update_state in the qcacld-3.0 TDLS public structs.
Unfortunately this left the driver with three different data
structures which serve the same purpose. Not only is this pointless,
but due to the way in which these structures are used there is an
implicit requirement that they be exactly identical. Further
complicating matters is the fact that these three structures each have
embedded structs which are also replicated. This approach is very
fragile since any change to any of these structs must be replicated
across the entire set. To align with the converged software
architecture and to improve code maintainability exclusively use the
TDLS public structs.

Change-Id: Ifc976815fea57afae86cc91b91c6b48f70b2a9a7
CRs-Fixed: 2395340
This commit is contained in:
Jeff Johnson
2019-02-07 18:20:03 -08:00
committed by nshrivas
parent d9e53400e9
commit 1d002854d3
5 changed files with 50 additions and 123 deletions
Download Patch File Download Diff File Expand all files Collapse all files

65
wmi/inc/wmi_unified_sta_param.h
View File

@@ -99,73 +99,8 @@ struct wlm_latency_level_param {
uint16_t vdev_id;
};
#define WMI_TDLS_MAX_SUPP_CHANNELS 128
#define WMI_TDLS_MAX_SUPP_OPER_CLASSES 32
#define WMI_2_4_GHZ_MAX_FREQ 3000
/**
* struct tdls_update_ch_params - channel parameters
* @chanId: ID of the channel
* @pwr: power level
* @dfsSet: is dfs supported or not
* @half_rate: is the channel operating at 10MHz
* @quarter_rate: is the channel operating at 5MHz
*/
struct tdls_update_ch_params {
uint8_t chanId;
uint8_t pwr;
bool dfsSet;
bool half_rate;
bool quarter_rate;
};
/**
* struct tdls_peer_cap_params - TDLS peer capablities parameters
* @isPeerResponder: is peer responder or not
* @peerUapsdQueue: peer uapsd queue
* @peerMaxSp: peer max SP value
* @peerBuffStaSupport: peer buffer sta supported or not
* @peerOffChanSupport: peer offchannel support
* @peerCurrOperClass: peer current operating class
* @selfCurrOperClass: self current operating class
* @peerChanLen: peer channel length
* @peerChan: peer channel list
* @peerOperClassLen: peer operating class length
* @peerOperClass: peer operating class
* @prefOffChanNum: peer offchannel number
* @prefOffChanBandwidth: peer offchannel bandwidth
* @opClassForPrefOffChan: operating class for offchannel
*/
struct tdls_peer_cap_params {
uint8_t isPeerResponder;
uint8_t peerUapsdQueue;
uint8_t peerMaxSp;
uint8_t peerBuffStaSupport;
uint8_t peerOffChanSupport;
uint8_t peerCurrOperClass;
uint8_t selfCurrOperClass;
uint8_t peerChanLen;
struct tdls_update_ch_params peerChan[WMI_TDLS_MAX_SUPP_CHANNELS];
uint8_t peerOperClassLen;
uint8_t peerOperClass[WMI_TDLS_MAX_SUPP_OPER_CLASSES];
uint8_t prefOffChanNum;
uint8_t prefOffChanBandwidth;
uint8_t opClassForPrefOffChan;
};
/**
* struct tdls_peer_state_params - TDLS peer state parameters
* @vdevId: vdev id
* @peerMacAddr: peer mac address
* @peerCap: peer capabality
*/
struct tdls_peer_state_params {
uint32_t vdevId;
uint8_t peerMacAddr[IEEE80211_ADDR_LEN];
uint32_t peerState;
struct tdls_peer_cap_params peerCap;
};
/**
* struct vdev_ie_info_param - IE info
* @vdev_id - vdev for which the IE is being sent