samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qcacmn: Add TX completion ring desc sanity check

Browse Source 
Suspect HW update WBM2SW ring HP, but the ring entry contents are
not updated accordingly which then host will fetch one stale ring entry,
this makes other TX packet are freed unexpectedlly.

Add change to detect this situation earlier, if HW cookie conversion is
done, then invalidate 2nd dword for upper 32bits of VA, so next time when
reap this ring entry contents to know if this desc is updated by
HW or not. if HW cookie conversion is not done, then compare the PA in
buff_addr_info with PA in current TX desc to check.

Change-Id: I351eb4f860216fc618ff28736d4832fcec45dcc5
CRs-Fixed: 3345935
This commit is contained in:
Jinwei Chen
2022-11-30 02:14:31 -08:00
committed by Madan Koyyalamudi
parent 0456b0a11e
commit 1bf08f3566
7 changed files with 141 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
hal/wifi3.0/be/hal_be_tx.h
View File

@@ -570,6 +570,20 @@ static inline uint8_t hal_tx_comp_get_cookie_convert_done(void *hal_desc)
}
#endif
/**
* hal_tx_comp_set_desc_va_63_32() - Set bit 32~63 value for 64 bit VA
* @hal_desc: completion ring descriptor pointer
* @val: value to be set
*
* Return: None
*/
static inline void hal_tx_comp_set_desc_va_63_32(void *hal_desc, uint32_t val)
{
HAL_SET_FLD(hal_desc,
WBM2SW_COMPLETION_RING_TX,
BUFFER_VIRT_ADDR_63_32) = val;
}
/**
* hal_tx_comp_get_desc_va() - Get Desc virtual address within completion Desc
* @hal_desc: completion ring descriptor pointer
@@ -578,7 +592,7 @@ static inline uint8_t hal_tx_comp_get_cookie_convert_done(void *hal_desc)
*
* Return: TX desc virtual address
*/
static inline uintptr_t hal_tx_comp_get_desc_va(void *hal_desc)
static inline uint64_t hal_tx_comp_get_desc_va(void *hal_desc)
{
uint64_t va_from_desc;
@@ -590,7 +604,7 @@ static inline uintptr_t hal_tx_comp_get_desc_va(void *hal_desc)
WBM2SW_COMPLETION_RING_TX,
BUFFER_VIRT_ADDR_63_32)) << 32);
return (uintptr_t)va_from_desc;
return va_from_desc;
}
/*---------------------------------------------------------------------------