Ver código fonte

qcacld-3.0: Reduce unwanted netlink log messages

qcacld-2.0 to qcacld-3.0 propagation

Reduce unwanted netlink log messages and modify the error value
print format from hex to decimal.

Change-Id: Ia94efe17b80d5f3c4a7006b914f4f0586360fded
CRs-Fixed: 804176
(cherry picked from commit f986a945d7124c5bcc962dc0b7f0642828b7687f)
Anurag Chouhan 8 anos atrás
pai
commit
1a77236aa5

+ 4 - 3
core/utils/logging/src/wlan_logging_sock_svc.c

@@ -147,11 +147,12 @@ static int wlan_send_sock_msg_to_app(tAniHdr *wmsg, int radio,
 	wnl = (tAniNlHdr *) nlh;
 	wnl->radio = radio;
 	memcpy(&wnl->wmsg, wmsg, wmsg_length);
-	LOGGING_TRACE(QDF_TRACE_LEVEL_INFO,
-		      "%s: Sending Msg Type [0x%X] to pid[%d]\n",
-		      __func__, be16_to_cpu(wmsg->type), pid);
 
 	err = nl_srv_ucast(skb, pid, MSG_DONTWAIT);
+	if (err)
+		LOGGING_TRACE(QDF_TRACE_LEVEL_INFO,
+			"%s: Failed sending Msg Type [0x%X] to pid[%d]\n",
+			__func__, wmsg->type, pid);
 	return err;
 }
 

+ 1 - 1
core/utils/nlink/src/wlan_nlink_srv.c

@@ -352,7 +352,7 @@ int nl_srv_ucast(struct sk_buff *skb, int dst_pid, int flag)
 
 	if (err < 0)
 		QDF_TRACE(QDF_MODULE_ID_HDD, QDF_TRACE_LEVEL_WARN,
-			  "NLINK: netlink_unicast to pid[%d] failed, ret[0x%X]",
+			  "NLINK: netlink_unicast to pid[%d] failed, ret[%d]",
 			  dst_pid, err);
 
 	return err;

+ 4 - 3
core/utils/ptt/src/wlan_ptt_sock_svc.c

@@ -116,9 +116,6 @@ int ptt_sock_send_msg_to_app(tAniHdr *wmsg, int radio, int src_mod, int pid)
 	wnl = (tAniNlHdr *) nlh;
 	wnl->radio = radio;
 	memcpy(&wnl->wmsg, wmsg, wmsg_length);
-	PTT_TRACE(QDF_TRACE_LEVEL_INFO,
-		  "%s: Sending Msg Type [0x%X] to pid[%d]\n", __func__,
-		  be16_to_cpu(wmsg->type), pid);
 #ifdef PTT_SOCK_DEBUG_VERBOSE
 	ptt_sock_dump_buf((const unsigned char *)skb->data, skb->len);
 #endif
@@ -128,6 +125,10 @@ int ptt_sock_send_msg_to_app(tAniHdr *wmsg, int radio, int src_mod, int pid)
 	else
 		err = nl_srv_bcast(skb);
 
+	if (err)
+		PTT_TRACE(QDF_TRACE_LEVEL_INFO,
+			  "%s:Failed sending Msg Type [0x%X] to pid[%d]\n",
+			  __func__, be16_to_cpu(wmsg->type), pid);
 	return err;
 }