samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

touch: raydium: NULL pointer panic from TOUCH driver

Browse Source 
During Reboot,Cancel the work and destroy_workqueue and deallocate the
memory for g_raydium_ts in shutdown and remove callbacks.

Change-Id: I8ce1fa9814e3d85fde33d3241cec2f00755b9f06
Signed-off-by: Surya Teja Kudiri <quic_skudiri@quicinc.com>
This commit is contained in:
Surya Teja Kudiri
2023-02-10 13:50:51 +05:30
committed by Gerrit - the friendly Code Review server
parent 0ebf44a4f9
commit 1966defdcf
1 changed files with 13 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
raydium/raydium_driver.c
View File

@@ -2512,6 +2512,10 @@ exit_check_functionality_failed:
void raydium_ts_shutdown(struct i2c_client *client) void raydium_ts_shutdown(struct i2c_client *client)
{ {
if (g_raydium_ts->workqueue) {
destroy_workqueue(g_raydium_ts->workqueue);
g_raydium_ts->workqueue = NULL;
}
#if defined(CONFIG_FB) #if defined(CONFIG_FB)
raydium_unregister_notifier(); raydium_unregister_notifier();
#elif defined(CONFIG_HAS_EARLYSUSPEND) #elif defined(CONFIG_HAS_EARLYSUSPEND)
@@ -2541,18 +2545,22 @@ if (active_panel)
if (gpio_is_valid(g_raydium_ts->irq_gpio)) if (gpio_is_valid(g_raydium_ts->irq_gpio))
gpio_free(g_raydium_ts->irq_gpio); gpio_free(g_raydium_ts->irq_gpio);
cancel_work_sync(&g_raydium_ts->work);
destroy_workqueue(g_raydium_ts->workqueue);
raydium_enable_regulator(g_raydium_ts, false); raydium_enable_regulator(g_raydium_ts, false);
raydium_get_regulator(g_raydium_ts, false); raydium_get_regulator(g_raydium_ts, false);
kfree(g_raydium_ts);
i2c_set_clientdata(client, NULL); i2c_set_clientdata(client, NULL);
} }
static int raydium_ts_remove(struct i2c_client *client) static int raydium_ts_remove(struct i2c_client *client)
{ {
if (g_raydium_ts->workqueue) {
destroy_workqueue(g_raydium_ts->workqueue);
g_raydium_ts->workqueue = NULL;
}
#if defined(CONFIG_FB) #if defined(CONFIG_FB)
raydium_unregister_notifier(); raydium_unregister_notifier();
#elif defined(CONFIG_HAS_EARLYSUSPEND) #elif defined(CONFIG_HAS_EARLYSUSPEND)
@@ -2580,12 +2588,11 @@ if (active_panel)
if (gpio_is_valid(g_raydium_ts->irq_gpio)) if (gpio_is_valid(g_raydium_ts->irq_gpio))
gpio_free(g_raydium_ts->irq_gpio); gpio_free(g_raydium_ts->irq_gpio);
cancel_work_sync(&g_raydium_ts->work);
destroy_workqueue(g_raydium_ts->workqueue);
raydium_enable_regulator(g_raydium_ts, false); raydium_enable_regulator(g_raydium_ts, false);
raydium_get_regulator(g_raydium_ts, false); raydium_get_regulator(g_raydium_ts, false);
kfree(g_raydium_ts);
i2c_set_clientdata(client, NULL); i2c_set_clientdata(client, NULL);
return 0; return 0;
} }