samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qcacmn: Free mem leak in qmi bypass mode

Browse Source 
QMI bypass mode uses 2mb of of mem region for
fw uses. Current implementation does not free this
memory region when qmi bypass mode in enabled.
Free mem leak in qmi bypass mode.

Change-Id: Ie11aa9f20f93183e0b999cd6578aea4b231f8d8b
This commit is contained in:
Govind Singh
2020-10-12 12:21:15 +05:30
committed by snandini
parent 1e52a027ce
commit 183dd69628
3 changed files with 68 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

77
hif/src/ce/ce_main.c
View File

@@ -3490,7 +3490,6 @@ void hif_unconfig_ce(struct hif_softc *hif_sc)
*/
static void hif_post_static_buf_to_target(struct hif_softc *scn)
{
void *target_va;
phys_addr_t target_pa;
struct ce_info *ce_info_ptr;
uint32_t msi_data_start;
@@ -3499,15 +3498,19 @@ static void hif_post_static_buf_to_target(struct hif_softc *scn)
uint32_t i = 0;
int ret;
target_va = qdf_mem_alloc_consistent(scn->qdf_dev,
scn->qdf_dev->dev,
FW_SHARED_MEM +
sizeof(struct ce_info),
&target_pa);
if (!target_va)
scn->vaddr_qmi_bypass =
(uint32_t *)qdf_mem_alloc_consistent(scn->qdf_dev,
scn->qdf_dev->dev,
FW_SHARED_MEM,
&target_pa);
if (!scn->vaddr_qmi_bypass) {
hif_err("Memory allocation failed could not post target buf");
return;
}
ce_info_ptr = (struct ce_info *)target_va;
scn->paddr_qmi_bypass = target_pa;
ce_info_ptr = (struct ce_info *)scn->vaddr_qmi_bypass;
if (scn->vaddr_rri_on_ddr) {
ce_info_ptr->rri_over_ddr_low_paddr =
@@ -3531,7 +3534,26 @@ static void hif_post_static_buf_to_target(struct hif_softc *scn)
}
hif_write32_mb(scn, scn->mem + BYPASS_QMI_TEMP_REGISTER, target_pa);
hif_info("target va %pK target pa %pa", target_va, &target_pa);
hif_info("target va %pK target pa %pa", scn->vaddr_qmi_bypass,
&target_pa);
}
/**
* hif_cleanup_static_buf_to_target() - clean up static buffer to WLAN FW
* @scn: pointer to HIF structure
*
*
* Return: void
*/
void hif_cleanup_static_buf_to_target(struct hif_softc *scn)
{
void *target_va = scn->vaddr_qmi_bypass;
phys_addr_t target_pa = scn->paddr_qmi_bypass;
qdf_mem_free_consistent(scn->qdf_dev, scn->qdf_dev->dev,
FW_SHARED_MEM, target_va,
target_pa, 0);
hif_write32_mb(scn, scn->mem + BYPASS_QMI_TEMP_REGISTER, 0);
}
#else
/**
@@ -3544,17 +3566,38 @@ static void hif_post_static_buf_to_target(struct hif_softc *scn)
*/
static void hif_post_static_buf_to_target(struct hif_softc *scn)
{
void *target_va;
phys_addr_t target_pa;
qdf_dma_addr_t target_pa;
target_va = qdf_mem_alloc_consistent(scn->qdf_dev, scn->qdf_dev->dev,
FW_SHARED_MEM, &target_pa);
if (!target_va) {
scn->vaddr_qmi_bypass =
(uint32_t *)qdf_mem_alloc_consistent(scn->qdf_dev,
scn->qdf_dev->dev,
FW_SHARED_MEM,
&target_pa);
if (!scn->vaddr_qmi_bypass) {
hif_err("Memory allocation failed could not post target buf");
return;
}
scn->paddr_qmi_bypass = target_pa;
hif_write32_mb(scn, scn->mem + BYPASS_QMI_TEMP_REGISTER, target_pa);
hif_info("target va %pK target pa %pa", target_va, &target_pa);
}
/**
* hif_cleanup_static_buf_to_target() - clean up static buffer to WLAN FW
* @scn: pointer to HIF structure
*
*
* Return: void
*/
void hif_cleanup_static_buf_to_target(struct hif_softc *scn)
{
void *target_va = scn->vaddr_qmi_bypass;
phys_addr_t target_pa = scn->paddr_qmi_bypass;
qdf_mem_free_consistent(scn->qdf_dev, scn->qdf_dev->dev,
FW_SHARED_MEM, target_va,
target_pa, 0);
hif_write32_mb(snc, scn->mem + BYPASS_QMI_TEMP_REGISTER, 0);
}
#endif
@@ -3562,6 +3605,10 @@ static void hif_post_static_buf_to_target(struct hif_softc *scn)
static inline void hif_post_static_buf_to_target(struct hif_softc *scn)
{
}
void hif_cleanup_static_buf_to_target(struct hif_softc *scn)
{
}
#endif
static int hif_srng_sleep_state_adjust(struct hif_softc *scn, bool sleep_ok,