qcacld-3.0: Don't set ml caps for pre CAC SAP adapter

Currently pre CAC command is failing as host is trying
to start an ML SAP as part of pre CAC. As ML SAP + ML
SAP concurrency is not supported and the first SAP is
an ML SAP, it's not possible to start another ML SAP
for pre CAC.

To address this issue create a non-ml SAP as part of
pre CAC.
Also take RTNL lock for hdd_open_adapter and
hdd_close_adapter because vendor command tool doesn't
take RTNL lock but cfg80211_register_netdevice
and cfg80211_unregister_netdevice API's expect RTNL lock.

CRs-Fixed: 3627785
Change-Id: I84ac7674cbb0911258736b2aa7886b74bc9c8714

core/hdd/inc/wlan_hdd_mlo.h

@@ -35,6 +35,7 @@
  * @is_add_virtual_iface: is netdev create request from add virtual interface
  * @is_single_link: Is the adapter single link ML
  * @num_sessions: No of session to create on start adapter
+ * @is_pre_cac_adapter: is a pre cac adapter with associated netdev
  * @unused: Reserved spare bits
  */
 struct hdd_adapter_create_param {
@@ -44,7 +45,8 @@ struct hdd_adapter_create_param {
 		 is_add_virtual_iface:1,
 		 is_single_link:1,
 		 num_sessions:4,
-		 unused:23;
+		 is_pre_cac_adapter:1,
+		 unused:22;
 };
 
 #ifdef WLAN_FEATURE_11BE_MLO

core/hdd/src/wlan_hdd_hostapd.c

@@ -6219,7 +6219,8 @@ static QDF_STATUS wlan_hdd_mlo_update(struct wlan_hdd_link_info *link_info)
 		wlan_hdd_get_mlo_link_id(beacon, &link_id, &num_link);
 		hdd_debug("MLO SAP vdev id %d, link id %d total link %d",
 			  link_info->vdev_id, link_id, num_link);
-		if (!num_link) {
+		if (!num_link || !link_info->vdev->mlo_dev_ctx ||
+		    !link_info->vdev->mlo_dev_ctx->ap_ctx) {
 			hdd_debug("start 11be AP without mlo");
 			return QDF_STATUS_SUCCESS;
 		}

core/hdd/src/wlan_hdd_main.c

@@ -8810,7 +8810,8 @@ struct hdd_adapter *hdd_open_adapter(struct hdd_context *hdd_ctx,
 		INIT_WORK(&adapter->ipv6_notifier_work,
 			  hdd_ipv6_notifier_work_queue);
 #endif
-		wlan_hdd_set_ml_cap_for_sap_intf(params, session_type);
+		if (!params->is_pre_cac_adapter)
+			wlan_hdd_set_ml_cap_for_sap_intf(params, session_type);
 		break;
 	case QDF_FTM_MODE:
 		adapter = hdd_alloc_station_adapter(hdd_ctx, mac_addr,

core/hdd/src/wlan_hdd_pre_cac.c

@@ -215,7 +215,7 @@ static int __wlan_hdd_request_pre_cac(struct hdd_context *hdd_ctx,
 	uint8_t *mac_addr = NULL;
 	uint32_t pre_cac_chan_freq = 0;
 	int ret;
-	struct hdd_adapter *ap_adapter, *pre_cac_adapter;
+	struct hdd_adapter *ap_adapter, *pre_cac_adapter = NULL;
 	struct hdd_ap_ctx *hdd_ap_ctx, *pre_cac_ap_ctx;
 	QDF_STATUS status;
 	struct wiphy *wiphy;
@@ -226,6 +226,7 @@ static int __wlan_hdd_request_pre_cac(struct hdd_context *hdd_ctx,
 	enum phy_ch_width cac_ch_width;
 	struct hdd_adapter_create_param params = {0};
 	struct wlan_hdd_link_info *pre_cac_link_info, *link_info;
+	bool is_rtnl_locked = false;
 
 	if (!policy_mgr_is_hw_dbs_capable(hdd_ctx->psoc)) {
 		hdd_debug("Pre CAC is not supported on non-dbs platforms");
@@ -302,11 +303,16 @@ static int __wlan_hdd_request_pre_cac(struct hdd_context *hdd_ctx,
 	 * feature announcement to not use this temporary interface for
 	 * any activity from user space.
 	 */
+
 	params.is_add_virtual_iface = 1;
-	pre_cac_adapter = hdd_open_adapter(hdd_ctx, QDF_SAP_MODE,
-					   SAP_PRE_CAC_IFNAME, mac_addr,
-					   NET_NAME_UNKNOWN, true,
-					   &params);
+	params.is_pre_cac_adapter = 1;
+	if (rtnl_trylock()) {
+		pre_cac_adapter = hdd_open_adapter(hdd_ctx, QDF_SAP_MODE,
+						   SAP_PRE_CAC_IFNAME,
+						   mac_addr, NET_NAME_UNKNOWN,
+						   true, &params);
+		rtnl_unlock();
+	}
 
 	if (!pre_cac_adapter) {
 		hdd_err("error opening the pre cac adapter");
@@ -427,7 +433,13 @@ stop_close_pre_cac_adapter:
 	qdf_mem_free(pre_cac_ap_ctx->beacon);
 	pre_cac_ap_ctx->beacon = NULL;
 close_pre_cac_adapter:
+	if (rtnl_trylock())
+		is_rtnl_locked = true;
+
 	hdd_close_adapter(hdd_ctx, pre_cac_adapter, true);
+
+	if (is_rtnl_locked)
+		rtnl_unlock();
 release_intf_addr_and_return_failure:
 	/*
 	 * Release the interface address as the adapter