qcacld-3.0: Resolve static analyzer issues

This change resolves following static analysis issues:
1. Using uint32_t and enumeration as operands to logical AND
operator (&&) is not allowed by the static analyzer tool.
Convert them to bool and use.
2. Overwriting the variable previous value before using it.
3. sizeof(key_alloc_buf[k]) returns 4/8 bytes as key_alloc_buf[k]
   contains pointer. Use sizeof(*key_alloc_buf[k]) to get right
   size of the object and use it to mem_zero the buffer.

Change-Id: I6faa5b3ff6847786a7f6ac525ccb0e5f60dbd020
CRs-Fixed: 3646512

components/umac/mlme/connection_mgr/core/src/wlan_cm_roam_fw_sync.c

@@ -447,7 +447,7 @@ cm_roam_update_mlo_mgr_info(struct wlan_objmgr_vdev *vdev,
 
 		channel.ch_freq = ml_link->channel.mhz;
 		channel.ch_cfreq1 = ml_link->channel.band_center_freq1;
-		channel.ch_cfreq1 = ml_link->channel.band_center_freq2;
+		channel.ch_cfreq2 = ml_link->channel.band_center_freq2;
 
 		/*
 		 * Update Link switch context for each vdev with roamed AP link

components/wmi/src/wmi_unified_roam_tlv.c

@@ -4132,7 +4132,7 @@ free_keys:
 			continue;
 
 		wmi_debug("Free key allocated at idx:%d", k);
-		qdf_mem_zero(key_alloc_buf[k], sizeof(key_alloc_buf[k]));
+		qdf_mem_zero(key_alloc_buf[k], sizeof(*key_alloc_buf[k]));
 		qdf_mem_free(key_alloc_buf[k]);
 	}
 

core/hdd/src/wlan_hdd_cfg80211.c

@@ -28695,7 +28695,7 @@ static int __wlan_hdd_cfg80211_set_bitrate_mask(struct wiphy *wiphy,
 			nss = 0;
 			if (band == NL80211_BAND_5GHZ)
 				rate_index += 4;
-			if (rate_index >= 0 && rate_index < 4)
+			if (rate_index < 4)
 				bit_rate = hdd_assemble_rate_code(
 					WMI_RATE_PREAMBLE_CCK, nss,
 					hdd_legacy_rates[rate_index].hw_value);

core/wma/src/wma_power.c

@@ -729,7 +729,7 @@ void wma_enable_sta_ps_mode(tpEnablePsParams ps_req)
 					vdev_id, uapsd_val);
 		}
 
-		if (ps_params.opm_mode && iface->uapsd_cached_val) {
+		if (!!ps_params.opm_mode && !!iface->uapsd_cached_val) {
 			ps_params.opm_mode = WMI_STA_PS_OPM_CONSERVATIVE;
 			wma_debug("Qpower is disabled");
 		}
@@ -911,7 +911,7 @@ void wma_enable_uapsd_mode(tp_wma_handle wma, tpEnableUapsdParams ps_req)
 		return;
 	}
 
-	if (ps_params.opm_mode && uapsd_val) {
+	if (!!ps_params.opm_mode && !!uapsd_val) {
 		ps_params.opm_mode = 0;
 		wma_debug("Disable power %d", vdev_id);
 	}