From 1482ae414051f36c6562b35950263d595fa3a067 Mon Sep 17 00:00:00 2001 From: Jeff Johnson Date: Sat, 2 Feb 2019 18:29:24 -0800 Subject: [PATCH] qcacld-3.0: Replace typedef tSirTsmIE The Linux Coding Style enumerates a few special cases where typedefs are useful, but stresses "NEVER EVER use a typedef unless you can clearly match one of those rules." The tSirTsmIE typedef does not meet any of those criteria, so replace it (and the "tp" variant) with a reference to the underlying struct. Further note the Linux Coding Style frowns upon mixed-case names and so-called Hungarian notation, so in conjunction rename the underlying struct to be in compliance. Change-Id: I9c0784f93fa67b571bb816ded4a137f4435accfc CRs-Fixed: 2394249 --- core/mac/inc/sir_api.h | 7 ++++--- core/sme/inc/csr_api.h | 2 +- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/core/mac/inc/sir_api.h b/core/mac/inc/sir_api.h index 57a23a9963..c4a60975ae 100644 --- a/core/mac/inc/sir_api.h +++ b/core/mac/inc/sir_api.h @@ -778,13 +778,14 @@ typedef struct sESETspecTspecInfo { tTspecInfo tspec[SIR_ESE_MAX_TSPEC_IES]; } tESETspecInfo; -typedef struct sSirTsmIE { +struct tsm_ie { uint8_t tsid; uint8_t state; uint16_t msmt_interval; -} tSirTsmIE, *tpSirTsmIE; +}; + typedef struct sSirSmeTsmIEInd { - tSirTsmIE tsmIe; + struct tsm_ie tsmIe; uint8_t sessionId; } tSirSmeTsmIEInd, *tpSirSmeTsmIEInd; typedef struct sAniTrafStrmMetrics { diff --git a/core/sme/inc/csr_api.h b/core/sme/inc/csr_api.h index a666f4e081..8685e7d3a3 100644 --- a/core/sme/inc/csr_api.h +++ b/core/sme/inc/csr_api.h @@ -1095,7 +1095,7 @@ struct csr_roam_info { uint32_t dtimPeriod; #ifdef FEATURE_WLAN_ESE bool isESEAssoc; - tSirTsmIE tsmIe; + struct tsm_ie tsmIe; uint32_t timestamp[2]; uint16_t tsmRoamDelay; tSirEseBcnReportRsp *pEseBcnReportRsp;