Browse Source

qcacld-3.0: Replace typedef tSirTsmIE

The Linux Coding Style enumerates a few special cases where typedefs
are useful, but stresses "NEVER EVER use a typedef unless you can
clearly match one of those rules." The tSirTsmIE typedef does not meet
any of those criteria, so replace it (and the "tp" variant) with a
reference to the underlying struct.

Further note the Linux Coding Style frowns upon mixed-case names
and so-called Hungarian notation, so in conjunction rename the
underlying struct to be in compliance.

Change-Id: I9c0784f93fa67b571bb816ded4a137f4435accfc
CRs-Fixed: 2394249
Jeff Johnson 6 years ago
parent
commit
1482ae4140
2 changed files with 5 additions and 4 deletions
  1. 4 3
      core/mac/inc/sir_api.h
  2. 1 1
      core/sme/inc/csr_api.h

+ 4 - 3
core/mac/inc/sir_api.h

@@ -778,13 +778,14 @@ typedef struct sESETspecTspecInfo {
 	tTspecInfo tspec[SIR_ESE_MAX_TSPEC_IES];
 } tESETspecInfo;
 
-typedef struct sSirTsmIE {
+struct tsm_ie {
 	uint8_t tsid;
 	uint8_t state;
 	uint16_t msmt_interval;
-} tSirTsmIE, *tpSirTsmIE;
+};
+
 typedef struct sSirSmeTsmIEInd {
-	tSirTsmIE tsmIe;
+	struct tsm_ie tsmIe;
 	uint8_t sessionId;
 } tSirSmeTsmIEInd, *tpSirSmeTsmIEInd;
 typedef struct sAniTrafStrmMetrics {

+ 1 - 1
core/sme/inc/csr_api.h

@@ -1095,7 +1095,7 @@ struct csr_roam_info {
 	uint32_t dtimPeriod;
 #ifdef FEATURE_WLAN_ESE
 	bool isESEAssoc;
-	tSirTsmIE tsmIe;
+	struct tsm_ie tsmIe;
 	uint32_t timestamp[2];
 	uint16_t tsmRoamDelay;
 	tSirEseBcnReportRsp *pEseBcnReportRsp;