Kaynağa Gözat

Merge "video-driver: Add comments to the logs"

qctecmdr 1 yıl önce
ebeveyn
işleme
13af8a0783

+ 1 - 1
driver/variant/iris33/src/msm_vidc_iris33.c

@@ -1359,7 +1359,7 @@ static int __boot_firmware_iris33(struct msm_vidc_core *core)
 	}
 
 	if (count >= max_tries) {
-		d_vpr_e("Error booting up vidc firmware, ctrl status %#x, ctrl init %#x\n",
+		d_vpr_e(FMT_STRING_BOOT_FIRMWARE_ERROR,
 			ctrl_status, ctrl_init_val);
 		return -ETIME;
 	}

+ 5 - 1
driver/vidc/inc/msm_vidc_debug.h

@@ -1,7 +1,7 @@
 /* SPDX-License-Identifier: GPL-2.0-only */
 /*
  * Copyright (c) 2020-2021, The Linux Foundation. All rights reserved.
- * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2023-2024, Qualcomm Innovation Center, Inc. All rights reserved.
  */
 
 #ifndef __MSM_VIDC_DEBUG__
@@ -56,6 +56,10 @@ extern bool msm_vidc_synx_fence_enable;
 	"%s: faulting address: %lx\n"
 #define FMT_STRING_SET_CAP \
 	"set cap: name: %24s, cap value: %#10x, hfi: %#10llx\n"
+#define FMT_STRING_SYSTEM_ERROR \
+	"%s: system error received\n"
+#define FMT_STRING_BOOT_FIRMWARE_ERROR \
+	"Error booting up vidc firmware, ctrl status %#x, ctrl init %#x\n"
 
 /* To enable messages OR these values and
  * echo the result to debugfs file.

+ 1 - 1
driver/vidc/src/venus_hfi_response.c

@@ -383,7 +383,7 @@ int handle_system_error(struct msm_vidc_core *core,
 {
 	bool bug_on = false;
 
-	d_vpr_e("%s: system error received\n", __func__);
+	d_vpr_e(FMT_STRING_SYSTEM_ERROR, __func__);
 	print_sfr_message(core);
 
 	if (pkt) {