samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qcacmn: Optimize schedule msg post error logging

Browse Source 
This change will reduce the repeated logging of scheduler posts

Change-Id: I26c297d2d3def55377f062a2de94f61cf09522de
CRs-Fixed: 2373005
This commit is contained in:
Madhvapathi Sriram
2018-12-19 12:50:25 +05:30
committed by nshrivas
parent 84da07f17e
commit 1397a33f48
3 changed files with 32 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
scheduler/inc/scheduler_api.h
View File

@@ -1,5 +1,5 @@
/* /*
* Copyright (c) 2014-2018 The Linux Foundation. All rights reserved. * Copyright (c) 2014-2019 The Linux Foundation. All rights reserved.
* *
* Permission to use, copy, modify, and/or distribute this software for * Permission to use, copy, modify, and/or distribute this software for
* any purpose with or without fee is hereby granted, provided that the * any purpose with or without fee is hereby granted, provided that the
@@ -188,14 +188,16 @@ static inline QDF_STATUS scheduler_post_msg(uint32_t qid,
* scheduler_post_msg * scheduler_post_msg
* Return: QDF status * Return: QDF status
*/ */
static inline QDF_STATUS scheduler_post_message(QDF_MODULE_ID src_id, QDF_STATUS scheduler_post_message_debug(QDF_MODULE_ID src_id,
QDF_MODULE_ID dest_id, QDF_MODULE_ID dest_id,
QDF_MODULE_ID que_id, QDF_MODULE_ID que_id,
struct scheduler_msg *msg) struct scheduler_msg *msg,
{ int line,
return scheduler_post_msg(scheduler_get_qid(src_id, dest_id, que_id), const char *func);
msg);
} #define scheduler_post_message(src_id, dest_id, que_id, msg) \
scheduler_post_message_debug(src_id, dest_id, que_id, msg, \
__LINE__, __func__)
/** /**
* scheduler_resume() - resume scheduler thread * scheduler_resume() - resume scheduler thread

19
scheduler/src/scheduler_api.c
View File

@@ -661,3 +661,22 @@ QDF_STATUS scheduler_get_queue_size(QDF_MODULE_ID qid, uint32_t *size)
return QDF_STATUS_SUCCESS; return QDF_STATUS_SUCCESS;
} }
QDF_STATUS scheduler_post_message_debug(QDF_MODULE_ID src_id,
QDF_MODULE_ID dest_id,
QDF_MODULE_ID que_id,
struct scheduler_msg *msg,
int line,
const char *func)
{
QDF_STATUS status;
status = scheduler_post_msg(scheduler_get_qid(src_id, dest_id, que_id),
msg);
if (QDF_IS_STATUS_ERROR(status))
sched_err("couldn't post from %d to %d - called from %d, %s",
src_id, dest_id, line, func);
return status;
}

9
umac/scan/dispatcher/src/wlan_scan_ucfg_api.c
View File

@@ -989,7 +989,6 @@ ucfg_scan_start(struct scan_start_request *req)
QDF_MODULE_ID_OS_IF, &msg); QDF_MODULE_ID_OS_IF, &msg);
if (QDF_IS_STATUS_ERROR(status)) { if (QDF_IS_STATUS_ERROR(status)) {
wlan_objmgr_vdev_release_ref(req->vdev, WLAN_SCAN_ID); wlan_objmgr_vdev_release_ref(req->vdev, WLAN_SCAN_ID);
scm_err("failed to post to QDF_MODULE_ID_OS_IF");
scm_scan_free_scan_request_mem(req); scm_scan_free_scan_request_mem(req);
} }
@@ -1182,10 +1181,8 @@ ucfg_scan_cancel(struct scan_cancel_request *req)
status = scheduler_post_message(QDF_MODULE_ID_OS_IF, status = scheduler_post_message(QDF_MODULE_ID_OS_IF,
QDF_MODULE_ID_SCAN, QDF_MODULE_ID_SCAN,
QDF_MODULE_ID_OS_IF, &msg); QDF_MODULE_ID_OS_IF, &msg);
if (QDF_IS_STATUS_ERROR(status)) { if (QDF_IS_STATUS_ERROR(status))
scm_err("failed to post to QDF_MODULE_ID_OS_IF");
goto vdev_put; goto vdev_put;
}
return QDF_STATUS_SUCCESS; return QDF_STATUS_SUCCESS;
@@ -1224,10 +1221,8 @@ ucfg_scan_cancel_sync(struct scan_cancel_request *req)
vdev = req->vdev; vdev = req->vdev;
status = ucfg_scan_cancel(req); status = ucfg_scan_cancel(req);
if (QDF_IS_STATUS_ERROR(status)) { if (QDF_IS_STATUS_ERROR(status))
scm_err("failed to post to QDF_MODULE_ID_OS_IF");
return status; return status;
}
memset(&cancel_scan_event, 0, sizeof(cancel_scan_event)); memset(&cancel_scan_event, 0, sizeof(cancel_scan_event));
/* /*