Selaa lähdekoodia

qcacld-3.0: Use qdf_mem_zero for zero initialization

Use qdf_mem_zero for zero initialization.

Change-Id: Ic2b8d907623cf67a4569aaf01398c1b3a2bff707
CRs-Fixed: 2376644
hangtian 6 vuotta sitten
vanhempi
sitoutus
127c953c7f
50 muutettua tiedostoa jossa 341 lisäystä ja 348 poistoa
  1. 6 5
      components/ipa/core/src/wlan_ipa_core.c
  2. 3 3
      components/ipa/core/src/wlan_ipa_rm.c
  3. 2 2
      components/p2p/core/src/wlan_p2p_off_chan_tx.c
  4. 2 2
      components/pmo/core/src/wlan_pmo_mc_addr_filtering.c
  5. 2 2
      components/pmo/core/src/wlan_pmo_suspend_resume.c
  6. 2 2
      components/tdls/core/src/wlan_tdls_ct.c
  7. 7 7
      core/bmi/src/bmi.c
  8. 6 6
      core/bmi/src/bmi_1.c
  9. 2 2
      core/cds/src/cds_sched.c
  10. 5 5
      core/dp/htt/htt.c
  11. 4 4
      core/dp/txrx/ol_rx.c
  12. 2 2
      core/dp/txrx/ol_rx_fwd.c
  13. 1 1
      core/dp/txrx/ol_txrx.c
  14. 2 2
      core/dp/txrx/ol_txrx_internal.h
  15. 2 2
      core/dp/txrx3.0/dp_rx_thread.c
  16. 2 2
      core/hdd/src/wlan_hdd_assoc.c
  17. 5 5
      core/hdd/src/wlan_hdd_main.c
  18. 1 1
      core/hdd/src/wlan_hdd_tx_rx.c
  19. 2 2
      core/mac/src/dph/dph_hash_table.c
  20. 4 4
      core/mac/src/pe/lim/lim_admit_control.c
  21. 20 21
      core/mac/src/pe/lim/lim_api.c
  22. 10 10
      core/mac/src/pe/lim/lim_assoc_utils.c
  23. 2 3
      core/mac/src/pe/lim/lim_ft.c
  24. 2 2
      core/mac/src/pe/lim/lim_ft_preauth.c
  25. 6 6
      core/mac/src/pe/lim/lim_ibss_peer_mgmt.c
  26. 2 2
      core/mac/src/pe/lim/lim_process_assoc_req_frame.c
  27. 4 4
      core/mac/src/pe/lim/lim_process_cfg_updates.c
  28. 2 2
      core/mac/src/pe/lim/lim_process_mlm_rsp_messages.c
  29. 19 19
      core/mac/src/pe/lim/lim_process_tdls.c
  30. 5 5
      core/mac/src/pe/lim/lim_send_frames_host_roam.c
  31. 44 44
      core/mac/src/pe/lim/lim_send_management_frames.c
  32. 21 21
      core/mac/src/pe/lim/lim_session.c
  33. 10 12
      core/mac/src/pe/lim/lim_utils.c
  34. 2 2
      core/mac/src/pe/rrm/rrm_api.c
  35. 2 2
      core/mac/src/pe/sch/sch_api.c
  36. 5 5
      core/mac/src/pe/sch/sch_beacon_gen.c
  37. 1 1
      core/mac/src/sys/legacy/src/system/src/sys_entry_func.c
  38. 17 17
      core/mac/src/sys/legacy/src/utils/src/parser_api.c
  39. 2 2
      core/sap/src/sap_ch_select.c
  40. 13 13
      core/sme/src/common/sme_api.c
  41. 1 1
      core/sme/src/common/sme_ft_api.c
  42. 66 70
      core/sme/src/csr/csr_api_roam.c
  43. 1 1
      core/sme/src/csr/csr_api_scan.c
  44. 3 3
      core/sme/src/csr/csr_neighbor_roam.c
  45. 2 2
      core/sme/src/csr/csr_util.c
  46. 6 6
      core/wma/src/wma_data.c
  47. 2 2
      core/wma/src/wma_dev_if.c
  48. 1 1
      core/wma/src/wma_features.c
  49. 6 6
      core/wma/src/wma_mgmt.c
  50. 2 2
      core/wma/src/wma_scan_roam.c

+ 6 - 5
components/ipa/core/src/wlan_ipa_core.c

@@ -229,7 +229,7 @@ static void wlan_ipa_send_pkt_to_tl(
 
 	skb = QDF_IPA_RX_DATA_SKB(ipa_tx_desc);
 
-	qdf_mem_set(skb->cb, sizeof(skb->cb), 0);
+	qdf_mem_zero(skb->cb, sizeof(skb->cb));
 
 	/* Store IPA Tx buffer ownership into SKB CB */
 	qdf_nbuf_ipa_owned_set(skb);
@@ -663,7 +663,7 @@ static void wlan_ipa_forward(struct wlan_ipa_priv *ipa_ctx,
 	if (ipa_ctx->suspended) {
 		qdf_spin_unlock_bh(&ipa_ctx->pm_lock);
 		ipa_info_rl("Tx in suspend, put in queue");
-		qdf_mem_set(skb->cb, sizeof(skb->cb), 0);
+		qdf_mem_zero(skb->cb, sizeof(skb->cb));
 		pm_tx_cb = (struct wlan_ipa_pm_tx_cb *)skb->cb;
 		pm_tx_cb->exception = true;
 		pm_tx_cb->iface_context = iface_ctx;
@@ -911,7 +911,7 @@ static void __wlan_ipa_i2w_cb(void *priv, qdf_ipa_dp_evt_type_t evt,
 	 * progress.
 	 */
 	if (ipa_ctx->suspended) {
-		qdf_mem_set(skb->cb, sizeof(skb->cb), 0);
+		qdf_mem_zero(skb->cb, sizeof(skb->cb));
 		pm_tx_cb = (struct wlan_ipa_pm_tx_cb *)skb->cb;
 		pm_tx_cb->iface_context = iface_context;
 		pm_tx_cb->ipa_tx_desc = ipa_tx_desc;
@@ -1094,8 +1094,9 @@ static bool wlan_ipa_uc_find_add_assoc_sta(struct wlan_ipa_priv *ipa_ctx,
 				ipa_ctx->assoc_stas_map[idx].is_reserved =
 					false;
 				ipa_ctx->assoc_stas_map[idx].sta_id = 0xFF;
-				qdf_mem_set(&ipa_ctx->assoc_stas_map[idx].
-					    mac_addr, 0, QDF_NET_ETH_LEN);
+				qdf_mem_zero(
+					&ipa_ctx->assoc_stas_map[idx].mac_addr,
+					QDF_NET_ETH_LEN);
 				return sta_found;
 			}
 		}

+ 3 - 3
components/ipa/core/src/wlan_ipa_rm.c

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2013-2018 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2013-2019 The Linux Foundation. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -419,7 +419,7 @@ QDF_STATUS wlan_ipa_wdi_setup_rm(struct wlan_ipa_priv *ipa_ctx)
 
 	qdf_create_work(0, &ipa_ctx->uc_rm_work.work,
 			wlan_ipa_uc_rm_notify_defer, ipa_ctx);
-	qdf_mem_set(&create_params, 0, sizeof(create_params));
+	qdf_mem_zero(&create_params, sizeof(create_params));
 	create_params.name = QDF_IPA_RM_RESOURCE_WLAN_PROD;
 	create_params.reg_params.user_data = ipa_ctx;
 	create_params.reg_params.notify_cb = wlan_ipa_rm_notify;
@@ -431,7 +431,7 @@ QDF_STATUS wlan_ipa_wdi_setup_rm(struct wlan_ipa_priv *ipa_ctx)
 		goto setup_rm_fail;
 	}
 
-	qdf_mem_set(&create_params, 0, sizeof(create_params));
+	qdf_mem_zero(&create_params, sizeof(create_params));
 	create_params.name = QDF_IPA_RM_RESOURCE_WLAN_CONS;
 	create_params.request_resource = wlan_ipa_rm_cons_request;
 	create_params.release_resource = wlan_ipa_rm_cons_release;

+ 2 - 2
components/p2p/core/src/wlan_p2p_off_chan_tx.c

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2017-2018 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2017-2019 The Linux Foundation. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -830,7 +830,7 @@ static QDF_STATUS p2p_packet_alloc(uint16_t size, void **data,
 		qdf_nbuf_set_protocol(nbuf, ETH_P_CONTROL);
 		*ppPacket = nbuf;
 		*data = qdf_nbuf_data(nbuf);
-		qdf_mem_set(*data, size, 0);
+		qdf_mem_zero(*data, size);
 		status = QDF_STATUS_SUCCESS;
 	}
 

+ 2 - 2
components/pmo/core/src/wlan_pmo_mc_addr_filtering.c

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2017-2018 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2017-2019 The Linux Foundation. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -66,7 +66,7 @@ static void pmo_core_fill_mc_list(struct pmo_vdev_priv_obj **vdev_ctx,
 			continue;
 		}
 		qdf_spin_lock_bh(&temp_ctx->pmo_vdev_lock);
-		qdf_mem_set(&(op_list->mc_addr[i].bytes), 0,
+		qdf_mem_zero(&(op_list->mc_addr[i].bytes),
 			QDF_MAC_ADDR_SIZE);
 		qdf_mem_copy(&(op_list->mc_addr[i].bytes),
 			ip->mc_addr[i].bytes, QDF_MAC_ADDR_SIZE);

+ 2 - 2
components/pmo/core/src/wlan_pmo_suspend_resume.c

@@ -302,8 +302,8 @@ void pmo_core_configure_dynamic_wake_events(struct wlan_objmgr_psoc *psoc)
 		enable_configured = false;
 		disable_configured = false;
 
-		qdf_mem_set(enable_mask,  sizeof(uint32_t) * BM_LEN, 0);
-		qdf_mem_set(disable_mask, sizeof(uint32_t) * BM_LEN, 0);
+		qdf_mem_zero(enable_mask,  sizeof(uint32_t) * BM_LEN);
+		qdf_mem_zero(disable_mask, sizeof(uint32_t) * BM_LEN);
 
 		vdev = pmo_psoc_get_vdev(psoc, vdev_id);
 		if (!vdev)

+ 2 - 2
components/tdls/core/src/wlan_tdls_ct.c

@@ -229,8 +229,8 @@ static void tdls_ct_sampling_tx_rx(struct tdls_vdev_priv_obj *tdls_vdev,
 	qdf_mem_copy(mac_table, tdls_vdev->ct_peer_table,
 	       (sizeof(struct tdls_conn_tracker_mac_table)) * mac_entries);
 
-	qdf_mem_set(tdls_vdev->ct_peer_table,
-	       (sizeof(struct tdls_conn_tracker_mac_table)) * mac_entries, 0);
+	qdf_mem_zero(tdls_vdev->ct_peer_table,
+	       (sizeof(struct tdls_conn_tracker_mac_table)) * mac_entries);
 
 	tdls_vdev->valid_mac_entries = 0;
 

+ 7 - 7
core/bmi/src/bmi.c

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2014-2018 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2014-2019 The Linux Foundation. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -253,8 +253,8 @@ QDF_STATUS bmi_read_soc_register(uint32_t address, uint32_t *param,
 	qdf_dma_addr_t rsp = info->bmi_rsp_da;
 
 	bmi_assert(BMI_COMMAND_FITS(sizeof(cid) + sizeof(address)));
-	qdf_mem_set(bmi_cmd_buff, 0, sizeof(cid) + sizeof(address));
-	qdf_mem_set(bmi_rsp_buff, 0, sizeof(cid) + sizeof(address));
+	qdf_mem_zero(bmi_cmd_buff, sizeof(cid) + sizeof(address));
+	qdf_mem_zero(bmi_rsp_buff, sizeof(cid) + sizeof(address));
 
 	if (info->bmi_done) {
 		BMI_DBG("Command disallowed");
@@ -298,7 +298,7 @@ QDF_STATUS bmi_write_soc_register(uint32_t address, uint32_t param,
 	qdf_dma_addr_t rsp = info->bmi_rsp_da;
 
 	bmi_assert(BMI_COMMAND_FITS(size));
-	qdf_mem_set(bmi_cmd_buff, 0, size);
+	qdf_mem_zero(bmi_cmd_buff, size);
 
 	if (info->bmi_done) {
 		BMI_DBG("Command disallowed");
@@ -343,7 +343,7 @@ bmilz_data(uint8_t *buffer, uint32_t length, struct ol_context *ol_ctx)
 	qdf_dma_addr_t rsp = info->bmi_rsp_da;
 
 	bmi_assert(BMI_COMMAND_FITS(BMI_DATASZ_MAX + header));
-	qdf_mem_set(bmi_cmd_buff, 0, BMI_DATASZ_MAX + header);
+	qdf_mem_zero(bmi_cmd_buff, BMI_DATASZ_MAX + header);
 
 	if (info->bmi_done) {
 		BMI_ERR("Command disallowed");
@@ -400,7 +400,7 @@ QDF_STATUS bmi_sign_stream_start(uint32_t address, uint8_t *buffer,
 	qdf_dma_addr_t rsp = info->bmi_rsp_da;
 
 	bmi_assert(BMI_COMMAND_FITS(BMI_DATASZ_MAX + header));
-	qdf_mem_set(bmi_cmd_buff, 0, BMI_DATASZ_MAX + header);
+	qdf_mem_zero(bmi_cmd_buff, BMI_DATASZ_MAX + header);
 
 	if (info->bmi_done) {
 		BMI_ERR("Command disallowed");
@@ -463,7 +463,7 @@ bmilz_stream_start(uint32_t address, struct ol_context *ol_ctx)
 	qdf_dma_addr_t rsp = info->bmi_rsp_da;
 
 	bmi_assert(BMI_COMMAND_FITS(sizeof(cid) + sizeof(address)));
-	qdf_mem_set(bmi_cmd_buff, 0, sizeof(cid) + sizeof(address));
+	qdf_mem_zero(bmi_cmd_buff, sizeof(cid) + sizeof(address));
 
 	if (info->bmi_done) {
 		BMI_DBG("Command disallowed");

+ 6 - 6
core/bmi/src/bmi_1.c

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2014-2018 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2014-2019 The Linux Foundation. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -49,9 +49,9 @@ bmi_read_memory(uint32_t address,
 
 	bmi_assert(BMI_COMMAND_FITS(BMI_DATASZ_MAX + sizeof(cid) +
 			sizeof(address) + sizeof(length)));
-	qdf_mem_set(bmi_cmd_buff, 0, BMI_DATASZ_MAX + sizeof(cid) +
+	qdf_mem_zero(bmi_cmd_buff, BMI_DATASZ_MAX + sizeof(cid) +
 			sizeof(address) + sizeof(length));
-	qdf_mem_set(bmi_rsp_buff, 0, BMI_DATASZ_MAX + sizeof(cid) +
+	qdf_mem_zero(bmi_rsp_buff, BMI_DATASZ_MAX + sizeof(cid) +
 			sizeof(address) + sizeof(length));
 
 	cid = BMI_READ_MEMORY;
@@ -120,7 +120,7 @@ QDF_STATUS bmi_write_memory(uint32_t address, uint8_t *buffer, uint32_t length,
 	}
 
 	bmi_assert(BMI_COMMAND_FITS(BMI_DATASZ_MAX + header));
-	qdf_mem_set(bmi_cmd_buff, 0, BMI_DATASZ_MAX + header);
+	qdf_mem_zero(bmi_cmd_buff, BMI_DATASZ_MAX + header);
 
 	cid = BMI_WRITE_MEMORY;
 
@@ -189,8 +189,8 @@ bmi_execute(uint32_t address, A_UINT32 *param, struct ol_context *ol_ctx)
 	}
 
 	bmi_assert(BMI_COMMAND_FITS(size));
-	qdf_mem_set(bmi_cmd_buff, 0, size);
-	qdf_mem_set(bmi_rsp_buff, 0, size);
+	qdf_mem_zero(bmi_cmd_buff, size);
+	qdf_mem_zero(bmi_rsp_buff, size);
 
 
 	BMI_DBG("BMI Execute: device: 0x%pK, address: 0x%x, param: %d",

+ 2 - 2
core/cds/src/cds_sched.c

@@ -125,8 +125,8 @@ static void cds_rx_thread_log_cpu_affinity_change(unsigned char core_affine_cnt,
 	char new_mask_str[10];
 	char old_mask_str[10];
 
-	qdf_mem_set(new_mask_str, sizeof(new_mask_str), 0);
-	qdf_mem_set(new_mask_str, sizeof(old_mask_str), 0);
+	qdf_mem_zero(new_mask_str, sizeof(new_mask_str));
+	qdf_mem_zero(new_mask_str, sizeof(old_mask_str));
 
 	cpumap_print_to_pagebuf(false, old_mask_str, old_mask);
 	cpumap_print_to_pagebuf(false, new_mask_str, new_mask);

+ 5 - 5
core/dp/htt/htt.c

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2011, 2014-2018 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2011, 2014-2019 The Linux Foundation. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -218,8 +218,8 @@ htt_htc_tx_htt2_service_start(struct htt_pdev_t *pdev,
 {
 	QDF_STATUS status;
 
-	qdf_mem_set(connect_req, 0, sizeof(struct htc_service_connect_req));
-	qdf_mem_set(connect_resp, 0, sizeof(struct htc_service_connect_resp));
+	qdf_mem_zero(connect_req, sizeof(struct htc_service_connect_req));
+	qdf_mem_zero(connect_resp, sizeof(struct htc_service_connect_resp));
 
 	/* The same as HTT service but no RX. */
 	connect_req->EpCallbacks.pContext = pdev;
@@ -784,8 +784,8 @@ int htt_htc_attach(struct htt_pdev_t *pdev, uint16_t service_id)
 	struct htc_service_connect_resp response;
 	QDF_STATUS status;
 
-	qdf_mem_set(&connect, sizeof(connect), 0);
-	qdf_mem_set(&response, sizeof(response), 0);
+	qdf_mem_zero(&connect, sizeof(connect));
+	qdf_mem_zero(&response, sizeof(response));
 
 	connect.pMetaData = NULL;
 	connect.MetaDataLength = 0;

+ 4 - 4
core/dp/txrx/ol_rx.c

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2011-2018 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2011-2019 The Linux Foundation. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -815,8 +815,8 @@ ol_rx_sec_ind_handler(ol_txrx_pdev_handle pdev,
 		     sizeof(peer->security[sec_index].michael_key));
 
 	if (sec_type != htt_sec_type_wapi) {
-		qdf_mem_set(peer->tids_last_pn_valid,
-			    OL_TXRX_NUM_EXT_TIDS, 0x00);
+		qdf_mem_zero(peer->tids_last_pn_valid,
+			    OL_TXRX_NUM_EXT_TIDS);
 	} else if (sec_index == txrx_sec_mcast || peer->tids_last_pn_valid[0]) {
 		for (i = 0; i < OL_TXRX_NUM_EXT_TIDS; i++) {
 			/*
@@ -1243,7 +1243,7 @@ ol_rx_deliver(struct ol_txrx_vdev_t *vdev,
 #ifdef QCA_SUPPORT_SW_TXRX_ENCAP
 	struct ol_rx_decap_info_t info;
 
-	qdf_mem_set(&info, sizeof(info), 0);
+	qdf_mem_zero(&info, sizeof(info));
 #endif
 
 	msdu = msdu_list;

+ 2 - 2
core/dp/txrx/ol_rx_fwd.c

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2011, 2014-2018 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2011, 2014-2019 The Linux Foundation. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -120,7 +120,7 @@ static inline void ol_rx_fwd_to_tx(struct ol_txrx_vdev_t *vdev, qdf_nbuf_t msdu)
 		}
 
 	/* Clear the msdu control block as it will be re-interpreted */
-	qdf_mem_set(msdu->cb, sizeof(msdu->cb), 0);
+	qdf_mem_zero(msdu->cb, sizeof(msdu->cb));
 	/* update any cb field expected by OL_TX_SEND */
 
 	msdu = OL_TX_SEND(vdev, msdu);

+ 1 - 1
core/dp/txrx/ol_txrx.c

@@ -1190,7 +1190,7 @@ ol_txrx_pdev_post_attach(struct cdp_pdev *ppdev)
 	/*
 	 * Initialize rx PN check characteristics for different security types.
 	 */
-	qdf_mem_set(&pdev->rx_pn[0], sizeof(pdev->rx_pn), 0);
+	qdf_mem_zero(&pdev->rx_pn[0], sizeof(pdev->rx_pn));
 
 	/* TKIP: 48-bit TSC, CCMP: 48-bit PN */
 	pdev->rx_pn[htt_sec_type_tkip].len =

+ 2 - 2
core/dp/txrx/ol_txrx_internal.h

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2011-2018 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2011-2019 The Linux Foundation. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -180,7 +180,7 @@ ol_rx_mpdu_list_next(struct ol_txrx_pdev_t *pdev,
 /* default conditional defs (may be undefed below) */
 
 #define TXRX_STATS_INIT(_pdev) \
-	qdf_mem_set(&((_pdev)->stats), sizeof((_pdev)->stats), 0x0)
+	qdf_mem_zero(&((_pdev)->stats), sizeof((_pdev)->stats))
 #define TXRX_STATS_ADD(_pdev, _field, _delta) {		\
 		_pdev->stats._field += _delta; }
 #define TXRX_STATS_MSDU_INCR(pdev, field, netbuf) \

+ 2 - 2
core/dp/txrx3.0/dp_rx_thread.c

@@ -84,7 +84,7 @@ static void dp_rx_tm_thread_dump_stats(struct dp_rx_thread *rx_thread)
 	uint32_t total_queued = 0;
 	uint32_t temp = 0;
 
-	qdf_mem_set(nbuf_queued_string, 0, sizeof(nbuf_queued_string));
+	qdf_mem_zero(nbuf_queued_string, sizeof(nbuf_queued_string));
 
 	for (reo_ring_num = 0; reo_ring_num < DP_RX_TM_MAX_REO_RINGS;
 	     reo_ring_num++) {
@@ -473,7 +473,7 @@ static QDF_STATUS dp_rx_tm_thread_init(struct dp_rx_thread *rx_thread,
 	char thread_name[15];
 	QDF_STATUS qdf_status;
 
-	qdf_mem_set(thread_name, 0, sizeof(thread_name));
+	qdf_mem_zero(thread_name, sizeof(thread_name));
 
 	if (!rx_thread) {
 		dp_err("rx_thread is null!");

+ 2 - 2
core/hdd/src/wlan_hdd_assoc.c

@@ -241,7 +241,7 @@ hdd_conn_set_authenticated(struct hdd_adapter *adapter, uint8_t auth_state)
 		qdf_get_time_of_the_day_in_hr_min_sec_usec(auth_time,
 							   time_buffer_size);
 	else
-		qdf_mem_set(auth_time, 0x00, time_buffer_size);
+		qdf_mem_zero(auth_time, time_buffer_size);
 
 }
 
@@ -269,7 +269,7 @@ void hdd_conn_set_connection_state(struct hdd_adapter *adapter,
 		qdf_get_time_of_the_day_in_hr_min_sec_usec(connect_time,
 							   time_buffer_size);
 	else
-		qdf_mem_set(connect_time, 0x00, time_buffer_size);
+		qdf_mem_zero(connect_time, time_buffer_size);
 
 }
 

+ 5 - 5
core/hdd/src/wlan_hdd_main.c

@@ -8198,7 +8198,7 @@ hdd_display_netif_queue_history_compact(struct hdd_context *hdd_ctx)
 		}
 
 		tbytes = 0;
-		qdf_mem_set(temp_str, 0, sizeof(temp_str));
+		qdf_mem_zero(temp_str, sizeof(temp_str));
 		for (i = WLAN_CONTROL_PATH; i < WLAN_REASON_TYPE_MAX; i++) {
 			if (adapter->queue_oper_stats[i].pause_count == 0)
 				continue;
@@ -10211,10 +10211,10 @@ int hdd_pktlog_enable_disable(struct hdd_context *hdd_ctx, bool enable,
 void hdd_free_mac_address_lists(struct hdd_context *hdd_ctx)
 {
 	hdd_debug("Resetting MAC address lists");
-	qdf_mem_set(hdd_ctx->provisioned_mac_addr,
-		    sizeof(hdd_ctx->provisioned_mac_addr), 0);
-	qdf_mem_set(hdd_ctx->derived_mac_addr,
-		    sizeof(hdd_ctx->derived_mac_addr), 0);
+	qdf_mem_zero(hdd_ctx->provisioned_mac_addr,
+		    sizeof(hdd_ctx->provisioned_mac_addr));
+	qdf_mem_zero(hdd_ctx->derived_mac_addr,
+		    sizeof(hdd_ctx->derived_mac_addr));
 	hdd_ctx->num_provisioned_addr = 0;
 	hdd_ctx->num_derived_addr = 0;
 	hdd_ctx->provisioned_intf_addr_mask = 0;

+ 1 - 1
core/hdd/src/wlan_hdd_tx_rx.c

@@ -477,7 +477,7 @@ void wlan_hdd_classify_pkt(struct sk_buff *skb)
 {
 	struct ethhdr *eh = (struct ethhdr *)skb->data;
 
-	qdf_mem_set(skb->cb, sizeof(skb->cb), 0);
+	qdf_mem_zero(skb->cb, sizeof(skb->cb));
 
 	/* check destination mac address is broadcast/multicast */
 	if (is_broadcast_ether_addr((uint8_t *)eh))

+ 2 - 2
core/mac/src/dph/dph_hash_table.c

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2012-2018 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2012-2019 The Linux Foundation. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -228,7 +228,7 @@ tpDphHashNode dph_init_sta_state(struct mac_context *mac, tSirMacAddr staAddr,
 	pnext = pStaDs->next;
 
 	/* Clear the STA node except for the next pointer */
-	qdf_mem_set((uint8_t *)pStaDs, sizeof(tDphHashNode), 0);
+	qdf_mem_zero((uint8_t *)pStaDs, sizeof(tDphHashNode));
 	pStaDs->next = pnext;
 
 	/* Initialize the assocId */

+ 4 - 4
core/mac/src/pe/lim/lim_admit_control.c

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2011-2018 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2011-2019 The Linux Foundation. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -683,7 +683,7 @@ QDF_STATUS lim_admit_control_add_ts(struct mac_context *mac, uint8_t *pAddr,
 	}
 	/* fill in a schedule if requested */
 	if (pSch != NULL) {
-		qdf_mem_set((uint8_t *) pSch, sizeof(*pSch), 0);
+		qdf_mem_zero((uint8_t *) pSch, sizeof(*pSch));
 		pSch->svcStartTime = pAddts->tspec.svcStartTime;
 		pSch->svcInterval = svcInterval;
 		pSch->maxSvcDuration = (uint16_t) pSch->svcInterval;    /* use SP = SI */
@@ -787,8 +787,8 @@ QDF_STATUS lim_admit_control_delete_sta(struct mac_context *mac, uint16_t assocI
    -------------------------------------------------------------*/
 QDF_STATUS lim_admit_control_init(struct mac_context *mac)
 {
-	qdf_mem_set(mac->lim.tspecInfo,
-		    LIM_NUM_TSPEC_MAX * sizeof(tLimTspecInfo), 0);
+	qdf_mem_zero(mac->lim.tspecInfo,
+		    LIM_NUM_TSPEC_MAX * sizeof(tLimTspecInfo));
 	return QDF_STATUS_SUCCESS;
 }
 

+ 20 - 21
core/mac/src/pe/lim/lim_api.c

@@ -77,8 +77,8 @@
 
 static void __lim_init_bss_vars(struct mac_context *mac)
 {
-	qdf_mem_set((void *)mac->lim.gpSession,
-		    sizeof(*mac->lim.gpSession) * mac->lim.maxBssId, 0);
+	qdf_mem_zero((void *)mac->lim.gpSession,
+		    sizeof(*mac->lim.gpSession) * mac->lim.maxBssId);
 
 	/* This is for testing purposes only, be default should always be off */
 	mac->lim.gpLimMlmSetKeysReq = NULL;
@@ -101,8 +101,8 @@ static void __lim_init_stats_vars(struct mac_context *mac)
 	mac->lim.gLimHeartBeatApMacIndex = 0;
 
 	/* Statistics to keep track of no. beacons rcvd in heart beat interval */
-	qdf_mem_set(mac->lim.gLimHeartBeatBeaconStats,
-		    sizeof(mac->lim.gLimHeartBeatBeaconStats), 0);
+	qdf_mem_zero(mac->lim.gLimHeartBeatBeaconStats,
+		    sizeof(mac->lim.gLimHeartBeatBeaconStats));
 
 #ifdef WLAN_DEBUG
 	/* Debug counters */
@@ -112,7 +112,7 @@ static void __lim_init_stats_vars(struct mac_context *mac)
 	mac->lim.numLearn = 0;
 	mac->lim.numLearnIgnore = 0;
 	mac->lim.numSme = 0;
-	qdf_mem_set(mac->lim.numMAC, sizeof(mac->lim.numMAC), 0);
+	qdf_mem_zero(mac->lim.numMAC, sizeof(mac->lim.numMAC));
 	mac->lim.gLimNumAssocReqDropInvldState = 0;
 	mac->lim.gLimNumAssocReqDropACRejectTS = 0;
 	mac->lim.gLimNumAssocReqDropACRejectSta = 0;
@@ -153,9 +153,9 @@ static void __lim_init_states(struct mac_context *mac)
 	 * when SME_START_BSS_REQ is received.
 	 */
 
-	qdf_mem_set(&mac->lim.gLimNoShortParams, sizeof(tLimNoShortParams), 0);
-	qdf_mem_set(&mac->lim.gLimNoShortSlotParams,
-		    sizeof(tLimNoShortSlotParams), 0);
+	qdf_mem_zero(&mac->lim.gLimNoShortParams, sizeof(tLimNoShortParams));
+	qdf_mem_zero(&mac->lim.gLimNoShortSlotParams,
+		    sizeof(tLimNoShortSlotParams));
 
 	mac->lim.gLimPhyMode = 0;
 	mac->lim.gLimProbeRespDisableFlag = 0; /* control over probe resp */
@@ -167,15 +167,15 @@ static void __lim_init_vars(struct mac_context *mac)
 
 
 	/* Deferred Queue Parameters */
-	qdf_mem_set(&mac->lim.gLimDeferredMsgQ, sizeof(tSirAddtsReq), 0);
+	qdf_mem_zero(&mac->lim.gLimDeferredMsgQ, sizeof(tSirAddtsReq));
 
 	/* addts request if any - only one can be outstanding at any time */
-	qdf_mem_set(&mac->lim.gLimAddtsReq, sizeof(tSirAddtsReq), 0);
+	qdf_mem_zero(&mac->lim.gLimAddtsReq, sizeof(tSirAddtsReq));
 	mac->lim.gLimAddtsSent = 0;
 	mac->lim.gLimAddtsRspTimerCount = 0;
 
 	/* protection related config cache */
-	qdf_mem_set(&mac->lim.cfgProtection, sizeof(tCfgProtection), 0);
+	qdf_mem_zero(&mac->lim.cfgProtection, sizeof(tCfgProtection));
 	mac->lim.gLimProtectionControl = 0;
 	SET_LIM_PROCESS_DEFD_MESGS(mac, true);
 
@@ -190,11 +190,11 @@ static void __lim_init_vars(struct mac_context *mac)
 	mac->lim.pDialogueTokenHead = NULL;
 	mac->lim.pDialogueTokenTail = NULL;
 
-	qdf_mem_set(&mac->lim.tspecInfo,
-		    sizeof(tLimTspecInfo) * LIM_NUM_TSPEC_MAX, 0);
+	qdf_mem_zero(&mac->lim.tspecInfo,
+		    sizeof(tLimTspecInfo) * LIM_NUM_TSPEC_MAX);
 
 	/* admission control policy information */
-	qdf_mem_set(&mac->lim.admitPolicyInfo, sizeof(tLimAdmitPolicyInfo), 0);
+	qdf_mem_zero(&mac->lim.admitPolicyInfo, sizeof(tLimAdmitPolicyInfo));
 }
 
 static void __lim_init_assoc_vars(struct mac_context *mac)
@@ -207,19 +207,18 @@ static void __lim_init_assoc_vars(struct mac_context *mac)
 	/* / MAC level Pre-authentication related globals */
 	mac->lim.gLimPreAuthChannelNumber = 0;
 	mac->lim.gLimPreAuthType = eSIR_OPEN_SYSTEM;
-	qdf_mem_set(&mac->lim.gLimPreAuthPeerAddr, sizeof(tSirMacAddr), 0);
+	qdf_mem_zero(&mac->lim.gLimPreAuthPeerAddr, sizeof(tSirMacAddr));
 	mac->lim.gLimNumPreAuthContexts = 0;
-	qdf_mem_set(&mac->lim.gLimPreAuthTimerTable, sizeof(tLimPreAuthTable),
-		    0);
+	qdf_mem_zero(&mac->lim.gLimPreAuthTimerTable, sizeof(tLimPreAuthTable));
 
 	/* Place holder for Pre-authentication node list */
 	mac->lim.pLimPreAuthList = NULL;
 
 	/* One cache for each overlap and associated case. */
-	qdf_mem_set(mac->lim.protStaOverlapCache,
-		    sizeof(tCacheParams) * LIM_PROT_STA_OVERLAP_CACHE_SIZE, 0);
-	qdf_mem_set(mac->lim.protStaCache,
-		    sizeof(tCacheParams) * LIM_PROT_STA_CACHE_SIZE, 0);
+	qdf_mem_zero(mac->lim.protStaOverlapCache,
+		    sizeof(tCacheParams) * LIM_PROT_STA_OVERLAP_CACHE_SIZE);
+	qdf_mem_zero(mac->lim.protStaCache,
+		    sizeof(tCacheParams) * LIM_PROT_STA_CACHE_SIZE);
 
 	mac->lim.pe_session = NULL;
 	mac->lim.reAssocRetryAttempt = 0;

+ 10 - 10
core/mac/src/pe/lim/lim_assoc_utils.c

@@ -1214,8 +1214,8 @@ static void lim_decide_short_preamble(struct mac_context *mac_ctx,
 		 * enable short preamble
 		 * reset the cache
 		 */
-		qdf_mem_set((uint8_t *) &session_entry->gLimNoShortParams,
-				sizeof(tLimNoShortParams), 0);
+		qdf_mem_zero((uint8_t *) &session_entry->gLimNoShortParams,
+				sizeof(tLimNoShortParams));
 		if (lim_enable_short_preamble(mac_ctx, true,
 			beacon_params, session_entry) != QDF_STATUS_SUCCESS)
 			pe_err("Cannot enable short preamble");
@@ -1272,9 +1272,9 @@ lim_decide_short_slot(struct mac_context *mac_ctx, tpDphHashNode sta_ds,
 			 * enable short slot time
 			 * reset the cache
 			 */
-			qdf_mem_set((uint8_t *) &session_entry->
+			qdf_mem_zero((uint8_t *) &session_entry->
 				gLimNoShortSlotParams,
-				sizeof(tLimNoShortSlotParams), 0);
+				sizeof(tLimNoShortSlotParams));
 			beacon_params->fShortSlotTime = true;
 			beacon_params->paramChangeBitmap |=
 				PARAM_SHORT_SLOT_TIME_CHANGED;
@@ -1305,9 +1305,9 @@ lim_decide_short_slot(struct mac_context *mac_ctx, tpDphHashNode sta_ds,
 			 * enable short slot time
 			 * reset the cache
 			 */
-			qdf_mem_set(
+			qdf_mem_zero(
 				(uint8_t *) &mac_ctx->lim.gLimNoShortSlotParams,
-				sizeof(tLimNoShortSlotParams), 0);
+				sizeof(tLimNoShortSlotParams));
 			/*in case of AP set SHORT_SLOT_TIME to enable*/
 			if (LIM_IS_AP_ROLE(session_entry)) {
 				beacon_params->fShortSlotTime = true;
@@ -1544,7 +1544,7 @@ lim_populate_own_rate_set(struct mac_context *mac_ctx,
 	 * put the result in pSupportedRates
 	 */
 
-	qdf_mem_set((uint8_t *) rates, sizeof(tSirSupportedRates), 0);
+	qdf_mem_zero((uint8_t *) rates, sizeof(tSirSupportedRates));
 	for (i = 0; i < temp_rate_set.numRates; i++) {
 		min = 0;
 		val = 0xff;
@@ -1685,7 +1685,7 @@ lim_populate_peer_rate_set(struct mac_context *mac,
 		uint8_t aRateIndex = 0;
 		uint8_t bRateIndex = 0;
 
-		qdf_mem_set((uint8_t *) pRates, sizeof(tSirSupportedRates), 0);
+		qdf_mem_zero((uint8_t *) pRates, sizeof(tSirSupportedRates));
 		for (i = 0; i < tempRateSet.numRates; i++) {
 			min = 0;
 			val = 0xff;
@@ -1944,7 +1944,7 @@ QDF_STATUS lim_populate_matching_rate_set(struct mac_context *mac_ctx,
 	}
 
 	rates = &sta_ds->supportedRates;
-	qdf_mem_set((uint8_t *) rates, sizeof(tSirSupportedRates), 0);
+	qdf_mem_zero((uint8_t *) rates, sizeof(tSirSupportedRates));
 	for (i = 0; (i < temp_rate_set2.numRates &&
 			 i < SIR_MAC_RATESET_EID_MAX); i++) {
 		for (j = 0; (j < temp_rate_set.numRates &&
@@ -3280,7 +3280,7 @@ QDF_STATUS lim_extract_ap_capabilities(struct mac_context *mac,
 					  uint16_t ieLen,
 					  tpSirProbeRespBeacon beaconStruct)
 {
-	qdf_mem_set((uint8_t *) beaconStruct, sizeof(tSirProbeRespBeacon), 0);
+	qdf_mem_zero((uint8_t *) beaconStruct, sizeof(tSirProbeRespBeacon));
 
 	pe_debug("The IE's being received are:");
 	QDF_TRACE_HEX_DUMP(QDF_MODULE_ID_PE, QDF_TRACE_LEVEL_DEBUG,

+ 2 - 3
core/mac/src/pe/lim/lim_ft.c

@@ -51,8 +51,7 @@ extern void lim_send_set_sta_key_req(struct mac_context *mac,
 void lim_ft_open(struct mac_context *mac, struct pe_session *pe_session)
 {
 	if (pe_session)
-		qdf_mem_set(&pe_session->ftPEContext, sizeof(tftPEContext),
-			    0);
+		qdf_mem_zero(&pe_session->ftPEContext, sizeof(tftPEContext));
 }
 
 void lim_ft_cleanup_all_ft_sessions(struct mac_context *mac)
@@ -107,7 +106,7 @@ void lim_ft_cleanup(struct mac_context *mac, struct pe_session *pe_session)
 	}
 
 	/* The session is being deleted, cleanup the contents */
-	qdf_mem_set(&pe_session->ftPEContext, sizeof(tftPEContext), 0);
+	qdf_mem_zero(&pe_session->ftPEContext, sizeof(tftPEContext));
 }
 
 #if defined(WLAN_FEATURE_HOST_ROAM) || defined(WLAN_FEATURE_ROAM_OFFLOAD)

+ 2 - 2
core/mac/src/pe/lim/lim_ft_preauth.c

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2016-2018 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2016-2019 The Linux Foundation. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -90,7 +90,7 @@ void lim_ft_cleanup_pre_auth_info(struct mac_context *mac,
 	}
 
 	/* The session is being deleted, cleanup the contents */
-	qdf_mem_set(&pe_session->ftPEContext, sizeof(tftPEContext), 0);
+	qdf_mem_zero(&pe_session->ftPEContext, sizeof(tftPEContext));
 
 	/* Delete the session created while handling pre-auth response */
 	if (pReAssocSessionEntry) {

+ 6 - 6
core/mac/src/pe/lim/lim_ibss_peer_mgmt.c

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2012-2018 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2012-2019 The Linux Foundation. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -603,7 +603,7 @@ void ibss_bss_add(struct mac_context *mac, struct pe_session *pe_session)
 	 * even though all the nodes are capable of doing CB.
 	 * so it is decided to leave the self HT capabilties intact. This may change if some issues are found in interop.
 	 */
-	qdf_mem_set((void *)&mlmStartReq, sizeof(mlmStartReq), 0);
+	qdf_mem_zero((void *)&mlmStartReq, sizeof(mlmStartReq));
 
 	qdf_mem_copy(mlmStartReq.bssId, pHdr->bssId, sizeof(tSirMacAddr));
 	mlmStartReq.rateSet.numRates =
@@ -683,7 +683,7 @@ void lim_ibss_init(struct mac_context *mac)
 	mac->lim.gLimNumIbssPeers = 0;
 
 	/* ibss info - params for which ibss to join while coalescing */
-	qdf_mem_set(&mac->lim.ibssInfo, sizeof(tAniSirLimIbss), 0);
+	qdf_mem_zero(&mac->lim.ibssInfo, sizeof(tAniSirLimIbss));
 } /*** end lim_ibss_init() ***/
 
 /**
@@ -972,7 +972,7 @@ lim_ibss_sta_add(struct mac_context *mac, void *pBody, struct pe_session *pe_ses
 	tSirMacAddr *pPeerAddr = (tSirMacAddr *) pBody;
 	tUpdateBeaconParams beaconParams;
 
-	qdf_mem_set((uint8_t *) &beaconParams, sizeof(tUpdateBeaconParams), 0);
+	qdf_mem_zero((uint8_t *) &beaconParams, sizeof(tUpdateBeaconParams));
 
 	if (pBody == 0) {
 		pe_err("Invalid IBSS AddSta");
@@ -1302,7 +1302,7 @@ void lim_ibss_add_bss_rsp_when_coalescing(struct mac_context *mac, void *msg,
 	infoLen = sizeof(tSirMacAddr) + sizeof(tSirMacChanNum) +
 		  sizeof(uint8_t) + pBeacon->ssId.length + 1;
 
-	qdf_mem_set((void *)&newBssInfo, sizeof(newBssInfo), 0);
+	qdf_mem_zero((void *)&newBssInfo, sizeof(newBssInfo));
 	qdf_mem_copy(newBssInfo.bssId.bytes, pHdr->bssId, QDF_MAC_ADDR_SIZE);
 	newBssInfo.channelNumber = (tSirMacChanNum) pAddBss->currentOperChannel;
 	qdf_mem_copy((uint8_t *) &newBssInfo.ssId,
@@ -1455,7 +1455,7 @@ lim_ibss_coalesce(struct mac_context *mac,
 	tpDphHashNode pStaDs;
 	tUpdateBeaconParams beaconParams;
 
-	qdf_mem_set((uint8_t *) &beaconParams, sizeof(tUpdateBeaconParams), 0);
+	qdf_mem_zero((uint8_t *) &beaconParams, sizeof(tUpdateBeaconParams));
 
 	sir_copy_mac_addr(currentBssId, pe_session->bssId);
 

+ 2 - 2
core/mac/src/pe/lim/lim_process_assoc_req_frame.c

@@ -915,8 +915,8 @@ static bool lim_check_wpa_rsn_ie(struct pe_session *session, struct mac_context
 	 * Clear the buffers so that frame parser knows that there isn't a
 	 * previously decoded IE in these buffers
 	 */
-	qdf_mem_set((uint8_t *) &dot11f_ie_rsn, sizeof(dot11f_ie_rsn), 0);
-	qdf_mem_set((uint8_t *) &dot11f_ie_wpa, sizeof(dot11f_ie_wpa), 0);
+	qdf_mem_zero((uint8_t *) &dot11f_ie_rsn, sizeof(dot11f_ie_rsn));
+	qdf_mem_zero((uint8_t *) &dot11f_ie_wpa, sizeof(dot11f_ie_wpa));
 	pe_err("RSN enabled auth, Re/Assoc req from STA: "
 		MAC_ADDRESS_STR, MAC_ADDR_ARRAY(hdr->sa));
 

+ 4 - 4
core/mac/src/pe/lim/lim_process_cfg_updates.c

@@ -47,8 +47,8 @@ void lim_set_cfg_protection(struct mac_context *mac, struct pe_session *pesessio
 	if (pesessionEntry != NULL && LIM_IS_AP_ROLE(pesessionEntry)) {
 		if (pesessionEntry->gLimProtectionControl ==
 		    MLME_FORCE_POLICY_PROTECTION_DISABLE)
-			qdf_mem_set((void *)&pesessionEntry->cfgProtection,
-				    sizeof(tCfgProtection), 0);
+			qdf_mem_zero((void *)&pesessionEntry->cfgProtection,
+				    sizeof(tCfgProtection));
 		else {
 			pe_debug("frm11a = %d, from11b = %d, frm11g = %d, "
 				   "ht20 = %d, nongf = %d, lsigTxop = %d, "
@@ -69,8 +69,8 @@ void lim_set_cfg_protection(struct mac_context *mac, struct pe_session *pesessio
 
 		if (mac->lim.gLimProtectionControl ==
 		    MLME_FORCE_POLICY_PROTECTION_DISABLE)
-			qdf_mem_set((void *)&mac->lim.cfgProtection,
-				    sizeof(tCfgProtection), 0);
+			qdf_mem_zero((void *)&mac->lim.cfgProtection,
+				    sizeof(tCfgProtection));
 		else {
 			val = mlme_cfg->sap_protection_cfg.protection_enabled;
 

+ 2 - 2
core/mac/src/pe/lim/lim_process_mlm_rsp_messages.c

@@ -2811,7 +2811,7 @@ void lim_process_mlm_set_sta_key_rsp(struct mac_context *mac_ctx,
 	tSetStaKeyParams *set_key_params;
 
 	SET_LIM_PROCESS_DEFD_MESGS(mac_ctx, true);
-	qdf_mem_set((void *)&mlm_set_key_cnf, sizeof(tLimMlmSetKeysCnf), 0);
+	qdf_mem_zero((void *)&mlm_set_key_cnf, sizeof(tLimMlmSetKeysCnf));
 	if (NULL == msg->bodyptr) {
 		pe_err("msg bodyptr is NULL");
 		return;
@@ -2903,7 +2903,7 @@ void lim_process_mlm_set_bss_key_rsp(struct mac_context *mac_ctx,
 	uint16_t key_len;
 
 	SET_LIM_PROCESS_DEFD_MESGS(mac_ctx, true);
-	qdf_mem_set((void *)&set_key_cnf, sizeof(tLimMlmSetKeysCnf), 0);
+	qdf_mem_zero((void *)&set_key_cnf, sizeof(tLimMlmSetKeysCnf));
 	if (NULL == msg->bodyptr) {
 		pe_err("msg bodyptr is null");
 		return;

+ 19 - 19
core/mac/src/pe/lim/lim_process_tdls.c

@@ -541,7 +541,7 @@ static QDF_STATUS lim_send_tdls_dis_req_frame(struct mac_context *mac,
 	 * and then hand it off to 'dot11f_pack_probe_request' (for
 	 * serialization).  We start by zero-initializing the structure:
 	 */
-	qdf_mem_set((uint8_t *) &tdlsDisReq, sizeof(tDot11fTDLSDisReq), 0);
+	qdf_mem_zero((uint8_t *) &tdlsDisReq, sizeof(tDot11fTDLSDisReq));
 
 	/*
 	 * setup Fixed fields,
@@ -609,7 +609,7 @@ static QDF_STATUS lim_send_tdls_dis_req_frame(struct mac_context *mac,
 	}
 
 	/* zero out the memory */
-	qdf_mem_set(pFrame, nBytes, 0);
+	qdf_mem_zero(pFrame, nBytes);
 
 	/*
 	 * IE formation, memory allocation is completed, Now form TDLS discovery
@@ -652,9 +652,9 @@ static QDF_STATUS lim_send_tdls_dis_req_frame(struct mac_context *mac,
 
 		/* padding zero if more than 5 bytes are required */
 		if (padLen > MIN_VENDOR_SPECIFIC_IE_SIZE)
-			qdf_mem_set(pFrame + header_offset + nPayload +
+			qdf_mem_zero(pFrame + header_offset + nPayload +
 				    MIN_VENDOR_SPECIFIC_IE_SIZE,
-				    padLen - MIN_VENDOR_SPECIFIC_IE_SIZE, 0);
+				    padLen - MIN_VENDOR_SPECIFIC_IE_SIZE);
 	}
 #endif
 
@@ -827,7 +827,7 @@ static QDF_STATUS lim_send_tdls_dis_rsp_frame(struct mac_context *mac,
 	 * and then hand it off to 'dot11f_pack_probe_request' (for
 	 * serialization).  We start by zero-initializing the structure:
 	 */
-	qdf_mem_set((uint8_t *) &tdlsDisRsp, sizeof(tDot11fTDLSDisRsp), 0);
+	qdf_mem_zero((uint8_t *) &tdlsDisRsp, sizeof(tDot11fTDLSDisRsp));
 
 	/*
 	 * setup Fixed fields,
@@ -919,7 +919,7 @@ static QDF_STATUS lim_send_tdls_dis_rsp_frame(struct mac_context *mac,
 	}
 
 	/* zero out the memory */
-	qdf_mem_set(pFrame, nBytes, 0);
+	qdf_mem_zero(pFrame, nBytes);
 
 	/*
 	 * IE formation, memory allocation is completed, Now form TDLS discovery
@@ -1140,7 +1140,7 @@ QDF_STATUS lim_send_tdls_link_setup_req_frame(struct mac_context *mac,
 	 */
 	smeSessionId = pe_session->smeSessionId;
 
-	qdf_mem_set((uint8_t *) &tdlsSetupReq, sizeof(tDot11fTDLSSetupReq), 0);
+	qdf_mem_zero((uint8_t *) &tdlsSetupReq, sizeof(tDot11fTDLSSetupReq));
 	tdlsSetupReq.Category.category = SIR_MAC_ACTION_TDLS;
 	tdlsSetupReq.Action.action = SIR_MAC_TDLS_SETUP_REQ;
 	tdlsSetupReq.DialogToken.token = dialog;
@@ -1289,7 +1289,7 @@ QDF_STATUS lim_send_tdls_link_setup_req_frame(struct mac_context *mac,
 	}
 
 	/* zero out the memory */
-	qdf_mem_set(pFrame, nBytes, 0);
+	qdf_mem_zero(pFrame, nBytes);
 
 	/*
 	 * IE formation, memory allocation is completed, Now form TDLS discovery
@@ -1398,7 +1398,7 @@ QDF_STATUS lim_send_tdls_teardown_frame(struct mac_context *mac,
 	 * and then hand it off to 'dot11f_pack_probe_request' (for
 	 * serialization).  We start by zero-initializing the structure:
 	 */
-	qdf_mem_set((uint8_t *) &teardown, sizeof(tDot11fTDLSTeardown), 0);
+	qdf_mem_zero((uint8_t *) &teardown, sizeof(tDot11fTDLSTeardown));
 	teardown.Category.category = SIR_MAC_ACTION_TDLS;
 	teardown.Action.action = SIR_MAC_TDLS_TEARDOWN;
 	teardown.Reason.code = reason;
@@ -1468,7 +1468,7 @@ QDF_STATUS lim_send_tdls_teardown_frame(struct mac_context *mac,
 	}
 
 	/* zero out the memory */
-	qdf_mem_set(pFrame, nBytes, 0);
+	qdf_mem_zero(pFrame, nBytes);
 
 	/*
 	 * IE formation, memory allocation is completed, Now form TDLS discovery
@@ -1519,9 +1519,9 @@ QDF_STATUS lim_send_tdls_teardown_frame(struct mac_context *mac,
 
 		/* padding zero if more than 5 bytes are required */
 		if (padLen > MIN_VENDOR_SPECIFIC_IE_SIZE)
-			qdf_mem_set(pFrame + header_offset + nPayload +
+			qdf_mem_zero(pFrame + header_offset + nPayload +
 				    addIeLen + MIN_VENDOR_SPECIFIC_IE_SIZE,
-				    padLen - MIN_VENDOR_SPECIFIC_IE_SIZE, 0);
+				    padLen - MIN_VENDOR_SPECIFIC_IE_SIZE);
 	}
 #endif
 	pe_debug("[TDLS] action: %d (%s) -%s-> OTA peer="MAC_ADDRESS_STR,
@@ -1595,7 +1595,7 @@ static QDF_STATUS lim_send_tdls_setup_rsp_frame(struct mac_context *mac,
 	 * and then hand it off to 'dot11f_pack_probe_request' (for
 	 * serialization).  We start by zero-initializing the structure:
 	 */
-	qdf_mem_set((uint8_t *) &tdlsSetupRsp, sizeof(tDot11fTDLSSetupRsp), 0);
+	qdf_mem_zero((uint8_t *) &tdlsSetupRsp, sizeof(tDot11fTDLSSetupRsp));
 
 	/*
 	 * setup Fixed fields,
@@ -1741,7 +1741,7 @@ static QDF_STATUS lim_send_tdls_setup_rsp_frame(struct mac_context *mac,
 	}
 
 	/* zero out the memory */
-	qdf_mem_set(pFrame, nBytes, 0);
+	qdf_mem_zero(pFrame, nBytes);
 
 	/*
 	 * IE formation, memory allocation is completed, Now form TDLS discovery
@@ -1842,7 +1842,7 @@ QDF_STATUS lim_send_tdls_link_setup_cnf_frame(struct mac_context *mac,
 	 */
 	smeSessionId = pe_session->smeSessionId;
 
-	qdf_mem_set((uint8_t *) &tdlsSetupCnf, sizeof(tDot11fTDLSSetupCnf), 0);
+	qdf_mem_zero((uint8_t *) &tdlsSetupCnf, sizeof(tDot11fTDLSSetupCnf));
 
 	/*
 	 * setup Fixed fields,
@@ -1933,7 +1933,7 @@ QDF_STATUS lim_send_tdls_link_setup_cnf_frame(struct mac_context *mac,
 	}
 
 	/* zero out the memory */
-	qdf_mem_set(pFrame, nBytes, 0);
+	qdf_mem_zero(pFrame, nBytes);
 
 	/*
 	 * IE formation, memory allocation is completed, Now form TDLS discovery
@@ -1985,9 +1985,9 @@ QDF_STATUS lim_send_tdls_link_setup_cnf_frame(struct mac_context *mac,
 
 		/* padding zero if more than 5 bytes are required */
 		if (padLen > MIN_VENDOR_SPECIFIC_IE_SIZE)
-			qdf_mem_set(pFrame + header_offset + nPayload +
+			qdf_mem_zero(pFrame + header_offset + nPayload +
 				    addIeLen + MIN_VENDOR_SPECIFIC_IE_SIZE,
-				    padLen - MIN_VENDOR_SPECIFIC_IE_SIZE, 0);
+				    padLen - MIN_VENDOR_SPECIFIC_IE_SIZE);
 	}
 #endif
 
@@ -2345,7 +2345,7 @@ lim_tdls_populate_matching_rate_set(struct mac_context *mac_ctx, tpDphHashNode s
 	temp_rate_set.numRates = supp_rates_len;
 
 	rates = &stads->supportedRates;
-	qdf_mem_set((uint8_t *) rates, sizeof(tSirSupportedRates), 0);
+	qdf_mem_zero((uint8_t *) rates, sizeof(tSirSupportedRates));
 
 	for (i = 0; i < temp_rate_set2.numRates; i++) {
 		for (j = 0; j < temp_rate_set.numRates; j++) {

+ 5 - 5
core/mac/src/pe/lim/lim_send_frames_host_roam.c

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2016-2018 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2016-2019 The Linux Foundation. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -104,7 +104,7 @@ void lim_send_reassoc_req_with_ft_ies_mgmt_frame(struct mac_context *mac_ctx,
 	add_ie = pe_session->pLimReAssocReq->addIEAssoc.addIEdata;
 	pe_debug("called in state: %d", pe_session->limMlmState);
 
-	qdf_mem_set((uint8_t *) frm, sizeof(*frm), 0);
+	qdf_mem_zero((uint8_t *) frm, sizeof(*frm));
 
 	caps = mlm_reassoc_req->capabilityInfo;
 #if defined(FEATURE_WLAN_WAPI)
@@ -349,7 +349,7 @@ void lim_send_reassoc_req_with_ft_ies_mgmt_frame(struct mac_context *mac_ctx,
 		goto end;
 	}
 	/* Paranoia: */
-	qdf_mem_set(frame, bytes + ft_ies_length, 0);
+	qdf_mem_zero(frame, bytes + ft_ies_length);
 
 	lim_print_mac_addr(mac_ctx, pe_session->limReAssocbssId, LOGD);
 	/* Next, we fill out the buffer descriptor: */
@@ -572,7 +572,7 @@ void lim_send_reassoc_req_mgmt_frame(struct mac_context *mac,
 	nAddIELen = pe_session->pLimReAssocReq->addIEAssoc.length;
 	pAddIE = pe_session->pLimReAssocReq->addIEAssoc.addIEdata;
 
-	qdf_mem_set((uint8_t *) frm, sizeof(*frm), 0);
+	qdf_mem_zero((uint8_t *) frm, sizeof(*frm));
 
 	caps = pMlmReassocReq->capabilityInfo;
 #if defined(FEATURE_WLAN_WAPI)
@@ -721,7 +721,7 @@ void lim_send_reassoc_req_mgmt_frame(struct mac_context *mac,
 		goto end;
 	}
 	/* Paranoia: */
-	qdf_mem_set(pFrame, nBytes, 0);
+	qdf_mem_zero(pFrame, nBytes);
 
 	/* Next, we fill out the buffer descriptor: */
 	lim_populate_mac_header(mac, pFrame, SIR_MAC_MGMT_FRAME,

+ 44 - 44
core/mac/src/pe/lim/lim_send_management_frames.c

@@ -223,7 +223,7 @@ lim_send_probe_req_mgmt_frame(struct mac_context *mac_ctx,
 	/* The scheme here is to fill out a 'tDot11fProbeRequest' structure */
 	/* and then hand it off to 'dot11f_pack_probe_request' (for */
 	/* serialization).  We start by zero-initializing the structure: */
-	qdf_mem_set((uint8_t *) &pr, sizeof(pr), 0);
+	qdf_mem_zero((uint8_t *) &pr, sizeof(pr));
 
 	/* & delegating to assorted helpers: */
 	populate_dot11f_ssid(mac_ctx, ssid, &pr.SSID);
@@ -377,7 +377,7 @@ lim_send_probe_req_mgmt_frame(struct mac_context *mac_ctx,
 		return QDF_STATUS_E_NOMEM;
 	}
 	/* Paranoia: */
-	qdf_mem_set(frame, bytes, 0);
+	qdf_mem_zero(frame, bytes);
 
 	/* Next, we fill out the buffer descriptor: */
 	lim_populate_mac_header(mac_ctx, frame, SIR_MAC_MGMT_FRAME,
@@ -554,7 +554,7 @@ lim_send_probe_rsp_mgmt_frame(struct mac_context *mac_ctx,
 	 * Fill out 'frm', after which we'll just hand the struct off to
 	 * 'dot11f_pack_probe_response'.
 	 */
-	qdf_mem_set((uint8_t *) frm, sizeof(tDot11fProbeResponse), 0);
+	qdf_mem_zero((uint8_t *) frm, sizeof(tDot11fProbeResponse));
 
 	/*
 	 * Timestamp to be updated by TFP, below.
@@ -748,7 +748,7 @@ lim_send_probe_rsp_mgmt_frame(struct mac_context *mac_ctx,
 		goto err_ret;
 	}
 	/* Paranoia: */
-	qdf_mem_set(frame, bytes, 0);
+	qdf_mem_zero(frame, bytes);
 
 	/* Next, we fill out the buffer descriptor: */
 	lim_populate_mac_header(mac_ctx, frame, SIR_MAC_MGMT_FRAME,
@@ -852,7 +852,7 @@ lim_send_addts_req_action_frame(struct mac_context *mac,
 	smeSessionId = pe_session->smeSessionId;
 
 	if (!pAddTS->wmeTspecPresent) {
-		qdf_mem_set((uint8_t *) &AddTSReq, sizeof(AddTSReq), 0);
+		qdf_mem_zero((uint8_t *) &AddTSReq, sizeof(AddTSReq));
 
 		AddTSReq.Action.action = SIR_MAC_QOS_ADD_TS_REQ;
 		AddTSReq.DialogToken.token = pAddTS->dialogToken;
@@ -906,7 +906,7 @@ lim_send_addts_req_action_frame(struct mac_context *mac,
 				nStatus);
 		}
 	} else {
-		qdf_mem_set((uint8_t *) &WMMAddTSReq, sizeof(WMMAddTSReq), 0);
+		qdf_mem_zero((uint8_t *) &WMMAddTSReq, sizeof(WMMAddTSReq));
 
 		WMMAddTSReq.Action.action = SIR_MAC_QOS_ADD_TS_REQ;
 		WMMAddTSReq.DialogToken.token = pAddTS->dialogToken;
@@ -955,7 +955,7 @@ lim_send_addts_req_action_frame(struct mac_context *mac,
 		return;
 	}
 	/* Paranoia: */
-	qdf_mem_set(pFrame, nBytes, 0);
+	qdf_mem_zero(pFrame, nBytes);
 
 	/* Next, we fill out the buffer descriptor: */
 	lim_populate_mac_header(mac, pFrame, SIR_MAC_MGMT_FRAME,
@@ -1079,7 +1079,7 @@ lim_send_assoc_rsp_mgmt_frame(struct mac_context *mac_ctx,
 
 	sme_session = pe_session->smeSessionId;
 
-	qdf_mem_set((uint8_t *) &frm, sizeof(frm), 0);
+	qdf_mem_zero((uint8_t *) &frm, sizeof(frm));
 
 	limGetQosMode(pe_session, &qos_mode);
 	limGetWmeMode(pe_session, &wme_mode);
@@ -1222,7 +1222,7 @@ lim_send_assoc_rsp_mgmt_frame(struct mac_context *mac_ctx,
 			pe_session->lim_non_ecsa_cap_num++;
 	}
 
-	qdf_mem_set((uint8_t *) &beacon_params, sizeof(beacon_params), 0);
+	qdf_mem_zero((uint8_t *) &beacon_params, sizeof(beacon_params));
 
 	if (LIM_IS_AP_ROLE(pe_session) &&
 	    (pe_session->gLimProtectionControl !=
@@ -1263,8 +1263,8 @@ lim_send_assoc_rsp_mgmt_frame(struct mac_context *mac_ctx,
 				pe_session->addIeParams.assocRespData_buff,
 				pe_session->addIeParams.assocRespDataLen);
 
-			qdf_mem_set((uint8_t *) &extracted_ext_cap,
-				    sizeof(extracted_ext_cap), 0);
+			qdf_mem_zero((uint8_t *) &extracted_ext_cap,
+				    sizeof(extracted_ext_cap));
 
 			stripoff_len = addn_ie_len;
 			sir_status =
@@ -1312,7 +1312,7 @@ lim_send_assoc_rsp_mgmt_frame(struct mac_context *mac_ctx,
 		return;
 	}
 	/* Paranoia: */
-	qdf_mem_set(frame, bytes, 0);
+	qdf_mem_zero(frame, bytes);
 
 	/* Next, we fill out the buffer descriptor: */
 	lim_populate_mac_header(mac_ctx, frame, SIR_MAC_MGMT_FRAME,
@@ -1407,7 +1407,7 @@ lim_send_delts_req_action_frame(struct mac_context *mac,
 	smeSessionId = pe_session->smeSessionId;
 
 	if (!wmmTspecPresent) {
-		qdf_mem_set((uint8_t *) &DelTS, sizeof(DelTS), 0);
+		qdf_mem_zero((uint8_t *) &DelTS, sizeof(DelTS));
 
 		DelTS.Category.category = SIR_MAC_ACTION_QOS_MGMT;
 		DelTS.Action.action = SIR_MAC_QOS_DEL_TS_REQ;
@@ -1424,7 +1424,7 @@ lim_send_delts_req_action_frame(struct mac_context *mac,
 				nStatus);
 		}
 	} else {
-		qdf_mem_set((uint8_t *) &WMMDelTS, sizeof(WMMDelTS), 0);
+		qdf_mem_zero((uint8_t *) &WMMDelTS, sizeof(WMMDelTS));
 
 		WMMDelTS.Category.category = SIR_MAC_ACTION_WME;
 		WMMDelTS.Action.action = SIR_MAC_QOS_DEL_TS_REQ;
@@ -1455,7 +1455,7 @@ lim_send_delts_req_action_frame(struct mac_context *mac,
 		return;
 	}
 	/* Paranoia: */
-	qdf_mem_set(pFrame, nBytes, 0);
+	qdf_mem_zero(pFrame, nBytes);
 
 	/* Next, we fill out the buffer descriptor: */
 	lim_populate_mac_header(mac, pFrame, SIR_MAC_MGMT_FRAME,
@@ -1627,11 +1627,11 @@ lim_send_assoc_req_mgmt_frame(struct mac_context *mac_ctx,
 		qdf_mem_free(mlm_assoc_req);
 		return;
 	}
-	qdf_mem_set((uint8_t *) frm, sizeof(tDot11fAssocRequest), 0);
+	qdf_mem_zero((uint8_t *) frm, sizeof(tDot11fAssocRequest));
 
 	if (add_ie_len && pe_session->is_ext_caps_present) {
-		qdf_mem_set((uint8_t *) &extr_ext_cap, sizeof(tDot11fIEExtCap),
-			    0);
+		qdf_mem_zero((uint8_t *) &extr_ext_cap,
+				sizeof(tDot11fIEExtCap));
 		sir_status = lim_strip_extcap_update_struct(mac_ctx,
 					add_ie, &add_ie_len, &extr_ext_cap);
 		if (QDF_STATUS_SUCCESS != sir_status) {
@@ -1988,7 +1988,7 @@ lim_send_assoc_req_mgmt_frame(struct mac_context *mac_ctx,
 		goto end;
 	}
 	/* Paranoia: */
-	qdf_mem_set(frame, bytes, 0);
+	qdf_mem_zero(frame, bytes);
 
 	/* Next, we fill out the buffer descriptor: */
 	lim_populate_mac_header(mac_ctx, frame, SIR_MAC_MGMT_FRAME,
@@ -2831,7 +2831,7 @@ lim_send_disassoc_mgmt_frame(struct mac_context *mac,
 	}
 	smeSessionId = pe_session->smeSessionId;
 
-	qdf_mem_set((uint8_t *) &frm, sizeof(frm), 0);
+	qdf_mem_zero((uint8_t *) &frm, sizeof(frm));
 
 	frm.Reason.code = nReason;
 
@@ -2856,7 +2856,7 @@ lim_send_disassoc_mgmt_frame(struct mac_context *mac,
 		return;
 	}
 	/* Paranoia: */
-	qdf_mem_set(pFrame, nBytes, 0);
+	qdf_mem_zero(pFrame, nBytes);
 
 	/* Next, we fill out the buffer descriptor: */
 	lim_populate_mac_header(mac, pFrame, SIR_MAC_MGMT_FRAME,
@@ -3008,7 +3008,7 @@ lim_send_deauth_mgmt_frame(struct mac_context *mac,
 	}
 	smeSessionId = pe_session->smeSessionId;
 
-	qdf_mem_set((uint8_t *) &frm, sizeof(frm), 0);
+	qdf_mem_zero((uint8_t *) &frm, sizeof(frm));
 
 	frm.Reason.code = nReason;
 
@@ -3033,7 +3033,7 @@ lim_send_deauth_mgmt_frame(struct mac_context *mac,
 		return;
 	}
 	/* Paranoia: */
-	qdf_mem_set(pFrame, nBytes, 0);
+	qdf_mem_zero(pFrame, nBytes);
 
 	/* Next, we fill out the buffer descriptor: */
 	lim_populate_mac_header(mac, pFrame, SIR_MAC_MGMT_FRAME,
@@ -3192,7 +3192,7 @@ lim_send_meas_report_frame(struct mac_context *mac,
 	void *pPacket;
 	QDF_STATUS qdf_status;
 
-	qdf_mem_set((uint8_t *) &frm, sizeof(frm), 0);
+	qdf_mem_zero((uint8_t *) &frm, sizeof(frm));
 
 	frm.Category.category = SIR_MAC_ACTION_SPECTRUM_MGMT;
 	frm.Action.action = SIR_MAC_ACTION_MEASURE_REPORT_ID;
@@ -3246,7 +3246,7 @@ lim_send_meas_report_frame(struct mac_context *mac,
 		return QDF_STATUS_E_FAILURE;
 	}
 	/* Paranoia: */
-	qdf_mem_set(pFrame, nBytes, 0);
+	qdf_mem_zero(pFrame, nBytes);
 
 	/* Next, we fill out the buffer descriptor: */
 	lim_populate_mac_header(mac, pFrame, SIR_MAC_MGMT_FRAME,
@@ -3318,7 +3318,7 @@ lim_send_tpc_report_frame(struct mac_context *mac,
 	void *pPacket;
 	QDF_STATUS qdf_status;
 
-	qdf_mem_set((uint8_t *) &frm, sizeof(frm), 0);
+	qdf_mem_zero((uint8_t *) &frm, sizeof(frm));
 
 	frm.Category.category = SIR_MAC_ACTION_SPECTRUM_MGMT;
 	frm.Action.action = SIR_MAC_ACTION_TPC_REPORT_ID;
@@ -3350,7 +3350,7 @@ lim_send_tpc_report_frame(struct mac_context *mac,
 		return QDF_STATUS_E_FAILURE;
 	}
 	/* Paranoia: */
-	qdf_mem_set(pFrame, nBytes, 0);
+	qdf_mem_zero(pFrame, nBytes);
 
 	/* Next, we fill out the buffer descriptor: */
 	lim_populate_mac_header(mac, pFrame, SIR_MAC_MGMT_FRAME,
@@ -3440,7 +3440,7 @@ lim_send_channel_switch_mgmt_frame(struct mac_context *mac,
 	}
 	smeSessionId = pe_session->smeSessionId;
 
-	qdf_mem_set((uint8_t *) &frm, sizeof(frm), 0);
+	qdf_mem_zero((uint8_t *) &frm, sizeof(frm));
 
 	frm.Category.category = SIR_MAC_ACTION_SPECTRUM_MGMT;
 	frm.Action.action = SIR_MAC_ACTION_CHANNEL_SWITCH_ID;
@@ -3470,7 +3470,7 @@ lim_send_channel_switch_mgmt_frame(struct mac_context *mac,
 		return QDF_STATUS_E_FAILURE;
 	}
 	/* Paranoia: */
-	qdf_mem_set(pFrame, nBytes, 0);
+	qdf_mem_zero(pFrame, nBytes);
 
 	/* Next, we fill out the buffer descriptor: */
 	lim_populate_mac_header(mac, pFrame, SIR_MAC_MGMT_FRAME,
@@ -3560,7 +3560,7 @@ lim_send_extended_chan_switch_action_frame(struct mac_context *mac_ctx,
 
 	sme_session_id = session_entry->smeSessionId;
 
-	qdf_mem_set(&frm, sizeof(frm), 0);
+	qdf_mem_zero(&frm, sizeof(frm));
 
 	frm.Category.category     = SIR_MAC_ACTION_PUBLIC_USAGE;
 	frm.Action.action         = SIR_MAC_ACTION_EXT_CHANNEL_SWITCH_ID;
@@ -3614,7 +3614,7 @@ lim_send_extended_chan_switch_action_frame(struct mac_context *mac_ctx,
 	}
 
 	/* Paranoia*/
-	qdf_mem_set(frame, num_bytes, 0);
+	qdf_mem_zero(frame, num_bytes);
 
 	/* Next, we fill out the buffer descriptor */
 	lim_populate_mac_header(mac_ctx, frame, SIR_MAC_MGMT_FRAME,
@@ -3728,7 +3728,7 @@ lim_p2p_oper_chan_change_confirm_action_frame(struct mac_context *mac_ctx,
 
 	sme_session_id = session_entry->smeSessionId;
 
-	qdf_mem_set(&frm, sizeof(frm), 0);
+	qdf_mem_zero(&frm, sizeof(frm));
 
 	frm.Category.category     = SIR_MAC_ACTION_VENDOR_SPECIFIC_CATEGORY;
 
@@ -3770,7 +3770,7 @@ lim_p2p_oper_chan_change_confirm_action_frame(struct mac_context *mac_ctx,
 		return QDF_STATUS_E_FAILURE;
 	}
 
-	qdf_mem_set(frame, num_bytes, 0);
+	qdf_mem_zero(frame, num_bytes);
 
 	/* Next, fill out the buffer descriptor */
 	lim_populate_mac_header(mac_ctx, frame, SIR_MAC_MGMT_FRAME,
@@ -3859,7 +3859,7 @@ lim_send_neighbor_report_request_frame(struct mac_context *mac,
 		return QDF_STATUS_E_FAILURE;
 	}
 	smeSessionId = pe_session->smeSessionId;
-	qdf_mem_set((uint8_t *) &frm, sizeof(frm), 0);
+	qdf_mem_zero((uint8_t *) &frm, sizeof(frm));
 
 	frm.Category.category = SIR_MAC_ACTION_RRM;
 	frm.Action.action = SIR_MAC_RRM_NEIGHBOR_REQ;
@@ -3892,7 +3892,7 @@ lim_send_neighbor_report_request_frame(struct mac_context *mac,
 		return QDF_STATUS_E_FAILURE;
 	}
 	/* Paranoia: */
-	qdf_mem_set(pFrame, nBytes, 0);
+	qdf_mem_zero(pFrame, nBytes);
 
 	/* Copy necessary info to BD */
 	lim_populate_mac_header(mac, pFrame, SIR_MAC_MGMT_FRAME,
@@ -3996,7 +3996,7 @@ lim_send_link_report_action_frame(struct mac_context *mac,
 		return QDF_STATUS_E_FAILURE;
 	}
 
-	qdf_mem_set((uint8_t *) &frm, sizeof(frm), 0);
+	qdf_mem_zero((uint8_t *) &frm, sizeof(frm));
 
 	frm.Category.category = SIR_MAC_ACTION_RRM;
 	frm.Action.action = SIR_MAC_RRM_LINK_MEASUREMENT_RPT;
@@ -4039,7 +4039,7 @@ lim_send_link_report_action_frame(struct mac_context *mac,
 		return QDF_STATUS_E_FAILURE;
 	}
 	/* Paranoia: */
-	qdf_mem_set(pFrame, nBytes, 0);
+	qdf_mem_zero(pFrame, nBytes);
 
 	/* Copy necessary info to BD */
 	lim_populate_mac_header(mac, pFrame, SIR_MAC_MGMT_FRAME,
@@ -4210,7 +4210,7 @@ lim_send_radio_measure_report_action_frame(struct mac_context *mac,
 		return QDF_STATUS_E_FAILURE;
 	}
 	/* Paranoia: */
-	qdf_mem_set(pFrame, nBytes, 0);
+	qdf_mem_zero(pFrame, nBytes);
 
 	/* Copy necessary info to BD */
 	lim_populate_mac_header(mac, pFrame, SIR_MAC_MGMT_FRAME,
@@ -4314,7 +4314,7 @@ QDF_STATUS lim_send_sa_query_request_frame(struct mac_context *mac, uint8_t *tra
 	uint8_t txFlag = 0;
 	uint8_t smeSessionId = 0;
 
-	qdf_mem_set((uint8_t *) &frm, sizeof(frm), 0);
+	qdf_mem_zero((uint8_t *) &frm, sizeof(frm));
 	frm.Category.category = SIR_MAC_ACTION_SA_QUERY;
 	/* 11w action  field is :
 	   action: 0 --> SA Query Request action frame
@@ -4343,7 +4343,7 @@ QDF_STATUS lim_send_sa_query_request_frame(struct mac_context *mac, uint8_t *tra
 		return QDF_STATUS_E_FAILURE;
 	}
 	/* Paranoia: */
-	qdf_mem_set(pFrame, nBytes, 0);
+	qdf_mem_zero(pFrame, nBytes);
 
 	/* Copy necessary info to BD */
 	lim_populate_mac_header(mac, pFrame, SIR_MAC_MGMT_FRAME,
@@ -4446,7 +4446,7 @@ QDF_STATUS lim_send_sa_query_response_frame(struct mac_context *mac,
 
 	smeSessionId = pe_session->smeSessionId;
 
-	qdf_mem_set((uint8_t *) &frm, sizeof(frm), 0);
+	qdf_mem_zero((uint8_t *) &frm, sizeof(frm));
 	frm.Category.category = SIR_MAC_ACTION_SA_QUERY;
 	/*11w action  field is :
 	   action: 0 --> SA query request action frame
@@ -4476,7 +4476,7 @@ QDF_STATUS lim_send_sa_query_response_frame(struct mac_context *mac,
 		return QDF_STATUS_E_FAILURE;
 	}
 	/* Paranoia: */
-	qdf_mem_set(pFrame, nBytes, 0);
+	qdf_mem_zero(pFrame, nBytes);
 
 	/* Copy necessary info to BD */
 	lim_populate_mac_header(mac, pFrame, SIR_MAC_MGMT_FRAME,
@@ -4599,7 +4599,7 @@ QDF_STATUS lim_send_addba_response_frame(struct mac_context *mac_ctx,
 		&status_code, &buff_size, &batimeout);
 
 	cdp_peer_release_ref(soc, peer, PEER_DEBUG_ID_LIM_SEND_ADDBA_RESP);
-	qdf_mem_set((uint8_t *) &frm, sizeof(frm), 0);
+	qdf_mem_zero((uint8_t *) &frm, sizeof(frm));
 	frm.Category.category = SIR_MAC_ACTION_BLKACK;
 	frm.Action.action = SIR_MAC_ADDBA_RSP;
 
@@ -4673,7 +4673,7 @@ QDF_STATUS lim_send_addba_response_frame(struct mac_context *mac_ctx,
 			num_bytes);
 		return QDF_STATUS_E_FAILURE;
 	}
-	qdf_mem_set(frame_ptr, num_bytes, 0);
+	qdf_mem_zero(frame_ptr, num_bytes);
 
 	lim_populate_mac_header(mac_ctx, frame_ptr, SIR_MAC_MGMT_FRAME,
 		SIR_MAC_MGMT_ACTION, peer_mac, session->selfMacAddr);

+ 21 - 21
core/mac/src/pe/lim/lim_session.c

@@ -103,20 +103,20 @@ static void pe_init_beacon_params(struct mac_context *mac,
 	pe_session->beaconParams.gHTObssMode = 0;
 
 	/* Number of legacy STAs associated */
-	qdf_mem_set((void *)&pe_session->gLim11bParams,
-		    sizeof(tLimProtStaParams), 0);
-	qdf_mem_set((void *)&pe_session->gLim11aParams,
-		    sizeof(tLimProtStaParams), 0);
-	qdf_mem_set((void *)&pe_session->gLim11gParams,
-		    sizeof(tLimProtStaParams), 0);
-	qdf_mem_set((void *)&pe_session->gLimNonGfParams,
-		    sizeof(tLimProtStaParams), 0);
-	qdf_mem_set((void *)&pe_session->gLimHt20Params,
-		    sizeof(tLimProtStaParams), 0);
-	qdf_mem_set((void *)&pe_session->gLimLsigTxopParams,
-		    sizeof(tLimProtStaParams), 0);
-	qdf_mem_set((void *)&pe_session->gLimOlbcParams,
-		    sizeof(tLimProtStaParams), 0);
+	qdf_mem_zero((void *)&pe_session->gLim11bParams,
+		    sizeof(tLimProtStaParams));
+	qdf_mem_zero((void *)&pe_session->gLim11aParams,
+		    sizeof(tLimProtStaParams));
+	qdf_mem_zero((void *)&pe_session->gLim11gParams,
+		    sizeof(tLimProtStaParams));
+	qdf_mem_zero((void *)&pe_session->gLimNonGfParams,
+		    sizeof(tLimProtStaParams));
+	qdf_mem_zero((void *)&pe_session->gLimHt20Params,
+		    sizeof(tLimProtStaParams));
+	qdf_mem_zero((void *)&pe_session->gLimLsigTxopParams,
+		    sizeof(tLimProtStaParams));
+	qdf_mem_zero((void *)&pe_session->gLimOlbcParams,
+		    sizeof(tLimProtStaParams));
 }
 
 /*
@@ -499,15 +499,15 @@ void lim_reset_bcn_probe_filter(struct mac_context *mac_ctx,
 	if (eSIR_INFRASTRUCTURE_MODE == bss_type) {
 		if (filter->num_sta_sessions)
 			filter->num_sta_sessions--;
-		qdf_mem_set(&filter->sta_bssid[session_id],
-			    sizeof(tSirMacAddr), 0);
+		qdf_mem_zero(&filter->sta_bssid[session_id],
+			    sizeof(tSirMacAddr));
 		pe_debug("Cleared STA Filter for session %d", session_id);
 	} else if (eSIR_IBSS_MODE == bss_type) {
 		if (filter->num_ibss_sessions)
 			filter->num_ibss_sessions--;
 		filter->ibss_ssid[session_id].length = 0;
-		qdf_mem_set(&filter->ibss_ssid[session_id].ssId,
-			    SIR_MAC_MAX_SSID_LENGTH, 0);
+		qdf_mem_zero(&filter->ibss_ssid[session_id].ssId,
+			    SIR_MAC_MAX_SSID_LENGTH);
 		pe_debug("Cleared IBSS Filter for session %d", session_id);
 	} else if (eSIR_INFRA_AP_MODE == bss_type) {
 		if (filter->num_sap_sessions)
@@ -582,7 +582,7 @@ struct pe_session *pe_create_session(struct mac_context *mac,
 	}
 
 	session_ptr = &mac->lim.gpSession[i];
-	qdf_mem_set((void *)session_ptr, sizeof(struct pe_session), 0);
+	qdf_mem_zero((void *)session_ptr, sizeof(struct pe_session));
 	/* Allocate space for Station Table for this session. */
 	session_ptr->dph.dphHashTable.pHashTable =
 		qdf_mem_malloc(sizeof(tpDphHashNode) * (numSta + 1));
@@ -627,8 +627,8 @@ struct pe_session *pe_create_session(struct mac_context *mac,
 	session_ptr->htRecommendedTxWidthSet = 0;
 	session_ptr->htSecondaryChannelOffset = 0;
 #ifdef FEATURE_WLAN_TDLS
-	qdf_mem_set(session_ptr->peerAIDBitmap,
-		    sizeof(session_ptr->peerAIDBitmap), 0);
+	qdf_mem_zero(session_ptr->peerAIDBitmap,
+		    sizeof(session_ptr->peerAIDBitmap));
 	session_ptr->tdls_prohibited = false;
 	session_ptr->tdls_chan_swit_prohibited = false;
 #endif

+ 10 - 12
core/mac/src/pe/lim/lim_utils.c

@@ -1004,7 +1004,7 @@ void lim_handle_update_olbc_cache(struct mac_context *mac_ctx)
 		pe_debug("protection offloaded");
 		return;
 	}
-	qdf_mem_set((uint8_t *) &beaconParams, sizeof(tUpdateBeaconParams), 0);
+	qdf_mem_zero((uint8_t *) &beaconParams, sizeof(tUpdateBeaconParams));
 	beaconParams.bssIdx = pe_session->bssIdx;
 
 	beaconParams.paramChangeBitmap = 0;
@@ -5087,7 +5087,7 @@ void lim_diag_event_report(struct mac_context *mac, uint16_t eventType,
 
 	WLAN_HOST_DIAG_EVENT_DEF(peEvent, host_event_wlan_pe_payload_type);
 
-	qdf_mem_set(&peEvent, sizeof(host_event_wlan_pe_payload_type), 0);
+	qdf_mem_zero(&peEvent, sizeof(host_event_wlan_pe_payload_type));
 
 	if (NULL == pe_session) {
 		qdf_mem_copy(peEvent.bssid, nullBssid, sizeof(tSirMacAddr));
@@ -5116,7 +5116,7 @@ static void lim_diag_fill_mgmt_event_report(struct mac_context *mac_ctx,
 {
 	uint8_t length;
 
-	qdf_mem_set(mgmt_event, sizeof(*mgmt_event), 0);
+	qdf_mem_zero(mgmt_event, sizeof(*mgmt_event));
 	mgmt_event->mgmt_type = mac_hdr->fc.type;
 	mgmt_event->mgmt_subtype = mac_hdr->fc.subType;
 	qdf_mem_copy(mgmt_event->self_mac_addr, session->selfMacAddr,
@@ -6151,9 +6151,8 @@ QDF_STATUS lim_strip_ie(struct mac_context *mac_ctx,
 			 * take oui IE and store in provided buffer.
 			 */
 			if (NULL != extracted_ie) {
-				qdf_mem_set(extracted_ie,
-					    eid_max_len + size_of_len_field + 1,
-					    0);
+				qdf_mem_zero(extracted_ie,
+					eid_max_len + size_of_len_field + 1);
 				if (elem_len <= eid_max_len)
 					qdf_mem_copy(extracted_ie, &ptr[0],
 					elem_len + size_of_len_field + 1);
@@ -6205,9 +6204,8 @@ QDF_STATUS lim_strip_supp_op_class_update_struct(struct mac_context *mac_ctx,
 	uint8_t extracted_buff[DOT11F_IE_SUPPOPERATINGCLASSES_MAX_LEN + 2];
 	QDF_STATUS status;
 
-	qdf_mem_set((uint8_t *)&extracted_buff[0],
-		    DOT11F_IE_SUPPOPERATINGCLASSES_MAX_LEN + 2,
-		    0);
+	qdf_mem_zero((uint8_t *)&extracted_buff[0],
+		    DOT11F_IE_SUPPOPERATINGCLASSES_MAX_LEN + 2);
 	status = lim_strip_ie(mac_ctx, addn_ie, addn_ielen,
 			      DOT11F_EID_SUPPOPERATINGCLASSES, ONE_BYTE,
 			      NULL, 0, extracted_buff,
@@ -6267,7 +6265,7 @@ void lim_update_extcap_struct(struct mac_context *mac_ctx,
 		return;
 	}
 
-	qdf_mem_set((uint8_t *)&out[0], DOT11F_IE_EXTCAP_MAX_LEN, 0);
+	qdf_mem_zero((uint8_t *)&out[0], DOT11F_IE_EXTCAP_MAX_LEN);
 	qdf_mem_copy(&out[0], &buf[2], buf[1]);
 
 	status = dot11f_unpack_ie_ext_cap(mac_ctx, &out[0],
@@ -6295,8 +6293,8 @@ QDF_STATUS lim_strip_extcap_update_struct(struct mac_context *mac_ctx,
 	uint8_t extracted_buff[DOT11F_IE_EXTCAP_MAX_LEN + 2];
 	QDF_STATUS status;
 
-	qdf_mem_set((uint8_t *)&extracted_buff[0], DOT11F_IE_EXTCAP_MAX_LEN + 2,
-		     0);
+	qdf_mem_zero((uint8_t *)&extracted_buff[0],
+			DOT11F_IE_EXTCAP_MAX_LEN + 2);
 	status = lim_strip_ie(mac_ctx, addn_ie, addn_ielen,
 			      DOT11F_EID_EXTCAP, ONE_BYTE,
 			      NULL, 0, extracted_buff,

+ 2 - 2
core/mac/src/pe/rrm/rrm_api.c

@@ -433,7 +433,7 @@ rrm_process_neighbor_report_req(struct mac_context *mac,
 
 	pe_debug("SSID present: %d", pNeighborReq->noSSID);
 
-	qdf_mem_set(&NeighborReportReq, sizeof(tSirMacNeighborReportReq), 0);
+	qdf_mem_zero(&NeighborReportReq, sizeof(tSirMacNeighborReportReq));
 
 	NeighborReportReq.dialogToken = ++mac->rrm.rrmPEContext.DialogToken;
 	NeighborReportReq.ssid_present = !pNeighborReq->noSSID;
@@ -1289,7 +1289,7 @@ QDF_STATUS rrm_initialize(struct mac_context *mac)
 	mac->rrm.rrmPEContext.rrmEnable = 0;
 	mac->rrm.rrmPEContext.prev_rrm_report_seq_num = 0xFFFF;
 
-	qdf_mem_set(pRRMCaps, sizeof(tRRMCaps), 0);
+	qdf_mem_zero(pRRMCaps, sizeof(tRRMCaps));
 	pRRMCaps->LinkMeasurement = 1;
 	pRRMCaps->NeighborRpt = 1;
 	pRRMCaps->BeaconPassive = 1;

+ 2 - 2
core/mac/src/pe/sch/sch_api.c

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2011-2018 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2011-2019 The Linux Foundation. All rights reserved.
  *
  * Permission to use, copy, modify, and/or distribute this software for
  * any purpose with or without fee is hereby granted, provided that the
@@ -338,7 +338,7 @@ uint32_t lim_send_probe_rsp_template_to_hal(struct mac_context *mac,
 	}
 
 	/* Paranoia: */
-	qdf_mem_set(pFrame2Hal, nBytes, 0);
+	qdf_mem_zero(pFrame2Hal, nBytes);
 
 	/* Next, we fill out the buffer descriptor: */
 	lim_populate_mac_header(mac, pFrame2Hal, SIR_MAC_MGMT_FRAME,

+ 5 - 5
core/mac/src/pe/sch/sch_beacon_gen.c

@@ -270,7 +270,7 @@ sch_set_fixed_beacon_fields(struct mac_context *mac_ctx, struct pe_session *sess
 	 * First set the fixed fields:
 	 * set the TFP headers, set the mac header
 	 */
-	qdf_mem_set((uint8_t *) &bcn_struct->macHdr, sizeof(tSirMacMgmtHdr), 0);
+	qdf_mem_zero((uint8_t *) &bcn_struct->macHdr, sizeof(tSirMacMgmtHdr));
 	mac = (tpSirMacMgmtHdr) &bcn_struct->macHdr;
 	mac->fc.type = SIR_MAC_MGMT_FRAME;
 	mac->fc.subType = SIR_MAC_MGMT_BEACON;
@@ -310,12 +310,12 @@ sch_set_fixed_beacon_fields(struct mac_context *mac_ctx, struct pe_session *sess
 
 	if (LIM_IS_AP_ROLE(session)) {
 		/* Initialize the default IE bitmap to zero */
-		qdf_mem_set((uint8_t *) &(session->DefProbeRspIeBitmap),
-			    (sizeof(uint32_t) * 8), 0);
+		qdf_mem_zero((uint8_t *) &(session->DefProbeRspIeBitmap),
+			    (sizeof(uint32_t) * 8));
 
 		/* Initialize the default IE bitmap to zero */
-		qdf_mem_set((uint8_t *) &(session->probeRespFrame),
-			    sizeof(session->probeRespFrame), 0);
+		qdf_mem_zero((uint8_t *) &(session->probeRespFrame),
+			    sizeof(session->probeRespFrame));
 
 		/*
 		 * Can be efficiently updated whenever new IE added in Probe

+ 1 - 1
core/mac/src/sys/legacy/src/system/src/sys_entry_func.c

@@ -63,7 +63,7 @@
 QDF_STATUS sys_init_globals(struct mac_context *mac)
 {
 
-	qdf_mem_set((uint8_t *) &mac->sys, sizeof(mac->sys), 0);
+	qdf_mem_zero((uint8_t *) &mac->sys, sizeof(mac->sys));
 
 	mac->sys.gSysEnableLinkMonitorMode = 0;
 

+ 17 - 17
core/mac/src/sys/legacy/src/utils/src/parser_api.c

@@ -1928,7 +1928,7 @@ sir_convert_probe_req_frame2_struct(struct mac_context *mac,
 	tDot11fProbeRequest pr;
 
 	/* Ok, zero-init our [out] parameter, */
-	qdf_mem_set((uint8_t *) pProbeReq, sizeof(tSirProbeReq), 0);
+	qdf_mem_zero((uint8_t *) pProbeReq, sizeof(tSirProbeReq));
 
 	/* delegate to the framesc-generated code, */
 	status = dot11f_unpack_probe_request(mac, pFrame, nFrame, &pr, false);
@@ -2206,7 +2206,7 @@ QDF_STATUS sir_convert_probe_frame2_struct(struct mac_context *mac,
 	tDot11fProbeResponse *pr;
 
 	/* Ok, zero-init our [out] parameter, */
-	qdf_mem_set((uint8_t *) pProbeResp, sizeof(tSirProbeRespBeacon), 0);
+	qdf_mem_zero((uint8_t *) pProbeResp, sizeof(tSirProbeRespBeacon));
 
 	pr = qdf_mem_malloc(sizeof(tDot11fProbeResponse));
 	if (!pr)
@@ -2486,7 +2486,7 @@ sir_convert_assoc_req_frame2_struct(struct mac_context *mac,
 	if (!ar)
 		return QDF_STATUS_E_NOMEM;
 	/* Zero-init our [out] parameter, */
-	qdf_mem_set((uint8_t *) pAssocReq, sizeof(tSirAssocReq), 0);
+	qdf_mem_zero((uint8_t *) pAssocReq, sizeof(tSirAssocReq));
 
 	/* delegate to the framesc-generated code, */
 	status = dot11f_unpack_assoc_request(mac, pFrame, nFrame, ar, false);
@@ -3030,7 +3030,7 @@ sir_convert_reassoc_req_frame2_struct(struct mac_context *mac,
 	if (!ar)
 		return QDF_STATUS_E_NOMEM;
 	/* Zero-init our [out] parameter, */
-	qdf_mem_set((uint8_t *) pAssocReq, sizeof(tSirAssocReq), 0);
+	qdf_mem_zero((uint8_t *) pAssocReq, sizeof(tSirAssocReq));
 
 	/* delegate to the framesc-generated code, */
 	status = dot11f_unpack_re_assoc_request(mac, pFrame, nFrame,
@@ -3210,8 +3210,8 @@ sir_beacon_ie_ese_bcn_report(struct mac_context *mac,
 	uint8_t *pos = NULL;
 
 	/* Zero-init our [out] parameter, */
-	qdf_mem_set((uint8_t *) &eseBcnReportMandatoryIe,
-		    sizeof(eseBcnReportMandatoryIe), 0);
+	qdf_mem_zero((uint8_t *) &eseBcnReportMandatoryIe,
+		    sizeof(eseBcnReportMandatoryIe));
 	pBies = qdf_mem_malloc(sizeof(tDot11fBeaconIEs));
 	if (!pBies)
 		return QDF_STATUS_E_NOMEM;
@@ -3502,7 +3502,7 @@ sir_parse_beacon_ie(struct mac_context *mac,
 	uint32_t status;
 
 	/* Zero-init our [out] parameter, */
-	qdf_mem_set((uint8_t *) pBeaconStruct, sizeof(tSirProbeRespBeacon), 0);
+	qdf_mem_zero((uint8_t *) pBeaconStruct, sizeof(tSirProbeRespBeacon));
 
 	pBies = qdf_mem_malloc(sizeof(tDot11fBeaconIEs));
 	if (!pBies)
@@ -3818,7 +3818,7 @@ sir_convert_beacon_frame2_struct(struct mac_context *mac,
 	mappedRXCh = WMA_GET_RX_CH(pFrame);
 
 	/* Zero-init our [out] parameter, */
-	qdf_mem_set((uint8_t *) pBeaconStruct, sizeof(tSirProbeRespBeacon), 0);
+	qdf_mem_zero((uint8_t *) pBeaconStruct, sizeof(tSirProbeRespBeacon));
 
 	pBeacon = qdf_mem_malloc(sizeof(tDot11fBeacon));
 	if (!pBeacon)
@@ -4217,7 +4217,7 @@ sir_convert_auth_frame2_struct(struct mac_context *mac,
 	uint32_t status;
 
 	/* Zero-init our [out] parameter, */
-	qdf_mem_set((uint8_t *) pAuth, sizeof(tSirMacAuthFrameBody), 0);
+	qdf_mem_zero((uint8_t *) pAuth, sizeof(tSirMacAuthFrameBody));
 
 	/* delegate to the framesc-generated code, */
 	status = dot11f_unpack_authentication(mac, pFrame, nFrame,
@@ -4266,9 +4266,9 @@ sir_convert_addts_rsp2_struct(struct mac_context *mac,
 		return QDF_STATUS_E_FAILURE;
 	}
 	/* Zero-init our [out] parameter, */
-	qdf_mem_set((uint8_t *) pAddTs, sizeof(tSirAddtsRspInfo), 0);
-	qdf_mem_set((uint8_t *) &addts, sizeof(tDot11fAddTSResponse), 0);
-	qdf_mem_set((uint8_t *) &wmmaddts, sizeof(tDot11fWMMAddTSResponse), 0);
+	qdf_mem_zero((uint8_t *) pAddTs, sizeof(tSirAddtsRspInfo));
+	qdf_mem_zero((uint8_t *) &addts, sizeof(tDot11fAddTSResponse));
+	qdf_mem_zero((uint8_t *) &wmmaddts, sizeof(tDot11fWMMAddTSResponse));
 
 	/* delegate to the framesc-generated code, */
 	switch (*pFrame) {
@@ -4434,7 +4434,7 @@ sir_convert_delts_req2_struct(struct mac_context *mac,
 		return QDF_STATUS_E_FAILURE;
 	}
 	/* Zero-init our [out] parameter, */
-	qdf_mem_set(pDelTs, sizeof(*pDelTs), 0);
+	qdf_mem_zero(pDelTs, sizeof(*pDelTs));
 
 	/* delegate to the framesc-generated code, */
 	switch (*pFrame) {
@@ -4537,8 +4537,8 @@ sir_convert_tpc_req_frame2_struct(struct mac_context *mac,
 	tDot11fTPCRequest req;
 	uint32_t status;
 
-	qdf_mem_set((uint8_t *) pTpcReqFrame, sizeof(tSirMacTpcReqActionFrame),
-		    0);
+	qdf_mem_zero((uint8_t *) pTpcReqFrame,
+			sizeof(tSirMacTpcReqActionFrame));
 	status = dot11f_unpack_tpc_request(mac, pFrame, nFrame, &req, false);
 	if (DOT11F_FAILED(status)) {
 		pe_err("Failed to parse a TPC Request frame (0x%08x, %d bytes):",
@@ -4574,8 +4574,8 @@ sir_convert_meas_req_frame2_struct(struct mac_context *mac,
 	uint32_t status;
 
 	/* Zero-init our [out] parameter, */
-	qdf_mem_set((uint8_t *) pMeasReqFrame,
-		    sizeof(tpSirMacMeasReqActionFrame), 0);
+	qdf_mem_zero((uint8_t *) pMeasReqFrame,
+		    sizeof(tpSirMacMeasReqActionFrame));
 
 	/* delegate to the framesc-generated code, */
 	status = dot11f_unpack_measurement_request(mac, pFrame,

+ 2 - 2
core/sap/src/sap_ch_select.c

@@ -1555,8 +1555,8 @@ static void sap_compute_spect_weight(tSapChSelSpectInfo *pSpectInfoParams,
 
 		ieLen = GET_IE_LEN_IN_BSS(
 				pScanResult->BssDescriptor.length);
-		qdf_mem_set((uint8_t *) pBeaconStruct,
-				   sizeof(tSirProbeRespBeacon), 0);
+		qdf_mem_zero((uint8_t *) pBeaconStruct,
+				   sizeof(tSirProbeRespBeacon));
 
 
 		if ((sir_parse_beacon_ie

+ 13 - 13
core/sme/src/common/sme_api.c

@@ -466,11 +466,11 @@ tSmeCmd *sme_get_command_buffer(struct mac_context *mac)
 
 	/* memset to zero */
 	if (pRetCmd) {
-		qdf_mem_set((uint8_t *)&pRetCmd->command,
-			    sizeof(pRetCmd->command), 0);
-		qdf_mem_set((uint8_t *)&pRetCmd->sessionId,
-			    sizeof(pRetCmd->sessionId), 0);
-		qdf_mem_set((uint8_t *)&pRetCmd->u, sizeof(pRetCmd->u), 0);
+		qdf_mem_zero((uint8_t *)&pRetCmd->command,
+			    sizeof(pRetCmd->command));
+		qdf_mem_zero((uint8_t *)&pRetCmd->sessionId,
+			    sizeof(pRetCmd->sessionId));
+		qdf_mem_zero((uint8_t *)&pRetCmd->u, sizeof(pRetCmd->u));
 	}
 
 	return pRetCmd;
@@ -1012,7 +1012,7 @@ QDF_STATUS sme_update_roam_params(mac_handle_t mac_handle,
 		mac_ctx->mlme_cfg->lfr.enable_5g_band_pref = true;
 		break;
 	case REASON_ROAM_SET_SSID_ALLOWED:
-		qdf_mem_set(&roam_params_dst->ssid_allowed_list, 0,
+		qdf_mem_zero(&roam_params_dst->ssid_allowed_list,
 				sizeof(tSirMacSSid) * MAX_SSID_ALLOWED_LIST);
 		roam_params_dst->num_ssid_allowed_list =
 			roam_params_src->num_ssid_allowed_list;
@@ -1025,7 +1025,7 @@ QDF_STATUS sme_update_roam_params(mac_handle_t mac_handle,
 		}
 		break;
 	case REASON_ROAM_SET_FAVORED_BSSID:
-		qdf_mem_set(&roam_params_dst->bssid_favored, 0,
+		qdf_mem_zero(&roam_params_dst->bssid_favored,
 			sizeof(tSirMacAddr) * MAX_BSSID_FAVORED);
 		roam_params_dst->num_bssid_favored =
 			roam_params_src->num_bssid_favored;
@@ -1038,7 +1038,7 @@ QDF_STATUS sme_update_roam_params(mac_handle_t mac_handle,
 		}
 		break;
 	case REASON_ROAM_SET_BLACKLIST_BSSID:
-		qdf_mem_set(&roam_params_dst->bssid_avoid_list, 0,
+		qdf_mem_zero(&roam_params_dst->bssid_avoid_list,
 			QDF_MAC_ADDR_SIZE * MAX_BSSID_AVOID_LIST);
 		roam_params_dst->num_bssid_avoid_list =
 			roam_params_src->num_bssid_avoid_list;
@@ -1519,8 +1519,8 @@ QDF_STATUS sme_set_plm_request(mac_handle_t mac_handle, tpSirPlmReq pPlmReq)
 	} /* End of for () */
 
 	/* Copying back the valid channel list to plm struct */
-	qdf_mem_set((void *)pPlmReq->plmChList,
-		    pPlmReq->plmNumCh, 0);
+	qdf_mem_zero((void *)pPlmReq->plmChList,
+		    pPlmReq->plmNumCh);
 	if (valid_count)
 		qdf_mem_copy(pPlmReq->plmChList, ch_list,
 			     valid_count);
@@ -2578,7 +2578,7 @@ QDF_STATUS sme_get_ap_channel_from_scan_cache(
 	if (!scan_filter)
 		return QDF_STATUS_E_FAILURE;
 
-	qdf_mem_set(&first_ap_profile, sizeof(tSirBssDescription), 0);
+	qdf_mem_zero(&first_ap_profile, sizeof(tSirBssDescription));
 	if (NULL == profile) {
 		scan_filter->EncryptionType.numEntries = 1;
 		scan_filter->EncryptionType.encryptionType[0]
@@ -9067,7 +9067,7 @@ QDF_STATUS sme_set_thermal_level(mac_handle_t mac_handle, uint8_t level)
 	QDF_STATUS qdf_status = QDF_STATUS_SUCCESS;
 
 	if (QDF_STATUS_SUCCESS == sme_acquire_global_lock(&mac->sme)) {
-		qdf_mem_set(&msg, sizeof(msg), 0);
+		qdf_mem_zero(&msg, sizeof(msg));
 		msg.type = WMA_SET_THERMAL_LEVEL;
 		msg.bodyval = level;
 
@@ -13734,7 +13734,7 @@ QDF_STATUS sme_set_del_pmkid_cache(mac_handle_t mac_handle, uint8_t session_id,
 	if (!pmk_cache)
 		return QDF_STATUS_E_NOMEM;
 
-	qdf_mem_set(pmk_cache, sizeof(*pmk_cache), 0);
+	qdf_mem_zero(pmk_cache, sizeof(*pmk_cache));
 
 	pmk_cache->vdev_id = session_id;
 

+ 1 - 1
core/sme/src/common/sme_ft_api.c

@@ -31,7 +31,7 @@ void sme_ft_open(mac_handle_t mac_handle, uint32_t sessionId)
 
 	if (NULL != pSession) {
 		/* Clean up the context */
-		qdf_mem_set(&pSession->ftSmeContext, sizeof(tftSMEContext), 0);
+		qdf_mem_zero(&pSession->ftSmeContext, sizeof(tftSMEContext));
 
 		pSession->ftSmeContext.pUsrCtx =
 			qdf_mem_malloc(sizeof(tFTRoamCallbackUsrCtx));

+ 66 - 70
core/sme/src/csr/csr_api_roam.c

@@ -1529,7 +1529,7 @@ void csr_roam_free_connect_profile(tCsrRoamConnectedProfile *profile)
 		qdf_mem_free(profile->pBssDesc);
 	if (profile->pAddIEAssoc)
 		qdf_mem_free(profile->pAddIEAssoc);
-	qdf_mem_set(profile, sizeof(tCsrRoamConnectedProfile), 0);
+	qdf_mem_zero(profile, sizeof(tCsrRoamConnectedProfile));
 	profile->AuthType = eCSR_AUTH_TYPE_UNKNOWN;
 }
 
@@ -2785,9 +2785,9 @@ static void csr_prune_ch_list(struct csr_channel *ch_lst, bool is_24_GHz)
 	 * channel in the structure.
 	 */
 	if (ch_lst->numChannels > num_channels) {
-		qdf_mem_set(&ch_lst->channelList[num_channels],
+		qdf_mem_zero(&ch_lst->channelList[num_channels],
 			    sizeof(ch_lst->channelList[0]) *
-			    (ch_lst->numChannels - num_channels), 0);
+			    (ch_lst->numChannels - num_channels));
 	}
 	ch_lst->numChannels = num_channels;
 }
@@ -3275,8 +3275,8 @@ static void csr_dump_connection_stats(struct mac_context *mac_ctx,
 	if (!conn_profile)
 		return;
 	profile = session->pCurRoamProfile;
-	qdf_mem_set(&conn_stats,
-		    sizeof(struct host_event_wlan_connection_stats), 0);
+	qdf_mem_zero(&conn_stats,
+		    sizeof(struct host_event_wlan_connection_stats));
 	qdf_mem_copy(conn_stats.bssid, conn_profile->bssid.bytes,
 		     QDF_MAC_ADDR_SIZE);
 	conn_stats.ssid_len = conn_profile->SSID.length;
@@ -3525,8 +3525,8 @@ QDF_STATUS csr_roam_call_callback(struct mac_context *mac, uint32_t sessionId,
 	 *                    eCSR_ROAM_DISASSOCIATED,
 	 */
 #ifdef FEATURE_WLAN_DIAG_SUPPORT_CSR
-	qdf_mem_set(&connectionStatus,
-			sizeof(host_event_wlan_status_payload_type), 0);
+	qdf_mem_zero(&connectionStatus,
+			sizeof(host_event_wlan_status_payload_type));
 
 	if ((eCSR_ROAM_ASSOCIATION_COMPLETION == u1)
 			&& (eCSR_ROAM_RESULT_ASSOCIATED == u2) && roam_info) {
@@ -4374,8 +4374,8 @@ static QDF_STATUS csr_get_rate_set(struct mac_context *mac,
 	uint8_t *pDstRate;
 	uint16_t rateBitmap = 0;
 
-	qdf_mem_set(pOpRateSet, sizeof(tSirMacRateSet), 0);
-	qdf_mem_set(pExRateSet, sizeof(tSirMacRateSet), 0);
+	qdf_mem_zero(pOpRateSet, sizeof(tSirMacRateSet));
+	qdf_mem_zero(pExRateSet, sizeof(tSirMacRateSet));
 	QDF_ASSERT(pIes != NULL);
 
 	if (NULL == pIes) {
@@ -4861,7 +4861,7 @@ static enum csr_join_state csr_roam_state_for_same_profile(
 				profile))
 		return eCsrReassocToSelfNoCapChange;
 	/* The key changes */
-	qdf_mem_set(&bssConfig, sizeof(bssConfig), 0);
+	qdf_mem_zero(&bssConfig, sizeof(bssConfig));
 	status = csr_roam_prepare_bss_config(mac_ctx, profile, bss_descr,
 				&bssConfig, ies_local);
 	if (QDF_IS_STATUS_SUCCESS(status)) {
@@ -4965,7 +4965,7 @@ QDF_STATUS csr_roam_should_roam(struct mac_context *mac, uint32_t sessionId,
 	QDF_STATUS status = QDF_STATUS_SUCCESS;
 	struct csr_roam_info roamInfo;
 
-	qdf_mem_set(&roamInfo, sizeof(struct csr_roam_info), 0);
+	qdf_mem_zero(&roamInfo, sizeof(struct csr_roam_info));
 	roamInfo.pBssDesc = pBssDesc;
 	status = csr_roam_call_callback(mac, sessionId, &roamInfo, roamId,
 				eCSR_ROAM_SHOULD_ROAM, eCSR_ROAM_RESULT_NONE);
@@ -5135,7 +5135,7 @@ static void csr_roam_join_handle_profile(struct mac_context *mac_ctx,
 				eCSR_ROAM_RESULT_NOT_ASSOCIATED);
 		}
 
-		qdf_mem_set(roam_info_ptr, sizeof(struct csr_roam_info), 0);
+		qdf_mem_zero(roam_info_ptr, sizeof(struct csr_roam_info));
 		if (!scan_result)
 			cmd->u.roamCmd.roamProfile.uapsd_mask = 0;
 		else
@@ -5713,15 +5713,14 @@ void csr_reinit_roam_cmd(struct mac_context *mac, tSmeCmd *pCommand)
 	pCommand->u.roamCmd.pLastRoamBss = NULL;
 	pCommand->u.roamCmd.pRoamBssEntry = NULL;
 	/* Because u.roamCmd is union and share with scanCmd and StatusChange */
-	qdf_mem_set(&pCommand->u.roamCmd, sizeof(struct roam_cmd), 0);
+	qdf_mem_zero(&pCommand->u.roamCmd, sizeof(struct roam_cmd));
 }
 
 void csr_reinit_wm_status_change_cmd(struct mac_context *mac,
 			tSmeCmd *pCommand)
 {
-	qdf_mem_set(&pCommand->u.wmStatusChangeCmd, sizeof(
-		struct wmstatus_changecmd),
-		    0);
+	qdf_mem_zero(&pCommand->u.wmStatusChangeCmd,
+			sizeof(struct wmstatus_changecmd));
 }
 
 void csr_roam_complete(struct mac_context *mac_ctx,
@@ -5758,8 +5757,8 @@ void csr_reset_pmkid_candidate_list(struct mac_context *mac,
 		sme_err("session: %d not found", sessionId);
 		return;
 	}
-	qdf_mem_set(&(pSession->PmkidCandidateInfo[0]),
-		    sizeof(tPmkidCandidateInfo) * CSR_MAX_PMKID_ALLOWED, 0);
+	qdf_mem_zero(&(pSession->PmkidCandidateInfo[0]),
+		    sizeof(tPmkidCandidateInfo) * CSR_MAX_PMKID_ALLOWED);
 	pSession->NumPmkidCandidate = 0;
 }
 
@@ -6212,7 +6211,7 @@ static void csr_roam_process_results_default(struct mac_context *mac_ctx,
 		csr_set_default_dot11_mode(mac_ctx);
 	}
 
-	qdf_mem_set(&roam_info, sizeof(struct csr_roam_info), 0);
+	qdf_mem_zero(&roam_info, sizeof(struct csr_roam_info));
 	/* Copy FILS sequence number used to be updated to userspace */
 	if (session->is_fils_connection)
 		csr_update_fils_seq_number(session, &roam_info);
@@ -6417,7 +6416,7 @@ static void csr_roam_process_start_bss_success(struct mac_context *mac_ctx,
 	sme_debug("receives start BSS ok indication");
 	status = QDF_STATUS_E_FAILURE;
 	start_bss_rsp = (tSirSmeStartBssRsp *) context;
-	qdf_mem_set(&roam_info, sizeof(struct csr_roam_info), 0);
+	qdf_mem_zero(&roam_info, sizeof(struct csr_roam_info));
 	if (CSR_IS_IBSS(profile))
 		session->connectState = eCSR_ASSOC_STATE_TYPE_IBSS_DISCONNECTED;
 	else if (CSR_IS_INFRA_AP(profile))
@@ -6779,7 +6778,7 @@ static void csr_roam_process_join_res(struct mac_context *mac_ctx,
 	}
 	session = CSR_GET_SESSION(mac_ctx, session_id);
 
-	qdf_mem_set(&roam_info, sizeof(roam_info), 0);
+	qdf_mem_zero(&roam_info, sizeof(roam_info));
 	conn_profile = &session->connectedProfile;
 	if (eCsrReassocSuccess == res) {
 		roam_info.reassoc = true;
@@ -7192,7 +7191,7 @@ static bool csr_roam_process_results(struct mac_context *mac_ctx, tSmeCmd *cmd,
 #endif
 		ibss_log = NULL;
 		start_bss_rsp = (tSirSmeStartBssRsp *)context;
-		qdf_mem_set(&roam_info, sizeof(roam_info), 0);
+		qdf_mem_zero(&roam_info, sizeof(roam_info));
 		roam_status = eCSR_ROAM_IBSS_IND;
 		roam_result = eCSR_ROAM_RESULT_IBSS_STARTED;
 		if (CSR_IS_INFRA_AP(profile)) {
@@ -7225,7 +7224,7 @@ static bool csr_roam_process_results(struct mac_context *mac_ctx, tSmeCmd *cmd,
 			session_id);
 		csr_roam_substate_change(mac_ctx, eCSR_ROAM_SUBSTATE_NONE,
 			session_id);
-		qdf_mem_set(&roam_info, sizeof(struct csr_roam_info), 0);
+		qdf_mem_zero(&roam_info, sizeof(struct csr_roam_info));
 		roam_info.pBssDesc = session->pConnectBssDesc;
 		if (roam_info.pBssDesc)
 			qdf_mem_copy(&roam_info.bssid,
@@ -7244,7 +7243,7 @@ static bool csr_roam_process_results(struct mac_context *mac_ctx, tSmeCmd *cmd,
 		/* We are here because we try to connect to the same AP */
 		/* No message to PE */
 		sme_debug("receives silently stop roaming indication");
-		qdf_mem_set(&roam_info, sizeof(roam_info), 0);
+		qdf_mem_zero(&roam_info, sizeof(roam_info));
 
 		/* to aviod resetting the substate to NONE */
 		mac_ctx->roam.curState[session_id] = eCSR_ROAMING_STATE_JOINED;
@@ -7290,7 +7289,7 @@ static bool csr_roam_process_results(struct mac_context *mac_ctx, tSmeCmd *cmd,
 		break;
 	case eCsrStopBssSuccess:
 		if (CSR_IS_NDI(profile)) {
-			qdf_mem_set(&roam_info, sizeof(roam_info), 0);
+			qdf_mem_zero(&roam_info, sizeof(roam_info));
 			csr_roam_update_ndp_return_params(mac_ctx, res,
 				&roam_status, &roam_result, &roam_info);
 			csr_roam_call_callback(mac_ctx, session_id, &roam_info,
@@ -7300,7 +7299,7 @@ static bool csr_roam_process_results(struct mac_context *mac_ctx, tSmeCmd *cmd,
 		break;
 	case eCsrStopBssFailure:
 		if (CSR_IS_NDI(profile)) {
-			qdf_mem_set(&roam_info, sizeof(roam_info), 0);
+			qdf_mem_zero(&roam_info, sizeof(roam_info));
 			csr_roam_update_ndp_return_params(mac_ctx, res,
 				&roam_status, &roam_result, &roam_info);
 			csr_roam_call_callback(mac_ctx, session_id, &roam_info,
@@ -7369,7 +7368,7 @@ QDF_STATUS csr_roam_copy_profile(struct mac_context *mac,
 	QDF_STATUS status = QDF_STATUS_SUCCESS;
 	uint32_t size = 0;
 
-	qdf_mem_set(pDstProfile, sizeof(struct csr_roam_profile), 0);
+	qdf_mem_zero(pDstProfile, sizeof(struct csr_roam_profile));
 	if (pSrcProfile->BSSIDs.numOfBSSIDs) {
 		size = sizeof(struct qdf_mac_addr) * pSrcProfile->BSSIDs.
 								numOfBSSIDs;
@@ -7571,7 +7570,7 @@ QDF_STATUS csr_roam_copy_connected_profile(struct mac_context *mac,
 	tCsrRoamConnectedProfile *pSrcProfile =
 		&mac->roam.roamSession[sessionId].connectedProfile;
 
-	qdf_mem_set(pDstProfile, sizeof(struct csr_roam_profile), 0);
+	qdf_mem_zero(pDstProfile, sizeof(struct csr_roam_profile));
 
 	pDstProfile->BSSIDs.bssid = qdf_mem_malloc(sizeof(struct qdf_mac_addr));
 	if (!pDstProfile->BSSIDs.bssid) {
@@ -8423,8 +8422,8 @@ QDF_STATUS csr_roam_save_connected_information(struct mac_context *mac,
 	 * LFR3.0, since the profile is not cleared.
 	 */
 	if (!pSession->roam_synch_in_progress) {
-		qdf_mem_set(&pSession->connectedProfile,
-				sizeof(tCsrRoamConnectedProfile), 0);
+		qdf_mem_zero(&pSession->connectedProfile,
+				sizeof(tCsrRoamConnectedProfile));
 		pConnectProfile->AuthType = pProfile->negotiatedAuthType;
 		pConnectProfile->AuthInfo = pProfile->AuthType;
 		pConnectProfile->EncryptionType =
@@ -8765,7 +8764,7 @@ csr_roam_reissue_roam_command(struct mac_context *mac, uint8_t session_id)
 		}
 		return;
 	}
-	qdf_mem_set(&roamInfo, sizeof(struct csr_roam_info), 0);
+	qdf_mem_zero(&roamInfo, sizeof(struct csr_roam_info));
 	roamInfo.pBssDesc = pCommand->u.roamCmd.pLastRoamBss;
 	roamInfo.statusCode = pSession->joinFailStatusCode.statusCode;
 	roamInfo.reasonCode = pSession->joinFailStatusCode.reasonCode;
@@ -9613,7 +9612,7 @@ void csr_roam_joined_state_msg_processor(struct mac_context *mac, void *pMsgBuf)
 		QDF_STATUS status;
 
 		sme_debug("ASSOCIATION confirmation can be given to upper layer ");
-		qdf_mem_set(&roamInfo, sizeof(struct csr_roam_info), 0);
+		qdf_mem_zero(&roamInfo, sizeof(struct csr_roam_info));
 		roam_info = &roamInfo;
 		pUpperLayerAssocCnf =
 			(tSirSmeAssocIndToUpperLayerCnf *) pMsgBuf;
@@ -10100,8 +10099,8 @@ QDF_STATUS csr_roam_send_set_key_cmd(struct mac_context *mac_ctx,
 	}
 
 	if (eSIR_ED_NONE != ed_type) {
-		qdf_mem_set(&setKeyEvent,
-			sizeof(host_event_wlan_security_payload_type), 0);
+		qdf_mem_zero(&setKeyEvent,
+			sizeof(host_event_wlan_security_payload_type));
 		if (qdf_is_macaddr_group(&set_key_cmd->peermac)) {
 			setKeyEvent.eventId = WLAN_SECURITY_EVENT_SET_BCAST_REQ;
 			setKeyEvent.encryptionModeMulticast =
@@ -10568,7 +10567,7 @@ csr_roam_chk_lnk_assoc_ind(struct mac_context *mac_ctx, tSirSmeRsp *msg_ptr)
 	tSirSmeAssocInd *pAssocInd;
 	struct csr_roam_info roam_info;
 
-	qdf_mem_set(&roam_info, sizeof(roam_info), 0);
+	qdf_mem_zero(&roam_info, sizeof(roam_info));
 	sme_debug("Receive WNI_SME_ASSOC_IND from SME");
 	pAssocInd = (tSirSmeAssocInd *) msg_ptr;
 	status = csr_roam_get_session_id_from_bssid(mac_ctx,
@@ -10858,7 +10857,7 @@ csr_roam_chk_lnk_deauth_ind(struct mac_context *mac_ctx, tSirSmeRsp *msg_ptr)
 	tSirSmeDeauthInd *pDeauthInd;
 	struct csr_roam_info roam_info;
 
-	qdf_mem_set(&roam_info, sizeof(roam_info), 0);
+	qdf_mem_zero(&roam_info, sizeof(roam_info));
 	sme_debug("DEAUTHENTICATION Indication from MAC");
 	pDeauthInd = (tpSirSmeDeauthInd) msg_ptr;
 	status = csr_roam_get_session_id_from_bssid(mac_ctx,
@@ -10994,7 +10993,7 @@ csr_roam_chk_lnk_swt_ch_ind(struct mac_context *mac_ctx, tSirSmeRsp *msg_ptr)
 		}
 	}
 
-	qdf_mem_set(&roamInfo, sizeof(struct csr_roam_info), 0);
+	qdf_mem_zero(&roamInfo, sizeof(struct csr_roam_info));
 	roamInfo.chan_info.chan_id = pSwitchChnInd->newChannelId;
 	roamInfo.chan_info.ch_width = pSwitchChnInd->chan_params.ch_width;
 	roamInfo.chan_info.sec_ch_offset =
@@ -11026,7 +11025,7 @@ csr_roam_chk_lnk_deauth_rsp(struct mac_context *mac_ctx, tSirSmeRsp *msg_ptr)
 	tSirSmeDeauthRsp *pDeauthRsp = (tSirSmeDeauthRsp *) msg_ptr;
 	struct csr_roam_info roam_info;
 
-	qdf_mem_set(&roam_info, sizeof(roam_info), 0);
+	qdf_mem_zero(&roam_info, sizeof(roam_info));
 	sme_debug("eWNI_SME_DEAUTH_RSP from SME");
 	sessionId = pDeauthRsp->sessionId;
 	if (!CSR_IS_SESSION_VALID(mac_ctx, sessionId))
@@ -11060,7 +11059,7 @@ csr_roam_chk_lnk_disassoc_rsp(struct mac_context *mac_ctx, tSirSmeRsp *msg_ptr)
 	 */
 	tSirSmeDisassocRsp *pDisassocRsp = (tSirSmeDisassocRsp *) msg_ptr;
 
-	qdf_mem_set(&roam_info, sizeof(roam_info), 0);
+	qdf_mem_zero(&roam_info, sizeof(roam_info));
 	sme_debug("eWNI_SME_DISASSOC_RSP from SME ");
 	sessionId = pDisassocRsp->sessionId;
 	if (!CSR_IS_SESSION_VALID(mac_ctx, sessionId))
@@ -11092,8 +11091,7 @@ csr_roam_diag_mic_fail(struct mac_context *mac_ctx, uint32_t sessionId)
 		sme_err("session %d not found", sessionId);
 		return;
 	}
-	qdf_mem_set(&secEvent, sizeof(host_event_wlan_security_payload_type),
-		    0);
+	qdf_mem_zero(&secEvent, sizeof(host_event_wlan_security_payload_type));
 	secEvent.eventId = WLAN_SECURITY_EVENT_MIC_ERROR;
 	secEvent.encryptionModeMulticast =
 		(uint8_t) diag_enc_type_from_csr_type(
@@ -11120,11 +11118,11 @@ csr_roam_chk_lnk_mic_fail_ind(struct mac_context *mac_ctx, tSirSmeRsp *msg_ptr)
 	tpSirSmeMicFailureInd pMicInd = (tpSirSmeMicFailureInd) msg_ptr;
 	eCsrRoamResult result = eCSR_ROAM_RESULT_MIC_ERROR_UNICAST;
 
-	qdf_mem_set(&roam_info, sizeof(roam_info), 0);
+	qdf_mem_zero(&roam_info, sizeof(roam_info));
 	status = csr_roam_get_session_id_from_bssid(mac_ctx,
 				&pMicInd->bssId, &sessionId);
 	if (QDF_IS_STATUS_SUCCESS(status)) {
-		qdf_mem_set(&roam_info, sizeof(struct csr_roam_info), 0);
+		qdf_mem_zero(&roam_info, sizeof(struct csr_roam_info));
 		roam_info.u.pMICFailureInfo = &pMicInd->info;
 		roam_info_ptr = &roam_info;
 		if (pMicInd->info.multicast)
@@ -11147,13 +11145,13 @@ csr_roam_chk_lnk_pbs_probe_req_ind(struct mac_context *mac_ctx, tSirSmeRsp *msg_
 	struct csr_roam_info roam_info;
 	tpSirSmeProbeReqInd pProbeReqInd = (tpSirSmeProbeReqInd) msg_ptr;
 
-	qdf_mem_set(&roam_info, sizeof(roam_info), 0);
+	qdf_mem_zero(&roam_info, sizeof(roam_info));
 	sme_debug("WPS PBC Probe request Indication from SME");
 
 	status = csr_roam_get_session_id_from_bssid(mac_ctx,
 			&pProbeReqInd->bssid, &sessionId);
 	if (QDF_IS_STATUS_SUCCESS(status)) {
-		qdf_mem_set(&roam_info, sizeof(struct csr_roam_info), 0);
+		qdf_mem_zero(&roam_info, sizeof(struct csr_roam_info));
 		roam_info.u.pWPSPBCProbeReq = &pProbeReqInd->WPSPBCProbeReq;
 		csr_roam_call_callback(mac_ctx, sessionId, &roam_info,
 				       0, eCSR_ROAM_WPS_PBC_PROBE_REQ_IND,
@@ -11205,7 +11203,7 @@ csr_roam_chk_lnk_wm_status_change_ntf(struct mac_context *mac_ctx,
 	tSirSmeNewBssInfo *pNewBss;
 	eRoamCmdStatus roamStatus = eCSR_ROAM_FAILED;
 
-	qdf_mem_set(&roam_info, sizeof(roam_info), 0);
+	qdf_mem_zero(&roam_info, sizeof(roam_info));
 	pStatusChangeMsg = (tSirSmeWmStatusChangeNtf *) msg_ptr;
 	switch (pStatusChangeMsg->statusChangeCode) {
 	case eSIR_SME_IBSS_ACTIVE:
@@ -11364,7 +11362,7 @@ csr_roam_chk_lnk_ibss_new_peer_ind(struct mac_context *mac_ctx, tSirSmeRsp *msg_
 	}
 #endif /* FEATURE_WLAN_DIAG_SUPPORT_CSR */
 
-	qdf_mem_set(&roam_info, sizeof(roam_info), 0);
+	qdf_mem_zero(&roam_info, sizeof(roam_info));
 	sessionId = csr_find_ibss_session(mac_ctx);
 	if (CSR_SESSION_ID_INVALID == sessionId)
 		return;
@@ -11454,7 +11452,7 @@ csr_roam_chk_lnk_ibss_peer_departed_ind(struct mac_context *mac_ctx,
 		sme_err("IBSS peer ind. message is NULL");
 		return;
 	}
-	qdf_mem_set(&roam_info, sizeof(roam_info), 0);
+	qdf_mem_zero(&roam_info, sizeof(roam_info));
 	pIbssPeerInd = (tSmeIbssPeerInd *) msg_ptr;
 	sessionId = csr_find_ibss_session(mac_ctx);
 	if (CSR_SESSION_ID_INVALID != sessionId) {
@@ -11492,8 +11490,8 @@ csr_roam_diag_set_ctx_rsp(struct mac_context *mac_ctx,
 	if (eCSR_ENCRYPT_TYPE_NONE ==
 		session->connectedProfile.EncryptionType)
 		return;
-	qdf_mem_set(&setKeyEvent,
-		    sizeof(host_event_wlan_security_payload_type), 0);
+	qdf_mem_zero(&setKeyEvent,
+		    sizeof(host_event_wlan_security_payload_type));
 	if (qdf_is_macaddr_group(&pRsp->peer_macaddr))
 		setKeyEvent.eventId =
 			WLAN_SECURITY_EVENT_SET_BCAST_RSP;
@@ -11534,7 +11532,7 @@ csr_roam_chk_lnk_set_ctx_rsp(struct mac_context *mac_ctx, tSirSmeRsp *msg_ptr)
 		return;
 	}
 
-	qdf_mem_set(&roam_info, sizeof(roam_info), 0);
+	qdf_mem_zero(&roam_info, sizeof(roam_info));
 	sessionId = pRsp->sessionId;
 	session = CSR_GET_SESSION(mac_ctx, sessionId);
 	if (!session) {
@@ -11632,7 +11630,7 @@ csr_roam_chk_lnk_max_assoc_exceeded(struct mac_context *mac_ctx, tSirSmeRsp *msg
 	tSmeMaxAssocInd *pSmeMaxAssocInd;
 	struct csr_roam_info roam_info;
 
-	qdf_mem_set(&roam_info, sizeof(roam_info), 0);
+	qdf_mem_zero(&roam_info, sizeof(roam_info));
 	pSmeMaxAssocInd = (tSmeMaxAssocInd *) msg_ptr;
 	sme_debug(
 		"max assoc have been reached, new peer cannot be accepted");
@@ -12133,7 +12131,7 @@ QDF_STATUS csr_roam_lost_link(struct mac_context *mac, uint32_t sessionId,
 		sme_err("session: %d not found", sessionId);
 		return QDF_STATUS_E_FAILURE;
 	}
-	qdf_mem_set(&roamInfo, sizeof(struct csr_roam_info), 0);
+	qdf_mem_zero(&roamInfo, sizeof(struct csr_roam_info));
 	if (eWNI_SME_DISASSOC_IND == type) {
 		result = eCSR_ROAM_RESULT_DISASSOC_IND;
 		pDisassocIndMsg = (tSirSmeDisassocInd *) pSirMsg;
@@ -12175,7 +12173,7 @@ QDF_STATUS csr_roam_lost_link(struct mac_context *mac, uint32_t sessionId,
 		status = csr_send_mb_deauth_cnf_msg(mac, pDeauthIndMsg);
 
 	/* prepare to tell HDD to disconnect */
-	qdf_mem_set(&roamInfo, sizeof(struct csr_roam_info), 0);
+	qdf_mem_zero(&roamInfo, sizeof(struct csr_roam_info));
 	roamInfo.statusCode = (tSirResultCodes) pSession->roamingStatusCode;
 	roamInfo.reasonCode = pSession->joinFailStatusCode.reasonCode;
 	if (eWNI_SME_DISASSOC_IND == type) {
@@ -13492,8 +13490,8 @@ void csr_roam_prepare_bss_params(struct mac_context *mac, uint32_t sessionId,
 				     pProfile->BSSIDs.bssid,
 				     sizeof(struct qdf_mac_addr));
 		else
-			qdf_mem_set(&pSession->bssParams.bssid,
-				    sizeof(struct qdf_mac_addr), 0);
+			qdf_mem_zero(&pSession->bssParams.bssid,
+				    sizeof(struct qdf_mac_addr));
 	}
 	Channel = pSession->bssParams.operationChn;
 	/* Set operating channel in pProfile which will be used */
@@ -13664,8 +13662,8 @@ csr_roam_diag_set_pmkid(struct csr_roam_session *pSession)
 {
 	WLAN_HOST_DIAG_EVENT_DEF(secEvent,
 				 host_event_wlan_security_payload_type);
-	qdf_mem_set(&secEvent,
-	    sizeof(host_event_wlan_security_payload_type), 0);
+	qdf_mem_zero(&secEvent,
+	    sizeof(host_event_wlan_security_payload_type));
 	secEvent.eventId = WLAN_SECURITY_EVENT_PMKID_UPDATE;
 	secEvent.encryptionModeMulticast =
 		(uint8_t) diag_enc_type_from_csr_type(
@@ -13977,7 +13975,7 @@ static QDF_STATUS csr_roam_start_wds(struct mac_context *mac, uint32_t sessionId
 			QDF_ASSERT(0);
 			return QDF_STATUS_E_FAILURE;
 		}
-		qdf_mem_set(&bssConfig, sizeof(struct bss_config_param), 0);
+		qdf_mem_zero(&bssConfig, sizeof(struct bss_config_param));
 		/* Assume HDD provide bssid in profile */
 		qdf_copy_macaddr(&pSession->bssParams.bssid,
 				 pProfile->BSSIDs.bssid);
@@ -14968,7 +14966,7 @@ QDF_STATUS csr_send_join_req_msg(struct mac_context *mac, uint32_t sessionId,
 			 * ESE-Tspec IEs in the ASSOC request is presently not
 			 * supported. so nullify the TSPEC parameters
 			 */
-			qdf_mem_set(&eseTspec, sizeof(tESETspecInfo), 0);
+			qdf_mem_zero(&eseTspec, sizeof(tESETspecInfo));
 			qdf_mem_copy(&csr_join_req->eseTspecInfo,
 					&eseTspec, sizeof(tESETspecInfo));
 		} else if (eWNI_SME_REASSOC_REQ == messageType) {
@@ -14979,8 +14977,7 @@ QDF_STATUS csr_send_join_req_msg(struct mac_context *mac, uint32_t sessionId,
 				(ese_config)) {
 				tESETspecInfo eseTspec;
 
-				qdf_mem_set(&eseTspec, sizeof(tESETspecInfo),
-						0);
+				qdf_mem_zero(&eseTspec, sizeof(tESETspecInfo));
 				eseTspec.numTspecs =
 					sme_qos_ese_retrieve_tspec_info(mac,
 						sessionId,
@@ -15002,8 +14999,7 @@ QDF_STATUS csr_send_join_req_msg(struct mac_context *mac, uint32_t sessionId,
 				 * presently not supported. so nullify the TSPEC
 				 * parameters
 				 */
-				qdf_mem_set(&eseTspec, sizeof(tESETspecInfo),
-						0);
+				qdf_mem_zero(&eseTspec, sizeof(tESETspecInfo));
 				qdf_mem_copy(&csr_join_req->eseTspecInfo,
 						&eseTspec,
 						sizeof(tESETspecInfo));
@@ -15429,7 +15425,7 @@ QDF_STATUS csr_set_ht2040_mode(struct mac_context *mac, uint32_t sessionId,
 	else
 		status = QDF_STATUS_SUCCESS;
 	if (QDF_IS_STATUS_SUCCESS(status)) {
-		qdf_mem_set(pMsg, sizeof(tSirSetHT2040Mode), 0);
+		qdf_mem_zero(pMsg, sizeof(tSirSetHT2040Mode));
 		pMsg->messageType = eWNI_SME_SET_HT_2040_MODE;
 		pMsg->length = len;
 
@@ -15461,7 +15457,7 @@ QDF_STATUS csr_send_mb_deauth_req_msg(struct mac_context *mac, uint32_t sessionI
 	if (NULL == pMsg)
 		return QDF_STATUS_E_NOMEM;
 
-	qdf_mem_set(pMsg, sizeof(tSirSmeDeauthReq), 0);
+	qdf_mem_zero(pMsg, sizeof(tSirSmeDeauthReq));
 	pMsg->messageType = eWNI_SME_DEAUTH_REQ;
 	pMsg->length = sizeof(tSirSmeDeauthReq);
 	pMsg->sessionId = sessionId;
@@ -16004,7 +16000,7 @@ static QDF_STATUS csr_roam_session_opened(struct mac_context *mac,
 	QDF_STATUS status = QDF_STATUS_SUCCESS;
 	struct csr_roam_info roam_info;
 
-	qdf_mem_set(&roam_info, sizeof(struct csr_roam_info), 0);
+	qdf_mem_zero(&roam_info, sizeof(struct csr_roam_info));
 
 	if (QDF_IS_STATUS_ERROR(qdf_status)) {
 		status = csr_roam_call_callback(mac, sessionId, &roam_info, 0,
@@ -16485,7 +16481,7 @@ static void csr_init_session(struct mac_context *mac, uint32_t sessionId)
 	csr_roam_free_connect_profile(&pSession->connectedProfile);
 	csr_roam_free_connected_info(mac, &pSession->connectedInfo);
 	csr_free_connect_bss_desc(mac, sessionId);
-	qdf_mem_set(&pSession->selfMacAddr, sizeof(struct qdf_mac_addr), 0);
+	qdf_mem_zero(&pSession->selfMacAddr, sizeof(struct qdf_mac_addr));
 	if (pSession->pWpaRsnReqIE) {
 		qdf_mem_free(pSession->pWpaRsnReqIE);
 		pSession->pWpaRsnReqIE = NULL;
@@ -19999,8 +19995,8 @@ void csr_roaming_report_diag_event(struct mac_context *mac_ctx,
 {
 	WLAN_HOST_DIAG_EVENT_DEF(roam_connection,
 		host_event_wlan_status_payload_type);
-	qdf_mem_set(&roam_connection,
-		sizeof(host_event_wlan_status_payload_type), 0);
+	qdf_mem_zero(&roam_connection,
+		sizeof(host_event_wlan_status_payload_type));
 	switch (reason) {
 	case eCSR_REASON_ROAM_SYNCH_IND:
 		roam_connection.eventId = eCSR_WLAN_STATUS_CONNECT;

+ 1 - 1
core/sme/src/csr/csr_api_scan.c

@@ -712,7 +712,7 @@ void csr_apply_channel_power_info_wrapper(struct mac_context *mac)
 	csr_apply_channel_power_info_to_fw(mac,
 		&mac->scan.base_channels, mac->scan.countryCodeCurrent);
 	/* clear the 11d channel list */
-	qdf_mem_set(&mac->scan.channels11d, sizeof(mac->scan.channels11d), 0);
+	qdf_mem_zero(&mac->scan.channels11d, sizeof(mac->scan.channels11d));
 }
 
 #ifdef FEATURE_WLAN_DIAG_SUPPORT_CSR

+ 3 - 3
core/sme/src/csr/csr_neighbor_roam.c

@@ -786,7 +786,7 @@ void csr_roam_reset_roam_params(struct mac_context *mac_ctx)
 		FL("Roaming parameters are reset"));
 	roam_params = &mac_ctx->roam.configParam.roam_params;
 	roam_params->num_ssid_allowed_list = 0;
-	qdf_mem_set(&roam_params->ssid_allowed_list, 0,
+	qdf_mem_zero(&roam_params->ssid_allowed_list,
 			sizeof(tSirMacSSid) * MAX_SSID_ALLOWED_LIST);
 }
 
@@ -1282,8 +1282,8 @@ QDF_STATUS csr_neighbor_roam_init(struct mac_context *mac, uint8_t sessionId)
 		pNeighborRoamInfo->cfgParams.nRoamBmissFinalBcnt;
 	pNeighborRoamInfo->currentRoamBeaconRssiWeight =
 		pNeighborRoamInfo->cfgParams.nRoamBeaconRssiWeight;
-	qdf_mem_set(&pNeighborRoamInfo->prevConnProfile,
-		    sizeof(tCsrRoamConnectedProfile), 0);
+	qdf_mem_zero(&pNeighborRoamInfo->prevConnProfile,
+		    sizeof(tCsrRoamConnectedProfile));
 
 	status = csr_ll_open(&pNeighborRoamInfo->roamableAPList);
 	if (QDF_STATUS_SUCCESS != status) {

+ 2 - 2
core/sme/src/csr/csr_util.c

@@ -4257,7 +4257,7 @@ uint8_t csr_construct_wapi_ie(struct mac_context *mac, uint32_t sessionId,
 		if (!fWapiMatch)
 			break;
 
-		qdf_mem_set(pWapiIe, sizeof(tCsrWapiIe), 0);
+		qdf_mem_zero(pWapiIe, sizeof(tCsrWapiIe));
 
 		pWapiIe->IeHeader.ElementID = DOT11F_EID_WAPI;
 
@@ -5726,7 +5726,7 @@ void csr_release_profile(struct mac_context *mac, struct csr_roam_profile *pProf
 			pProfile->ChannelInfo.ChannelList = NULL;
 		}
 		csr_free_fils_profile_info(pProfile);
-		qdf_mem_set(pProfile, sizeof(struct csr_roam_profile), 0);
+		qdf_mem_zero(pProfile, sizeof(struct csr_roam_profile));
 	}
 }
 

+ 6 - 6
core/wma/src/wma_data.c

@@ -2518,7 +2518,7 @@ QDF_STATUS wma_tx_packet(void *wma_context, void *tx_frame, uint16_t frmLen,
 				 * MAC header and data, Keep the CCMP header and
 				 * trailer as 0's, firmware shall fill this
 				 */
-				qdf_mem_set(pFrame, newFrmLen, 0);
+				qdf_mem_zero(pFrame, newFrmLen);
 				qdf_mem_copy(pFrame, wh, sizeof(*wh));
 				qdf_mem_copy(pFrame + sizeof(*wh) +
 					     hdr_len,
@@ -2552,7 +2552,7 @@ QDF_STATUS wma_tx_packet(void *wma_context, void *tx_frame, uint16_t frmLen,
 			 * MAC header and data. MMIE field will be
 			 * filled by cds_attach_mmie API
 			 */
-			qdf_mem_set(pFrame, newFrmLen, 0);
+			qdf_mem_zero(pFrame, newFrmLen);
 			qdf_mem_copy(pFrame, wh, sizeof(*wh));
 			qdf_mem_copy(pFrame + sizeof(*wh),
 				     pData + sizeof(*wh), frmLen - sizeof(*wh));
@@ -2659,7 +2659,7 @@ QDF_STATUS wma_tx_packet(void *wma_context, void *tx_frame, uint16_t frmLen,
 		wma_decap_to_8023(skb, &decap_info);
 
 		/* Zero out skb's context buffer for the driver to use */
-		qdf_mem_set(skb->cb, sizeof(skb->cb), 0);
+		qdf_mem_zero(skb->cb, sizeof(skb->cb));
 
 		/* Terminate the (single-element) list of tx frames */
 		skb->next = NULL;
@@ -3029,7 +3029,7 @@ void ol_rx_err(void *pdev, uint8_t vdev_id,
 		IEEE80211_IS_MULTICAST(eth_hdr->ether_dhost);
 	qdf_mem_copy(mic_err_ind->info.TSC, pn, SIR_CIPHER_SEQ_CTR_SIZE);
 
-	qdf_mem_set(&cds_msg, sizeof(struct scheduler_msg), 0);
+	qdf_mem_zero(&cds_msg, sizeof(struct scheduler_msg));
 	cds_msg.type = eWNI_SME_MIC_FAILURE_IND;
 	cds_msg.bodyptr = (void *) mic_err_ind;
 
@@ -3155,7 +3155,7 @@ wma_indicate_err(
 		if (!mic_err_ind)
 			return;
 
-		qdf_mem_set((void *) mic_err_ind, 0,
+		qdf_mem_zero((void *)mic_err_ind,
 			 sizeof(*mic_err_ind));
 		mic_err_ind->messageType = eWNI_SME_MIC_FAILURE_IND;
 		mic_err_ind->length = sizeof(*mic_err_ind);
@@ -3185,7 +3185,7 @@ wma_indicate_err(
 			 (void *)&err_info->
 			 u.mic_err.pn, SIR_CIPHER_SEQ_CTR_SIZE);
 
-		qdf_mem_set(&cds_msg, sizeof(struct scheduler_msg), 0);
+		qdf_mem_zero(&cds_msg, sizeof(struct scheduler_msg));
 		cds_msg.type = eWNI_SME_MIC_FAILURE_IND;
 		cds_msg.bodyptr = (void *) mic_err_ind;
 		if (QDF_STATUS_SUCCESS !=

+ 2 - 2
core/wma/src/wma_dev_if.c

@@ -2112,7 +2112,7 @@ QDF_STATUS wma_create_peer(tp_wma_handle wma, struct cdp_pdev *pdev,
 
 		WMA_LOGD("%s: remote ibss peer %pM key clearing\n", __func__,
 			 peer_addr);
-		qdf_mem_set(&key_info, sizeof(key_info), 0);
+		qdf_mem_zero(&key_info, sizeof(key_info));
 		key_info.smesessionId = vdev_id;
 		qdf_mem_copy(key_info.peer_macaddr.bytes, peer_addr,
 				IEEE80211_ADDR_LEN);
@@ -4539,7 +4539,7 @@ static void wma_add_bss_ibss_mode(tp_wma_handle wma, tpAddBssParams add_bss)
 	/* clear leftover ibss keys on bss peer */
 
 	WMA_LOGD("%s: ibss bss key clearing", __func__);
-	qdf_mem_set(&key_info, sizeof(key_info), 0);
+	qdf_mem_zero(&key_info, sizeof(key_info));
 	key_info.smesessionId = vdev_id;
 	key_info.numKeys = SIR_MAC_MAX_NUM_OF_DEFAULT_KEYS;
 	qdf_mem_copy(&wma->ibsskey_info, &key_info, sizeof(tSetBssKeyParams));

+ 1 - 1
core/wma/src/wma_features.c

@@ -329,7 +329,7 @@ QDF_STATUS wma_get_snr(tAniGetSnrReq *psnr_req)
 	if (!psnr_req_bkp)
 		return QDF_STATUS_E_NOMEM;
 
-	qdf_mem_set(psnr_req_bkp, sizeof(tAniGetSnrReq), 0);
+	qdf_mem_zero(psnr_req_bkp, sizeof(tAniGetSnrReq));
 	psnr_req_bkp->staId = psnr_req->staId;
 	psnr_req_bkp->pDevContext = psnr_req->pDevContext;
 	psnr_req_bkp->snrCallback = psnr_req->snrCallback;

+ 6 - 6
core/wma/src/wma_mgmt.c

@@ -1937,8 +1937,8 @@ static QDF_STATUS wma_setup_install_key_cmd(tp_wma_handle wma_handle,
 	qdf_mem_copy(params.peer_mac, key_params->peer_mac, IEEE80211_ADDR_LEN);
 
 #ifdef FEATURE_WLAN_WAPI
-	qdf_mem_set(params.tx_iv, 16, 0);
-	qdf_mem_set(params.rx_iv, 16, 0);
+	qdf_mem_zero(params.tx_iv, 16);
+	qdf_mem_zero(params.rx_iv, 16);
 #endif
 	params.key_txmic_len = 0;
 	params.key_rxmic_len = 0;
@@ -2256,7 +2256,7 @@ void wma_set_bsskey(tp_wma_handle wma_handle, tpSetBssKeyParams key_info)
 			     sizeof(tSetBssKeyParams));
 	}
 
-	qdf_mem_set(&key_params, sizeof(key_params), 0);
+	qdf_mem_zero(&key_params, sizeof(key_params));
 	key_params.vdev_id = key_info->smesessionId;
 	key_params.key_type = key_info->encType;
 	key_params.singl_tid_rc = key_info->singleTidRc;
@@ -2379,9 +2379,9 @@ static void wma_set_ibsskey_helper(tp_wma_handle wma_handle,
 		return;
 	}
 
-	qdf_mem_set(&key_params, sizeof(key_params), 0);
+	qdf_mem_zero(&key_params, sizeof(key_params));
 	opmode = cdp_get_opmode(soc, txrx_vdev);
-	qdf_mem_set(&key_params, sizeof(key_params), 0);
+	qdf_mem_zero(&key_params, sizeof(key_params));
 	key_params.vdev_id = key_info->smesessionId;
 	key_params.key_type = key_info->encType;
 	key_params.singl_tid_rc = key_info->singleTidRc;
@@ -2507,7 +2507,7 @@ void wma_set_stakey(tp_wma_handle wma_handle, tpSetStaKeyParams key_info)
 			}
 		}
 	}
-	qdf_mem_set(&key_params, sizeof(key_params), 0);
+	qdf_mem_zero(&key_params, sizeof(key_params));
 	key_params.vdev_id = key_info->smesessionId;
 	key_params.key_type = key_info->encType;
 	key_params.singl_tid_rc = key_info->singleTidRc;

+ 2 - 2
core/wma/src/wma_scan_roam.c

@@ -2804,7 +2804,7 @@ QDF_STATUS wma_roam_scan_fill_self_caps(tp_wma_handle wma_handle,
 	uint8_t nCfgValue8, *pCfgValue8;
 	tSirMacQosInfoStation macQosInfoSta;
 
-	qdf_mem_set(&macQosInfoSta, sizeof(tSirMacQosInfoStation), 0);
+	qdf_mem_zero(&macQosInfoSta, sizeof(tSirMacQosInfoStation));
 	/* Roaming is done only for INFRA STA type.
 	 * So, ess will be one and ibss will be Zero
 	 */
@@ -4834,7 +4834,7 @@ QDF_STATUS wma_scan_probe_setoui(tp_wma_handle wma, tSirScanMacOui *psetoui)
 {
 	struct scan_mac_oui set_oui;
 
-	qdf_mem_set(&set_oui, sizeof(struct scan_mac_oui), 0);
+	qdf_mem_zero(&set_oui, sizeof(struct scan_mac_oui));
 
 	if (!wma || !wma->wmi_handle) {
 		WMA_LOGE("%s: WMA is closed, can not issue  cmd", __func__);