ソースを参照

qcacld-3.0: Fix comparision of unsigned values against 0

Add changes to remove comparision of unsigned values against 0

Change-Id: I36b35f0c3cee22a636af1202a3ec1003e0a425c4
CRs-Fixed: 2049500
Sreelakshmi Konamki 7 年 前
コミット
0d17c6a381
2 ファイル変更7 行追加7 行削除
  1. 2 3
      core/sme/src/common/sme_api.c
  2. 5 4
      core/wma/src/wma_dev_if.c

+ 2 - 3
core/sme/src/common/sme_api.c

@@ -9445,8 +9445,7 @@ QDF_STATUS sme_update_tdls_peer_state(tHalHandle hHal,
 	num = 0;
 	peer_chan_len = peerStateParams->peerCap.peerChanLen;
 
-	if (peer_chan_len >= 0 &&
-	    peer_chan_len <= SME_TDLS_MAX_SUPP_CHANNELS) {
+	if (peer_chan_len <= SME_TDLS_MAX_SUPP_CHANNELS) {
 		for (i = 0; i < peerStateParams->peerCap.peerChanLen; i++) {
 			chanId = peerStateParams->peerCap.peerChan[i];
 			if (csr_roam_is_channel_valid(pMac, chanId) &&
@@ -12177,7 +12176,7 @@ QDF_STATUS sme_get_valid_channels_by_band(tHalHandle hHal,
 		return QDF_STATUS_E_INVAL;
 	}
 
-	if ((wifiBand < WIFI_BAND_UNSPECIFIED) || (wifiBand >= WIFI_BAND_MAX)) {
+	if (wifiBand >= WIFI_BAND_MAX) {
 		sme_err("Invalid wifiBand: %d", wifiBand);
 		return QDF_STATUS_E_INVAL;
 	}

+ 5 - 4
core/wma/src/wma_dev_if.c

@@ -3658,10 +3658,11 @@ static void wma_add_bss_sta_mode(tp_wma_handle wma, tpAddBssParams add_bss)
 send_bss_resp:
 
 	wma_vdev_set_he_config(wma, vdev_id, add_bss);
-	cdp_peer_find_by_addr(soc, pdev, add_bss->bssId,
-		&add_bss->staContext.staIdx);
-	add_bss->status = (add_bss->staContext.staIdx < 0) ?
-			  QDF_STATUS_E_FAILURE : QDF_STATUS_SUCCESS;
+	if (NULL == cdp_peer_find_by_addr(soc, pdev, add_bss->bssId,
+					&add_bss->staContext.staIdx))
+		add_bss->status = QDF_STATUS_E_FAILURE;
+	else
+		add_bss->status = QDF_STATUS_SUCCESS;
 	add_bss->bssIdx = add_bss->staContext.smesessionId;
 	qdf_mem_copy(add_bss->staContext.staMac, add_bss->bssId,
 		     sizeof(add_bss->staContext.staMac));