qcacld-3.0: Refine the extscan reset significant change logic

Make the following updates to the extscan reset significant change
logic:
1) Exclusively use the Unified WMI data structures.
2) Update the HDD<=>SME interface to enforce the contract that SME
   must not make any assumptions about the buffers provided by HDD.

Change-Id: I9b63924f4219f6d3567e3ee2b1a31e1a9ce3bc29
CRs-Fixed: 2309570

core/hdd/src/wlan_hdd_ext_scan.c

@@ -3549,23 +3549,19 @@ int wlan_hdd_cfg80211_extscan_reset_bssid_hotlist(struct wiphy *wiphy,
  * Return: none
  */
 static int
-__wlan_hdd_cfg80211_extscan_reset_significant_change(struct wiphy
-						       *wiphy,
-						       struct
-						       wireless_dev
-						       *wdev, const void *data,
-						       int data_len)
+__wlan_hdd_cfg80211_extscan_reset_significant_change(struct wiphy *wiphy,
+						     struct wireless_dev *wdev,
+						     const void *data,
+						     int data_len)
 {
-	tpSirExtScanResetSignificantChangeReqParams pReqMsg = NULL;
+	struct extscan_capabilities_reset_params params;
 	struct net_device *dev = wdev->netdev;
 	struct hdd_adapter *adapter = WLAN_HDD_GET_PRIV_PTR(dev);
 	struct hdd_context *hdd_ctx = wiphy_priv(wiphy);
-	struct nlattr *tb[QCA_WLAN_VENDOR_ATTR_EXTSCAN_SUBCMD_CONFIG_PARAM_MAX +
-			  1];
+	struct nlattr *tb[EXTSCAN_PARAM_MAX + 1];
 	struct hdd_ext_scan_context *context;
-	uint32_t request_id;
 	QDF_STATUS status;
-	int retval;
+	int id, retval;
 	unsigned long rc;
 
 	hdd_enter_dev(dev);
@@ -3584,43 +3580,33 @@ __wlan_hdd_cfg80211_extscan_reset_significant_change(struct wiphy
 		return -ENOTSUPP;
 	}
 
-	if (wlan_cfg80211_nla_parse(tb,
-			   QCA_WLAN_VENDOR_ATTR_EXTSCAN_SUBCMD_CONFIG_PARAM_MAX,
-			   data, data_len, wlan_hdd_extscan_config_policy)) {
+	if (wlan_cfg80211_nla_parse(tb, EXTSCAN_PARAM_MAX, data, data_len,
+				    wlan_hdd_extscan_config_policy)) {
 		hdd_err("Invalid ATTR");
 		return -EINVAL;
 	}
 
-	pReqMsg = qdf_mem_malloc(sizeof(*pReqMsg));
-	if (!pReqMsg) {
-		hdd_err("qdf_mem_malloc failed");
-		return -ENOMEM;
-	}
-
 	/* Parse and fetch request Id */
-	if (!tb[QCA_WLAN_VENDOR_ATTR_EXTSCAN_SUBCMD_CONFIG_PARAM_REQUEST_ID]) {
+	id = QCA_WLAN_VENDOR_ATTR_EXTSCAN_SUBCMD_CONFIG_PARAM_REQUEST_ID;
+	if (!tb[id]) {
 		hdd_err("attr request id failed");
-		goto fail;
+		return -EINVAL;
 	}
 
-	pReqMsg->requestId =
-		nla_get_u32(tb
-		 [QCA_WLAN_VENDOR_ATTR_EXTSCAN_SUBCMD_CONFIG_PARAM_REQUEST_ID]);
-	pReqMsg->sessionId = adapter->session_id;
-	hdd_debug("Req Id %d Session Id %d",
-		pReqMsg->requestId, pReqMsg->sessionId);
+	params.request_id = nla_get_u32(tb[id]);
+	params.vdev_id = adapter->session_id;
+	hdd_debug("Req Id %d Vdev Id %d", params.request_id, params.vdev_id);
 
 	context = &ext_scan_context;
 	spin_lock(&context->context_lock);
 	INIT_COMPLETION(context->response_event);
-	context->request_id = request_id = pReqMsg->requestId;
+	context->request_id = params.request_id;
 	spin_unlock(&context->context_lock);
 
-	status = sme_reset_significant_change(hdd_ctx->mac_handle, pReqMsg);
+	status = sme_reset_significant_change(hdd_ctx->mac_handle, &params);
 	if (!QDF_IS_STATUS_SUCCESS(status)) {
 		hdd_err("sme_reset_significant_change failed(err=%d)",
 			status);
-		qdf_mem_free(pReqMsg);
 		return -EINVAL;
 	}
 
@@ -3633,7 +3619,7 @@ __wlan_hdd_cfg80211_extscan_reset_significant_change(struct wiphy
 		retval = -ETIMEDOUT;
 	} else {
 		spin_lock(&context->context_lock);
-		if (context->request_id == request_id)
+		if (context->request_id == params.request_id)
 			retval = context->response_status;
 		else
 			retval = -EINVAL;
@@ -3641,10 +3627,6 @@ __wlan_hdd_cfg80211_extscan_reset_significant_change(struct wiphy
 	}
 	hdd_exit();
 	return retval;
-
-fail:
-	qdf_mem_free(pReqMsg);
-	return -EINVAL;
 }
 
 /**

core/mac/inc/sir_api.h

@@ -4309,12 +4309,6 @@ typedef struct {
 	tSirWifiSignificantChange ap[];
 } tSirWifiSignificantChangeEvent, *tpSirWifiSignificantChangeEvent;
 
-typedef struct {
-	uint32_t requestId;
-	uint8_t sessionId;
-} tSirExtScanResetSignificantChangeReqParams,
-*tpSirExtScanResetSignificantChangeReqParams;
-
 typedef struct {
 	uint32_t requestId;
 	uint32_t numResultsAvailable;

core/sme/inc/sme_api.h

@@ -1033,9 +1033,17 @@ QDF_STATUS
 sme_set_significant_change(mac_handle_t mac_handle,
 			   struct extscan_set_sig_changereq_params *params);
 
-QDF_STATUS sme_reset_significant_change(tHalHandle hHal,
-		tSirExtScanResetSignificantChangeReqParams
-		*pResetReq);
+/**
+ * sme_reset_significant_change() -  SME API to reset significant change
+ * @mac_handle: Opaque handle to the MAC context
+ * @params: extscan reset significant change structure
+ *
+ * Return: QDF_STATUS
+ */
+QDF_STATUS
+sme_reset_significant_change(mac_handle_t mac_handle,
+			     struct extscan_capabilities_reset_params *params);
+
 QDF_STATUS sme_get_cached_results(tHalHandle hHal,
 		tSirExtScanGetCachedResultsReqParams *
 		pCachedResultsReq);

core/sme/src/common/sme_api.c

@@ -11287,36 +11287,37 @@ sme_set_significant_change(mac_handle_t mac_handle,
 	return status;
 }
 
-/*
- * sme_reset_significant_change
- * SME API to reset significant change
- *
- * hHal
- * pResetReq: extscan reset significant change structure
- * Return QDF_STATUS
- */
-QDF_STATUS sme_reset_significant_change(tHalHandle hHal,
-				tSirExtScanResetSignificantChangeReqParams
-					*pResetReq)
+QDF_STATUS
+sme_reset_significant_change(mac_handle_t mac_handle,
+			     struct extscan_capabilities_reset_params *params)
 {
-	QDF_STATUS status = QDF_STATUS_SUCCESS;
-	QDF_STATUS qdf_status = QDF_STATUS_SUCCESS;
-	tpAniSirGlobal pMac = PMAC_STRUCT(hHal);
+	QDF_STATUS status;
+	tpAniSirGlobal mac = MAC_CONTEXT(mac_handle);
 	struct scheduler_msg message = {0};
+	struct extscan_capabilities_reset_params *bodyptr;
 
-	status = sme_acquire_global_lock(&pMac->sme);
+	/* per contract must make a copy of the params when messaging */
+	bodyptr = qdf_mem_malloc(sizeof(*bodyptr));
+	if (!bodyptr) {
+		sme_err("buffer allocation failure");
+		return QDF_STATUS_E_NOMEM;
+	}
+	*bodyptr = *params;
+
+	status = sme_acquire_global_lock(&mac->sme);
 	if (QDF_IS_STATUS_SUCCESS(status)) {
 		/* Serialize the req through MC thread */
-		message.bodyptr = pResetReq;
+		message.bodyptr = bodyptr;
 		message.type = WMA_EXTSCAN_RESET_SIGNF_CHANGE_REQ;
 		MTRACE(qdf_trace(QDF_MODULE_ID_SME, TRACE_CODE_SME_TX_WMA_MSG,
 				 NO_SESSION, message.type));
-		qdf_status = scheduler_post_msg(QDF_MODULE_ID_WMA,
-						 &message);
-		if (!QDF_IS_STATUS_SUCCESS(qdf_status))
-			status = QDF_STATUS_E_FAILURE;
+		status = scheduler_post_msg(QDF_MODULE_ID_WMA, &message);
+		sme_release_global_lock(&mac->sme);
+	}
 
-		sme_release_global_lock(&pMac->sme);
+	if (QDF_IS_STATUS_ERROR(status)) {
+		sme_err("failure: %d", status);
+		qdf_mem_free(bodyptr);
 	}
 	return status;
 }

core/wma/inc/wma_internal.h

@@ -399,8 +399,18 @@ QDF_STATUS
 wma_extscan_start_change_monitor(tp_wma_handle wma,
 			struct extscan_set_sig_changereq_params *params);
 
-QDF_STATUS wma_extscan_stop_change_monitor(tp_wma_handle wma,
-		   tSirExtScanResetSignificantChangeReqParams *pResetReq);
+/**
+ * wma_extscan_stop_change_monitor() - send stop change monitor cmd
+ * @wma: wma handle
+ * @params: change monitor request params
+ *
+ * This function sends stop change monitor request to fw.
+ *
+ * Return: QDF status
+ */
+QDF_STATUS
+wma_extscan_stop_change_monitor(tp_wma_handle wma,
+			struct extscan_capabilities_reset_params *params);
 
 QDF_STATUS wma_extscan_get_cached_results(tp_wma_handle wma,
 					  tSirExtScanGetCachedResultsReqParams *

core/wma/src/wma_main.c

@@ -8170,9 +8170,7 @@ static QDF_STATUS wma_mc_process_msg(struct scheduler_msg *msg)
 		qdf_mem_free(msg->bodyptr);
 		break;
 	case WMA_EXTSCAN_RESET_SIGNF_CHANGE_REQ:
-		wma_extscan_stop_change_monitor(wma_handle,
-			(tSirExtScanResetSignificantChangeReqParams *)
-							msg->bodyptr);
+		wma_extscan_stop_change_monitor(wma_handle, msg->bodyptr);
 		qdf_mem_free(msg->bodyptr);
 		break;
 	case WMA_EXTSCAN_GET_CACHED_RESULTS_REQ:

core/wma/src/wma_scan_roam.c

@@ -4734,20 +4734,9 @@ wma_extscan_start_change_monitor(tp_wma_handle wma,
 	return status;
 }
 
-/**
- * wma_extscan_stop_change_monitor() - send stop change monitor cmd
- * @wma: wma handle
- * @pResetReq: Reset change request params
- *
- * This function sends stop change monitor request to fw.
- *
- * Return: QDF status
- */
 QDF_STATUS wma_extscan_stop_change_monitor(tp_wma_handle wma,
-		   tSirExtScanResetSignificantChangeReqParams *pResetReq)
+			struct extscan_capabilities_reset_params *params)
 {
-	struct extscan_capabilities_reset_params params = {0};
-
 	if (!wma || !wma->wmi_handle) {
 		WMA_LOGE("%s: WMA is closed, can not issue  cmd", __func__);
 		return QDF_STATUS_E_INVAL;
@@ -4758,11 +4747,8 @@ QDF_STATUS wma_extscan_stop_change_monitor(tp_wma_handle wma,
 		return QDF_STATUS_E_FAILURE;
 	}
 
-	params.request_id = pResetReq->requestId;
-	params.vdev_id = pResetReq->sessionId;
-
 	return wmi_unified_extscan_stop_change_monitor_cmd(wma->wmi_handle,
-					&params);
+							   params);
 }
 
 /**