samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

disp: msm: sde: Register LUTDMA dummy region after parameter validation

Browse Source 
A dummy LUTDMA region is registered prior to parameter validation, potentially
causing the usage of an unallocated memory if the sde_mdss_cfg structure is
invalid. Update the code flow so that the dummy LUTDMA region is registered after
all parameter validation

Change-Id: I9a10b166ee7a611b9d5d2cb0555822996d123c10
Signed-off-by: Christopher Braga <quic_cbraga@quicinc.com>
This commit is contained in:
Christopher Braga
2023-05-16 10:57:11 -04:00
parent ee2ee3b129
commit 06fe4deb2a
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
msm/sde/sde_reg_dma.c
View File

@@ -122,6 +122,12 @@ int sde_reg_dma_init(void __iomem *addr, struct sde_mdss_cfg *m,
set_default_dma_ops(&reg_dma);
if (!addr || !m || !dev) {
DRM_DEBUG("invalid addr %pK catalog %pK dev %pK\n", addr, m,
dev);
return 0;
}
/**
* Register dummy range to ensure register dump is only done on
* targeted LUTDMA regions. start = 1, end = 1 so full range isn't used
@@ -129,12 +135,6 @@ int sde_reg_dma_init(void __iomem *addr, struct sde_mdss_cfg *m,
sde_dbg_reg_register_dump_range(LUTDMA_DBG_NAME, "DUMMY_LUTDMA", 1, 1,
m->dma_cfg.xin_id);
if (!addr || !m || !dev) {
DRM_DEBUG("invalid addr %pK catalog %pK dev %pK\n", addr, m,
dev);
return 0;
}
if (!m->reg_dma_count)
return 0;