qcacld-3.0: Fix sanity checks and MLO macro definitions

Fix sanity checks of unsigned integer values in HDD APIs
and move MLO macros to the HDD MLO file from SME.

Change-Id: I3a8ff8a379be1fcbfd357e145ebc7aa53fde3818
CRs-Fixed: 3423121

core/hdd/inc/wlan_hdd_mlo.h

@@ -45,6 +45,11 @@ struct hdd_adapter_create_param {
 		 unused:27;
 };
 
+#ifdef WLAN_FEATURE_11BE_MLO
+#define MAX_SIMULTANEOUS_STA_ML_LINKS 1
+#define MAX_NUM_STA_ML_LINKS 3
+#endif
+
 #if defined(WLAN_FEATURE_11BE_MLO) && defined(CFG80211_11BE_BASIC)
 #define hdd_adapter_is_link_adapter(x) ((x)->mlo_adapter_info.is_link_adapter)
 #define hdd_adapter_is_ml_adapter(x)   ((x)->mlo_adapter_info.is_ml_adapter)

core/hdd/src/wlan_hdd_cfg80211.c

@@ -10828,7 +10828,7 @@ static int hdd_set_wfc_state(struct hdd_adapter *adapter,
 
 }
 
-#ifdef WLAN_FEATURE_11BE
+#ifdef WLAN_FEATURE_11BE_MLO
 /**
  * hdd_set_eht_max_simultaneous_links() - Set EHT maximum number of
  * simultaneous links
@@ -10844,7 +10844,7 @@ static int hdd_set_eht_max_simultaneous_links(struct hdd_adapter *adapter,
 	struct hdd_context *hdd_ctx = WLAN_HDD_GET_CTX(adapter);
 
 	cfg_val = nla_get_u8(attr);
-	if (cfg_val < 0 || cfg_val > MAX_SIMULTANEOUS_STA_ML_LINKS)
+	if (cfg_val > MAX_SIMULTANEOUS_STA_ML_LINKS)
 		return -EINVAL;
 
 	sme_set_mlo_max_simultaneous_links(hdd_ctx->mac_handle,
@@ -10867,7 +10867,7 @@ static int hdd_set_eht_max_num_links(struct hdd_adapter *adapter,
 	struct hdd_context *hdd_ctx = WLAN_HDD_GET_CTX(adapter);
 
 	cfg_val = nla_get_u8(attr);
-	if (cfg_val < 0 || cfg_val > MAX_NUM_STA_ML_lINKS)
+	if (cfg_val > MAX_NUM_STA_ML_LINKS)
 		return -EINVAL;
 
 	sme_set_mlo_max_links(hdd_ctx->mac_handle,

core/sme/inc/sme_api.h

@@ -3679,9 +3679,6 @@ enum sme_eht_tx_bfee_cap_type {
 };
 
 #ifdef WLAN_FEATURE_11BE
-#define MAX_SIMULTANEOUS_STA_ML_LINKS 1
-#define MAX_NUM_STA_ML_lINKS 3
-
 /**
  * sme_set_eht_testbed_def() - set eht testbed default
  * @mac_handle: Opaque handle to the global MAC context