Преглед на файлове

qcacld-3.0: wma: Remove logs for cds_get_context() checks

cds_get_context() function already takes care of logging the
caller function name in case of any error.
Hence there is no need to add the error log again.
Getting rid of these unnecessary logs reduces driver memory footprint.

Change-Id: I44e2998effe642932d83376bf92083be8d52073d
CRs-Fixed: 2822110
Srinivas Girigowda преди 4 години
родител
ревизия
04ec73013d
променени са 3 файла, в които са добавени 7 реда и са изтрити 21 реда
  1. 2 6
      core/wma/src/wma_he.c
  2. 4 12
      core/wma/src/wma_utils.c
  3. 1 3
      core/wma/src/wma_utils_ut.c

+ 2 - 6
core/wma/src/wma_he.c

@@ -1432,10 +1432,8 @@ void wma_set_he_txbf_params(uint8_t vdev_id, bool su_bfer,
 	QDF_STATUS status;
 	tp_wma_handle wma = cds_get_context(QDF_MODULE_ID_WMA);
 
-	if (!wma) {
-		wma_err("Invalid WMA handle");
+	if (!wma)
 		return;
-	}
 
 	hemu_mode = DOT11AX_HEMU_MODE;
 	hemu_mode |= ((su_bfer << HE_SUBFER) | (su_bfee << HE_SUBFEE) |
@@ -1469,10 +1467,8 @@ QDF_STATUS wma_get_he_capabilities(struct he_capability *he_cap)
 	tp_wma_handle wma_handle;
 
 	wma_handle = cds_get_context(QDF_MODULE_ID_WMA);
-	if (!wma_handle) {
-		wma_err("Invalid WMA handle");
+	if (!wma_handle)
 		return QDF_STATUS_E_FAILURE;
-	}
 
 	qdf_mem_copy(he_cap->phy_cap,
 		     &wma_handle->he_cap.phy_cap,

+ 4 - 12
core/wma/src/wma_utils.c

@@ -3388,10 +3388,8 @@ void *wma_get_beacon_buffer_by_vdev_id(uint8_t vdev_id, uint32_t *buffer_size)
 	uint32_t buf_size;
 
 	wma = cds_get_context(QDF_MODULE_ID_WMA);
-	if (!wma) {
-		wma_err("Invalid WMA handle");
+	if (!wma)
 		return NULL;
-	}
 
 	if (vdev_id >= wma->max_bssid) {
 		wma_err("Invalid vdev_id %u", vdev_id);
@@ -3435,10 +3433,8 @@ uint8_t *wma_get_vdev_address_by_vdev_id(uint8_t vdev_id)
 	struct wlan_objmgr_vdev *vdev;
 
 	wma = cds_get_context(QDF_MODULE_ID_WMA);
-	if (!wma) {
-		wma_err("Invalid WMA handle");
+	if (!wma)
 		return NULL;
-	}
 
 	if (vdev_id >= wma->max_bssid) {
 		wma_err("Invalid vdev_id %u", vdev_id);
@@ -3512,10 +3508,8 @@ struct wma_txrx_node  *wma_get_interface_by_vdev_id(uint8_t vdev_id)
 	tp_wma_handle wma;
 
 	wma = cds_get_context(QDF_MODULE_ID_WMA);
-	if (!wma) {
-		wma_err("Invalid WMA handle");
+	if (!wma)
 		return NULL;
-	}
 
 	if (vdev_id >= wma->max_bssid) {
 		wma_err("Invalid vdev_id %u", vdev_id);
@@ -3558,10 +3552,8 @@ void wma_update_intf_hw_mode_params(uint32_t vdev_id, uint32_t mac_id,
 	QDF_STATUS status;
 
 	wma = cds_get_context(QDF_MODULE_ID_WMA);
-	if (!wma) {
-		wma_err("Invalid WMA handle");
+	if (!wma)
 		return;
-	}
 
 	if (!wma->interfaces) {
 		wma_err("Interface is NULL");

+ 1 - 3
core/wma/src/wma_utils_ut.c

@@ -42,10 +42,8 @@ void wma_set_dbs_capability_ut(uint32_t dbs)
 	uint32_t i;
 
 	wma = cds_get_context(QDF_MODULE_ID_WMA);
-	if (!wma) {
-		wma_err("Invalid WMA handle");
+	if (!wma)
 		return;
-	}
 
 	/* DBS list was not configured by the FW, so
 	 * for UT, we can configure a single entry