samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qcacld-3.0: Remove dead code from wma_tx_packet

Browse Source 
In the PI wma_tx_packet, host assigns downld_comp_required
to true/false according to tx_frm_download_comp_cb,
is_high_latency, tx_frm_ota_comp_cb, all the three
conditions to be true. Also the host checks
tx_frm_download_comp_cb, and assigns tx_frm_index
according to downld_comp_required, but in the else
case when tx_frm_download_comp_cb is false, the check
of downld_comp_required is void, as the downld_comp_required
cannot be true if prior tx_frm_download_comp_cb is false,
so the code in the else part which checks tx_frm_download_comp_cb
and assigns tx_frm_index is dead, and in any case cannot be
executed.

Fix is to remove the check of downld_comp_required in
the else case.

Change-Id: If1a376099234d541d508f18cee075dd0f1603294
CRs-Fixed: 2233558
This commit is contained in:
gaurank kathpalia
2018-05-02 12:30:52 +05:30
committed by nshrivas
parent 1273054d88
commit 04476d6eb8
1 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
core/wma/src/wma_data.c
View File

@@ -2686,10 +2686,6 @@ QDF_STATUS wma_tx_packet(void *wma_context, void *tx_frame, uint16_t frmLen,
tx_frm_index = GENERIC_NODOWLOAD_ACK_COMP_INDEX;
} else {
if (downld_comp_required)
tx_frm_index =
GENERIC_DOWNLD_COMP_NOACK_COMP_INDEX;
else
tx_frm_index =
GENERIC_NODOWNLD_NOACK_COMP_INDEX;
}