samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

msm: adsprpc: add ftrace for dspsignal events for perf debugging

Browse Source 
Define new ftrace to log dspsignal events like signalling, waiting,
waking up, completing and cancelling wait. These ftraces can be
used in performance debugging of dspqueue overheads.

Change-Id: Iaf5f3df0f7ba3bd3da94f7614724b8f63ca09ed6
Signed-off-by: Thyagarajan Venkatanarayanan <quic_venkatan@quicinc.com>
This commit is contained in:
Thyagarajan Venkatanarayanan
2023-08-10 16:30:27 -07:00
parent 322b6a2596
commit 02257e15e3
2 changed files with 39 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
dsp/adsprpc.c
View File

@@ -5652,6 +5652,7 @@ static void handle_remote_signal(uint64_t msg, int cid)
(sig->state == DSPSIGNAL_STATE_SIGNALED)) {
DSPSIGNAL_VERBOSE("Signaling signal %u for PID %u\n",
signal_id, pid);
trace_fastrpc_dspsignal("complete", signal_id, sig->state, 0);
complete(&sig->comp);
sig->state = DSPSIGNAL_STATE_SIGNALED;
} else if (sig->state == DSPSIGNAL_STATE_UNUSED) {
@@ -5682,7 +5683,7 @@ int fastrpc_handle_rpc_response(void *data, int len, int cid)
struct fastrpc_channel_ctx *chan = NULL;
unsigned long irq_flags = 0;
int64_t ns = 0;
uint64_t xo_time_in_us = 0;
uint64_t xo_time_in_us = 0, dspsig_msg = 0;
xo_time_in_us = CONVERT_CNT_TO_US(__arch_counter_get_cntvct());
@@ -5690,7 +5691,9 @@ int fastrpc_handle_rpc_response(void *data, int len, int cid)
/*
* dspsignal message from the DSP
*/
handle_remote_signal(*((uint64_t *)data), cid);
dspsig_msg = *((uint64_t *)data);
trace_fastrpc_transport_response(cid, dspsig_msg, 0, 0, 0);
handle_remote_signal(dspsig_msg, cid);
goto bail;
}
@@ -6870,7 +6873,7 @@ int fastrpc_dspsignal_signal(struct fastrpc_file *fl,
msg = (((uint64_t)fl->tgid_frpc) << 32) | ((uint64_t)sig->signal_id);
err = fastrpc_transport_send(cid, (void *)&msg, sizeof(msg), fl->tvm_remote_domain);
mutex_unlock(&channel_ctx->smd_mutex);
trace_fastrpc_dspsignal("signal", sig->signal_id, 0, 0);
bail:
return err;
}
@@ -6923,10 +6926,12 @@ int fastrpc_dspsignal_wait(struct fastrpc_file *fl,
}
spin_unlock_irqrestore(&fl->dspsignals_lock, irq_flags);
trace_fastrpc_dspsignal("wait", signal_id, s->state, wait->timeout_usec);
if (timeout != 0xffffffff)
ret = wait_for_completion_interruptible_timeout(&s->comp, timeout);
else
ret = wait_for_completion_interruptible(&s->comp);
trace_fastrpc_dspsignal("wakeup", signal_id, s->state, wait->timeout_usec);
if (ret == 0) {
DSPSIGNAL_VERBOSE("Wait for signal %u timed out\n", signal_id);
@@ -7114,6 +7119,7 @@ int fastrpc_dspsignal_cancel_wait(struct fastrpc_file *fl,
if (s->state != DSPSIGNAL_STATE_CANCELED) {
s->state = DSPSIGNAL_STATE_CANCELED;
trace_fastrpc_dspsignal("cancel", signal_id, s->state, 0);
complete_all(&s->comp);
}

30
dsp/fastrpc_trace.h
View File

@@ -391,6 +391,36 @@ TRACE_EVENT(fastrpc_msg,
TP_printk(" %s", __get_str(buf))
);
TRACE_EVENT(fastrpc_dspsignal,
TP_PROTO(const char *event, uint32_t signal_id,
int state, uint32_t timeout),
TP_ARGS(event, signal_id, state, timeout),
TP_STRUCT__entry(
__string(buf, event)
__field(u32, signal_id)
__field(int, state)
__field(u32, timeout)
),
TP_fast_assign(
#if IS_ENABLED(CONFIG_MSM_ADSPRPC_TRUSTED)
memcpy(__get_str(buf), (event), (sizeof(event) - 1));
__get_str(buf)[sizeof(event) - 1] = '\0';
#else
__assign_str(buf, event);
#endif
__entry->signal_id = signal_id;
__entry->state = state;
__entry->timeout = timeout;
),
TP_printk("%s for sig id %u, state %d, timeout %u",
__get_str(buf), __entry->signal_id, __entry->state, __entry->timeout)
);
#endif
/* This part must be outside protection */