samsung-sm8650/android_kernel_samsung_sm8650-modules
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qcacmn: Avoid NULL pointer deference

Browse Source 
Validate sta_ctx->copied_conn_req before use to avoid NULL pointer
deference.

Change-Id: I0d46901f7709b1b6bcf63a7ca5178fb7ad90b33d
CRs-Fixed: 3621066
This commit is contained in:
Jianmin Zhu
2023-09-22 14:36:59 +08:00
committed by Rahul Choudhary
parent 02a38d9b75
commit 01c751d3fd
1 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
umac/mlo_mgr/src/wlan_mlo_mgr_sta.c
View File

@@ -818,8 +818,11 @@ mlo_prepare_and_send_connect(struct wlan_objmgr_vdev *vdev,
QDF_MAC_ADDR_REF(link_info.link_addr.bytes), QDF_MAC_ADDR_REF(link_info.link_addr.bytes),
wlan_vdev_get_id(vdev)); wlan_vdev_get_id(vdev));
qdf_mem_copy(&req, sta_ctx->copied_conn_req, if (sta_ctx->copied_conn_req)
sizeof(struct wlan_cm_connect_req)); qdf_mem_copy(&req, sta_ctx->copied_conn_req,
sizeof(struct wlan_cm_connect_req));
else
mlo_err("Invalid copied_conn_req");
mlo_update_connect_req_chan_info(&req); mlo_update_connect_req_chan_info(&req);
@@ -834,7 +837,9 @@ mlo_prepare_and_send_connect(struct wlan_objmgr_vdev *vdev,
req.ssid.length = ssid.length; req.ssid.length = ssid.length;
qdf_mem_copy(&req.ssid.ssid, &ssid.ssid, ssid.length); qdf_mem_copy(&req.ssid.ssid, &ssid.ssid, ssid.length);
mlo_allocate_and_copy_ies(&req, sta_ctx->copied_conn_req); if (sta_ctx->copied_conn_req)
mlo_allocate_and_copy_ies(&req, sta_ctx->copied_conn_req);
if (!req.assoc_ie.ptr) if (!req.assoc_ie.ptr)
mlo_err("Failed to allocate assoc IEs"); mlo_err("Failed to allocate assoc IEs");